[{"id":3685227,"web_url":"http://patchwork.ozlabs.org/comment/3685227/","msgid":"","list_archive_url":null,"date":"2026-05-01T21:07:09","subject":"Re: [PATCH net-next 11/12] misc: tc956x_pci: add TC956x/QPS615\n support","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> diff --git a/drivers/misc/tc956x_pci.c b/drivers/misc/tc956x_pci.c\n\n> +static inline void chip_reset_assert(const struct tc956x_chip *chip,\n> +\t\t\t\t enum reset_id id)\n> +{\n> +\ttc956x_reset_clock_set(chip, true, true, true, (u8)id);\n> +}\n\nThis is in drivers/misc, where the rules might be different. But in\nnetdev, we don't like inline functions in .c files. It is better to\nlet the compiler decide.\n\n> +static void chip_init_state(struct tc956x_chip *chip)\n> +{\n> +\t/* The only IP block we currently use is MSIGEN */\n> +\tchip_reset_assert(chip, RESET_MCU);\n> +\tchip_reset_assert(chip, RESET_MCU1);\n> +\tchip_reset_assert(chip, RESET_INTC);\n> +\tchip_reset_assert(chip, RESET_UART0);\n> +\tchip_clock_disable(chip, CLOCK_MCU);\n> +\tchip_clock_disable(chip, CLOCK_SRAM);\n> +\tchip_clock_disable(chip, CLOCK_PLL);\n> +\tchip_clock_disable(chip, CLOCK_SGMII);\n\nWith my networking hat on, this one standard out.\n\n> +\tchip_clock_disable(chip, CLOCK_REFCLK);\n\nThe name REFCLK is sometimes used as for the clock signals for RGMII?\n\n> +static int\n> +tc956x_function_probe(struct pci_dev *pdev, const struct pci_device_id *id)\n> +{\n> +\tstruct device *dev = &pdev->dev;\n> +\tstruct tc956x_chip *chip;\n> +\tunsigned int msigen_irq;\n> +\tint ret;\n> +\n> +\t/* Despite being a PCI device, we require devicetree */\n> +\tif (!dev->of_node)\n> +\t\treturn -EINVAL;\n\nMight be worth a dev_err(), since it is unusual.\n\n\tAndrew","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256\n header.s=20171124 header.b=gXstL101;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35975-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=\"gXstL101\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=156.67.10.101","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=lunn.ch"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6kGH5qx5z1yJ0\n\tfor ; Sat, 02 May 2026 07:10:31 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 94CF830157B5\n\tfor ; Fri, 1 May 2026 21:07:47 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7DE30425CE2;\n\tFri, 1 May 2026 21:07:45 +0000 (UTC)","from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A2D0D33B970;\n\tFri, 1 May 2026 21:07:43 +0000 (UTC)","from andrew by vps0.lunn.ch with local (Exim 4.94.2)\n\t(envelope-from )\n\tid 1wIv4n-000soC-0l; Fri, 01 May 2026 23:07:09 +0200"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777669665; cv=none;\n b=FHEtQ67tqB3mqNYzUCQthCoOPY1yvM8ok4Tc8PY0Yg2hGbMLG/QQe4ZzfBb9SulxECvoE085BuXU3Lptkfdvmo3srtF7fSafTq0ZOrwOfL1l/HDgq7mysABPdsRV1yqgotRwXQU1ZLdg5/PHPNg1ASpTgUyPlcmjrZkPCljCrBU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777669665; c=relaxed/simple;\n\tbh=u87LzqlH4jRqVyZEH6dO8+Zeo9R8H6Mo5eyptjOYFsg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=AmS0Huocapt65fm4EsiOSmncCRkITJw17WhORaOViS/tDLWOiw1uDMmGV61jKG/VU3+uVpAmBwmr7A1ar3Ucwngfp7OU8dVjnotEKApW2z4++HNawP9CGT2yyoHhnZgM+pivBUANJTscvPev8xr8KuHcnp+vvEjAK7fwwyOp5ME=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch;\n spf=pass smtp.mailfrom=lunn.ch;\n dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=gXstL101; arc=none smtp.client-ip=156.67.10.101","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;\n\ts=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:\n\tReferences:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:\n\tDate:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:\n\tContent-ID:Content-Description:Content-Disposition:In-Reply-To:References;\n\tbh=MlvvIWkz8YMmdMlfmtJ0yWa0qZs1kSt9IYxCuFbScAk=; b=gXstL101nagcCiccTw5+p86AFI\n\tLCVmkJk5MzBQrdomImehrJrPQ5TcMdXkBKDpTrJH8Nzremn/xMQUc42PTv2HqdmW3k9TDYfeSQu6/\n\tNedeeZiflcknh8Jh9+gDnBe6QiG4b58NO6jTt4zCgB6LQI1eGJ8L39MQiugt3vvps6xo=;","Date":"Fri, 1 May 2026 23:07:09 +0200","From":"Andrew Lunn ","To":"Alex Elder ","Cc":"andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n\tkuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com,\n\trmk+kernel@armlinux.org.uk, andersson@kernel.org,\n\tkonradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,\n\tconor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org,\n\tarnd@arndb.de, gregkh@linuxfoundation.org, daniel@riscstar.com,\n\tmohd.anwar@oss.qualcomm.com, a0987203069@gmail.com,\n\talexandre.torgue@foss.st.com, ast@kernel.org,\n\tboon.khai.ng@altera.com, chenchuangyu@xiaomi.com,\n\tchenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org,\n\thkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com,\n\tjulianbraha@gmail.com, livelycarpet87@gmail.com,\n\tmatthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc,\n\tprabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com,\n\trohan.g.thomas@altera.com, sdf@fomichev.me,\n\tsiyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com,\n\twens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org,\n\tlinux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-stm32@st-md-mailman.stormreply.com,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next 11/12] misc: tc956x_pci: add TC956x/QPS615\n support","Message-ID":"","References":"<20260501155421.3329862-1-elder@riscstar.com>\n <20260501155421.3329862-12-elder@riscstar.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260501155421.3329862-12-elder@riscstar.com>"}}]