[{"id":3685192,"web_url":"http://patchwork.ozlabs.org/comment/3685192/","msgid":"<1f34cbce-e2dd-4e80-b136-55d0efa50002@lunn.ch>","list_archive_url":null,"date":"2026-05-01T17:38:22","subject":"Re: [PATCH net-next 08/12] dt-bindings: net: toshiba,tc965x-dwmac:\n add TC956x Ethernet bridge","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"Your ASCII art of the chip might be useful here as documentation.\n\n> + # We can't allOf reference Ethernet-controller.yaml because we end up with\n> + # contradictory $nodename rules (`ethernet@` versus `pci@`). Happily only a\n> + # small number of the properties are useful on TC956x so we can just reference\n> + # what we need.\n\nWhy not add an subnodes for the ethernet interfaces?\n\n> +examples:\n> + - |\n> + pcie {\n> + #address-cells = <3>;\n> + #size-cells = <2>;\n> +\n> + tc956x_emac0: pci@0,0 {\n> + compatible = \"pci1179,0220\";\n> + reg = <0x50000 0x0 0x0 0x0 0x0>;\n> + #address-cells = <3>;\n> + #size-cells = <2>;\n> + device_type = \"pci\";\n> + ranges;\n> +\n> + gpio-controller;\n> + #gpio-cells = <2>;\n\nI've not got to the GPIO driver patch yet...\n\nIs the GPIO part of the ethernet device, or part of the chip? The\nhierarchy here should match the hierarchy of the hardware.\n\n> + phy-mode = \"10gbase-r\";\n> + phy-handle = <&tc956x_emac0_phy>;\n> +\n> + mdio {\n> + compatible = \"snps,dwmac-mdio\";\n> + #address-cells = <1>;\n> + #size-cells = <0>;\n> +\n> + tc956x_emac0_phy: ethernet-phy@1c {\n> + compatible = \"ethernet-phy-id311c.1c12\";\n> + reg = <0x1c>;\n> + };\n> + };\n> + };\n> + pci@0,1 {\n> + compatible = \"pci1179,0220\";\n> + reg = <0x50100 0x0 0x0 0x0 0x0>;\n> + #address-cells = <3>;\n> + #size-cells = <2>;\n> + device_type = \"pci\";\n> + ranges;\n> +\n\nYou second ethernet does not have a gpio controller?\n\n\tAndrew","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256\n header.s=20171124 header.b=1RUdOWDp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35969-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=\"1RUdOWDp\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=156.67.10.101","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=lunn.ch"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6dZN2K2Gz1xvV\n\tfor ; Sat, 02 May 2026 03:39:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C57F530117A9\n\tfor ; Fri, 1 May 2026 17:39:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2704A31690E;\n\tFri, 1 May 2026 17:38:59 +0000 (UTC)","from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C3F93148B5;\n\tFri, 1 May 2026 17:38:57 +0000 (UTC)","from andrew by vps0.lunn.ch with local (Exim 4.94.2)\n\t(envelope-from )\n\tid 1wIrok-000qnU-W4; Fri, 01 May 2026 19:38:22 +0200"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777657138; cv=none;\n b=V6rK4Fh9tSA9lAq8lwOb5pg4qPA3jcCKUU2S1CSh9UmDFgQsVuwOBVKcRvJk81U6hGQ2ov0u4GeGHm6LL6lS1S17C6cJMvLWT6/aW/2Nbu/3o0NIff4EHKgkGj7abCnTckeuvuxFudq+YK+SbEDl1UGYgwz2tqmEfO/ysV2lMcg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777657138; c=relaxed/simple;\n\tbh=FkLvuBwHLW9KIU/MWqsTCq6sClXi+dyujMF+dGFavFk=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=rEyfZ97z01lv+9o7s1tsyZnStvEVYu1SkYo+L5c/CDfm7co33GWk5EolOTHBQ7Q+Hhsvb4Uwgha6RqKLYoJV7qGsl/36nallS7fa9vUzZ8wrKePrKxKaFbwbho48VfuqBWexaIlvT0ZKN3JQ+Omoy5iFKz0NC4r2Al8NWcugXR4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch;\n spf=pass smtp.mailfrom=lunn.ch;\n dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=1RUdOWDp; arc=none smtp.client-ip=156.67.10.101","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;\n\ts=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:\n\tReferences:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:\n\tDate:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:\n\tContent-ID:Content-Description:Content-Disposition:In-Reply-To:References;\n\tbh=v1G+n5y3YaiJOCPRo9ZSXyCutKw19S+mOiIPygXvWbA=; b=1RUdOWDpRr1oCft025cSv8R4JM\n\t7JEFjRj+B2aOR33WNSyqJ0LUTLOPlRXuB27RxpQuiHsoK2UxvcHt/feQeARPBKKRd75vpeMJBL+VA\n\tQutEOfQtlovqoFmxTw5pLgvxcNj79Ys9Gxw2YAyJbf0T6TYLP527f884yruR48HgiUwQ=;","Date":"Fri, 1 May 2026 19:38:22 +0200","From":"Andrew Lunn ","To":"Alex Elder ","Cc":"andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n\tkuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com,\n\trmk+kernel@armlinux.org.uk, andersson@kernel.org,\n\tkonradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,\n\tconor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org,\n\tarnd@arndb.de, gregkh@linuxfoundation.org,\n\tDaniel Thompson , mohd.anwar@oss.qualcomm.com,\n\ta0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org,\n\tboon.khai.ng@altera.com, chenchuangyu@xiaomi.com,\n\tchenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org,\n\thkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com,\n\tjulianbraha@gmail.com, livelycarpet87@gmail.com,\n\tmatthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc,\n\tprabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com,\n\trohan.g.thomas@altera.com, sdf@fomichev.me,\n\tsiyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com,\n\twens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org,\n\tlinux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-stm32@st-md-mailman.stormreply.com,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next 08/12] dt-bindings: net: toshiba,tc965x-dwmac:\n add TC956x Ethernet bridge","Message-ID":"<1f34cbce-e2dd-4e80-b136-55d0efa50002@lunn.ch>","References":"<20260501155421.3329862-1-elder@riscstar.com>\n <20260501155421.3329862-9-elder@riscstar.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260501155421.3329862-9-elder@riscstar.com>"}}]