[{"id":3685184,"web_url":"http://patchwork.ozlabs.org/comment/3685184/","msgid":"<9203d8dd-8ec0-415e-9c2e-5b06b1b8dc11@lunn.ch>","list_archive_url":null,"date":"2026-05-01T17:13:46","subject":"Re: [PATCH net-next 04/12] net: stmmac: dma: create a separate\n dma_device pointer","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":">  \tif (priv->dma_cap.host_dma_width) {\n> -\t\tret = dma_set_mask_and_coherent(device,\n> -\t\t\t\tDMA_BIT_MASK(priv->dma_cap.host_dma_width));\n> +\t\tu64 mask = DMA_BIT_MASK(priv->dma_cap.host_dma_width);\n> +\n> +\t\tret = dma_set_mask_and_coherent(priv->dma_device, mask);\n\nI'm nitpicking, but i don't think you need to introduce mask.\nDMA_BIT_MASK... is already on a line of its own, and is within the 80\nlimit. Nothing changes here with s/device/priv->dma_device/\n\n\tAndrew","headers":{"Return-Path":"\n <linux-gpio+bounces-35967-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256\n header.s=20171124 header.b=u+I9EEI/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35967-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=\"u+I9EEI/\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=156.67.10.101","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=lunn.ch"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6d1t6b9xz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 02 May 2026 03:14:26 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 1835B3010391\n\tfor <incoming@patchwork.ozlabs.org>; Fri,  1 May 2026 17:14:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1F961401A1D;\n\tFri,  1 May 2026 17:14:18 +0000 (UTC)","from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B80B62F6910;\n\tFri,  1 May 2026 17:14:16 +0000 (UTC)","from andrew by vps0.lunn.ch with local (Exim 4.94.2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1wIrQw-000qct-9N; Fri, 01 May 2026 19:13:46 +0200"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777655657; cv=none;\n b=d6SogR4mkk7FumOC/I+MK/zOUVxE0DRvObgqjuG8glokE1Q3qBDIW2DC6ebC6AilVB7T/dvdc+/GhW7fKWsfGthpbKAY15+QA9CcJxzECb80merHQIp8wyQsvyIXRIFHvWOLIYRDM1YAH/hTUwu8ZoMLW7b9nX2JsFmJu6h47jY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777655657; c=relaxed/simple;\n\tbh=cTInKL0vnv1m17I0Uo9CYtS7vCNe6CQR8YpO+Hhi1p8=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=VMK4yd8HJ7SsH8FymBSoxsxaekfn4yVuiajtwZr8ONUQflBj2VEdZJ8NzRx7et0UnKwMQs48iar4jsjrgB1Vpbo0cwFHP6DaUHHBBq3OYM+1qi5aLPFxEamqaPebmy+G9tv9GpUH980DV1+XY9TSEHOUDeF4Fv+4R40Ei97BS/8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch;\n spf=pass smtp.mailfrom=lunn.ch;\n dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=u+I9EEI/; arc=none smtp.client-ip=156.67.10.101","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;\n\ts=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:\n\tReferences:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:\n\tDate:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:\n\tContent-ID:Content-Description:Content-Disposition:In-Reply-To:References;\n\tbh=lLJVwKR+EGGEi9cMlsW7QVMJE91Mo9bGN8zBGdpkLnI=; b=u+I9EEI/AB86R5VT4TkU4k8rsU\n\tTLMdzjjcBzScJIZfKf/g8wrUGda+btr5RWsguNxBF1nysIWqWMAh9H07fMriOjK5ANltD7k1sYxZN\n\tao1NhwskbN8CL5y3h6AjSycbFOfsaJBNkTxHY0vUNycbpPze7FRlIb6EWLc03k5qpeIc=;","Date":"Fri, 1 May 2026 19:13:46 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Alex Elder <elder@riscstar.com>","Cc":"andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n\tkuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com,\n\trmk+kernel@armlinux.org.uk, andersson@kernel.org,\n\tkonradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,\n\tconor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org,\n\tarnd@arndb.de, gregkh@linuxfoundation.org, daniel@riscstar.com,\n\tmohd.anwar@oss.qualcomm.com, a0987203069@gmail.com,\n\talexandre.torgue@foss.st.com, ast@kernel.org,\n\tboon.khai.ng@altera.com, chenchuangyu@xiaomi.com,\n\tchenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org,\n\thkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com,\n\tjulianbraha@gmail.com, livelycarpet87@gmail.com,\n\tmatthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc,\n\tprabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com,\n\trohan.g.thomas@altera.com, sdf@fomichev.me,\n\tsiyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com,\n\twens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org,\n\tlinux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-stm32@st-md-mailman.stormreply.com,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next 04/12] net: stmmac: dma: create a separate\n dma_device pointer","Message-ID":"<9203d8dd-8ec0-415e-9c2e-5b06b1b8dc11@lunn.ch>","References":"<20260501155421.3329862-1-elder@riscstar.com>\n <20260501155421.3329862-5-elder@riscstar.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260501155421.3329862-5-elder@riscstar.com>"}},{"id":3685198,"web_url":"http://patchwork.ozlabs.org/comment/3685198/","msgid":"<539b9de3-4a78-44cf-9085-06cd0cab2d17@riscstar.com>","list_archive_url":null,"date":"2026-05-01T18:06:23","subject":"Re: [PATCH net-next 04/12] net: stmmac: dma: create a separate\n dma_device pointer","submitter":{"id":89551,"url":"http://patchwork.ozlabs.org/api/people/89551/","name":"Alex Elder","email":"elder@riscstar.com"},"content":"On 5/1/26 12:13 PM, Andrew Lunn wrote:\n>>   \tif (priv->dma_cap.host_dma_width) {\n>> -\t\tret = dma_set_mask_and_coherent(device,\n>> -\t\t\t\tDMA_BIT_MASK(priv->dma_cap.host_dma_width));\n>> +\t\tu64 mask = DMA_BIT_MASK(priv->dma_cap.host_dma_width);\n>> +\n>> +\t\tret = dma_set_mask_and_coherent(priv->dma_device, mask);\n> \n> I'm nitpicking, but i don't think you need to introduce mask.\n> DMA_BIT_MASK... is already on a line of its own, and is within the 80\n> limit. Nothing changes here with s/device/priv->dma_device/\n> \n> \tAndrew\n\nI did this.  It was simply to silence a checkpatch.pl warning\nabout a long line.\n\nI don't care either way, I'll gladly put it back the way it was.\n\n\t\t\t\t\t-Alex","headers":{"Return-Path":"\n <linux-gpio+bounces-35970-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=riscstar-com.20251104.gappssmtp.com\n header.i=@riscstar-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=psJ3Fjh4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35970-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com\n header.i=@riscstar-com.20251104.gappssmtp.com header.b=\"psJ3Fjh4\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.173","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=riscstar.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=riscstar.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6fB735hGz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 02 May 2026 04:06:39 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 5000D3007531\n\tfor <incoming@patchwork.ozlabs.org>; Fri,  1 May 2026 18:06:31 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B356E33F38A;\n\tFri,  1 May 2026 18:06:29 +0000 (UTC)","from mail-yw1-f173.google.com (mail-yw1-f173.google.com\n [209.85.128.173])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EFE2633260F\n\tfor <linux-gpio@vger.kernel.org>; Fri,  1 May 2026 18:06:27 +0000 (UTC)","by mail-yw1-f173.google.com with SMTP id\n 00721157ae682-799001d73bdso21094487b3.0\n        for <linux-gpio@vger.kernel.org>;\n Fri, 01 May 2026 11:06:27 -0700 (PDT)","from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net.\n [75.72.117.212])\n        by smtp.gmail.com with ESMTPSA id\n 00721157ae682-7bd66019105sm14575347b3.0.2026.05.01.11.06.23\n        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n        Fri, 01 May 2026 11:06:26 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777658789; cv=none;\n b=oTseX0Bntm6MDvGWsOiBaiUg79If85HBhfmgYYzylKceNX0Po6DwK5QOQs4Xg1hGbFn22JcLNM3l0qNRyRTGabjEQH1FPddJ73hmAhT90h6ZGfXJ0KfIxC8PNTMSwu5GiNmi5W6R7ab+n7rx7AEwzqo6TCKHKiLyGuBxMs50u7o=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777658789; c=relaxed/simple;\n\tbh=oKkQnY5vlFNovbcjfh6JBo8TVogGXpyGhtvkDtTNy3E=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=O3nT0ea8eUkeJG+ZuPjpKfWLnk0Sj5SG5cdflEfEfGZd+BeRX23ECdEEqfW8EExICbjXrd2c0YPnpOzfFFlV3GCgMU1hyTrF8wuqpgyjxggC8/RQ/X/9vRZ9Oa7ulQaiGgqfULRf8zmV0+yjVJ3PrZKcKfXcjiNq7na14azN48A=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=riscstar.com;\n spf=pass smtp.mailfrom=riscstar.com;\n dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com\n header.i=@riscstar-com.20251104.gappssmtp.com header.b=psJ3Fjh4;\n arc=none smtp.client-ip=209.85.128.173","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1777658787;\n x=1778263587; darn=vger.kernel.org;\n        h=content-transfer-encoding:in-reply-to:from:content-language\n         :references:cc:to:subject:user-agent:mime-version:date:message-id\n         :from:to:cc:subject:date:message-id:reply-to;\n        bh=h1DjW845zhModhDu44NYwmrHvDI4OE4s13MqVWiObLc=;\n        b=psJ3Fjh4F/IvT+GnFPrExEwYlGYre21c/sJ635RZrszNYBXaXf5wN64XMn6ym7/psU\n         Q2p+xXX2OyIDv3LMm6MTze4TlZkVqEoa5LBRKzq8SHUMpzTAWhKGajoUlT/6qaLDwchY\n         5BnJcxhDXuQgHakxWjVfWWVVLyFWoIHmsKPMrAtEoUGU4SP3U/bJWLSo/wF43VT4VLU3\n         JVzTAhYmNHQMjGVKGbxeLIpjZKHAtTc12qpZWpK/Atj7nRqy6PwkvuqCStFJ1iK3aWrp\n         kNUE6XQc2lSrMSKr6TAQQe2G4Uo/xq82lf8T/LX65G1UDU74tl4CipLKYY0ErDW5fkzF\n         Md4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777658787; x=1778263587;\n        h=content-transfer-encoding:in-reply-to:from:content-language\n         :references:cc:to:subject:user-agent:mime-version:date:message-id\n         :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n         :reply-to;\n        bh=h1DjW845zhModhDu44NYwmrHvDI4OE4s13MqVWiObLc=;\n        b=o9jFK7vTCuNNdCaanYeUE0QcfvRPTT1vMQdFTaOa7R9r1Vjv0i18h9bzYoK9GqzJVG\n         oehVElFrFmY2HFcPkqz36mZ8jtQgV2bR2lwrNE0CkmiUOXP50unwXT9jHmPAFCT1PSkT\n         olr9jhEMVWQ3EEHgtwyUheiBIdBxe9JAlb46QOZ5SpcbCEkTEyu4BcFN9KQAjO1UfJS7\n         ZVxOSyyQWSm3KIGmHBId7TdNOpY3EiwvfSYw1REiOX2nhY0AMgNg+2FXt5lVnExBCPc6\n         ZMDqM/+L5pBLWGrUAy+Z8jlUTLbRk9ONoz4cb/3FZcXR4eosewFNyaAv5IJ+OBAHJT2l\n         4tpw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ98uI25iZccoKh2jKlcxbiYg25P41diy1LucahKuvuA9in6xpZ6xkLziNtinZidm2fFPMLqVZlBYhD7@vger.kernel.org","X-Gm-Message-State":"AOJu0YxWCBzHJ2eepRjwnbNHsk4oxLBXeIKdR5d2cnBUXJhelYBGnxXf\n\tHgjNmTWCwYn0idU9kcLVQ/LTD83mTVzS589VudcW75h/sS4cvNvJINXreKGknSrhp0I=","X-Gm-Gg":"AeBDieuMHcmM6wlo30nLC+GS3fzwvO9fd9QrZa27Xmlby3QAMZOnQTJ1AVvaiU3N374\n\tSEdjm8uR1AmXbURIMy4fQSGMxAUNmAWnBjfsrsXEPuQ+Fb45cf/s3POKl21O65OyDYdoE2nNuR+\n\tSRCpeD/mOI5pqWxdavYzP5fjnDvFf65GLF7BGfQNGeAGK0ngR4yuW7HKaIQeMwjLG9Lqfi2sWCu\n\tjED7IelYW+7U0w/6vyTtkYhY37KQ87uEAwz4hAA4ppyGlRNERmpiuzCoMCilINByJoZ+HJu9XSS\n\tBpJecuG97rteCdoT3s45Z/oTdsRF+pQWKlU9PgOWIuyEgNA1sy1KqAVli/e8xIdUNL+D0iXMzVD\n\tGBXIsKdGQT+CChRW+zVC1wWB1/aortROTCZWPQu5BUkZvWuclM/MUVeYS6BcOrALzHUN6kEaHcX\n\t2jo0rTkd9Yoler+yeFZ7ZHP34aGdcZL++Jpa3xCkLr2dWX0RePUP+GNYac+8XHBgbuKQGHV55ep\n\tw==","X-Received":"by 2002:a05:690c:dd3:b0:7af:6904:3f3f with SMTP id\n 00721157ae682-7bd77170409mr4261187b3.45.1777658787005;\n        Fri, 01 May 2026 11:06:27 -0700 (PDT)","Message-ID":"<539b9de3-4a78-44cf-9085-06cd0cab2d17@riscstar.com>","Date":"Fri, 1 May 2026 13:06:23 -0500","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH net-next 04/12] net: stmmac: dma: create a separate\n dma_device pointer","To":"Andrew Lunn <andrew@lunn.ch>","Cc":"andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com,\n rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org,\n robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org,\n brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,\n daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com,\n alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com,\n chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net,\n hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com,\n john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com,\n matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc,\n prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com,\n rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn,\n weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org,\n bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,\n linux-stm32@st-md-mailman.stormreply.com,\n linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","References":"<20260501155421.3329862-1-elder@riscstar.com>\n <20260501155421.3329862-5-elder@riscstar.com>\n <9203d8dd-8ec0-415e-9c2e-5b06b1b8dc11@lunn.ch>","Content-Language":"en-US","From":"Alex Elder <elder@riscstar.com>","In-Reply-To":"<9203d8dd-8ec0-415e-9c2e-5b06b1b8dc11@lunn.ch>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit"}},{"id":3685225,"web_url":"http://patchwork.ozlabs.org/comment/3685225/","msgid":"<4cbe1a04-4a49-4e4d-95f4-ed4df1afa24f@lunn.ch>","list_archive_url":null,"date":"2026-05-01T20:55:41","subject":"Re: [PATCH net-next 04/12] net: stmmac: dma: create a separate\n dma_device pointer","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Fri, May 01, 2026 at 01:06:23PM -0500, Alex Elder wrote:\n> On 5/1/26 12:13 PM, Andrew Lunn wrote:\n> > >   \tif (priv->dma_cap.host_dma_width) {\n> > > -\t\tret = dma_set_mask_and_coherent(device,\n> > > -\t\t\t\tDMA_BIT_MASK(priv->dma_cap.host_dma_width));\n> > > +\t\tu64 mask = DMA_BIT_MASK(priv->dma_cap.host_dma_width);\n> > > +\n> > > +\t\tret = dma_set_mask_and_coherent(priv->dma_device, mask);\n> > \n> > I'm nitpicking, but i don't think you need to introduce mask.\n> > DMA_BIT_MASK... is already on a line of its own, and is within the 80\n> > limit. Nothing changes here with s/device/priv->dma_device/\n> > \n> > \tAndrew\n> \n> I did this.  It was simply to silence a checkpatch.pl warning\n> about a long line.\n> \n> I don't care either way, I'll gladly put it back the way it was.\n\nPlease pull checkpatch fixes out into a patch of their own.\n\n       Andrew","headers":{"Return-Path":"\n <linux-gpio+bounces-35974-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256\n header.s=20171124 header.b=G3dAtTYj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35974-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=\"G3dAtTYj\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=156.67.10.101","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=lunn.ch"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6jy80JsMz1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 02 May 2026 06:56:31 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 39A2330095DA\n\tfor <incoming@patchwork.ozlabs.org>; Fri,  1 May 2026 20:56:29 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 27BA74219ED;\n\tFri,  1 May 2026 20:56:27 +0000 (UTC)","from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B11B03491C4;\n\tFri,  1 May 2026 20:56:25 +0000 (UTC)","from andrew by vps0.lunn.ch with local (Exim 4.94.2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1wIuth-000shL-GJ; Fri, 01 May 2026 22:55:41 +0200"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777668986; cv=none;\n b=fpsUf+yhDtUJJbriSusYk4QgHFg7p7QRECnQwovYyFM4qAtbn0CKWJrf6aFSlU3fZryf8+/1XjK/QYQ1R/qeqwhYZ9cOV6lOrKiYzN+dJdLIXgnyB70+mqDqWSbZRF1GxizNcfDlHC6bRFgyz1zIkKPLA9ZY9iHkYkFM0lTh80Y=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777668986; c=relaxed/simple;\n\tbh=xrA5pvPy1cRCoop4m79kAzLeDUdXCIENeq4TEMsPG5M=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=eCBGqdRN/PQ1DntE3iXtTOaGfkVgy9fFx/VS1MeFtyqhcpLI3LyXFS+RQ+6wiI77TqOQwhl+/9RGh2LmbuT/s4p3vlYnrzdkzAtXis0P0o3R9CZEJtaX2/c0ew0crA55cUzyjDklkVtCf/cQQ9CSOR1ca+Ych9sFDNW3zjfsc4k=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch;\n spf=pass smtp.mailfrom=lunn.ch;\n dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=G3dAtTYj; arc=none smtp.client-ip=156.67.10.101","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;\n\ts=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:\n\tReferences:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:\n\tDate:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:\n\tContent-ID:Content-Description:Content-Disposition:In-Reply-To:References;\n\tbh=3Tcbg9/ugxpQr7TMEC6mX5fl4hcvqIRPYh248BBUiSY=; b=G3dAtTYjFbHZBVFYI5xNUl+35H\n\tKRyZcgox694pudSxsak7WqvEaSJg6i8zmsRlzvrlJA0nRmjkBO6Ki8ttOeZGIjBBz33HVTKQwHVEa\n\tOMKtIGMqPN3Ly370NqGZwL6N2Xu0utn81eXt57J1kyFdGXLZLZHNAY4GisuufoMlJTZk=;","Date":"Fri, 1 May 2026 22:55:41 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Alex Elder <elder@riscstar.com>","Cc":"andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n\tkuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com,\n\trmk+kernel@armlinux.org.uk, andersson@kernel.org,\n\tkonradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,\n\tconor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org,\n\tarnd@arndb.de, gregkh@linuxfoundation.org, daniel@riscstar.com,\n\tmohd.anwar@oss.qualcomm.com, a0987203069@gmail.com,\n\talexandre.torgue@foss.st.com, ast@kernel.org,\n\tboon.khai.ng@altera.com, chenchuangyu@xiaomi.com,\n\tchenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org,\n\thkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com,\n\tjulianbraha@gmail.com, livelycarpet87@gmail.com,\n\tmatthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc,\n\tprabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com,\n\trohan.g.thomas@altera.com, sdf@fomichev.me,\n\tsiyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com,\n\twens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org,\n\tlinux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-stm32@st-md-mailman.stormreply.com,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next 04/12] net: stmmac: dma: create a separate\n dma_device pointer","Message-ID":"<4cbe1a04-4a49-4e4d-95f4-ed4df1afa24f@lunn.ch>","References":"<20260501155421.3329862-1-elder@riscstar.com>\n <20260501155421.3329862-5-elder@riscstar.com>\n <9203d8dd-8ec0-415e-9c2e-5b06b1b8dc11@lunn.ch>\n <539b9de3-4a78-44cf-9085-06cd0cab2d17@riscstar.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<539b9de3-4a78-44cf-9085-06cd0cab2d17@riscstar.com>"}}]