[{"id":3685177,"web_url":"http://patchwork.ozlabs.org/comment/3685177/","msgid":"","list_archive_url":null,"date":"2026-05-01T16:50:45","subject":"Re: [PATCH net-next 02/12] net: pcs: pcs-xpcs: select operating mode\n for 10G-baseR capable PCS","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> +static int xpcs_config_operating_mode(struct dw_xpcs *xpcs, int an_mode)\n> +{\n> +\tint mdio_stat2, ret;\n> +\n> +\tswitch (an_mode) {\n> +\tcase DW_AN_C37_SGMII:\n> +\tcase DW_AN_C37_1000BASEX:\n> +\tcase DW_2500BASEX:\n> +\t\tmdio_stat2 = xpcs_read(xpcs, MDIO_MMD_PCS, MDIO_STAT2);\n> +\t\tif (mdio_stat2 < 0)\n> +\t\t\treturn mdio_stat2;\n> +\n> +\t\t/*\n> +\t\t * If this XPCS supports 10Gbase-R then it will be the default\n> +\t\t * which prevents 1000base-X and slower from working correctly.\n\nIt would be interesting to know if Toshiba messed up the integration\nof the PCS, or there is an errata for the licensed IP.\n\nAnybody got access to the databook and erratas?\n\n\tAndrew","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256\n header.s=20171124 header.b=xrgHg38W;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35965-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=\"xrgHg38W\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=156.67.10.101","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=lunn.ch"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6cX55tRCz1xvV\n\tfor ; Sat, 02 May 2026 02:52:05 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 6022F300A8E0\n\tfor ; Fri, 1 May 2026 16:52:00 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A54583DBD71;\n\tFri, 1 May 2026 16:51:56 +0000 (UTC)","from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F4993CF032;\n\tFri, 1 May 2026 16:51:46 +0000 (UTC)","from andrew by vps0.lunn.ch with local (Exim 4.94.2)\n\t(envelope-from )\n\tid 1wIr4f-000qVa-3e; Fri, 01 May 2026 18:50:45 +0200"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777654314; cv=none;\n b=JLPfdrYyDJft1ItJo42cSEU7ZihTVywr2kPmk0EPFZIJ2z5rs/FOXW552Kup4FHh8LykYlVRswPbW+lI1xs/ikkGOmFGOSMiJQqXj8Bc22b1KHPaMLtRxE/XCfWWHrRqdzOMDhpgStSbstn9ZdHJ8isLSxUs+fGgcsvBD3PXd2M=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777654314; c=relaxed/simple;\n\tbh=CTFis4He3t1/LFd4De7rN9wAVKxGHHY19eqLUCarLt0=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=e0tpjknyads3DfZm2ECcsgmi0NG56E+DI/5QMvT7rz+BLrxu0oXvofEkZpChmkqISdUPaP0foX5QI9qJJlU1XFNbo8UvF5g4EFJRE5TOMiHVR7IO44OBZo0HnvFjUEyeR8kNFya0TtQaGS21tc2iDYIO+TaxmdBSJyo5rlbNu0w=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=lunn.ch;\n spf=pass smtp.mailfrom=lunn.ch;\n dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch\n header.b=xrgHg38W; arc=none smtp.client-ip=156.67.10.101","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;\n\ts=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:\n\tReferences:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:\n\tDate:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:\n\tContent-ID:Content-Description:Content-Disposition:In-Reply-To:References;\n\tbh=RgEmX7QWgKuD1xhClx3Y+N85BnaTDGrIn2lScP6LvKU=; b=xrgHg38WznelxoazLMABuUpg3K\n\tCuv2JUXhNPm0pIm2H8VrqhbDIwFNhL+Op32WUoSqymwLL4xc1QLW10L0q1pY1ovTnR3HdNiWmiDUQ\n\tmMLyATdYrjaQ+gda2tIzVaJojM4cFRHvE+0vPm78KYHsVVzS/JMS1eXRNefXhrEu3k7k=;","Date":"Fri, 1 May 2026 18:50:45 +0200","From":"Andrew Lunn ","To":"Alex Elder ","Cc":"andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n\tkuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com,\n\trmk+kernel@armlinux.org.uk, andersson@kernel.org,\n\tkonradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,\n\tconor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org,\n\tarnd@arndb.de, gregkh@linuxfoundation.org,\n\tDaniel Thompson , mohd.anwar@oss.qualcomm.com,\n\ta0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org,\n\tboon.khai.ng@altera.com, chenchuangyu@xiaomi.com,\n\tchenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org,\n\thkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com,\n\tjulianbraha@gmail.com, livelycarpet87@gmail.com,\n\tmatthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc,\n\tprabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com,\n\trohan.g.thomas@altera.com, sdf@fomichev.me,\n\tsiyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com,\n\twens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org,\n\tlinux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-stm32@st-md-mailman.stormreply.com,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH net-next 02/12] net: pcs: pcs-xpcs: select operating mode\n for 10G-baseR capable PCS","Message-ID":"","References":"<20260501155421.3329862-1-elder@riscstar.com>\n <20260501155421.3329862-3-elder@riscstar.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260501155421.3329862-3-elder@riscstar.com>"}},{"id":3685199,"web_url":"http://patchwork.ozlabs.org/comment/3685199/","msgid":"","list_archive_url":null,"date":"2026-05-01T18:07:47","subject":"Re: [PATCH net-next 02/12] net: pcs: pcs-xpcs: select operating mode\n for 10G-baseR capable PCS","submitter":{"id":89551,"url":"http://patchwork.ozlabs.org/api/people/89551/","name":"Alex Elder","email":"elder@riscstar.com"},"content":"On 5/1/26 11:50 AM, Andrew Lunn wrote:\n>> +static int xpcs_config_operating_mode(struct dw_xpcs *xpcs, int an_mode)\n>> +{\n>> +\tint mdio_stat2, ret;\n>> +\n>> +\tswitch (an_mode) {\n>> +\tcase DW_AN_C37_SGMII:\n>> +\tcase DW_AN_C37_1000BASEX:\n>> +\tcase DW_2500BASEX:\n>> +\t\tmdio_stat2 = xpcs_read(xpcs, MDIO_MMD_PCS, MDIO_STAT2);\n>> +\t\tif (mdio_stat2 < 0)\n>> +\t\t\treturn mdio_stat2;\n>> +\n>> +\t\t/*\n>> +\t\t * If this XPCS supports 10Gbase-R then it will be the default\n>> +\t\t * which prevents 1000base-X and slower from working correctly.\n> \n> It would be interesting to know if Toshiba messed up the integration\n> of the PCS, or there is an errata for the licensed IP.\n> \n> Anybody got access to the databook and erratas?\n> \n> \tAndrew\n\nI have the same question. We do not (currently/yet?) have access\nto this information.\n\n\t\t\t\t\t-Alex","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=riscstar-com.20251104.gappssmtp.com\n header.i=@riscstar-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=G7l+WI78;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35971-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com\n header.i=@riscstar-com.20251104.gappssmtp.com header.b=\"G7l+WI78\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.160.175","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=riscstar.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=riscstar.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6fCl3R3Pz1xvV\n\tfor ; Sat, 02 May 2026 04:08:03 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 119123008C22\n\tfor ; Fri, 1 May 2026 18:08:01 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0C8343F1657;\n\tFri, 1 May 2026 18:07:57 +0000 (UTC)","from mail-qt1-f175.google.com (mail-qt1-f175.google.com\n [209.85.160.175])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 00D563F2111\n\tfor ; Fri, 1 May 2026 18:07:52 +0000 (UTC)","by mail-qt1-f175.google.com with SMTP id\n d75a77b69052e-50e97863425so20690281cf.0\n for ;\n Fri, 01 May 2026 11:07:52 -0700 (PDT)","from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net.\n [75.72.117.212])\n by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-51040b80a4dsm20498971cf.24.2026.05.01.11.07.48\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 01 May 2026 11:07:50 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777658875; cv=none;\n b=jt46bJYTt/MzuvlyqqF0ZBIeIHx7TPHdezH8eKMz8vCdY3uT9HGOzCP+WsCf+USuNwUdA4cw8BlmI2GDS4u58rPRy6w78i1lzJ/n/2vpDZmeYoIbKl/HIaCVmKGMawMmJEWBUe8zjJlcJixjHLYyKAwWlGZOMyN6lkxHZmgIprY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777658875; c=relaxed/simple;\n\tbh=eynylHZFBsXgEqVs+4fseQrXK93kdKB/9Os3we6Deik=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=FAC0Oxi1LwkltXY6hL2WigjbeaxnkDfxEQWo4tgVecjLHlkUfBilo87NRwMRW508BYYDhT8drAhxlYOKIjBH5UB6hgehiOX1/Dp+Jp6+6Y8GyxGu9Lwtu6jKQ3Xhh5yZEH2VpgqBil5x1REJ8TFVBvaO9zuWaJneZILwruCRS30=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=riscstar.com;\n spf=pass smtp.mailfrom=riscstar.com;\n dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com\n header.i=@riscstar-com.20251104.gappssmtp.com header.b=G7l+WI78;\n arc=none smtp.client-ip=209.85.160.175","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1777658871;\n x=1778263671; darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=a7l6FEvqkNwJ0g7Pn9F7zooR8PbKdP3FdX90Rm3Ztm8=;\n b=G7l+WI787dWOE2tuWa3pxOfVBIYDqnB2m5j6wtTcxdKJGenYim/0DQ7lc1rQAGN38R\n egZGidDVax5FzICC7e6oByuAVxtIc43hobHgPS6WF9qrrLDMcPiscPYRYItZAdR95oq/\n 3F8mrn+s6cyh8RxBW2qKlMbk9rQzufBK2taQ4JyRAwVLRhWdNOMAaOjfeNiViFLqGwjH\n KoJUY3jNnKDwN7H7sNIRSGtV0okc2Lvj4rIyMJm7ht42K8oWrCz1ueaD6d5EWEqgOVxa\n QmZjJghsojHblT2joTbvV8bouomEpeQwLsAMHIzNap0chIQy8QEu5w+5oOtX4L0IrXhy\n 1VZg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777658871; x=1778263671;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=a7l6FEvqkNwJ0g7Pn9F7zooR8PbKdP3FdX90Rm3Ztm8=;\n b=EUYjHA/LeXoUaafnwK9FHy4sZg4cmbAHSCxsoKjP1xQjMoA1hNEZimVBvrbdPZY8V5\n Ixn1qFBN2m4y8C9ztrI+I5dN8AwiyS2//Iz4iR7Jr58WfrXlt1Q40yj5zwPBz1j2y0Ae\n jg1cjzagyxZQd+U/1XLenZm9r+3EsiFcdhkwhFwhTBv4D+8Mi7LijfL/dk9huZuF15TC\n kQopZri+71/Z7v0zxkJpATDhPvMLoqCqkl18f/smWnsyTUdEA6eWsMtnhCv3R11gBw/8\n 0Gy7fT8s2Z04+X3PcStSP/iW6IomoFLO/5REjbYINYiRTC3DCTkOLjSKfhtCcGNu7t9Z\n 1liA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9YMYhq7206K3HOBEkOw8I3g8FSoTXSt27p9zDZ+p2RzvR4HQLpjLD6tE6Ed/JLfg9lgb1lbu4adsjA@vger.kernel.org","X-Gm-Message-State":"AOJu0Yx29xJ4k5SnuVf+2NIVEAq9Th2tOcXTVTxrAzmr/SwAjXplG8LY\n\t9sGJ4hC5q1IOhwMwIrvEpr9ur4lp5xm5iapjICbNHFYDJjg+1g1VgZTV1zuJfnXi8kY=","X-Gm-Gg":"AeBDievvJsmbOqol6AlSVhJ9lIlQvo9YATuovjbYiFTaSRm6bJuSc7E52QOv6Q32uw5\n\t1+neGKE/lB2yacWhp3UoOcJs0bzuRQTf648xmP1X+3z3+bdTaXmtwJM00cXSw7LTnsktb3ftOkI\n\tUv8UoIX73nCkosNm2pHul3XEA+cCgUkvh3vfOs8Mczro5fqcTyQRDRXiIBhSosx95u4GjsH9iBV\n\tRsTnFypQeCbwtJmdH/kFEgSxYba+whz0BbTIf58hxR8lAGqMoCAbEVqiPjDCW1vz5fTpUD/uxeV\n\t/3TebjynjGoiYQemgdYshmbv1WyIHbS7JFoie6FiQX/uaYnFeYb/SKDuj70+usJEQmry+T2ITX2\n\taK4ULYrf3vjmDZHilD2U4VvFAcK8IFXd5dchGDBpA5fKhAusyLH0ByfD+965+SlHC83UEhm268K\n\tv/FiQmWUNrniql0LgLss9HP99Bo2qbTU295nLFMNWIWtetpnZhLxyNpaH/gOynPgQWYyClbu/KD\n\tpZX9UUiXhJn","X-Received":"by 2002:a05:622a:903:b0:50b:3f6a:1d88 with SMTP id\n d75a77b69052e-5104be231f4mr4182581cf.19.1777658871298;\n Fri, 01 May 2026 11:07:51 -0700 (PDT)","Message-ID":"","Date":"Fri, 1 May 2026 13:07:47 -0500","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH net-next 02/12] net: pcs: pcs-xpcs: select operating mode\n for 10G-baseR capable PCS","To":"Andrew Lunn ","Cc":"andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com,\n rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org,\n robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org,\n brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,\n Daniel Thompson , mohd.anwar@oss.qualcomm.com,\n a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org,\n boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org,\n daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com,\n inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com,\n livelycarpet87@gmail.com, matthew.gerlach@altera.com,\n mcoquelin.stm32@gmail.com, me@ziyao.cc,\n prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com,\n rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn,\n weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org,\n bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,\n linux-stm32@st-md-mailman.stormreply.com,\n linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","References":"<20260501155421.3329862-1-elder@riscstar.com>\n <20260501155421.3329862-3-elder@riscstar.com>\n ","Content-Language":"en-US","From":"Alex Elder ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]