[{"id":3685245,"web_url":"http://patchwork.ozlabs.org/comment/3685245/","msgid":"<177767942280.3662469.15016765867771829872.git-patchwork-notify@kernel.org>","list_archive_url":null,"date":"2026-05-01T23:50:22","subject":"Re: [PATCH net 01/14] netfilter: replace skb_try_make_writable() by\n skb_ensure_writable()","submitter":{"id":80291,"url":"http://patchwork.ozlabs.org/api/people/80291/","name":null,"email":"patchwork-bot+netdevbpf@kernel.org"},"content":"Hello:\n\nThis series was applied to netdev/net.git (main)\nby Pablo Neira Ayuso :\n\nOn Fri, 1 May 2026 14:22:24 +0200 you wrote:\n> skb_try_make_writable() only works on clones and uncloned packets might\n> have their network header in paged fragments.\n> \n> nft_fwd needs to work for the ingress and egress hooks, but the egress\n> hook where skb->data points to the mac header, use skb_network_offset()\n> to include the mac header. The flowtable is fine since it already uses\n> the transport offset.\n> \n> [...]\n\nHere is the summary with links:\n - [net,01/14] netfilter: replace skb_try_make_writable() by skb_ensure_writable()\n https://git.kernel.org/netdev/net/c/1049970d7583\n - [net,02/14] netfilter: nft_fwd_netdev: add device and headroom validate with neigh forwarding\n https://git.kernel.org/netdev/net/c/0a0b35f0bf10\n - [net,03/14] netfilter: nft_fwd_netdev: use recursion counter in neigh egress path\n https://git.kernel.org/netdev/net/c/1d47b55b36d2\n - [net,04/14] netfilter: x_tables: add .check_hooks to matches and targets\n https://git.kernel.org/netdev/net/c/6813985ca456\n - [net,05/14] netfilter: nft_compat: run xt_check_hooks_{match,target}() from .validate\n https://git.kernel.org/netdev/net/c/2f768d638d97\n - [net,06/14] netfilter: xt_CT: fix usersize for v1 and v2 revision\n https://git.kernel.org/netdev/net/c/8bedb6c46945\n - [net,07/14] netfilter: nf_tables: fix netdev hook allocation memleak with dormant tables\n https://git.kernel.org/netdev/net/c/63bac0278603\n - [net,08/14] netfilter: nf_socket: skip socket lookup for non-first fragments\n https://git.kernel.org/netdev/net/c/0bf00859d7a5\n - [net,09/14] netfilter: nf_tables: skip L4 header parsing for non-first fragments\n https://git.kernel.org/netdev/net/c/009d203e56db\n - [net,10/14] netfilter: xtables: fix L4 header parsing for non-first fragments\n https://git.kernel.org/netdev/net/c/952e121c9613\n - [net,11/14] netfilter: flowtable: ensure sufficient headroom in xmit path\n https://git.kernel.org/netdev/net/c/ef4f741e8627\n - [net,12/14] netfilter: flowtable: fix inline vlan encapsulation in xmit path\n https://git.kernel.org/netdev/net/c/a177ae30f786\n - [net,13/14] netfilter: flowtable: fix inline pppoe encapsulation in xmit path\n https://git.kernel.org/netdev/net/c/69c54f80f4a7\n - [net,14/14] netfilter: flowtable: use skb_pull_rcsum() to pop vlan/pppoe header\n https://git.kernel.org/netdev/net/c/baa3c65435fb\n\nYou are awesome, thank you!","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ridUYzzb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12388-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ridUYzzb\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6nqr006zz1yJ0\n\tfor ; Sat, 02 May 2026 09:51:19 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 008833019F30\n\tfor ; Fri, 1 May 2026 23:51:12 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 87D1737B03F;\n\tFri, 1 May 2026 23:51:10 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1680E2EC0A1;\n\tFri, 1 May 2026 23:51:09 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A41DBC2BCB4;\n\tFri, 1 May 2026 23:51:09 +0000 (UTC)","from [10.30.226.235] (localhost [IPv6:::1])\n\tby aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id\n 02DD7380CEF5;\n\tFri, 1 May 2026 23:50:24 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777679470; cv=none;\n b=Mb4j+x9C7SDbMgsyZoI2xtu0lhYvJFSKi79o4c3+lPlDIBBmmtgAb/7wH3ed4WbLpf/OBqOsC6K2s3SDk2HVfUTCTEY4YGyuxipLYRF5uM0kXjyRlKkJI3mozvtMWTOGgBBY8fQ7eXGUohASNjiiw2e35NJZVAoHz+XCmQlboHQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777679470; c=relaxed/simple;\n\tbh=blhZiMz/SgM1lwXzxNwOF/MqFMiwiS0W4iq5pX26ISo=;\n\th=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References:\n\t In-Reply-To:To:Cc;\n b=YLTiNXUBjtFKoE7sUj0Td3phC7x4Jsbr7W6J280UbhdpKI3jxWVA0hfJCzvpkl4UUzCTzaqBLRN1jLORrLAWjh7YfDAcOGXyTjvM2+TY+okGFDMDdjeG0DRIjM0E3wD/DqM3+XtXcsIRujBmVpDPaNF3p9uXRNWxQsOzZ5sXGrg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ridUYzzb; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777679469;\n\tbh=blhZiMz/SgM1lwXzxNwOF/MqFMiwiS0W4iq5pX26ISo=;\n\th=Subject:From:Date:References:In-Reply-To:To:Cc:From;\n\tb=ridUYzzbW5d9KyRTmy9Bv6NTF+Gjw9gTRy5yF0PtQVzQhxnkhBUu/iPKTEP62Cwvp\n\t RgOI5LbCokT4ta2HuLNyHbuQWh8/cE48NXkm86tnXsEjVyglB2TQ9AzVwsb9ix2jqm\n\t J33bmzLmcz4BEvUk6iT8Jm7rtG9tK5SY7zjaNjlmykJTE/Mi42OpalzU2mCBrBEYlz\n\t UiOsw5f+Tb3fsYD0fmBaRuFzKKw3wHHIjo6WsfogsuqXSamoXk18JsxBdeIJYg1Ted\n\t PMTNkonPQaa0FSlfBjcT026aY8gkrLXsUAfkpXimfClIxY3j+CwQBN9r3jPhBKrQZB\n\t iHSeFbU5//TQQ==","Content-Type":"text/plain; charset=\"utf-8\"","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [PATCH net 01/14] netfilter: replace skb_try_make_writable() by\n skb_ensure_writable()","From":"patchwork-bot+netdevbpf@kernel.org","Message-Id":"\n <177767942280.3662469.15016765867771829872.git-patchwork-notify@kernel.org>","Date":"Fri, 01 May 2026 23:50:22 +0000","References":"<20260501122237.296262-2-pablo@netfilter.org>","In-Reply-To":"<20260501122237.296262-2-pablo@netfilter.org>","To":"Pablo Neira Ayuso ","Cc":"netfilter-devel@vger.kernel.org, davem@davemloft.net,\n netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,\n edumazet@google.com, fw@strlen.de, horms@kernel.org"}}]