[{"id":3685159,"web_url":"http://patchwork.ozlabs.org/comment/3685159/","msgid":"","list_archive_url":null,"date":"2026-05-01T15:47:31","subject":"Re: [PATCH v4 13/19] cifs: option to disable time-based eviction of\n cache","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"Seems like there is still value in temporarily free up the dir cache\n(setting dir_cache_timeout to 0), remount with nohandlecache may not\nbe as helpful if you just want to temporarily reset the dir cache for\ndebugging. Is there another option that could set it to unlimited\n(e.g. setting to -1, if that is allowed)?\n\nOn Fri, May 1, 2026 at 6:20 AM wrote:\n>\n> From: Shyam Prasad N \n>\n> Today there is no way to disable time-based eviction of dir cache.\n> dir_cache_timeout = 0 meant immediate free up of dir cache on next\n> laundromat scan. We already have nohandlecache to disable dir cache.\n>\n> This changes the meaning of dir_cache_timeout = 0 to mean unlimited\n> timeout. Shrinker-based eviction is still possible.\n>\n> Signed-off-by: Shyam Prasad N \n> ---\n> fs/smb/client/cifsfs.c | 2 +-\n> fs/smb/client/connect.c | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c\n> index ee5de358e27f8..79a6a4c297ee3 100644\n> --- a/fs/smb/client/cifsfs.c\n> +++ b/fs/smb/client/cifsfs.c\n> @@ -121,7 +121,7 @@ MODULE_PARM_DESC(cifs_max_pending, \"Simultaneous requests to server for \"\n> unsigned int dir_cache_timeout = 30;\n> module_param(dir_cache_timeout, uint, 0644);\n> MODULE_PARM_DESC(dir_cache_timeout, \"Number of seconds to cache directory contents for which we have a lease. Default: 30 \"\n> - \"Range: 1 to 65000 seconds, 0 to disable caching dir contents\");\n> + \"Range: 0 to 65000 seconds. 0 disables timeout-based cleanup (cached dirs persist until explicitly invalidated).\");\n> /* Module-wide total cached dirents (in bytes) across all tcons */\n> atomic64_t cifs_dircache_bytes_used = ATOMIC64_INIT(0);\n> static struct shrinker *cifs_dircache_shrinker;\n> diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c\n> index 69b38f0ccf2b2..849c16c538353 100644\n> --- a/fs/smb/client/connect.c\n> +++ b/fs/smb/client/connect.c\n> @@ -2698,7 +2698,7 @@ cifs_get_tcon(struct cifs_ses *ses, struct smb3_fs_context *ctx)\n>\n> if (ses->server->dialect >= SMB20_PROT_ID &&\n> (ses->server->capabilities & SMB2_GLOBAL_CAP_DIRECTORY_LEASING))\n> - nohandlecache = ctx->nohandlecache || !dir_cache_timeout;\n> + nohandlecache = ctx->nohandlecache;\n> else\n> nohandlecache = true;\n> tcon = tcon_info_alloc(!nohandlecache, netfs_trace_tcon_ref_new);\n> --\n> 2.43.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=CMLnBP6S;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11345-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"CMLnBP6S\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.219.54","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6b6Q3y4Qz1xqf\n\tfor ; Sat, 02 May 2026 01:48:14 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CE2F43009CD5\n\tfor ; Fri, 1 May 2026 15:47:53 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7EE0F3D16EC;\n\tFri, 1 May 2026 15:47:50 +0000 (UTC)","from mail-qv1-f54.google.com (mail-qv1-f54.google.com\n [209.85.219.54])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 22DAC3D1717\n\tfor ; Fri, 1 May 2026 15:47:45 +0000 (UTC)","by mail-qv1-f54.google.com with SMTP id\n 6a1803df08f44-8a3970f1a0eso21262256d6.2\n for ;\n Fri, 01 May 2026 08:47:45 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777650469; cv=pass;\n b=uis5hwXjhXbwdvPCL0piZwhzrZNS96WrgPOmOsoLkytklyV42mXzUEknruv//1MgOQPPdREaIfYQ0iOnfnZ3PoGoFYJWzt4RmmvngyXkmdTYFW5+kqBKAKDoJQxOyI1HikbN1byxHSe4tAYOAo8pM30ot7Z+FcKkVAo8P/5XcuE=","i=1; a=rsa-sha256; t=1777650464; cv=none;\n d=google.com; s=arc-20240605;\n b=QboVQskl3ZwgqPEbx9YlNNlAXThdJVPvaF4tKT/FYoWJtjKTjfvjn+64KfKqdXlg6J\n 4K4mBabH6TCQ2F6U6R1GFXunj9jxbgDbV1HNt5aAYx7o3/WZ50U89/azHRLsF0QHsNx9\n oHetlft1UT2KpvjA8V0+RqZXlEfEqn4PGeqdRSNwF3g5RdWg1MgE0BlAohck11ImGxo1\n 0/4fa/25Wha9xgntK6H/cDLMclWy8qU5vRrGnFOr12DSM3e9nQtFqalpIaQ5evdCNDCk\n a1YmKczugCZz8qm9io37MQ3KC4k26ZFtsS7J2RXmGiuL7XenPTxrObdoIzkL5qV7t1Qf\n 6HBw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777650469; c=relaxed/simple;\n\tbh=KAMJcyUu+loBy7Z7OuvsQT75z4RaI/BrOPyP8+HUS3E=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=Zol9ncB2BHhx9qZZ4ygqYgB+lo4FVGMuFCl6c8DsjioEevH3gT8398PehE9x+NVCXB/5STwUaK3xf6JXguCwtILNiWG27kAuJX/xCkrPOswmXZhFLKxB+SXt7Acs57EMatbrBfTMk3uTqgeMa6jZyYIzdhraG+FGq1n6/1i/tY8=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=LbaE+Aza58xRPo79sT8dReX3dgImdntDKN4JIT9S5r8=;\n fh=7A3r6+09tzNnhHTw+uNnYVJyzJRQqAQTAUc0TDW5sqE=;\n b=f7WrKSmrmWw2xENOAvTJQTWxbtr+0SJ5YKX+2L+8qit60I/HzcgxhWXKSH1EEIK9NV\n TiaffIiiUvYOWGKw/11GmK0SjTi3MoF4o217hgtN5DTDwoKnn/riddyFQDpHvxhtpZ5t\n sqJtg/IkdZtt8Sb7NJOMZRcyh++qmpuXnfqWbVAZKzyWDscCrSEdWX5/D+FQXc/9LT29\n PfczwbgfimUz5dJ0fMHgFRKzWj7XHU/T/z74FPQk/1FGnTE/orqVATISPred36iDyH5V\n yyrwD1QIQGZFmdxsSnlL2VptW76aneaJzTyL5FALiy+LqgcFWSBdTQdrp7HccpZ1jfAZ\n TU3g==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=CMLnBP6S; arc=pass smtp.client-ip=209.85.219.54","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777650464; x=1778255264;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LbaE+Aza58xRPo79sT8dReX3dgImdntDKN4JIT9S5r8=;\n b=CMLnBP6S4xDar5Bv0HF8WsfB3qnRulGc2NuS4wdEkB81S35IpLNa3s5PCIWM5WfPHx\n uDkogzQ/f8puhXH4D2U8GZ4ughspXC8LAbgwrTAea6RzxMAwGFcC7Dzh+ODtYifD0iIK\n I06svyZWTPF6YUgzLPSgihg9iVdCtaRgXH1qaOf5dhP1xwfKxsWqu/a3zBQbiX8R7wR0\n GWpzwch58PWtZhTu2G9l9eL/lMQAf3e5Zbu0DZcNFqXqsuBATWegPwPq8RoOHkwbDLO6\n f9i08E2YIS8CtZIdiRbZAxBQdhTIZd8m2wqm6BLpKGj9SM2Xgn0YrHvDw3sBf87xCxj7\n R3wQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777650464; x=1778255264;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LbaE+Aza58xRPo79sT8dReX3dgImdntDKN4JIT9S5r8=;\n b=CoX0ZKqfDgFQZdlMR8oYI3z3vqsH2vYjyJFmOAB2CLvu81LkWmO/M7HioJTAr30lX3\n VXEDWYdsEzrEQioM3o7VlQWofI8OhcGAci6XyIquBxH7eY+MbsyCM28w/cJvWLNgRi/Y\n 0Bhu5FEFfXKDI80A+5s3hj2eQRE69ZGl9jWTSXNhAZyyZq8j2f4KFyQwtjxRScQpjlzI\n bj6nUjeD6yVuRUO3hEg25xLUhb+PbLdPkTX+An+Imdz1d/Dx5ID/Hs+UoJwv6dCosDmO\n XzY8e05KOcv+5Dk1mmL8FPvpnZeHUIg85IaZLalMVV1dNsJRlAfW/KUxJP8OuBHHpv7c\n qWRQ==","X-Gm-Message-State":"AOJu0YzQV6Pq9S2YvT9eakVGohl6gWY4QgbrmaHaLFRvX33dsDXPOLOr\n\tuReconcivtPgF/HEGSgtCGWoHboRcB1IZPRR0/qO4Et1KxZo+GMMZfrRmvQ414fy08qEpxBJStA\n\tvb0WS/u1n8+zTGAl0Dutn6POYKrIusCo=","X-Gm-Gg":"AeBDieubr16DiuTZmWvhxzo6bRDEg8ckz/W3xFMSWYsm2pqESrvNZ6uxcE7coyOW2o3\n\t8uIzESJxVqtx12AE0e18PJ1fv02L8XE6ep0MXzBLBf9Q2Bshh5K+0Rem78pfL58/yBQ/PGwJKXd\n\tGs3Xg+hHOUI3N9BXSH4QC7r1QO+nN9ULwHm+/5CvWqF5Bn0LsOvdRo4n2elRSeRHBFADQwxl7cW\n\t8EdGxsijZ81vi3fNZWcb7dOOpmUUvpV+w76Bnlv3IfX+wAoF5xUhD5qxGJHVJbVmGBMUze9IvKR\n\tI5gQmpccGawu5KHGHDzpegczdxRNgE7awbGMVs9cldPd6hlPV+bVsew6wRZyYJH3MPp7+N1zjo6\n\tcuiq4Ic6hXQSLDXFTEabBG2lelNPGvLWlYYFgNlVVes7q8/raQz2h6j9Tj0fldOMDOOscJZg=","X-Received":"by 2002:a05:6214:4285:b0:89c:cfcc:2f31 with SMTP id\n 6a1803df08f44-8b667d75121mr314426d6.32.1777650464271; Fri, 01 May 2026\n 08:47:44 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260501112023.338005-1-sprasad@microsoft.com>\n <20260501112023.338005-13-sprasad@microsoft.com>","In-Reply-To":"<20260501112023.338005-13-sprasad@microsoft.com>","From":"Steve French ","Date":"Fri, 1 May 2026 10:47:31 -0500","X-Gm-Features":"AVHnY4KZUhie906gbiYG-risco5S5vSN8rwIdb5hOXMHNzFG6cwnGLrAOIBCwTc","Message-ID":"\n ","Subject":"Re: [PATCH v4 13/19] cifs: option to disable time-based eviction of\n cache","To":"nspmangalore@gmail.com","Cc":"linux-cifs@vger.kernel.org, pc@manguebit.org, bharathsm@microsoft.com,\n\tdhowells@redhat.com, henrique.carvalho@suse.com, ematsumiya@suse.de,\n\tShyam Prasad N ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]