[{"id":3684997,"web_url":"http://patchwork.ozlabs.org/comment/3684997/","msgid":"","list_archive_url":null,"date":"2026-05-01T00:57:15","subject":"Re: [PATCH] ASoC: tegra: ADMAIF: allocate with a single kzalloc","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Thu, Apr 30, 2026 at 02:42:02PM -0700, Rosen Penev wrote:\n> Signed-off-by: Rosen Penev \n> ---\n> Consolidate the allocations for capture_dma_data and playback_dma_data\n> into a single kzalloc by using a flexible array member at the end of\n> the tegra_admaif struct. This reduces the number of allocations from\n> three to one, simplifies error handling, and improves memory locality.\n> \n\nWhy is the changelog for this included after the --- as something to be\nremoved from the commit?","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=g4m4RRYB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14126-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"g4m4RRYB\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6CLY3hSZz1y1d\n\tfor ; Fri, 01 May 2026 10:57:22 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 0A71B30058C9\n\tfor ; Fri, 1 May 2026 00:57:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 52D42273D8D;\n\tFri, 1 May 2026 00:57:18 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 15FFF79CD;\n\tFri, 1 May 2026 00:57:17 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 81DFAC2BCB3;\n\tFri, 1 May 2026 00:57:17 +0000 (UTC)","by finisterre.sirena.org.uk (Postfix, from userid 1000)\n\tid 36FA71AC5860; Fri, 01 May 2026 01:57:15 +0100 (BST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777597038; cv=none;\n b=brgVvhANQvyjNj7pI9HfrwPFUwy3EHrGEIHHqWHaAYNggZ+/ppoX7hVXk8FCXmXr0PS2+JYavj84s6I2pKneUVRFKArTsFs1OIMDN7eKTyoSn1k1rdEo7upJzzCsf4lFfcgshR6IYp+bsJeoehVBNF5/VEWiobK5cFXayuTJP5c=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777597038; c=relaxed/simple;\n\tbh=PG9ltAWBLj8EtAjYTgCzT0ZRbzn2Rm/InA+LF3h+xBg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=Y7+H+Qy/Nv873L9sy8HptognYBkzj3tePysiYXBksZUlCgHOf+bNPopjG8UCpM528Ov49/+aMnXV/0zm1g8T2NL2DI55IjZW6KOOFwpaiHVksRWuMjjo+T0hIFbRT7Nd8uiLx4onKC5WwBcA5+v8j/4KZXOfgqLsRO6+C8uvPyE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=g4m4RRYB; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777597037;\n\tbh=PG9ltAWBLj8EtAjYTgCzT0ZRbzn2Rm/InA+LF3h+xBg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=g4m4RRYB2N8oxdneirtbwnEec5RVHmYBrsqFf4i2dDPhSDiOjXq2S7+vCOJ5OLuaE\n\t 65RUkTKmv0cWs9iNSXlFKXgWK3qRHn9o8eTe+aMTXakCvEAs09ov5tdb5a42+YFmge\n\t 5y7HsATQU+Yst6nuSrp+ynCqYhtxdPwCMAujyLm9A9vVjHU4iB6KwCP7z3JuLj59LS\n\t +gifv6MILoCuj0mbEe+AaUKh7o1XWKhMgm2AeJcmg0plHcLly/xifjbgWRkPj2GWFT\n\t gTa3ZPda0O7RzEtwAp6pGw4u+wJ8GYTegYCyazhMnEb6ex3YAVkbtSJyKlJBxDdItj\n\t R/LgMaIkqG6DQ==","Date":"Fri, 1 May 2026 09:57:15 +0900","From":"Mark Brown ","To":"Rosen Penev ","Cc":"linux-sound@vger.kernel.org, Liam Girdwood ,\n\tJaroslav Kysela , Takashi Iwai ,\n\tThierry Reding ,\n\tJonathan Hunter ,\n\t\"open list:TEGRA ARCHITECTURE SUPPORT\" ,\n\topen list ","Subject":"Re: [PATCH] ASoC: tegra: ADMAIF: allocate with a single kzalloc","Message-ID":"","References":"<20260430214202.58405-1-rosenp@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"4tm3J6wD+vEuxauR\"","Content-Disposition":"inline","In-Reply-To":"<20260430214202.58405-1-rosenp@gmail.com>","X-Cookie":"667:"}},{"id":3684999,"web_url":"http://patchwork.ozlabs.org/comment/3684999/","msgid":"","list_archive_url":null,"date":"2026-05-01T01:14:57","subject":"Re: [PATCH] ASoC: tegra: ADMAIF: allocate with a single kzalloc","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/people/70304/","name":"Rosen Penev","email":"rosenp@gmail.com"},"content":"On Thu, Apr 30, 2026 at 5:57 PM Mark Brown wrote:\n>\n> On Thu, Apr 30, 2026 at 02:42:02PM -0700, Rosen Penev wrote:\n> > Signed-off-by: Rosen Penev \n> > ---\n> > Consolidate the allocations for capture_dma_data and playback_dma_data\n> > into a single kzalloc by using a flexible array member at the end of\n> > the tegra_admaif struct. This reduces the number of allocations from\n> > three to one, simplifies error handling, and improves memory locality.\n> >\n>\n> Why is the changelog for this included after the --- as something to be\n> removed from the commit?\nMe being careless. That is, it was written after git format-patch. Will resend.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=W1kE6gNP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14127-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"W1kE6gNP\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.167.47","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6Cl76WS7z1yHZ\n\tfor ; Fri, 01 May 2026 11:15:15 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E78403019F0F\n\tfor ; Fri, 1 May 2026 01:15:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BDF4F28504D;\n\tFri, 1 May 2026 01:15:13 +0000 (UTC)","from mail-lf1-f47.google.com (mail-lf1-f47.google.com\n [209.85.167.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EFA12C21C7\n\tfor ; Fri, 1 May 2026 01:15:12 +0000 (UTC)","by mail-lf1-f47.google.com with SMTP id\n 2adb3069b0e04-5a4113ab355so1620907e87.1\n for ;\n Thu, 30 Apr 2026 18:15:11 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777598113; cv=pass;\n b=i8K5dlth3bQvJrnaW1JLEs6OHypPZH8KpFr7M61OWjzwqUKExXzA1I1FQhDDlkA50bqOYfGF07to0pm84b2CDANbnaNNSfrzPB6KjpPQU85Dl4uiSn7e/ROqVJH5/RzZXQTmzKWE6Sn+O3OctfQ7i1mldSb7U6mkLf0f1HjC9Ik=","i=1; a=rsa-sha256; t=1777598110; cv=none;\n d=google.com; s=arc-20240605;\n b=bi5zmw+CzkSmPPt4lz3Y6o7Q9+BgYt5L1FYerP7rtfURYa11/ZtRAUZZAAdp9A9nQ2\n U6yY3K7BEP8OYl72r+9vGfjoTmduo0njt2zwp48/E/y+0tQSF/EgB4szTVtKWyWc1u2l\n Bd9Tw/R6JWXS7hZGb/vlfHI5OKTOVy5GB0hOKt9lGGumKIxcs+/FZ0lOuZ8cWIlo/jIr\n jjmxYe8yivqSwd89s7iRb7fFKPmAxxytqRfvy1fmmWMmNa48eFKHOJTFH5x85XjzKnba\n jE2lnDxQdQWBiBGFBVO3hhbpaUKrVFFUAYuXCAizkB3d16ig5QMM8inoTfcb96EpDyZ8\n dwLw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777598113; c=relaxed/simple;\n\tbh=hgpPYo94hdwn1yG+kirVjaUTavU5lOmf9ey6YZWV9Z4=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=FLFoDcoppG7Cdx2ZT08sMqHjWyH7t5b5YWWdTqJD7zOvo6lNlCBhJvyTTJEVyg8cEHJ0dwkY2E1wItGnPDdc8OtqqM7/OdB2JUDDxClXJUzJcP0dJyXFhJGsw4IYmkJQHnE3u2e1o17zn8DiRlr4Y+rflSneA9cxaw4B6P+tDfs=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=hgpPYo94hdwn1yG+kirVjaUTavU5lOmf9ey6YZWV9Z4=;\n fh=TSWFL4wpUbKnGkF+TKep8DhndsL2/iTUoVrrl9MVeuI=;\n b=clzmQVk/qSvs3DEZe8FN8zPDuaM6IjRG3+Mttpi+RgFtkt3bhgBK497CGmCIxlxVTf\n FJnkdjgGWo7DXQc1X0zYjhYKbHufm8h+0+GHZav4yJv2ifR4fRhTwd58ZvAxI5GPqhg0\n rTbibeTLvfC5UMwHBqENfroaRiYLjjOmZI4Fd5vBoDcG4saBEoz1Ze1H7FY/g/jJGhF5\n wJbD1k6V+PDTNRh8X8TF6ht8jGJ7my0b0JYz6TcSpHkRaeRHMVP93Z21uewJLN8IJXQ5\n tD3c6dSinPYsQEvOFgzWNkYovDqfKdnrTK9i7H9WxLotAdpcI2lC6yAIkrRA/WtKph9k\n HYOA==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=W1kE6gNP; arc=pass smtp.client-ip=209.85.167.47","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777598110; x=1778202910;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hgpPYo94hdwn1yG+kirVjaUTavU5lOmf9ey6YZWV9Z4=;\n b=W1kE6gNPfxldCrlmNXJIeRm8HLJD342OSQO1lH6nKgDEPFNx1SkTWX5uYeHSEV3I3P\n evcLiY70NRrNztoHbuNJthUzlZJ5gJvqXQ5C0jciSfPFNxwNGwlMxMjhUYSIOEdcIVLv\n 8yIbidvU3KaoLFw+U/NvcKmmMu65rNfPKa232pJDNOxzBQUM2Jev+UcaIGskswXtCWR8\n Ve6vX3wbc34obpbl1eOwa6OQBZ+hQg63WGp5QRAvP4CPaj/mSv4roELupkProxedoRwQ\n 0DfyG+826zTwXO7Ivh0JiImrTSYZobbwRpmBS7G5MEeNvPaBj+rdJ7wNN9TiQY8zuRsM\n PltQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777598110; x=1778202910;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=hgpPYo94hdwn1yG+kirVjaUTavU5lOmf9ey6YZWV9Z4=;\n b=c9en7BgWblKZAd3N2L9/Jsf7Rpewuf0iFLtRDNxJhrXO0h/23aT5wmBOL6g5SNv4Yf\n LOZy81OdX8w99cRbqWAwaDdfIbgUc/9gCjkALnp8rFq+ePBrtdu9Tjo+1ugN9YjZOBvH\n uSMnS/HaWxbA8K22WTNZK/CHxpvIEQbot4HEC0Ow4YXU/4IiC1X8xjzb4KF6AsUAOlOa\n Tbw8920JfupCYfqvXr/gn0eu5vNaIpQuS8BmIYekGmY+o+sN/tpisKmA7QyVtYsBzc+7\n JQVMJGzYogQAKn5YgQ6+eA+OjRgSyOxmaIGuQeuAWAPzvSVZWO6bzyuZJ7pKv4tJ1xAz\n EXpw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/vlmpXfsHUTT5L4FD4gSvYX3Rm03I2Bzy3VmkFJKT2EQKmS6UEt35ei2vXkU58JvUNBm0WEc0JjAecFg==@vger.kernel.org","X-Gm-Message-State":"AOJu0Yy4nFgBC2rrb/6PQIjY9AyXfizXzhSg+kjsa68z4Sl6m1s/Mfm0\n\tzm0R9hcYeyYCu1juaCNxcrEIAjKIHzJ6XwcTkkSluBBOvjPcdvYH7BMKWv804JGvZWw82HNrRFq\n\t9IbnQd0dNUEop2M19WVGUeIq7ob9fkUOVhb3r","X-Gm-Gg":"AeBDieuXubIAe2WdBOoTQxkJJkbyQKwliz+N/M67eDz+POqXRbcv8/FbnwbuKfLfdz+\n\tmXRLxIjo0D3tGfzEkdx/Ew47AQAFoYtjaIQBBdAHbjGyUTjNHdWtmlRHYX2CnAFcqgFtJ92Sv8g\n\tqwyPWiZlKSnVfmLb3l9xZUFEMQ1v2TtuQbIrB8CwzZIAQBj3HWy2yrpYGjTUfJEBzd0gqAQsoOS\n\tSMGezf2hCd+yxtgGMEZu0xd10XjerzcT683zJ6RMjcfYCSq88sPYgd0JJJ8Gs9YSbk27K4Khllz\n\t00RIQo8KPi+jBKCuVYHo6+wpvgIHKCk/X1AHFEIeJgx6L9OhyTP3RoMMZSKw6qS2CkEKt5drruK\n\ttvIzPDHQqP0gpRX61/8leIT/WGkEkT7uX1NT427P/lj65n3GG81wLuWIl9/p4AAJzFkcZ","X-Received":"by 2002:a05:6512:3b13:b0:5a2:b90d:9bb5 with SMTP id\n 2adb3069b0e04-5a8522d8199mr2150167e87.29.1777598110255; Thu, 30 Apr 2026\n 18:15:10 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260430214202.58405-1-rosenp@gmail.com>\n ","In-Reply-To":"","From":"Rosen Penev ","Date":"Thu, 30 Apr 2026 18:14:57 -0700","X-Gm-Features":"AVHnY4KJj_PPFx_XiTlTc5dud7Z3CoLFk_oPTNDVX6T1HaAb2jGtfETjZDPhn6U","Message-ID":"\n ","Subject":"Re: [PATCH] ASoC: tegra: ADMAIF: allocate with a single kzalloc","To":"Mark Brown ","Cc":"linux-sound@vger.kernel.org, Liam Girdwood ,\n\tJaroslav Kysela , Takashi Iwai ,\n\tThierry Reding ,\n Jonathan Hunter ,\n\t\"open list:TEGRA ARCHITECTURE SUPPORT\" ,\n open list ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]