[{"id":3684823,"web_url":"http://patchwork.ozlabs.org/comment/3684823/","msgid":"","list_archive_url":null,"date":"2026-04-30T16:18:46","subject":"Re: [PATCH] hw/net/allwinner-sun8i-emac: Flush queued packets when rx\n is enabled","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Thu, 30 Apr 2026 at 05:08, wrote:\n>\n> From: 宋文武 \n>\n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3459\n> Signed-off-by: 宋文武 \n> ---\n> hw/net/allwinner-sun8i-emac.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/hw/net/allwinner-sun8i-emac.c b/hw/net/allwinner-sun8i-emac.c\n> index 9b7c67ae8e..7cc06b73c2 100644\n> --- a/hw/net/allwinner-sun8i-emac.c\n> +++ b/hw/net/allwinner-sun8i-emac.c\n> @@ -727,6 +727,10 @@ static void allwinner_sun8i_emac_write(void *opaque, hwaddr offset,\n> break;\n> case REG_RX_CTL_0: /* Receive Control 0 */\n> s->rx_ctl0 = value;\n> + if ((value & RX_CTL0_RX_EN) &&\n> + allwinner_sun8i_emac_can_receive(nc)) {\n> + qemu_flush_queued_packets(nc);\n> + }\n> break;\n> case REG_RX_CTL_1: /* Receive Control 1 */\n> s->rx_ctl1 = value | RX_CTL1_RX_MD;\n\nThanks for this patch; I've queued it to target-arm.next with\nan expanded commit message.\n\nI dropped the direct check on (value & RX_CTL0_RX_EN), because\nallwinner_sun8i_emac_can_receive() also checks\n(s->rx_ctl0 & RX_CTL0_RX_EN) and won't return true unless it's\nset, so we don't need to check the same thing twice; so the\npatch as I have it is:\n\n@@ -727,6 +727,9 @@ static void allwinner_sun8i_emac_write(void\n*opaque, hwaddr offset,\n break;\n case REG_RX_CTL_0: /* Receive Control 0 */\n s->rx_ctl0 = value;\n+ if (allwinner_sun8i_emac_can_receive(nc)) {\n+ qemu_flush_queued_packets(nc);\n+ }\n break;\n case REG_RX_CTL_1: /* Receive Control 1 */\n s->rx_ctl1 = value | RX_CTL1_RX_MD;\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=orXTOQZd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5zry33JRz1yGq\n\tfor ; Fri, 01 May 2026 02:19:30 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIU6V-00058E-Rw; Thu, 30 Apr 2026 12:19:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIU6P-00057Y-Ey\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 12:19:01 -0400","from mail-yx1-xb12e.google.com ([2607:f8b0:4864:20::b12e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIU6N-0003IN-SM\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 12:19:01 -0400","by mail-yx1-xb12e.google.com with SMTP id\n 956f58d0204a3-65006c99d38so1139748d50.3\n for ; Thu, 30 Apr 2026 09:18:59 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1777565938; cv=none;\n d=google.com; s=arc-20240605;\n b=iRSgSupTtfw+dd5vSJeTZf/R4Lbys8YMhA038jSs+QPckNvG0gUs7vkS0UdWKtCsV8\n 6qD3I2EnMxeqAQzD6ZKiQXx03WmhY9xI6WcWC2ZzZgIs8pSmn8nzc0xKTlr3gNKBVHFd\n IA0u7BDiLTSeov4iDAnC4NQV5CL95JwqgTZASkd3aG6vVkZI+pEp+md5x2QQjYBumwJI\n lO2IQr9HDKFjeJKoYMx6TgC0s2jKhle/2zS+NDQ+XENOvtBt6SWsnuese3ry14TzF690\n sAld320XsEMcibcL4eSJODJQ+aE3TmQjWGavrXcUT/YR5ARQtpFGTts5BodthS0Mwo5D\n hEKQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=IWf6n2+rQx00tlBPS009bMm3BcgcawxuPrXZh+58IsM=;\n fh=D1BglRlJyEUKfawI0ZHvDE6D7YDMhtOop9g6laYss04=;\n b=GDWYuiFsNb1hVqn/JgjF0OgdeS+K02D84Tv4OW8g1x1Vii+mZFANk4rLYtwuGlX84w\n LUYahZYE3VMw/WWEJwz4Su+UuKHUw41DQMTsPwIV0hK4WQhxvQZH5GoFCIUTa1MZc8pw\n Usy6+GdyV4STymGPnnVeC1krUJzHydprLz9wi5yL0O3Fqb5aBoaYDBwVxB0VIQDLIIyk\n sgxZNQ+sgeH2qv+XF/xXCiD5j5Gqbu/woIqYzpek2eIGs271fOWFpfnZH9bzXInXrkbg\n HqRgSazSpSxD01sm+rBLKwZkMuBK6IszHiCSIdDJkuHzDz3ipQ6M73s1UCAbTA0Vgy6w\n Xglg==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777565938; x=1778170738; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IWf6n2+rQx00tlBPS009bMm3BcgcawxuPrXZh+58IsM=;\n b=orXTOQZdNxoP9mxmqlRQW/19yPOGgMa5pgY3geqDXps4LEbavH/AlbnR4172mo7yW6\n ywdwtP+Qjhjqx6rjeoQLtOuK2QLkt/8WGtnAVZm8LfkKH4jDWaTgpC3gchHcci0dXMXY\n B3ooyGT4D03ewPH/T8Jf7tAhA23+XHfu5y0ziGGqwjVtkKcbO/+XxgRbY2VXIXSCrbdm\n H8B+5dHaa4pDd6BpJ1yu/mqu+R+TUCgvvLir03q5MjmrN6fJrRebco7Il6DIlgej4vvD\n PtT0q0nvkpWJEzJYLFU4moyp8eVkrq5RO2peeeU9Qz+enDfgcUELfuEe7bQ+rdlzEKSd\n 7eGw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777565938; x=1778170738;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=IWf6n2+rQx00tlBPS009bMm3BcgcawxuPrXZh+58IsM=;\n b=mwdbjLBACpl1epYnmG4A/mj60YKdrWnoJLGb5is8AFbcZZwxMLcgubC+IH6upfiL0P\n I97zTroubc7BhAhXMjrw8kBIClAakSBEvvEBqP39WmPlArb7bpSnAiB847h+rSYHZTuX\n qXaN8769Fuz+k13zQWXNSKGoxajprCzGYTGGtk9+6nYXzfGKPz/qm2wA8VFLdegecjTw\n 2wf3Brn0Sy8PT2eIiR3QtM5DZ9zipsyIqy18+RJGq8JkBgZJw2JqGEfDKGo0AVsDh3Xp\n NmU/KAEic+Adc1S+gVrsZpGcq5kBTYoPb0hytR94Kx/HYXQLIm4OM2U8U5l/pA8oev7T\n RJDQ==","X-Gm-Message-State":"AOJu0YyNGKCNRJn1o7sZeV8RCfVv4houuc32nHqPfAvYj0j/LiywS8bb\n +gGbT+9Si8l2Y241f7/EWW6z746+iGVjrG+GSdOH91V/bmNwTxUd5S4UZGP5lmqaxuARH4nyZBw\n fpf3Epjs2LP64tfkxKvPh3AL+zgalH9M/oZg4c2FQ2CS13CcFTiWRdms=","X-Gm-Gg":"AeBDieuXYeUddP0OzBVTiiwTKmRXnImWTdLlSjX0bw17SaVOxOWMujNbkkUWrwIbOb6\n soVU5F4QgVJTLZSB36SO2ETheK8kvE804VmtaoG9QZbcrKfegMjeFssAg6i0qb4xYPx6gIwgPkm\n WHyrGGUSJQpg6vuGS/6DlOjBia1JUjLXzCFLzN9WfofUruSZc8dI88FPftoPJ2toCtSfRIPOnlM\n RQCK+1S3nHNfFw3jyDLSHoNwcINP1HditWnMkyzen7rVNJ1xUn0lyMahKQbYZgm+o9tWpE6oVAn\n XGL+6McwbBoNRVKIov1C9aoqNCVDc3MD3P0j2PAjRlXsrJlGw35ai81ozXdPU6MFmhKvaotFRCK\n sRqs7fsqxxT3T","X-Received":"by 2002:a05:690e:190c:b0:650:3e1f:907c with SMTP id\n 956f58d0204a3-65c18503a47mr3017462d50.0.1777565938317; Thu, 30 Apr 2026\n 09:18:58 -0700 (PDT)","MIME-Version":"1.0","References":"<20260430040753.3337-1-iyzsong@envs.net>","In-Reply-To":"<20260430040753.3337-1-iyzsong@envs.net>","From":"Peter Maydell ","Date":"Thu, 30 Apr 2026 17:18:46 +0100","X-Gm-Features":"AVHnY4IIIorx1xkrEBS1R9K2W-QNLlsG2iNu5IcnwNcfXuKfCBUy22hqBemJxs8","Message-ID":"\n ","Subject":"Re: [PATCH] hw/net/allwinner-sun8i-emac: Flush queued packets when rx\n is enabled","To":"iyzsong@envs.net","Cc":"qemu-devel@nongnu.org, =?utf-8?b?5a6L5paH5q2m?= ,\n Strahinja Jankovic ,\n Jason Wang ,\n \"open list:Allwinner-a10\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b12e;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb12e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]