[{"id":3684711,"web_url":"http://patchwork.ozlabs.org/comment/3684711/","msgid":"<177755650101.425569.4344368132239630879.robh@kernel.org>","list_archive_url":null,"date":"2026-04-30T13:41:41","subject":"Re: [PATCH 1/2] dt-bindings: i3c: add binding for Realtek RTS490x\n I3C HUB","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Thu, 30 Apr 2026 20:13:53 +0800, zain_zhou@realsil.com.cn wrote:\n> From: zain_zhou \n> \n> Add DT binding schema for Realtek RTS490x series I3C HUB devices.\n> \n> The binding describes configuration properties for:\n> - LDO enable/disable and voltage level per port group\n> - Pull-up resistance per port group\n> - IO driver strength per port\n> - Per target-port mode (I3C/SMBus/GPIO/disabled), pull-up,\n> IO mode, SMBus clock frequency and polling interval\n> - Hub network always-I3C mode\n> - Hardware identification via CSEL pin (id) and CP1 pins (id-cp1)\n> \n> Signed-off-by: zain_zhou \n> ---\n> .../bindings/i3c/realtek,rts490x-i3c-hub.yaml | 410 ++++++++++++++++++\n> MAINTAINERS | 6 +\n> 2 files changed, 416 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml\n> \n\nMy bot found errors running 'make dt_binding_check' on your patch:\n\nyamllint warnings/errors:\n\ndtschema/dtc warnings/errors:\n/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml: ignoring, error in schema: patternProperties: @[0-9]$: properties: polling-interval-ms: type\n/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml: patternProperties:@[0-9]$:properties:polling-interval-ms: 'anyOf' conditional failed, one must be fixed:\n\t'maxItems' is a required property\n\t\thint: Only \"maxItems\" is required for a single entry if there are no constraints defined for the values.\n\t'type' is not one of ['maxItems', 'description', 'deprecated']\n\t\thint: Only \"maxItems\" is required for a single entry if there are no constraints defined for the values.\n\tAdditional properties are not allowed ('type' was unexpected)\n\t\thint: Arrays must be described with a combination of minItems/maxItems/items\n\t'type' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']\n\thint: cell array properties must define how many entries and what the entries are when there is more than one entry.\n\tfrom schema $id: http://devicetree.org/meta-schemas/cell.yaml\n/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml: patternProperties:@[0-9]$:properties:polling-interval-ms:type: 'uint32' is not one of ['boolean', 'object']\n\tfrom schema $id: http://devicetree.org/meta-schemas/core.yaml\n/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml: patternProperties:@[0-9]$:properties:clock-frequency:type: 'uint32' is not one of ['boolean', 'object']\n\tfrom schema $id: http://devicetree.org/meta-schemas/core.yaml\n/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml: patternProperties:@[0-9]$:properties:clock-frequency: 'type' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']\n\tfrom schema $id: http://devicetree.org/meta-schemas/cell.yaml\n/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml: patternProperties:@[0-9]$:properties:clock-frequency:type: 'anyOf' conditional failed, one must be fixed:\n\t'uint32' is not one of ['array', 'boolean', 'integer', 'null', 'number', 'object', 'string']\n\t'uint32' is not of type 'array'\n/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.yaml: patternProperties:@[0-9]$:properties:polling-interval-ms:type: 'anyOf' conditional failed, one must be fixed:\n\t'uint32' is not one of ['array', 'boolean', 'integer', 'null', 'number', 'object', 'string']\n\t'uint32' is not of type 'array'\nLexical error: Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.example.dts:50.34-55 Unexpected 'I2C_OWN_SLAVE_ADDRESS'\nLexical error: Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.example.dts:114.34-55 Unexpected 'I2C_OWN_SLAVE_ADDRESS'\nFATAL ERROR: Syntax error parsing input tree\nmake[2]: *** [scripts/Makefile.dtbs:140: Documentation/devicetree/bindings/i3c/realtek,rts490x-i3c-hub.example.dtb] Error 1\nmake[2]: *** Waiting for unfinished jobs....\nmake[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1637: dt_binding_check] Error 2\nmake: *** [Makefile:248: __sub-make] Error 2\n\ndoc reference errors (make refcheckdocs):\n\nSee https://patchwork.kernel.org/project/devicetree/patch/20260430121354.6253-1-zain_zhou@realsil.com.cn\n\nThe base for the series is generally the latest rc1. A different dependency\nshould be noted in *this* patch.\n\nIf you already ran 'make dt_binding_check' and didn't see the above\nerror(s), then make sure 'yamllint' is installed and dt-schema is up to\ndate:\n\npip3 install dtschema --upgrade\n\nPlease check and re-submit after running the above command yourself. Note\nthat DT_SCHEMA_FILES can be set to your schema file to speed up checking\nyour schema. However, it must be unset to test all examples with your schema.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=qep3HF6J;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35927-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"qep3HF6J\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5wNr2qsZz1yHZ\n\tfor ; Thu, 30 Apr 2026 23:43:24 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9847030134B0\n\tfor ; Thu, 30 Apr 2026 13:41:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CE1C5428467;\n\tThu, 30 Apr 2026 13:41:43 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E2964266BC;\n\tThu, 30 Apr 2026 13:41:43 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EDF17C2BCB3;\n\tThu, 30 Apr 2026 13:41:42 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777556503; cv=none;\n b=GU7dH3x1ze99mseTQ0riJbBcFWipXonrAAvaaXj0sarQQW3zUap/2mFcKJqtDufLxM/wERFrLCc7xF6bgXckRVCL3tFqTq9b4BtO3sNDtvIPemA2L2YKq+I0LFMUnVulCGvtfvw0YmCHq3U322HdvNGN34gz9sFR9I+u3LwyoIo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777556503; c=relaxed/simple;\n\tbh=qo0NVFUmB45SVo0XMWqHC4qOMxTWR++i0ZQMSOzxZkE=;\n\th=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References:\n\t Message-Id:Subject;\n b=D8qbDp7o0wyYfYKvc8E+s9TT6Ap/6l8b98cf+dHrVLqMGjs3hdIGiygzaRIFWD3/YXJYRp0fm+hM0CK8Ook8K11cWWX1ZEhcygByOodShIaE+Bw0MfqmRoPipQwURO7NUuJsA8Ra4rGnUnWkVjZEjQEUB2M2DKn4eg5p1eVZHt8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=qep3HF6J; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777556503;\n\tbh=qo0NVFUmB45SVo0XMWqHC4qOMxTWR++i0ZQMSOzxZkE=;\n\th=Date:From:Cc:To:In-Reply-To:References:Subject:From;\n\tb=qep3HF6J7LU9utiSV6oY7tghewHVRkU6ejIBxqhGqkcMONqXqpem5RPYWLTDmKFBw\n\t WgyTxRXQv2jFoP5jbRZ+PrYO/TM+cWVnz/Go+Zf5LGx0LkaVJKdgEjj3ty3Ny3D5m0\n\t SgXndJWbzinHtk02ey/XuQXoTNG83/vB5PGOIlbYGIeXd4z+wjZo4dgvNjWjK05rdm\n\t w8y7Fbs1ro1ke2y87ZMz7jLvbHiaysrbJkpbLJslDyglv5Rng6UkMmvOkvh2KGo1kC\n\t rE6/KvLoyBHXuUrFqohF4dDZKPwt2E+DF+sKVueXBffIJqH55VRgedDsXwTOeFoB7U\n\t NcSUXWveZiATA==","Date":"Thu, 30 Apr 2026 08:41:41 -0500","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","From":"\"Rob Herring (Arm)\" ","Cc":"linusw@kernel.org, gregkh@linuxfoundation.org,\n linux-i3c@lists.infradead.org, brgl@kernel.org, conor+dt@kernel.org,\n linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,\n linux-staging@lists.linux.dev, alexandre.belloni@bootlin.com,\n linux-gpio@vger.kernel.org, Frank.Li@nxp.com, krzk+dt@kernel.org","To":"zain_zhou@realsil.com.cn","In-Reply-To":"<20260430121354.6253-1-zain_zhou@realsil.com.cn>","References":"<20260430121354.6253-1-zain_zhou@realsil.com.cn>","Message-Id":"<177755650101.425569.4344368132239630879.robh@kernel.org>","Subject":"Re: [PATCH 1/2] dt-bindings: i3c: add binding for Realtek RTS490x\n I3C HUB"}}]