[{"id":3684632,"web_url":"http://patchwork.ozlabs.org/comment/3684632/","msgid":"","list_archive_url":null,"date":"2026-04-30T11:42:03","subject":"Re: [PATCH V3 3/3] memory: tegra: Restore MC interrupt masks on\n resume","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 30/04/2026 10:52, Ashish Mhetre wrote:\n> The MC interrupt mask registers lose their state across SC7. Without\n\nSC7 may not mean anything to anyone that is not familiar with Tegra. I \noften refer to this as 'Tegra low power suspend state (aka. SC7)'. Or we \ncan just simply say 'suspend' instead of 'SC7'.\n\nKrzysztof, do you want use to clarify this and update the commit message?\n\n> re-applying them on resume, MC interrupts that were enabled at probe\n> remain masked after wake, so any post-resume MC error goes unreported.\n> \n> Factor the existing intmask programming out of tegra_mc_probe() into\n> tegra_mc_setup_intmask() and reuse it from the system resume callback\n> so the mask state is restored on wake.\n> \n> Signed-off-by: Ashish Mhetre \n> ---\n> drivers/memory/tegra/mc.c | 23 ++++++++++++++++-------\n> 1 file changed, 16 insertions(+), 7 deletions(-)\n> \n> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c\n> index 64e41338cdf2..cfcfc7291106 100644\n> --- a/drivers/memory/tegra/mc.c\n> +++ b/drivers/memory/tegra/mc.c\n> @@ -911,6 +911,19 @@ static void tegra_mc_num_channel_enabled(struct tegra_mc *mc)\n> \t}\n> }\n> \n> +static void tegra_mc_setup_intmask(struct tegra_mc *mc)\n> +{\n> +\tunsigned int i;\n> +\n> +\tfor (i = 0; i < mc->soc->num_intmasks; i++) {\n> +\t\tif (mc->soc->num_channels)\n> +\t\t\tmc_ch_writel(mc, MC_BROADCAST_CHANNEL, mc->soc->intmasks[i].mask,\n> +\t\t\t\t mc->soc->intmasks[i].reg);\n> +\t\telse\n> +\t\t\tmc_writel(mc, mc->soc->intmasks[i].mask, mc->soc->intmasks[i].reg);\n> +\t}\n> +}\n> +\n> static int tegra_mc_probe(struct platform_device *pdev)\n> {\n> \tstruct tegra_mc *mc;\n> @@ -971,13 +984,7 @@ static int tegra_mc_probe(struct platform_device *pdev)\n> \t\t\t}\n> \t\t}\n> \n> -\t\tfor (i = 0; i < mc->soc->num_intmasks; i++) {\n> -\t\t\tif (mc->soc->num_channels)\n> -\t\t\t\tmc_ch_writel(mc, MC_BROADCAST_CHANNEL, mc->soc->intmasks[i].mask,\n> -\t\t\t\t\t mc->soc->intmasks[i].reg);\n> -\t\t\telse\n> -\t\t\t\tmc_writel(mc, mc->soc->intmasks[i].mask, mc->soc->intmasks[i].reg);\n> -\t\t}\n> +\t\ttegra_mc_setup_intmask(mc);\n> \t}\n> \n> \tif (mc->soc->reset_ops) {\n> @@ -1018,6 +1025,8 @@ static int tegra_mc_resume(struct device *dev)\n> \tif (mc->soc->ops && mc->soc->ops->resume)\n> \t\tmc->soc->ops->resume(mc);\n> \n> +\ttegra_mc_setup_intmask(mc);\n> +\n> \treturn 0;\n> }\n> \n\nOtherwise this looks good to me.\n\nJon","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=Z7KhV9wh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14114-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"Z7KhV9wh\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.56.24","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5sj82mb8z1xqf\n\tfor ; Thu, 30 Apr 2026 21:42:20 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CE8CC3003615\n\tfor ; Thu, 30 Apr 2026 11:42:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 975173ACA65;\n\tThu, 30 Apr 2026 11:42:15 +0000 (UTC)","from BN1PR04CU002.outbound.protection.outlook.com\n (mail-eastus2azon11010024.outbound.protection.outlook.com [52.101.56.24])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 09C943D7D97;\n\tThu, 30 Apr 2026 11:42:13 +0000 (UTC)","from DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12)\n by DS5PPFB8FBD73EA.namprd12.prod.outlook.com (2603:10b6:f:fc00::65e) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.21; Thu, 30 Apr\n 2026 11:42:08 +0000","from DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391]) by DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391%6]) with mapi id 15.20.9870.020; Thu, 30 Apr 2026\n 11:42:08 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777549335; cv=fail;\n b=DhRS/jQGZs4OBT+AeEazz4p9CSihPqTHdXfoEHE7ZuKzOMprcBfYuqzsgyxA1DTxjqDG9heMcNb+EV7hTai2f44iLGMXSFZn7/h1oCFO/1VViARLSoHP412+ckJ98HkwaZdogjxt8dhnm/2MJEABfeM63ET9CQgu8U3sCZPSjvU=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=qPmXiG8dEEEqvTrd1iYKi94KBkk8ncH1JiyTV8J7So4vcZflBW1I/2/ovVbFF+gtpdaH9OB4uS3J8ff/SkhWjXFkW9QhpS5br28+5xL6O9ZepgHeEkdfskKP4bYeC7mXuo3jvRqyHddNUMs3Rgo3aXpVNYXv5Wnpc235Rj+UR09PSTwxcj4MEZ2kogoVW+g+a03Ri9YNWnnRhVcoMhKnIungPvuN/NRbhvXrZSW+bw7elxvJJ3Rj3TIZvg04AJ8sNIqy5cq915Rw7JybluR6zDroKcXUJkzGaTDuLyTfBtmOcFDiaqdXauZ3iftijhzYR0zoGqt1LGJqBzXIyfnO+w=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777549335; c=relaxed/simple;\n\tbh=LzL7Yq+8Nx27jMB2tJ1w+vcZUU3ynkETLj4ecLbuFIs=;\n\th=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=G9MqqtQfMm8yWfxHt86gpcyPP8qV9DK52kM25cBSii1gnIpLFCZ5FntdFJS/FHGUWAqxizHjskZkQAFqbxMiTTb8Fukf6tGej9i45l32v0kmx2bSyTy8twhIRQ726Dgj3N/ke/luqt2zrffLVZQUurMHs87vtI8HIVPTd40pB9Y=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=X9x3XjXOnhK+FrCtkLiT2YEu1Wr3fuk4HEllLs3boR0=;\n b=Yc9f9xum1yiQk+5g0gAtqdbz18xeDKYxiq4jrWBDc3DUJxj2tJy410murNZT0FwoqyJklkf4E4c2PrFSb/4PDH1RU0hDjXyWd9nXsz/xJiEL3jjAo4p2mG8uO3qI3WV4VCijVF6MG1W1K1L/yRAN/qwud3KvzH852m/e6MzwTNd5ghNXeydDDCIQWsVXgGyfRxloioSWD26F5ZE4gInAQROnL3oiqpUdfXj0xz9CTcBvZonBV6RjtdwgodLlxSipmja4qFi4sdzoYbGbT3k8CG8X7fdm3C8QRZKV8Kyofm9r0Lx8m+snuHeGab2x7t39dQLzgAiowJJrzUYH55kEOg=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=Z7KhV9wh; arc=fail smtp.client-ip=52.101.56.24","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=X9x3XjXOnhK+FrCtkLiT2YEu1Wr3fuk4HEllLs3boR0=;\n b=Z7KhV9whGGnmNcQ8/pj8MGxJb4S1shzIXIJughdteiRKy5O86fSZLlhOj0FbyLYDNQtp90WV/z2y43UXsZCzMv6VkJTvzV6XX4jRkxtAIUAI03w3rpDVHSCob2FXSeJvEzM6+L7BLqYpn1MNGHBMAsJztoSPqEkPVNbzxAg/YzRlxc1ytjj7QEuK3F1ovNmiNHxxI9LcQ7rXUIz/waWfFjkQ9NngFDNNB5z0WZBkimBSlNE2D6dDXLzFpuCgNNMi3ABmTUAjKP5k95TX9YVvIx0L5f7hprfoMfmtoeLieNuhTBrblFlOiWadzf5H+HHM16vsT5Iouj4olkpGZdcQEQ==","Message-ID":"","Date":"Thu, 30 Apr 2026 12:42:03 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH V3 3/3] memory: tegra: Restore MC interrupt masks on\n resume","To":"Ashish Mhetre , krzk@kernel.org,\n thierry.reding@kernel.org","Cc":"ketanp@nvidia.com, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org","References":"<20260430095202.1167651-1-amhetre@nvidia.com>\n <20260430095202.1167651-4-amhetre@nvidia.com>","Content-Language":"en-US","From":"Jon Hunter ","In-Reply-To":"<20260430095202.1167651-4-amhetre@nvidia.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"LO2P265CA0300.GBRP265.PROD.OUTLOOK.COM\n (2603:10a6:600:a5::24) To DS2PR12MB9750.namprd12.prod.outlook.com\n (2603:10b6:8:2b0::12)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS2PR12MB9750:EE_|DS5PPFB8FBD73EA:EE_","X-MS-Office365-Filtering-Correlation-Id":"a19fc6a4-5c86-4d61-534b-08dea6ad824f","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|366016|376014|1800799024|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\tutVXruafwCNkI4sSzu25kA2zeU5uf01ieCzOmKgjAq0TV1ovCYiNtT6BDulvngMqNvvN4SPvy3K9Ajk64lLYdoDzVn0cKyEE23evIT7S3BBhGnjptGaUgj9Bwkv+X5P5ZnBv1KcgqikN5T8esgBQkZTOHL/9nYkX7/pDPykEGEdz4rcWOSApGU7s6k3Bs12Qb4TG6BPVJvsNfuezRUVLgdeT+5kGIIEJAgav71yCxJYQKWRMoNu4mHs1ToJSuVnHbJEg3Chm5nLfZoa+kFRNeXKW7y4JNXxDGbyAtjppTKONbKmpG5RHHe2VvU7e61oJEdOde1o+wWhxi2ZAzNKSlpbTL512eIfwoVz3j5Hyow69dGwvPnbydaiplDpBFxKji5YY8ZruPZhcbJZz4Mw7EyLGb7BjD1rDR4GCXW0HWGysWC/wD7Ox5sfDbkiMTS1+/PJP/c1lTBDRbLDKoJGFddUX1j+ASSYemh1u4WgxOkEFnFDycI900DxozRDv4RqQyiPkcOOLr+09/oj6+wSLqt2RftlQKtd/U8vduyt1zXr2eDRZ6Ojy/ANxFcBriaue9U7I+oLnVgVKauiSBPMOhTWO0S1fAxhW+zbi56CXnivOQaoZr+DqAOgpXfxzTWTg+XNNI/t0f+v2BHngmvY0A4lXs2epUUKuc7IWOBwaTsxs7lvEFiYqINoKT/XUKyhuDvImKExxJTHFgCrvuRZ+5RflkqM8bq8EgcudBBWwhOM=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9750.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?uitEuwCQjCDfrlP8CFcjCaBLOEtH?=\n\t=?utf-8?q?IYsZyMPXYtYsxvlCJbXrhuSQi28y0clsNismCXkizeEfGFrIbF1frOqn5DllL5TuR?=\n\t=?utf-8?q?HkEW8IXDeQEv8Y12iOUo0E3fkG9sVbzPe1XdGHbJjzm2UDD2dXulNnh5vLyIYb7I6?=\n\t=?utf-8?q?QOLBjFAVv05BgO6DgN0LjggNoRGax9JUbclFf4N+FDVlgSGifECJQSbP8XNGFLQet?=\n\t=?utf-8?q?mbDRcs/yjzGeJLpe6tlNiRWm+48jGmUvJJjpfS9gFIyhJHOsEzCRQKb0vLPNYcOTc?=\n\t=?utf-8?q?2HhJI42/wbdKN5nRGVcJC00v8r1glih8xjfBJZ/mTv/CtC/HKc8cW5h/g02bNNpIu?=\n\t=?utf-8?q?0npu7ATC38IozMe4vJyfcQvmgtllSY2fDR401egRZL0NOYRZNQylh0Ng3xWeuY3ab?=\n\t=?utf-8?q?8uJnnK7c0SWbXJY5JIm2lJqCC9pDpVB0uAUGE4y8j30AF9POSq7YpCseiWi1l/oDq?=\n\t=?utf-8?q?NgdCl854jjv8KA7niMZwEc8XP/3ATLAd1fkn9ZSMqDl9TfJCeBrrViUIJvVMnyNpz?=\n\t=?utf-8?q?CUOBnN77RfWSx10f2IiQkZcR8xP5uDCXOkReds6IBhGVzXcITL76njjZ0+o7AWtIj?=\n\t=?utf-8?q?TgsF2aXz/DmrbMFuHKFZu2n6R1NWmfME9WI4fEEU0tUEr+vTP4xfkgRBRqQEDi6jW?=\n\t=?utf-8?q?8HOP2YECbKvsRxl1stn/9lQTMnANzvVnWfpbWb7We7VObs6wHHXlPTLxJZ2KVi8nE?=\n\t=?utf-8?q?UXeiUI1Qxid277rDapUOGc3Kcl3lmJLOZg6zkO5w60XFLDgtRV9sAnndqctJbO/16?=\n\t=?utf-8?q?ehZOBNkktQws3tNsiHKqFyJ0FF279k5pAJ/q41AxDYMqYPQ4jwcZ9M/oA5K0s90kk?=\n\t=?utf-8?q?t0eUVlG68evMRmYGYtbGrWK5ADtKUZlQIIAKuYc04FK2MTGxv4xyn7kZ7xpW482YE?=\n\t=?utf-8?q?Qhdcue1U5Me31jG7ZK03QVTBdmcsjQTD+0qOpWpnMAIxdUyMNC8yNnmcUl8ZGcgmS?=\n\t=?utf-8?q?PaH7ysutjy3DEbirj2O+iwkF6zcqdzsGsZlkGIhs584KkJLMLDVRL350bGLMcmRqp?=\n\t=?utf-8?q?GAVDgmz/KktpOXox7aTWzJokdoTksQ6SQtAYPhNac0PeJiSjdqdj0MVBnjm9bM7ne?=\n\t=?utf-8?q?rlvuEDUud34ZFYVRN4D+Ip7/1wLvPiw8JL0HZBpy/gYllzf3sXgjUQoKsmyGfU4Ih?=\n\t=?utf-8?q?JTuCwHBF5sORE8dXuNb+pLijttqvheRBFUhSUPpR0mGHE4w62GxwzMhpI7ePT4e6Y?=\n\t=?utf-8?q?EOQFRl4fDXnqPlL0L1dqGMUBE6HpmH9HOiBhpzA6kLLLD9yB6Gnrznal+YJN+eBbF?=\n\t=?utf-8?q?Nog+aEF0QbqOCI2vSE50d//52VPp6FQ23MDX+NJsQUhWn+HuUx7lwz7lNL3hUn9op?=\n\t=?utf-8?q?TxiF3+JW09UV2kmycCmTBb+SzM0WXsma7PyCoOoYuAWtH3GU7TWCB2PjheM9E1YVl?=\n\t=?utf-8?q?suMe9o60QGtZBDHl/t5vTKSEeKSfR+w25v4tIxBVbuMlTbnXDVcuPFZ6dsqQnoddE?=\n\t=?utf-8?q?EVNCOyBEVyHyy5TaYCGvK+0GFzCgIdqeeJTyn9/7gpBXrEbgTN4ov56zVICOwDxMZ?=\n\t=?utf-8?q?cfQ+IsDrW9usglzj2OKab0/9cyymXkcxZB78Dv7ZmqBwyvaohngwpYk34PfION7w4?=\n\t=?utf-8?q?HAXQNU7Vjd9BWnGbxVuwBYvAkwVXufGHImrCV+fsqs30XoWITDZYpXC1lzFYBihBR?=\n\t=?utf-8?q?ZiyBHg37emJd6uGr5THYl6Dy84GuQC1A=3D=3D?=","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n a19fc6a4-5c86-4d61-534b-08dea6ad824f","X-MS-Exchange-CrossTenant-AuthSource":"DS2PR12MB9750.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Apr 2026 11:42:08.0923\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n ZZXEshiDbNj5WQ7/FQ0lRMMzE0wnkHbQisrVRiU9WFSJmNyFjQPAkH2aQlJJ1UPxQMNy7hZDmaSP4tcVWhjN1w==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS5PPFB8FBD73EA"}}]