[{"id":3685082,"web_url":"http://patchwork.ozlabs.org/comment/3685082/","msgid":"<570055d0-18a4-45a1-bfd2-c3af6b4d4e4b@linaro.org>","list_archive_url":null,"date":"2026-05-01T09:57:18","subject":"Re: [PATCH v2 17/25] target/arm: Implement translate_for_debug","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/30/26 19:38, Peter Maydell wrote:\n> Implement the translate_for_debug method instead of the\n> get_phys_addr_attrs_debug one. This allows us to pass the caller the\n> lg_page_size from our internal GetPhysAddrResult struct.\n> \n> Awkwardly, translate_for_debug's \"true on success\" convention\n> is the opposite of the one we use internally in ptw.c, so\n> we have to be careful about the sense of the return values.\n> This corresponds to the way that arm_cpu_tlb_fill_align()\n> also has to return true when get_phys_addr() returns false.\n> \n> Signed-off-by: Peter Maydell\n> Reviewed-by: Philippe Mathieu-Daudé\n> Message-id:20260417173105.1648172-17-peter.maydell@linaro.org\n> ---\n> v1->v2: use 'fault' for the bool variable, not 'ret'\n> ---\n> target/arm/cpu.c | 2 +-\n> target/arm/cpu.h | 3 ---\n> target/arm/internals.h | 4 ++++\n> target/arm/ptw.c | 39 +++++++++++++++++++++++----------------\n> 4 files changed, 28 insertions(+), 20 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=zVaD4oEi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6RL430f1z1y04\n\tfor ; Fri, 01 May 2026 19:57:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIkci-0004sn-Nk; Fri, 01 May 2026 05:57:28 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIkch-0004sY-0V\n for qemu-devel@nongnu.org; Fri, 01 May 2026 05:57:27 -0400","from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wIkcf-0001GT-2W\n for qemu-devel@nongnu.org; Fri, 01 May 2026 05:57:26 -0400","by mail-pl1-x62c.google.com with SMTP id\n d9443c01a7336-2b2429f98d0so10324085ad.2\n for ; Fri, 01 May 2026 02:57:24 -0700 (PDT)","from [192.168.10.140] ([180.233.125.15])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b9cae4aae5sm19053595ad.66.2026.05.01.02.57.21\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 01 May 2026 02:57:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777629443; x=1778234243; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=M53zaaezspq9ZCsNV7lBKWBaZetG414KB3W2v7/BPbc=;\n b=zVaD4oEi5LiA2Syad2AYGRlvDxadF/yLWPgxUl253NsogjtloKkWVbItzSuiJBY1Co\n rTU6akBXFqJtW9VALdMDyZ3vG59CKyRkL8Y2yLi2WDj1DukGkbsxV681EiQ0fh/N6bf/\n dw2qS6HElnlqjPRlU6tHSyhNp84FiXjzpuNEz5l04B9i6Sv7CnvDNDasfQvLn0eTGQz9\n EnLHERlumgjqlA0+omSZ81cbyn4dmGTmX/Eg0RUYwt/gZZPs16fDZRxkROTy5bgYaAdO\n N+p9vFGSBev1JMm1zU41kyNd+3/tIBHa/Q0f1FnuJJlZA2y+t9bc0lce3AeVOJui9XwP\n rwTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777629443; x=1778234243;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=M53zaaezspq9ZCsNV7lBKWBaZetG414KB3W2v7/BPbc=;\n b=KaHu2AUD4POr3dozzSOTIvAh06chKYBAsn38/nVQf4GHuh9udLylU7+rXgj0tL0D17\n +frfwjNok8avgIBJpBYzI0CkEvFp2egxwA2KtpNlgym79gG4YF5N2GcPof33dv/7tA2E\n E4dztzCckObKlD11DAog5xMr7h2IEkAdMa0fyRyrqe+wwHWwA1bW9S8cbeX4GJpeNAai\n 91640yQNZFoFYP3fYdvSwiNyxaOpuBKjco9ATAq5muJLsnN/U21XTCGW4Xqs4H6jT9oG\n iYo4320rnk4PPQ1Fge30KkQNq8Yd47Nfim9ujOMT8i8sPknxgeWYLr+DP8SIIED+8UjW\n 13TA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+4NKtNQRcyr4DzNXNzsk5Mi5bG19keyC+PlbTvwMHiENjKsV7btprhthnz/ZBQ+/iTjTLSlsXYLZUQ@nongnu.org","X-Gm-Message-State":"AOJu0YywLFxEObGeZfjDThV4dLF24Ii6xOBB/SyCKJTRApYqv1oMzpAX\n pTyCAQxE7C/yzhAfhNvhIE7IZQWwYKtX/lBOXEmMWpeCzjkk/+0GHndYVLcRZYVZvrpwinapRYH\n 3a4IeJRQ=","X-Gm-Gg":"AeBDieu6faF0J/lqdW1xAak3K4D62pu9hRM4HTkSeMCzYdhzzyq2BftHuwpUYoFI+KF\n Zv2RG2z4KBjfL6fcMODXWii6z/9od/4Px9U8JzNzIuja7Niz9Gxpfp0BBDQrM6tst/+YfSILNTD\n rRHedPHGMJzpKKXcI/SoxEakX/BqysTQ0SnX1EqmKiniYbLCWEXUt6qLUNXq5x+9Ve++LHHRrW+\n wuqxoLu6rpRKHFsXIPgB7tmcJejOiS2Fr73DpIIy4rtohj+dNg1aVRIcpSWI+76MPXDAEBrsOxs\n NblSj9Mj3j4728NEOQ/jZeRNQqwHb2ulAZNtEF3EU1qvJ6j07hvi56rcFhpgR54n7cDaPc5iC9T\n a3zLaJauOE3+xWoHNM3CzIZJtBmcjqbolR71KbeU6YYMb8M8TpxPKrH4NaJ05xIkmKDoM4RcODb\n R2RAoThbGEJSFRWra1QCASwdzhpTdsPTP46eco990A3pMTAzH6jqqTADwuxL65ihg=","X-Received":"by 2002:a17:902:d50d:b0:2b0:7026:24c2 with SMTP id\n d9443c01a7336-2b9a2508467mr70834815ad.36.1777629442836;\n Fri, 01 May 2026 02:57:22 -0700 (PDT)","Message-ID":"<570055d0-18a4-45a1-bfd2-c3af6b4d4e4b@linaro.org>","Date":"Fri, 1 May 2026 19:57:18 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 17/25] target/arm: Implement translate_for_debug","To":"Peter Maydell , qemu-devel@nongnu.org","References":"<20260430093810.2762539-1-peter.maydell@linaro.org>\n <20260430093810.2762539-18-peter.maydell@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260430093810.2762539-18-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62c;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]