[{"id":3684770,"web_url":"http://patchwork.ozlabs.org/comment/3684770/","msgid":"<8cb18c45e3a08fc64b854b945878d6edbee03416.camel@linux.ibm.com>","list_archive_url":null,"date":"2026-04-30T15:02:29","subject":"Re: [PATCH v2 08/25] target/ppc: Make get_phys_page_debug handle\n non-page-aligned addrs","submitter":{"id":88361,"url":"http://patchwork.ozlabs.org/api/people/88361/","name":"Miles Glenn","email":"milesg@linux.ibm.com"},"content":"Reviewed-by: Glenn Miles \n\nThanks,\n\nGlenn\n\nOn Thu, 2026-04-30 at 10:37 +0100, Peter Maydell wrote:\n> Currently our implementations of SysemuCPUOps::get_phys_page_debug\n> and SysemuCPUOps::get_phys_page_attrs_debug are a mix of \"accepts a\n> non-page-aligned virtual address and returns the corresponding\n> non-page-aligned physical address\" and \"only returns a page-aligned\n> physical address\". This is awkward for callsites, which in practice\n> all want the physical address for an arbitrary virtual address and\n> have to work around the possibility of getting a page-aligned\n> address, and it doesn't account for protection being possibly on a\n> sub-page-sized granularity. We want to standardize on the\n> implementation having to handle non-page-aligned addresses.\n> \n> The ppc_xlate() function can accept a non-page-aligned input but may\n> return a page-aligned output; we take the simple approach of ORing\n> the page offset back into the result address after calling it.\n> \n> Signed-off-by: Peter Maydell \n> Reviewed-by: Richard Henderson \n> Message-id: 20260417173105.1648172-8-peter.maydell@linaro.org\n> ---\n> target/ppc/mmu_common.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c\n> index 52d48615ac..a1345df716 100644\n> --- a/target/ppc/mmu_common.c\n> +++ b/target/ppc/mmu_common.c\n> @@ -863,7 +863,7 @@ hwaddr ppc_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)\n> ppc_env_mmu_index(&cpu->env, false), false) ||\n> ppc_xlate(cpu, addr, MMU_INST_FETCH, &raddr, &s, &p,\n> ppc_env_mmu_index(&cpu->env, true), false)) {\n> - return raddr & TARGET_PAGE_MASK;\n> + return raddr | (addr & ~TARGET_PAGE_MASK);\n> }\n> return -1;\n> }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=hzfUmX23;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5yBw4sYRz1yGq\n\tfor ; Fri, 01 May 2026 01:04:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wISvl-0000Vd-Np; Thu, 30 Apr 2026 11:03:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wISv6-0000Qu-Rk; Thu, 30 Apr 2026 11:03:24 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wISv0-0000jy-RZ; Thu, 30 Apr 2026 11:03:16 -0400","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63U9DJNN1914783; Thu, 30 Apr 2026 15:02:36 GMT","from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drnb5gcs7-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 30 Apr 2026 15:02:35 +0000 (GMT)","from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63UEs2xt031756;\n Thu, 30 Apr 2026 15:02:34 GMT","from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds8aw3jxx-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 30 Apr 2026 15:02:34 +0000 (GMT)","from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63UF2WKF3605448\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 30 Apr 2026 15:02:32 GMT","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id C15C95805C;\n Thu, 30 Apr 2026 15:02:32 +0000 (GMT)","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 606CD5805D;\n Thu, 30 Apr 2026 15:02:30 +0000 (GMT)","from mambor8.rchland.ibm.com (unknown [9.10.239.198])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 30 Apr 2026 15:02:30 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:reply-to:subject:to; s=pp1;\n bh=gQRtJ0L7c/5Z6Hz2FLTO4Te4twaV8I1/XGUl0GP7d/Y=; b=hzfUmX23IzcB\n uh06+/C8bI0Am9nnq8CVlLMISloxDIiVJa9q+VtHGG9NSEaq7mcWo9Ug5o1OHnvs\n X0en4rl2tjc3IAB10K609OdnPrVnXAyvfkfv84tfi06nfjP2PukqiWOlfXoFn8rg\n 9uVWC5QZ0vEX9w61KuxWbJPnw24nK04fEXqqGqPC3HEErueC+rCCNo8H2g6h+lES\n dRfYZ31ARyL5cHeIH4vk0PRygay7v7K3OeTwl8ps5xL2vdrsi5BN942IodxvVYDb\n PjNJ8rJyk/CEqdunec0bA2R6y4t5tPjf58O8al09p81iiQJeKjWN/6HDWhm1NOat\n cXq/4z8P2w==","Message-ID":"<8cb18c45e3a08fc64b854b945878d6edbee03416.camel@linux.ibm.com>","Subject":"Re: [PATCH v2 08/25] target/ppc: Make get_phys_page_debug handle\n non-page-aligned addrs","From":"Miles Glenn ","To":"Peter Maydell , qemu-devel@nongnu.org","Cc":"qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,\n qemu-s390x@nongnu.org,\n Philippe =?iso-8859-1?q?Mathieu-Daud=E9?= ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n Paolo Bonzini ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Alex =?iso-8859-1?q?Benn=E9e?= ,\n Alexandre Iooss , Mahmoud Mandour ,\n Peter Xu , \"Edgar E. Iglesias\" ,\n Jiaxun Yang , Nicholas Piggin ,\n Chinmay Rath , Palmer Dabbelt ,\n Alistair Francis , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , Ilya Leoshkevich ,\n David Hildenbrand ,\n Mark Cave-Ayland ,\n Artyom Tarasenko , Max Filippov ","Date":"Thu, 30 Apr 2026 10:02:29 -0500","In-Reply-To":"<20260430093810.2762539-9-peter.maydell@linaro.org>","References":"<20260430093810.2762539-1-peter.maydell@linaro.org>\n <20260430093810.2762539-9-peter.maydell@linaro.org>","Organization":"IBM","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.28.5 (3.28.5-27.el8_10) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Authority-Analysis":"v=2.4 cv=AqDeGu9P c=1 sm=1 tr=0 ts=69f36f0c cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8\n a=KKAkSRfTAAAA:8 a=-46nHPmGWPDw9I8CGM8A:9 a=QEXdDO2ut3YA:10\n a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDMwMDE1MiBTYWx0ZWRfX7mlSUiJH+efK\n 9ilzbt2jdanVt2tXl7b4YMiryNy9CHE+Ea1dmrBMRekp8uThiZ/0ZOUqpe15oT6epGPVKPZvhKU\n Pjk2iKwarkTlcKpJ+8X7KDa5LKbRH0PLMwo2jAGoXfyw8RtlhZUVjhfRNhzkj7BD5Vz7L0KV/DB\n h08iL+vDSB91WhyRCYZ/JYejuu02DAYocxgNsOMYg3jXCuG8au5dAC+IZ/xWGG4BsynbD0u0FWd\n XGmmA/+Ij2yaY44/VMeUgJAYN8M6k7aSnFpYlYzq22gMJ4mNur2c7E28tjehw+bcAI77eqB1Ype\n fTgxVz1s10gwrILdnvHqXw8mpUporcb98/Tekr6T4ETVJaTKgmH6VWBrf7V2T66mV+9IYrxCEls\n HrpY8jcuhMUVqppVleE+QvW6uj07gTnjVIuKHTtHxdtUrPsFiesBSvkYv7V7gS7PBoaQ/QY/2x6\n fJxe3BPZbtGgMuU/g3g==","X-Proofpoint-GUID":"GJ3vrb5pZ2K64prRGtpBc4kKAJXfD4z-","X-Proofpoint-ORIG-GUID":"mLsDhH_fvqHm8TlodVz6-dSPFFqTTSCG","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-30_04,2026-04-30_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1011\n lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604300152","Received-SPF":"pass client-ip=148.163.156.1;\n envelope-from=milesg@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"milesg@linux.ibm.com","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]