[{"id":3684538,"web_url":"http://patchwork.ozlabs.org/comment/3684538/","msgid":"<536e3912-9351-4825-b25b-776e4cd4c748@nvidia.com>","list_archive_url":null,"date":"2026-04-30T08:39:46","subject":"Re: [PATCH V2 1/2] memory: tegra: Wire up system sleep PM ops","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 30/04/2026 08:09, Ashish Mhetre wrote:\n> The tegra-mc platform driver does not register any dev_pm_ops, so the\n> the SoC-specific ->resume() is never invoked (e.g. tegra186_mc_resume)\n> on system wake. On Tegra186 and later this means MC client Stream-ID\n> override registers are not reprogrammed.\n> \n> Register a dev_pm_ops on the tegra-mc driver and route the system\n> resume callback into mc->soc->ops->resume() so the existing SID\n> restore path runs again on wake.\n> \n> No suspend callback is needed as the resume path reprograms all MC\n> state from the static SoC tables, so there is nothing to save.\n> \n> Fixes: fe3b082a6eb8 (\"memory: tegra: Add SID override programming for MC clients\")\n> Signed-off-by: Ashish Mhetre \n> ---\n> drivers/memory/tegra/mc.c | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n> \n> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c\n> index d620660da331..343ac0018eba 100644\n> --- a/drivers/memory/tegra/mc.c\n> +++ b/drivers/memory/tegra/mc.c\n> @@ -13,6 +13,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -1010,10 +1011,23 @@ static void tegra_mc_sync_state(struct device *dev)\n> \t\ticc_sync_state(dev);\n> }\n> \n> +static int tegra_mc_resume(struct device *dev)\n> +{\n> +\tstruct tegra_mc *mc = dev_get_drvdata(dev);\n> +\n> +\tif (mc->soc->ops && mc->soc->ops->resume)\n> +\t\treturn mc->soc->ops->resume(mc);\n\nI noticed that the tegra186_mc_resume never fails and always returns 0. \nGiven that this is the only resume handler, it seem that we should \nchange this to a void return type and then we can avoid the extra return \nhere. This also simplifies the next patch. So may be we should add one \nmore patch to change the return type for this resume callback.\n\nIf we ever need to return a error code in the future we can add back, \nbut if we don't need it now, then I don't see why we should keep this.\n\nJon","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=WoLtSlZZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14076-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"WoLtSlZZ\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.93.196.26","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5nfl5vDjz1yGq\n\tfor ; Thu, 30 Apr 2026 18:39:59 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 10A9D30065C2\n\tfor ; Thu, 30 Apr 2026 08:39:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CE9223FE375;\n\tThu, 30 Apr 2026 08:39:55 +0000 (UTC)","from SA9PR02CU001.outbound.protection.outlook.com\n (mail-southcentralusazon11013026.outbound.protection.outlook.com\n [40.93.196.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E663FE350;\n\tThu, 30 Apr 2026 08:39:54 +0000 (UTC)","from DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12)\n by DS0PR12MB8366.namprd12.prod.outlook.com (2603:10b6:8:f9::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.21; Thu, 30 Apr\n 2026 08:39:51 +0000","from DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391]) by DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391%6]) with mapi id 15.20.9870.020; Thu, 30 Apr 2026\n 08:39:50 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777538395; cv=fail;\n b=Ml/XaqlLAcBVGa07CJJ7LAqk+9VL+3vouFF3q+aC/OCx5EsvYqgznuziV4AcXk6V6yhHGbvAck2Zpx7taFPjEcDmsNXCsFsQ0EyS+tCoNMzMNHgUnF1tglCKNIlhPJqMY9iQXRkUGpy05QSWrTJa6dHWmmwURutcrhvuNyTY354=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=uhZ/AT9dUgndUCktqQHuvPt2UesIXwiTVl4z3zjVG1TvinT+vPLgfZE+JGZp+6tKWDkSFWfOVxReFPpwnOGi8xfAHDuGS2R+HyDbJv/kHA/Ze3MdtKbvpYIbkDTF8tVB15XR4jtnv63W3MbeoBfGctmNiYGqPAUieRIY5wgisMFS614U1xw5R4m/5pSJ4UI13EDZ4WgsPZr/hKlOfj6c1UYkW3Ubh5MazuEdISNigkVQm5PuPq86QoY7sHrBusBz590dx9PHRYhvJdnkwlIZBLR8EpGPWqDh5GWYEqZObEQeSns61pmYnZNxTk8V7qtxWNserviMA2mqIEgoS80Pxg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777538395; c=relaxed/simple;\n\tbh=64AIAAjVfPqrFa4LIklzpn1ZaeVX4RJ8q7Hb+NhUzk4=;\n\th=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=WIsCN67xSQCQXRnHoabl4cvEitfNjUg28WAM3mHzA17qe5UsGtnip3Ck+fLZhMWcBTQg6pGQ83vDdv9Eq6OobbZMOV3ycduPh3Y+4S3It3pbXUYnBqKm3mo6Zv1HWeFP9NlgdHay7IvyLH9poeg1bpyHDHgpUiFLscfEIX3hz0I=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Ww2SYTZlCWzHVW7Z6m/yKjZtfYXvmcpui37WagX/61k=;\n b=GonEwBpSbClJ5lQokUZ30bqhTAEoqKIYYzhji7dUzq3xqzB/aotLjbc7nXnrWDgIbm9GYy+/fK1iklDQF3DPuLK3vgTdiyNE3ycbGBp5UVAvNIIpWQ+x+3fRQjPJaUCTCkhTHLKOANF45EaI5xv6ishxOOnq9FAudkCMrmuqT9uu31hVTSYJRvOGvF0ArBoSOljqA/5FxX2rYVEYHZDpx426RmoQEOnGhsboWyZnvfuIyZzmNwGMvnJOPKP1089CeChbPYfdM540ccbkF7zuCDD9WoWtDD4ZjMbYaTBblyXcKyYPc9H3DuBeJXj1vew5x02INjFeopQxRw3ZZRnEaQ=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=WoLtSlZZ; arc=fail smtp.client-ip=40.93.196.26","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ww2SYTZlCWzHVW7Z6m/yKjZtfYXvmcpui37WagX/61k=;\n b=WoLtSlZZ4TmdW7w1fxcBrsbU+ySaOVa2JSO+R+2V/IQ3oiOUMIKCv3mBHrFFmL2fI3AFqYq6vaEU5Mug6aNODPVa10XoNLDHwloC9lQ34tv0xzH1JXKIE5wJiucV0naqa+P2nsGHBbQQuoOIUgi8WMzX6rDt2yiM1juyCnwz6c+qDXXiX0TNFSzNgDOOv73BFQIcSmIhbeg9ae2I5jm8q1RwBBT/ebxQrEwQ8Tki/oJ76W03c7fI0JK2YLyRNId8oQJAqMrP/TWObIyu16M/d5f+Zgz6p/m0KOalfriK76DKGJO/ClJ8BujguSuYyPvGt19CtWqi/zF5xSKffmpg1g==","Message-ID":"<536e3912-9351-4825-b25b-776e4cd4c748@nvidia.com>","Date":"Thu, 30 Apr 2026 09:39:46 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH V2 1/2] memory: tegra: Wire up system sleep PM ops","To":"Ashish Mhetre , krzk@kernel.org,\n thierry.reding@kernel.org","Cc":"ketanp@nvidia.com, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org","References":"<20260430070954.1005564-1-amhetre@nvidia.com>\n <20260430070954.1005564-2-amhetre@nvidia.com>","From":"Jon Hunter ","Content-Language":"en-US","In-Reply-To":"<20260430070954.1005564-2-amhetre@nvidia.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"LO4P123CA0356.GBRP123.PROD.OUTLOOK.COM\n (2603:10a6:600:18d::19) To DS2PR12MB9750.namprd12.prod.outlook.com\n (2603:10b6:8:2b0::12)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS2PR12MB9750:EE_|DS0PR12MB8366:EE_","X-MS-Office365-Filtering-Correlation-Id":"8ff7fbe9-18cb-4688-dd45-08dea6940b36","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|366016|376014|1800799024|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n\tSeC04pqgrpNZvgGo9QEL4HHvgiA2si4qTcjsBHW6CTBva4NQmit6Oq3sbaNkTMYyY79M8kj3T/eDI1eCd6cQwkSW7m2YGODQC0fRvG0aM5eAgGS04TQRKtq5i64tuAS+DjpzKeHjljV0nGJJiwzhOynZ6ydK2teT4NnxWJHwxSuxNao4/0p9Sa5dI2nkmeTk89jsXWobBZchwuTs62/U0zxEslMkEFdItX+hzh6AZrIewFaLJmZYe+BMpt5yC5xcVxsrOke5mmETHnEZ8hvArWr9x+kZW2yWEiyQwMLxYuA9eqgtH2pts4HfPc/nNpSL2E/nwsKbtdEW6093dNmIp/RrtKnmg2htgOPfPs2qtnGBksmZA2uvrc6am7SfkQzomNhVFeK+L06YHBCH1XPc0cyYeF0bUionsSbcBZRt4rsh9lhqRBSKK+GLbx0sZucBLISTfyJDQS0BTkEEoljbWaQ9uHkB0DAptZvxU4M2dR3S0dwSnkuOIicUQxhvo431T7z/+uBz3+3e6Is1+jBU3Z+/Q5w0n+G4zcvGI4uRHLfYWLI8bLVzMvfgJ8h7Qc0snnYHYZyE/pcG/AnpAwNkJtMAXxdcDZB1s3UCi4oYrS8SNE7l8zSyyP1f1MW+q42blUDPHUHDDO50pn2JxvN8TD17Mg4vVH6ZCOjZAfS+xwczzL/kNsy/6AAJUwHyKY9ndlNsQAPwet8la8tdC/geukUE/6Iwq0PEQ3Ndbs2FieA=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9750.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?PoK9XMNF1Tl6fWHFqss8VvVBNj+P?=\n\t=?utf-8?q?BRmUjVTlLq2IFdMSbvGzD97DzGqI/MWSwptqwGpACzIrVkRXZSjYzrUcZAiT1myy7?=\n\t=?utf-8?q?Sk0l7Yoxe5WsIf8gG5K8eQvqEaMGSVNXQRFHw7W/XAFL+z3zz+g84j0XQouvfZ/Bl?=\n\t=?utf-8?q?Q81b/iS71XqhWJMKHsX/PaIdVxjVY5nROxNiRWu+RAykn24J66aw/MvMKTGw16fNL?=\n\t=?utf-8?q?8yD/dHqIRz2xGZa/pNvC/37R3F5naUn4nFd2Kw5JMghXxi2rj62Ps28/LNFSYiO+j?=\n\t=?utf-8?q?ljquqt8MtOlD8oMpV3kgY8Kjeuow7a9NMLMIz/x0PWDv+fsfbP74axzwwg/Q6X1EB?=\n\t=?utf-8?q?glXM5l5EdwvEDIujpf5juu/CcohebKRZlr9aRyb6fXib8aRcpSi3CMtbU5Qcn18QA?=\n\t=?utf-8?q?nkXIAnB21QmEmc6On75QXa7pmXMWlwCbs0lMyuTWFW7gbjvLJpOns1lESsObdr3Sl?=\n\t=?utf-8?q?CMdXrStW7OGlMPFFlDqQBni0XLMERD8jDmORCXS5hM6UUZGPbR+7znMs8Hv2vtSDT?=\n\t=?utf-8?q?lLswte3rrCo+ZGOBmF+M7lIT4JMQ9BIUN44b7aEp4bV6fxnRLYo0WgGGPdQ6axCXc?=\n\t=?utf-8?q?Fl7gaMtmDZWkcRkrn64mMx416r969Rjdxr6l33JTihOK5f2FwmRIUUMvAIsI8SIrj?=\n\t=?utf-8?q?Ngzrk6GQBISiBCyv6e6CJo6Te441Z4zFB4YiX9JPKystEaoKs/JIqp3RCmW0vqIVq?=\n\t=?utf-8?q?qThgY0767u52L+96wKR9unsk7cGb1O4MqarCySZShTBOOFljOnvfkWBrWi1ecgCPc?=\n\t=?utf-8?q?qocpb+XLLJrf4B4aRRUlzlfGVa2yE1PsCH93+UKpDHHUcbyx4mRNSDrLiS//rwi8d?=\n\t=?utf-8?q?BBFn7x98tgtjZeKDTfC6mN1j3EVD9iZwTPWoP0SoKgQo9cUDeTYdDzV6Pz7WafE7F?=\n\t=?utf-8?q?V+yQLvoBSptm2VCxKqD+gjch1UxzjxOaRZIxbTMq1oqrhpiV9zPm3xvn/qkUR+9sQ?=\n\t=?utf-8?q?j8KID0Tn+IqvsOuqaoyxZNxw9NUdGKQ293/s2ZJkymwa3gY31eYArHjDC4gHMpvNg?=\n\t=?utf-8?q?aRjKvTUiihKdcImrhcwjXB8N75MsAZ+2T6CruYLC3xY5xtz8h6L2XCvvn5DYbqJmq?=\n\t=?utf-8?q?x3O3Py4BZtkuBHTB8pNuURc77wPrHB49TP5ziewUaqVGEpgF9LwPet1B/a6Mcsexx?=\n\t=?utf-8?q?OUbuGgxhgRXEiqvi1T0RlXlScV2mAuyp7CuBzSJk3Uy9EDdHnyC4OBLT3Z/lMuMxz?=\n\t=?utf-8?q?A6EQc3Q8JJ4TVXS6jsPcNdLdKFsL7HGrjF95LD9AX4PsRZe6BWK0pBeZNfApFMZ1W?=\n\t=?utf-8?q?CYZmSLvXDJ2H/c6vHp3osQaPco4iW6pTF04v21SL+6E+/xWW0MKMGWbbGnjVxQ2F3?=\n\t=?utf-8?q?OHe0+p8TLVRdKfRlCiBoPGWKkzIfQwsoEWr0rSse1gsZrmuwm7tpliEWuKCAmYeDK?=\n\t=?utf-8?q?xEeXGjekdSU/OPn7QjULrAnwol18OTGnBWF6OjsYJ5DEXia6k3BUF6DA3dnLE28J3?=\n\t=?utf-8?q?vUczSV3Kdm6qaaZ7u3xWNSJpI3RKjD4T1fE8fMJcQW3Vg9fkiTqe7cPChaNEm9f8C?=\n\t=?utf-8?q?bepcEpciUr0Uavacc66Dgd37cXer15FAlxAnJ54B7Y4sS9G5QnWbNATuKlKFZVT+Z?=\n\t=?utf-8?q?Hf8/sulziKiuyEidBfc+PhbT7ZYuGncq1mao8aMA2eNPDXQNFZ3o9m2tnB5nlzpKS?=\n\t=?utf-8?q?uRXn4F7XzE+8+Qx6mlAkLRH7dcVF7j/Q=3D=3D?=","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 8ff7fbe9-18cb-4688-dd45-08dea6940b36","X-MS-Exchange-CrossTenant-AuthSource":"DS2PR12MB9750.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Apr 2026 08:39:50.7617\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n MKnbRM1NedBNPn9kBuu4IKGSaVOHLboavg/2w7wT6BIObgQh/eUv9wiJfoIt1C4N+hJRLmDRD7vFPN0baRtuUw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS0PR12MB8366"}},{"id":3684573,"web_url":"http://patchwork.ozlabs.org/comment/3684573/","msgid":"","list_archive_url":null,"date":"2026-04-30T09:39:29","subject":"Re: [PATCH V2 1/2] memory: tegra: Wire up system sleep PM ops","submitter":{"id":75198,"url":"http://patchwork.ozlabs.org/api/people/75198/","name":"Ashish Mhetre","email":"amhetre@nvidia.com"},"content":"On 4/30/2026 2:09 PM, Jon Hunter wrote:\n>\n>\n> On 30/04/2026 08:09, Ashish Mhetre wrote:\n>> The tegra-mc platform driver does not register any dev_pm_ops, so the\n>> the SoC-specific ->resume() is never invoked (e.g. tegra186_mc_resume)\n>> on system wake. On Tegra186 and later this means MC client Stream-ID\n>> override registers are not reprogrammed.\n>>\n>> Register a dev_pm_ops on the tegra-mc driver and route the system\n>> resume callback into mc->soc->ops->resume() so the existing SID\n>> restore path runs again on wake.\n>>\n>> No suspend callback is needed as the resume path reprograms all MC\n>> state from the static SoC tables, so there is nothing to save.\n>>\n>> Fixes: fe3b082a6eb8 (\"memory: tegra: Add SID override programming for \n>> MC clients\")\n>> Signed-off-by: Ashish Mhetre \n>> ---\n>>   drivers/memory/tegra/mc.c | 14 ++++++++++++++\n>>   1 file changed, 14 insertions(+)\n>>\n>> diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c\n>> index d620660da331..343ac0018eba 100644\n>> --- a/drivers/memory/tegra/mc.c\n>> +++ b/drivers/memory/tegra/mc.c\n>> @@ -13,6 +13,7 @@\n>>   #include \n>>   #include \n>>   #include \n>> +#include \n>>   #include \n>>   #include \n>>   #include \n>> @@ -1010,10 +1011,23 @@ static void tegra_mc_sync_state(struct device \n>> *dev)\n>>           icc_sync_state(dev);\n>>   }\n>>   +static int tegra_mc_resume(struct device *dev)\n>> +{\n>> +    struct tegra_mc *mc = dev_get_drvdata(dev);\n>> +\n>> +    if (mc->soc->ops && mc->soc->ops->resume)\n>> +        return mc->soc->ops->resume(mc);\n>\n> I noticed that the tegra186_mc_resume never fails and always returns \n> 0. Given that this is the only resume handler, it seem that we should \n> change this to a void return type and then we can avoid the extra \n> return here. This also simplifies the next patch. So may be we should \n> add one more patch to change the return type for this resume callback.\n>\n> If we ever need to return a error code in the future we can add back, \n> but if we don't need it now, then I don't see why we should keep this.\n>\n> Jon\n>\n\nOkay, I'll update the return-type in new patch and send V3.\n\nThanks,\nAshish Mhetre","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=HhhFAPnS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14079-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"HhhFAPnS\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.62.5","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5q87092xz1yHZ\n\tfor ; Thu, 30 Apr 2026 19:47:03 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id A46AA3062C3C\n\tfor ; Thu, 30 Apr 2026 09:39:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7C26828751B;\n\tThu, 30 Apr 2026 09:39:41 +0000 (UTC)","from DM5PR21CU001.outbound.protection.outlook.com\n (mail-centralusazon11011005.outbound.protection.outlook.com [52.101.62.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 338B73A6406;\n\tThu, 30 Apr 2026 09:39:38 +0000 (UTC)","from BN5PR12MB9511.namprd12.prod.outlook.com (2603:10b6:408:2a9::14)\n by CH2PR12MB4245.namprd12.prod.outlook.com (2603:10b6:610:af::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.21; Thu, 30 Apr\n 2026 09:39:35 +0000","from BN5PR12MB9511.namprd12.prod.outlook.com\n ([fe80::4d8d:5f91:6c3c:dc8c]) by BN5PR12MB9511.namprd12.prod.outlook.com\n ([fe80::4d8d:5f91:6c3c:dc8c%4]) with mapi id 15.20.9870.013; Thu, 30 Apr 2026\n 09:39:35 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777541981; cv=fail;\n b=SSjCNcEQLRBAmpC6ZXgYFy/wAqZc+KZwUAbpXEVU74q+hzIXyiK/bQ4lqUiSTogFuxDxVkeCnKl70IJ0+SHm7UZJI3+kA+CKNxm4O58KTuWSmeF07cJmLIotarVG1Pz+EiNuH2fyLScYbKVLoxgikn1AOjFNKLHvipbwBhFusN8=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=GrQ7SVsgP/YUqR5qiV4xDquRsU4narGxn/AvWorSuPgWaPKeUnVaPSbwulZO6hlO8NV2M5vJX2xDOt6gVKFKDb/K6ZDJEEzhJUwr2UDo0E0W5hFK2JjvqCBhyb5sNMmzoND9a0dL8sJ9nHs5ntaXUOF5rxwA2WymRpOEdlCPp9VWgpPsfG35LQ07uxIDd5p3eNkztMJEaJ9dr8OaqnYiWYg99arX8hn/C4i0HFWPOeLs+7dEI41Mgo6AXnquzaduEPKmkVzXSe5eGlPaPSqf1rKuu2YG1CmWEYxFPLzlVuto5rmD959W2Okfp1MhG6Ji8I0d9OJlSGgbpF+ivqfVZw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777541981; c=relaxed/simple;\n\tbh=CAtZTp8uBN2+0QI5gy1Mie3TU1nJQOniOGJc675xMvw=;\n\th=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=Wi150yoiSGgDBJ7mighHONfEuCgSMx4XLY81WDQYQ1cnDgXBJ3R5m2YTipfX0zRGL+02CYptO03DEPuCika+W3inRNUPPcxua1ZTJ6sKn2zEIoWTGyhNGG5tl/XswNaLYgxrcO6i5pOmFUp4ZfGInXAhyFLZEhA6Q+lCZWVL3aY=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=CGoeTSeTvEDkdv6FR15oEmUyxwLRjVgAC4gBFlaY1ZU=;\n b=Edf1dVe7y3lTBBfPTElijIgSuQWRbNbrHSi6bn4VPH3lSr6kXlhCtZIaaZmSFpwavL3084xHwmzdmbs4PdD7E0ov13JIWp0dn3OB2ygJlVRMx3IdS23RXbLDgLTCxQkllzNV5NplLGD9AO2dLI4sg0ysvmqNOqqLKwvgYxSkRsAgaJ8GnjnBZNC3yKDIiuq6FhpOr7lLJMxav0/K6Npgg5qMZJayDI1kj5HOZfvF5iLAlUyXPLPLAJwSnkPfcErDnF1IQyaaeLGTeXWGKwEBCqi2f+lCOW/2XVbAVyEukKbdcJjQciDN4qHw2HmS3ERBi1kVv7FztUwdvZ3twXFN3g=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=HhhFAPnS; arc=fail smtp.client-ip=52.101.62.5","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=CGoeTSeTvEDkdv6FR15oEmUyxwLRjVgAC4gBFlaY1ZU=;\n b=HhhFAPnSzhAGm9Fe3CZInBQK2dfEH3uynTM8yOzhJYGOrxF1OQgyX8MjkuBE5pTPVH/XbmMj71kvsQzZuxVnMHbXQ+0xeKxk1Yo3KL/1spr1wR+IoTbu3OccGGhH5FhHbLruLwDs7i3HFeahwQl1nkDYprBFK6hcj0aSb2oqD5Yw2+WEaPmV9HXlk58FMFxFWpYiW991yMrizsUWNnP50aATGfGFUPljSlNAxVMKDhJcIXePI5jTgbthnnIsR9OIogRL1un9sgB9WSDqjwi6E+Hq+Usd6EJON9CsmuaRYDzFU0bPX7/1UxGCrFhTjt8A+4bC9V75EDEjxfq1vonOlA==","Message-ID":"","Date":"Thu, 30 Apr 2026 15:09:29 +0530","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH V2 1/2] memory: tegra: Wire up system sleep PM ops","To":"Jon Hunter , krzk@kernel.org,\n thierry.reding@kernel.org","Cc":"ketanp@nvidia.com, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org","References":"<20260430070954.1005564-1-amhetre@nvidia.com>\n <20260430070954.1005564-2-amhetre@nvidia.com>\n <536e3912-9351-4825-b25b-776e4cd4c748@nvidia.com>","Content-Language":"en-US","From":"Ashish Mhetre ","In-Reply-To":"<536e3912-9351-4825-b25b-776e4cd4c748@nvidia.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"SJ0PR05CA0189.namprd05.prod.outlook.com\n (2603:10b6:a03:330::14) To BN5PR12MB9511.namprd12.prod.outlook.com\n (2603:10b6:408:2a9::14)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"BN5PR12MB9511:EE_|CH2PR12MB4245:EE_","X-MS-Office365-Filtering-Correlation-Id":"ac55da48-9a98-4c59-0704-08dea69c63b3","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|366016|376014|1800799024|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\tAAzCtCIiQloSyKk/VYurfu2xeAlvbh2OSe4FFD1c5TcgI4PNbi8AUCb+Ad+wfF70xggeUmwMdJSe+jOTEBgdP14xtrzZfyIYL/6h4s1pN1aLU8XiEaq42niQSjJBSoXxHW0ZE93u1qDr2JC8HPL9ExRqFq/l0T8iF54ChTLeXC86ADvQydHkQ5QKwJl5VM3yMdBmb8At1krf3Vhy0nFRQmcQTVIY0vefxKWR3esXALJ+iE+5KhjwCM/SDHhVKF1OAPjP65LjZdLn6xjybsuIP1LNJJRerJevxmb10ZfAYS4MaK2qjkOvLU48wZQEdd7TqHe3SPWFugIgbYKJOwpiYrTpxbyqzMaJMXQehZ2b0Q7EurJF8gS2hV2zIYHC+/aBeQd4z9wBqJD+Mp162W90y7pUA2VdAMhWTUwB4UoObR+UnHHArcw2WYnOCiQs65uI3DC1YsmCHfEdruPisk6B+vCG9WdvpKtxo9tDxWGj+AVk5ESNJdpzhTlkmh+YeFgGubsU+oxeDD1cz0qhHp1s9gtCug3GEIlTk8hJe2yU550ouwxZov/wZ3Q3nVYCt9CoiVQAZRadP5xuEMSpGp9UhwaKxKZVKzdA3OJUFUhfs/P7IulyAkkN8gU+E1/8y+5zfeRaG9HEmQ4TDdiYYaWUtVYFhCNx1mk5sU5yz2jiE+5kmmwHiMFddtU0PvslrIiJtL0OQvtVnKbUu0ETT7/PhLorkvf6hCIS6yzPl4DYo/k=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN5PR12MB9511.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?hj+eBqhBDrqacjnns2D6D0bsyNW9?=\n\t=?utf-8?q?yB4IC0KFWKOntcOmVWfySJIc8uKQSd+EdZjmsJmPosygDUzou3PoKkXTQyGBZpmDk?=\n\t=?utf-8?q?GBi+1sqCS/U2FGkLoOQjfDrSyVO3/+Fc3+05K/VRvpydFcGjvAk4i63OMdPzy7u9y?=\n\t=?utf-8?q?QG1ILvw4EFF/0HlzrmzwpZHhcBooW0usiu1FrOf1/o66An2YQ4fdq95PS/CxpVwf4?=\n\t=?utf-8?q?0af5Am7hSdG7lpYpNvsyR0h449rmnQSZHHqVWTeqC8TkjmtAM9e/WF5hFH8L53bAz?=\n\t=?utf-8?q?wJ58QzOOpjM4yoEVws5QLlHomvwka3vxNVe5jNiHGIB+nhiTgYsR4CQ6NaprqliPC?=\n\t=?utf-8?q?SUT32nBnoSvd7Y3vP1asD1EpjaYRhGY80eyt83OHuuj/WhPB5/0jYPSN7YWMkNOy+?=\n\t=?utf-8?q?JwHVBjTFagYvwyCYs5afwtLq632I3OJ9Y+3Ej68njWGbtyTONkCizWQQVCJ62A4gO?=\n\t=?utf-8?q?vIgMwIoPE+TIN1jtNHugizmoAWYruzxZPU7oLoEvivTgkcReE9PRI75VKsTAasB4M?=\n\t=?utf-8?q?ummJ4r9WI5NG1UyOlyUR9Lu3C8+pBV187BlXPiirte5rMlkwKhcjpTfWFeaBQzcVi?=\n\t=?utf-8?q?l5kaZ0cSX2Y7kgW3VdzIbN4regT6dbiteP1bMaqA9yZj236fNa9Av6d2WlCCXZZAV?=\n\t=?utf-8?q?L3RthQTyHd4dM3t4qCIRUw5wOJAVi4KPIffGe3pxXrV4SW9LX7sRxt8erPnxOkqEi?=\n\t=?utf-8?q?PjFmc33obs5jEzwLOw06vZ2/Ez/iVpUdmHfdseRvGdAsLb2TzmBSvOu8Npq4ZzCr8?=\n\t=?utf-8?q?rVAZef/fDTt89MdSjeE95gH20qgEXQrqk9acWZR3Z/FGMsihrNjTWhsPnrZZqMX5x?=\n\t=?utf-8?q?2kOzzST4Au7NXln3pA+yyb3YmchuvloXCGerxabVEoWwUeq2Kh16zmHurx/6+M15L?=\n\t=?utf-8?q?8GhfOOHluk3Z9Ks6J1WnBt3tv9+98C7iIpJ8yOPJLjDB4y7RFVJFMRJhPacfHsrLc?=\n\t=?utf-8?q?fE1tBxp6WRD1PVLuWy3224fDt1LIX7XdYKwX0793E5sbPCz+BkROvxaDP4tgepM89?=\n\t=?utf-8?q?12BeZkntyKsh10uZTHuCjjYrgVpi1652tj4/wPckscKsmT1vrDghiNbLBFlfZi/ko?=\n\t=?utf-8?q?7PAwbHO3oXgS0u7KQRYlrP7+i97RTf3Yn+NdhOcfxvqFekxFtwQ3OpBqrBlZTSyTm?=\n\t=?utf-8?q?ICFQYhPj3TUGb7XRppreE3a6IqxlBL4IGSxYFwPdbdJjxrr4qYLje8bod0TH6nEZ2?=\n\t=?utf-8?q?BVOPDQPlm0O8ExpMCqBQgZTkObsapJqGTyGOPEzQrj91sE8UvkZYrH7K2poiMINcV?=\n\t=?utf-8?q?05cv5H1JqaG/M1/jAH+amYssmEI+gyNdmkqOg6zpX0hXFIOPdH5hYs5KStaRdbwdm?=\n\t=?utf-8?q?dq/3MmzP4WC1b9imwdIx2kqkJC1OKJ53hAWVGv8iNe577AYm5/9+BZXf4fWx8V6UT?=\n\t=?utf-8?q?7af9PxoevYY5IU8LgbtlfbB4ofdZrox255Qai8LhmK1Cfyv8AUDIUgD4+pshtorUm?=\n\t=?utf-8?q?ZDH4g+hr9BFIqaciEVuGjFbP9kiXhWvgRhrB/Yz8DzSB57Zf0fm0acXGS02AyzTh9?=\n\t=?utf-8?q?MF2Ks24Bm1SRmV/D7PGwi5mqxE7u9IURkOBJVCiCejjvv/1EXHGoKnWMtjm3rbWlW?=\n\t=?utf-8?q?4+fOI+QLpWn5k+8j/647X3UQHxGvtDRT7dw/Dt5AUyhlfA2zLuhBGt8+VGmmkPYJT?=\n\t=?utf-8?q?mD9SnYLOP0NufYMJ+cZBE/Wb+cgxsiLw=3D=3D?=","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n ac55da48-9a98-4c59-0704-08dea69c63b3","X-MS-Exchange-CrossTenant-AuthSource":"BN5PR12MB9511.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Apr 2026 09:39:35.2679\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n W07NwXSB5fwzcC+Ar9CkmIRP3G3KdmUmofsk9gMmcYeafaRQQVxZ2JwQz3sip+BpDAi5xZ49qfrbMS63axfrag==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH2PR12MB4245"}}]