[{"id":3684468,"web_url":"http://patchwork.ozlabs.org/comment/3684468/","msgid":"<20260430063458.3933-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-30T06:34:58","subject":"Re: [LTP] fsconfig04: Check FSCONFIG_SET_PATH","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Wei,\n\nOn Thu, 30 Apr 2026 05:19:07 +0000, Wei Gao wrote:\n> fsconfig04: Check FSCONFIG_SET_PATH\n\n> +\tFixes: https://github.com/linux-test-project/ltp/issues/1169\n\n`Fixes:` must reference a git commit SHA. Use `Closes:` for GitHub issue URLs.\n\n> +\tTEST(fsconfig(fd, FSCONFIG_CMD_CREATE, NULL, NULL, 0));\n> +\tif (TST_RET == -1)\n> +\t\ttst_brk(TFAIL | TTERRNO, \"fsconfig(FSCONFIG_CMD_CREATE) failed\");\n\n[...]\n\n> +\tsnprintf(path, sizeof(path), \"tune2fs -l %s 2>&1\", dev0);\n> +\ttune2fs = SAFE_POPEN(path, \"r\");\n> +\n> +\twhile (fgets(line, PATH_MAX, tune2fs)) {\n> +\t\tif (*line && strstr(line, \"Journal device:\") && strstr(line, device_str)) {\n\n`FSCONFIG_CMD_CREATE` instantiates the filesystem context in kernel memory but\ndoes not update the on-disk superblock. `tune2fs -l dev0` will still show dev1\nas the journal device (from the last mkfs), not dev2 — so `found` will always\nbe 0 and the test always reports TFAIL. Either complete the mount with\nfsmount()/move_mount() and verify the active journal via runtime state, or\nconfirm whether ext4's FSCONFIG_CMD_CREATE with journal_path actually persists\nthe binding to the superblock (and document it if so).\n\n---\nNote:\n\nOur agent completed the review of the patch. The agent can sometimes produce\nfalse positives although often its findings are genuine. If you find issues with\nthe review, please comment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=V7Y2wQcN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ktj61gtz1yGq\n\tfor ; Thu, 30 Apr 2026 16:35:09 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id CCCC03E2681\n\tfor ; Thu, 30 Apr 2026 08:35:07 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 660433E250B\n for ; Thu, 30 Apr 2026 08:35:01 +0200 (CEST)","from mail-qt1-x844.google.com (mail-qt1-x844.google.com\n [IPv6:2607:f8b0:4864:20::844])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 1A9AB6001EE\n for ; Thu, 30 Apr 2026 08:35:01 +0200 (CEST)","by mail-qt1-x844.google.com with SMTP id\n d75a77b69052e-50fb8e9a4edso6347581cf.1\n for ; Wed, 29 Apr 2026 23:35:01 -0700 (PDT)","from\n runnervmeorf1.azymcduxfoqubelgmubqnbqpmd.ex.internal.cloudapp.net\n ([135.232.232.89]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-5101ae657d7sm36359881cf.21.2026.04.29.23.34.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 23:34:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777530900; x=1778135700; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7F0yJvdTcAJ3hfbniqHxMBtPz7ueXINQtrdWTAV3DqA=;\n b=V7Y2wQcN09H7l5DuS1RkyCH2GljmYT9BNThJpS245VnETxN6Ho26eAe4yBOfDtWtAx\n C5xL1mH0qWDNT3ijXOSBgJj3F9WUQcBKW4F564t4d2o8MjVM7VBdYOjNtIyS7aDGu/FI\n gZWgdcI1gwlZdNY6LsEO5PNy4Fnmt0W01NXA3nSbzt8A64d6jra5mgWCkVp0IblN+kUD\n Jn/4ZOubAOJXj+2kiQlSXljUqsdWHqFZD/rg3bGiqVHx7W1XOYBnzE5Q5QQ/CmUSgjSR\n iN9TMexzpNbrQ51kQQBDA9Chywou+5frLs2x+rOPFApjygiHEXiXai7GS3JvQfGscz3c\n LBnw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777530900; x=1778135700;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7F0yJvdTcAJ3hfbniqHxMBtPz7ueXINQtrdWTAV3DqA=;\n b=PEsnCsm9MlGFE70QWrmpRaNhvVhNQyMzSusdv2bt10tCJzC1e+TjS/zJM6+DTXUkT3\n MYpYmD5Jk9VU4spLG3YEwERt5wwsVgfpfW19M9P9kXZJ5DG/jJ0KnnjP6e22DTcjoFnR\n tBcehi3S5FTI05PtoEzcI4Z0cXRzW2Ry1cmqbZpQYOWUXIaQcpvfIweXkbeUr5qOMYoE\n AUhFeeazOdMQxJ9NoUIv1+j+v/15u+2u/rH4ME2l5UzaOS6wq2CFQu5R41od2pdC56zN\n AVWnMT+gNMyLleOdJGbgt0DSsGpj2H6yx/eMOOba/fq/b26BNyKizga8TmgrFZLS0eqY\n lZgA==","X-Gm-Message-State":"AOJu0YyISMSp2v34mHkJMmUZ15BVvlbCzNC188el5YfQm6tnFdnie7hh\n NeojbxgKHzOOyd6YtvGkgpoMYHYTMA7dpAPT//RkOjoUL2+udlNOrPf+","X-Gm-Gg":"AeBDieurioKIzE0Rnh98LgvpcYAj/eGY76lr/YPREyT5BbJbz4iRlRFwZ9oKhul7Jgg\n OJU5+sZrxDv1nxdKZCJz7A1YtuS1rdP50vS6BKRdgyKcjg7ySbZg/xkDssX+X8xD8igt0lVO44J\n 7yqSLI/epfp7PUg/TBk/b7RjNx92asFKf0HapHePsgjvSHlhBMG8XlulkZdWNDr03VqXXVUMl+f\n ewx4ADEDKgSM17sfUA0fsozrAEPbdmT5f5mxmjgTCVWGOEwRD6Usv0snZ25p3BaZgzC5bpNuPE3\n jYe+9TYTGNPBak3SaXV99k8zF5Wdp3sVcaoEDdnjTpqu9oac8UxcIHFcfLdi25XWPJoFM4rEVSk\n ZzPoExoxsXKJ1i4TbKwTIaublvkISJ1B04wrkaRG7T9ZfX0AB+UXbMXv9t7fDprGXe857rwnwdf\n ptdJmOTJgh67vSRmvMdgl8iSt8cksd4zmkD6UdM/n5OGaCyQQKwUMBIqybfg3YKF96Zp28Oux03\n nA8E9cHZ18NARpqaSMG3HUrk4kUifxRnhZzwn51RoosE9P8SgM=","X-Received":"by 2002:a05:622a:1456:b0:50e:42ec:ca76 with SMTP id\n d75a77b69052e-5102ad9af34mr21229011cf.38.1777530899862;\n Wed, 29 Apr 2026 23:34:59 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Wei Gao ","Date":"Thu, 30 Apr 2026 06:34:58 +0000","Message-ID":"<20260430063458.3933-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430051915.2178-1-wegao@suse.com>","References":"<20260430051915.2178-1-wegao@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] fsconfig04: Check FSCONFIG_SET_PATH","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]