[{"id":3684470,"web_url":"http://patchwork.ozlabs.org/comment/3684470/","msgid":"<20260430063508.4014-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-30T06:35:08","subject":"Re: [LTP] testcases/kernel/device-drivers/nvme: Add NVMe device\n discovery test","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi priyama2,\n\nOn Fri, 1 May 2026 15:14:20 +0000, priyama2 wrote:\n> +++ b/testcases/kernel/device-drivers/nvme/Makefile\n> +# Copyright (c) 2024 IBM Corporation\n\nThis file is new and added in 2026; the copyright year must match the\nyear of creation. Change 2024 -> 2026.\n\n[...]\n\n> +static int nvme_device_found;\n> +static char nvme_dev_name[256];\n\n[...]\n\n> +static void run(unsigned int n)\n> +{\n> +\t/* Reset state for each iteration */\n> +\tnvme_device_found = 0;\n> +\tmemset(nvme_dev_name, 0, sizeof(nvme_dev_name));\n> +\n> +\tswitch (n) {\n> +\tcase 0:\n> +\t\ttest_detect_nvme_controllers();\n> +\t\tbreak;\n> +\tcase 1:\n> +\t\ttest_enumerate_namespaces();\n\nWith .tcnt = 4, each run(n) is a separate call, so the reset at the top\nzeroes out nvme_device_found before cases 1-3 can use the value set by\ncase 0. On a machine with NVMe hardware, cases 1-3 always TCONF. Move\nthe device discovery into setup() so the state persists across all run()\ninvocations.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/25150858409\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=FLksZh7R;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5kvP0j9zz1yGq\n\tfor ; Thu, 30 Apr 2026 16:35:44 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id E337E3E2503\n\tfor ; Thu, 30 Apr 2026 08:35:42 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id B50DF3E2CFE\n for ; Thu, 30 Apr 2026 08:35:12 +0200 (CEST)","from mail-dl1-x1244.google.com (mail-dl1-x1244.google.com\n [IPv6:2607:f8b0:4864:20::1244])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 340A8140033C\n for ; Thu, 30 Apr 2026 08:35:12 +0200 (CEST)","by mail-dl1-x1244.google.com with SMTP id\n a92af1059eb24-12c8ccc7755so863029c88.0\n for ; Wed, 29 Apr 2026 23:35:12 -0700 (PDT)","from\n runnervmeorf1.g5u13dfph0depip0q4sluubs0f.dx.internal.cloudapp.net\n ([52.159.226.242]) by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12de321f1cesm8132687c88.8.2026.04.29.23.35.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 23:35:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777530910; x=1778135710; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LwQyJO50C0oXmA4DMVirP4fFlMiZ+p20Gx96/k+F4Hw=;\n b=FLksZh7Rg8S2dAFUOV+BOQaJ7ol1/4PpB/MKisW+LKYmfzcBE67jJRoQskwNdyeuZg\n SyQQxDNKe6uU1uxDgKven6CLBNW0+6cFFfRG9CwEPJymSMQVtpuWElckNjXrg9VvKZVl\n obJY4jlkiZ4erIyEfqN+ehCrbuGXxBOpm2BReN3IIZi6Xw4rD+v/+IL//vvLekdeLywY\n QN+lCdG1tf8ejHMeU5JJaF6rhbLjY95SBLmHZUS8Xz5nkIDc4G36rNuBxf8EcsV6+uVg\n Ya1xQ+W9lpauxSm7VmlWPOjCHtiVI0DGd/P1UD7H2q95InjA8TeuCQM7eKJ17u4OiFua\n lpCg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777530910; x=1778135710;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LwQyJO50C0oXmA4DMVirP4fFlMiZ+p20Gx96/k+F4Hw=;\n b=WjWbi634+hiOUu0LGwJuSiyZkTwt/qrsxZATwGjg3bDsav9gU+4VaG7NlwNXGnliA8\n AsO6jxmcHLQzgr17SiBV1TdnTTMMjhqOtiff9AvgiMGVzqNQo9OPM9HzlETeF0HKCjAH\n 3hAqkChOkzSVniJhdu2u0tCUC0xIY+mDFDlq4cYf8kFgk5cEmkmxGYT56gU/8rdygifp\n ny+OJ7ZzcnU5Ypf8xJU8SIqXX1a7qzE55uvfqJUNHPw/Kpu25kUYU7uWq783deLbWe1E\n HaZS4t0c4HXJOe69ZTeQiq1zIz0qp5LutdxXMMBtt2ve3YvKNy7YLt4moBw014x+tNhq\n FeKA==","X-Gm-Message-State":"AOJu0YwxcwgH7ITzAOB7b/iXtyzaeFx4TPhvX+fdZEsIgJmvQUGO7Q9w\n /hBLZ1L+9tWp0ejfv8ZqvmVgf6Og7Mz5QrOQagP8liJua1KzhY+aZaw4","X-Gm-Gg":"AeBDieulGFUON7HL4DlsV/UOHqzbMXIen/VzGUWhSXbNDFxpL1W6giaJ+yJ1PcRAWdy\n 6OT58eBG81QBCd/0p0BOMe36QTWX5qrw4TlWWUox/DCh15o7v6a0CZyXKFrcaUBjpYrgQ6quewr\n I30BYBiYliMci/KTyLH/cTOY6d7xnFOEW2BePj6sKhMVnJjntq6LqdhMJ2ug5bkBpNN5RrBAwAJ\n pbUaO4qG+86kFOw01M/qKmfixFlYA1CSio7AT3vqOkQP1rYveIcK9uyTROcp/oCbkYbkOH5rG4/\n jIMDmiwY/ORBix0oiw4WXvCxBcbUYomX6ocTa7H7RSNrNj2hHr5XUHCYF2U2vsd75/VhEHq07tV\n FqhJyKPPbiwG7om8Ys8VObvjLF9P1bb/rMHxY+DVK9xTiJv8cL8LvsFtJtusVTbGTIK2MJpl06u\n nFO/TSx+VAfay0kUPK0gXZ+HzyZo86Ebs5cx/k+BDx1OPSRXIBMUKqJWraJIFHa6TnGq6Se3pLD\n 0S0enmUtBU1QEf1XDpG2d/bsl+LljYy+8sE+StA2jH6rvy+nVM=","X-Received":"by 2002:a05:701b:280d:b0:12d:ed19:e69f with SMTP id\n a92af1059eb24-12ded19e77bmr233893c88.22.1777530910411;\n Wed, 29 Apr 2026 23:35:10 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"priyama2 ","Date":"Thu, 30 Apr 2026 06:35:08 +0000","Message-ID":"<20260430063508.4014-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260501151420.1042995-1-priyama2@linux.ibm.com>","References":"<20260501151420.1042995-1-priyama2@linux.ibm.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] testcases/kernel/device-drivers/nvme: Add NVMe device\n discovery test","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]