[{"id":3684489,"web_url":"http://patchwork.ozlabs.org/comment/3684489/","msgid":"","list_archive_url":null,"date":"2026-04-30T07:13:28","subject":"Re: [PATCH] match: Simplify patterns for `a != b` implies a or b is\n non-zero","submitter":{"id":1765,"url":"http://patchwork.ozlabs.org/api/people/1765/","name":"Richard Biener","email":"richard.guenther@gmail.com"},"content":"On Thu, Apr 30, 2026 at 6:12 AM Andrew Pinski\n wrote:\n>\n> This simplified the patterns by using a for loop. Also noticed\n> that the `:c` on the inner ne/eq is not needed as it will match\n> the same canonicalization as the inner bit_ior too so removes that too.\n>\n> This removes a little more 300 lines from the generated gimple-match*.cc files too.\n>\n> Bootstrapped and tested on x86_64-linux-gnu.\n\nOK.\n\nRichard.\n\n> gcc/ChangeLog:\n>\n> * match.pd (`(a !=/== b) &\\| ((a|b) ==/!= 0)`):\n> Simplify patterns using for loop and remove the `:c`\n> on the inner ne/eq.\n>\n> Signed-off-by: Andrew Pinski \n> ---\n> gcc/match.pd | 40 ++++++++++++++++++++--------------------\n> 1 file changed, 20 insertions(+), 20 deletions(-)\n>\n> diff --git a/gcc/match.pd b/gcc/match.pd\n> index df960a0cf29..62c43b31117 100644\n> --- a/gcc/match.pd\n> +++ b/gcc/match.pd\n> @@ -7068,29 +7068,29 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)\n> #if GIMPLE\n> /* Given two integers a and b:\n> (a != b) & ((a|b) != 0) -> (a != b)\n> - (a != b) | ((a|b) != 0) -> ((a|b) != 0)\n> - (a == b) & ((a|b) == 0) -> ((a|b) == 0)\n> (a == b) | ((a|b) == 0) -> (a == b)\n> +\n> + (a == b) & ((a|b) == 0) -> ((a|b) == 0)\n> + (a != b) | ((a|b) != 0) -> ((a|b) != 0)\n> +\n> (a != b) & ((a|b) == 0) -> false\n> (a == b) | ((a|b) != 0) -> true */\n> -(simplify\n> - (bit_and:c (ne:c @0 @1) (ne (bit_ior @0 @1) integer_zerop))\n> - (ne @0 @1))\n> -(simplify\n> - (bit_ior:c (ne:c @0 @1) (ne (bit_ior@2 @0 @1) integer_zerop@3))\n> - (ne @2 @3))\n> -(simplify\n> - (bit_and:c (eq:c @0 @1) (eq (bit_ior@2 @0 @1) integer_zerop@3))\n> - (eq @2 @3))\n> -(simplify\n> - (bit_ior:c (eq:c @0 @1) (eq (bit_ior @0 @1) integer_zerop))\n> - (eq @0 @1))\n> -(simplify\n> - (bit_and:c (ne:c @0 @1) (eq (bit_ior @0 @1) integer_zerop))\n> - { constant_boolean_node (false, type); })\n> -(simplify\n> - (bit_ior:c (eq:c @0 @1) (ne (bit_ior @0 @1) integer_zerop))\n> - { constant_boolean_node (true, type); })\n> +(for bitop (bit_and bit_ior)\n> + neeq (ne eq)\n> + (simplify\n> + (bitop:c (neeq @0 @1) (neeq (bit_ior @0 @1) integer_zerop))\n> + (neeq @0 @1)))\n> +(for bitop (bit_and bit_ior)\n> + neeq (eq ne)\n> + (simplify\n> + (bitop:c (neeq @0 @1) (neeq (bit_ior@2 @0 @1) integer_zerop@3))\n> + (neeq @2 @3)))\n> +(for bitop (bit_and bit_ior)\n> + neeql (ne eq)\n> + neeqr (eq ne)\n> + (simplify\n> + (bitop (neeql @0 @1) (neeqr (bit_ior @0 @1) integer_zerop))\n> + { constant_boolean_node (bitop==BIT_AND_EXPR, type); }))\n> #endif\n>\n> /* These was part of minmax phiopt. */\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=HcW5qUcK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=HcW5qUcK","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=209.85.208.48"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5llw5Sd5z1yHv\n\tfor ; Thu, 30 Apr 2026 17:14:19 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 256C34BABF16\n\tfor ; Thu, 30 Apr 2026 07:14:13 +0000 (GMT)","from mail-ed1-f48.google.com (mail-ed1-f48.google.com\n [209.85.208.48])\n by sourceware.org (Postfix) with ESMTPS id 474894B9DB79\n for ; Thu, 30 Apr 2026 07:13:45 +0000 (GMT)","by mail-ed1-f48.google.com with SMTP id\n 4fb4d7f45d1cf-67b6dc50b61so121404a12.2\n for ; Thu, 30 Apr 2026 00:13:45 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 256C34BABF16","OpenDKIM Filter v2.11.0 sourceware.org 474894B9DB79"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 474894B9DB79","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 474894B9DB79","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777533225; cv=pass;\n b=F7Dt80vTFuHxI0p+hlgN4ZMw0eElXr4ZIy0s90DjAgGvpGCsyddsm8EBBiuk798Ils45cAeSLTaWtXTXYAWtgljsjy3XaDdPewlUY+7RumDf1etkVbpFnsaXopmVSEsrC6nbFZ9XW7C5Q5rjV3ZzjKGjMZlxsjvlYZXT4ZF47VU=","i=1; a=rsa-sha256; t=1777533224; cv=none;\n d=google.com; s=arc-20240605;\n b=k6LLt3V5wjXzTfHWtXZCi9sNaym2okFAQMClrRDdgIBG3L7wpYv2qYIC3BkUFylBum\n IVvvg7vplwSl3ofT3ZXNiXzAhxtgtvVV3enucH1BzWcVXjF3Oizy9UXSfe8MMgbchXwf\n F7jCgbsTAIdIIvySyPCZ56XoqESQ9Cx+/1p8v3qvl+YqUaBT+a1LKIfwrFJlS4kfmjWe\n iQH1uY8nMNesWi0NFaOEjC1/99gJ5Ia3FB3GRlwed5ifC9dLsnSFj6C8HCxKDm7o2uSS\n 0xeHIg7MUkjZKD2WMCE69/83zKwhsXq3qnVb2c4IZnQj/gGbEUvu9v32/VtVvLRqupAv\n X4Eg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777533225; c=relaxed/simple;\n bh=SYBF+VEqc6FAn9VwTZORPwIDYfoVImfk5LYSVk1Nrno=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=fZ+2wxSMgNYUUoVVolF/GAsZ7vYj6pqxGs4KsgEOWAFxbTrr6M7VEUw+T4S8cZhJcdKAMbGx1Qa5nnugZJr0jvDWz3m2H0RsJPuXarfbD6zOYI3XoW9TJaOR1UDDuvBIbmtK6dxze89QBYAYaLCjY6KuJ0CtDEumB92sDRKHbEY=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=tHPah7chGqVeG7B0EplvvG1CvPfI85nLW0JSfLYf+gA=;\n fh=+uEDwx55CzEWtNA/tzpV1shOHaMh+Xh7AN17D33930Y=;\n b=cyF1D3+mV1dv1tBl3IZ3jvh8S+VDHhlDgK1VZ+AHS4gKKvKVWw/fTOX/khDnYrW5Hy\n QDan99fV4PjJv85D0Ty8Kr+RpN89wvkrJdIzqdFni4iFrJBOcaWNdUMzOpuw/LiH4t5r\n P15LYRdChEO+LcQAzh7yNR64BJWgieuqjdw0wdI2XdHhZ9NCyROa4zcC4aSJU2qHp2Ge\n TVETRwpNLQFQInT6RApqSxZkBSObqpCv6nXGbzjvPh0HAItsZPCvL3T13qyf2GUln2Tv\n 2Bwp1Ajh7RnjA+2QLmdKDmoeX7BvSye0LQTv+UsqDpl4okTF6ITGJ14wUzT5PFXhWDH1\n n/Gg==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777533224; x=1778138024; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tHPah7chGqVeG7B0EplvvG1CvPfI85nLW0JSfLYf+gA=;\n b=HcW5qUcK5xxSetanpLCqb5F+3uqehnqNy44C3XBKwFjuAfo0zRzFixgnG+b8gm8Gm2\n bOhdIszPuG4Swgaj44QXWFTms+NFl+x8AdnF8G4YQryWE3+UObRuitUQN1RtKBXlzFcE\n a4xjC2SsBkd4vT9ETbyr98aY9DzAR+c+Lou9FPgBqB9HAoDyDl8xukzS9NuvQZ0CuBUd\n FFGjs0b30nJ7X5GWl65gyV4zXvws7XLDjHMV6DSgChQw/Wl+WNPJ1OuB53EueUHqGURo\n /MYjrdsz05TgnVWptjQOfTfNCUq/9BoEFBBQqde8asaZ75MODIXlTNBjWsKeQwT5Smpq\n 9GBg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777533224; x=1778138024;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=tHPah7chGqVeG7B0EplvvG1CvPfI85nLW0JSfLYf+gA=;\n b=cul+Me9eFsjDYx8YmQmuyhLzUBMMn8q7f7WrBgSCMHUlDASRVoltejdnfnmBS8mxfn\n wBUbPzD0UiK/KTxZAv2tKqO5JgHJgwOar9mTF4+ruveJmgS+yLCDqvba786QKpB950rc\n NsaZidBQLdB7zky6TPwAxuryVF5GNuQIgmq2xATz5rdmCktIWFO1yLNtjAypQ7SxY1KA\n Lxkl8KIm3HTrk56scFmtWXJRCyeFzTushabknzyHZ+GZKI4KzwBv6cnw7Cs36jNpZvrM\n nX3aVbJbP2yigc55C6Y5WtyeD78YVaMUI9eItc/UzRHvoAiIbH2C3u2Evj5EYuCStLvX\n Zyyw==","X-Gm-Message-State":"AOJu0Yy4xgNaNTvdm8eveiO2mNDbbPreW1V0UtL4eC4Y3z68unT0tBBo\n ZUa+KODVXCIcJUnMRrcXO/LP7ZBz4aPXrz+BbvzdYE/GBkhmGmxn1OB1K5vOM5eWejYwvuvy8EF\n p9UHsQtBNjvgpTZ090Q3Y69+iBDm3lzbzvQ==","X-Gm-Gg":"AeBDieszaBt6YpD3afSjEDnvrmWgWSUPypYDBwWP7x4aHv9Z4FMfOp+M9R/bULCQkG1\n jWaCF/gC62fJjt/XojdYVnpoLD2XfbckPT4pcyEwedEj6y81iL2i1bRg4fMX2I0MeC2yftai2Gd\n jI7hjJ76xke5H6/ceUVzGULnsterx+9Mtkd8TJ5rKFrkjNo9xwxURtQ9Ng1dAsBMDhjxCVNJ2Cq\n n1TLOmvWyneh8gL+ex0PYeorakISKJUe0hFauivO33N7cL2w7AMmPSKzGb/abwgoBJD9sxyWsXE\n 1D6myJSB0HtwFVw47KLTKL09mi4=","X-Received":"by 2002:a17:907:26cc:b0:ba6:2c73:47dd with SMTP id\n a640c23a62f3a-bbac46d9b4dmr93971966b.5.1777533223948; Thu, 30 Apr 2026\n 00:13:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20260430041056.2722022-1-andrew.pinski@oss.qualcomm.com>","In-Reply-To":"<20260430041056.2722022-1-andrew.pinski@oss.qualcomm.com>","From":"Richard Biener ","Date":"Thu, 30 Apr 2026 09:13:28 +0200","X-Gm-Features":"AVHnY4IAe65qURlqKL8wMdgrfWbz4LR0DFGXVZISDBTl7D1m7WFDLyiGL7KWxK0","Message-ID":"\n ","Subject":"Re: [PATCH] match: Simplify patterns for `a != b` implies a or b is\n non-zero","To":"Andrew Pinski ","Cc":"gcc-patches@gcc.gnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]