[{"id":3684469,"web_url":"http://patchwork.ozlabs.org/comment/3684469/","msgid":"<20260430063500.4035-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-30T06:35:00","subject":"Re: [LTP] shmctl03: Fix 32-bit compat mode failure by adjusting\n comparisons for compat mode truncation","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Wei,\n\nOn Thu, 30 Apr 2026, Wei Gao wrote:\n> shmctl03: Fix 32-bit compat mode failure by adjusting comparisons for\n> compat mode truncation\n\n> +#define TST_ASSERT_SATURATED_INT 0x01\n[...]\n> +\tif (flags & TST_ASSERT_SATURATED_INT) {\n> +\t\tif (sys_val_64 > (unsigned long long)INT_MAX)\n> +\t\t\texpected_val = (unsigned long)INT_MAX;\n\nFor shmmax in compat mode, can you confirm the saturation is to INT_MAX\n(2^31-1) rather than UINT_MAX (2^32-1)? The compat_shminfo64.shmmax\nfield is __compat_ulong_t (unsigned 32-bit), so truncation to UINT_MAX\nwould be the natural expectation. A reference to the relevant kernel\ncompat code path in ipc/shm.c would help clarify.\n\nPre-existing issues noticed in the surrounding code (not introduced\nby this patch):\n\n- testcases/kernel/syscalls/ipc/shmctl/shmctl03.c:13 — #include\n \"tse_newipc.h\" appears unused; no symbols from it are referenced.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/25150858881\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=leTaybie;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5kv46G9Vz1yGq\n\tfor ; Thu, 30 Apr 2026 16:35:28 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 813C33E2505\n\tfor ; Thu, 30 Apr 2026 08:35:25 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 7DEB73E255B\n for ; Thu, 30 Apr 2026 08:35:03 +0200 (CEST)","from mail-qk1-x743.google.com (mail-qk1-x743.google.com\n [IPv6:2607:f8b0:4864:20::743])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id D98A96008C0\n for ; Thu, 30 Apr 2026 08:35:02 +0200 (CEST)","by mail-qk1-x743.google.com with SMTP id\n af79cd13be357-8eab809593cso58140885a.3\n for ; Wed, 29 Apr 2026 23:35:02 -0700 (PDT)","from\n runnervmeorf1.25nck5mkgfoenofczkdl0zm0ze.cx.internal.cloudapp.net\n ([20.55.223.181]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b3ff335ccdsm10555386d6.20.2026.04.29.23.35.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 23:35:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777530902; x=1778135702; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/CouMg6Rwh8LRPN0uu7sBlus20fuovY5UkE6tBvmXJc=;\n b=leTaybieA9swltWyrUjd0iIb4XVnkvj0j/JXNgvEAjl1buR95YPbVotKC0MYeG/fCE\n rj2H+vi65973IMAUTxNjvLUuytZy8xYtHOSkTgrBMLtPhRE1vlQSvZjMlInGCioDOPRh\n wuT9sCMY9a9Qr+Sw9tV2Klr8EctYjL183mIrBRBoohQ0oelpo5Vb/qZQQv0246MktZDk\n JItIx0seswEBateVu3NTfdJrEM0cTxINeKl0iN74voDXmmmaAvVPZP515ykNctK1q1h+\n J4a6AbXUBoMfiPmFVD/ZSoOvsN1MedFe0ro6S9QiJj0hlCJxmpuFrcjrzqBaU0EIwdAo\n 4+Zg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777530902; x=1778135702;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=/CouMg6Rwh8LRPN0uu7sBlus20fuovY5UkE6tBvmXJc=;\n b=kya9vHedQMjY4kPBubp2bGy87a2LgOePM1bV9HqCqnxvXGL7DEUIrIN/7gVyTSSsRS\n VyqDSeqf0qYrZ5G/4A+Dm2SPpJewQ7jug20dX/MMCBGOihdV+Ifa96bLSvTrlUICUvL3\n /vtLZcHU3YCoYq9+NSkDSzGoe/GT7RlSDjqwVe7DcxEqizFMvXvYzcIxUfqVJtz72mtf\n qcZQJ3LvedJBy+tu7sBTcAwXuRL6OerPFHWUdE9PS1ZZZNIeGkmculITuBI5z4QUA1KJ\n mPJVXkefM4H8GrBDsIqQowMWBne0lVKGUU7EUanm7Ljs259FZ0QOHIJxxR8kWzctcb1E\n HdCQ==","X-Gm-Message-State":"AOJu0YxPyQ3omWxRygbx5nrWxv325jDUVnXhVivTPSbp3qCkpMEIO6oA\n B2Bl3DPBo7FTHv4zcmjeM1tu0F92GlGMSup2seHYcX+ZnFuU8nryVdRT","X-Gm-Gg":"AeBDieu2nIytG7n9oryiPQ8hKJT4gmljcYi6sH25Mzt1MZg9o3krPzxDkxLdhTlXp3J\n niH+3ky9sPLL3YyIgrUpnM60bBEbgQTQ3KDLlC30K4/PblrHBm+u4s1NTbY9LsneSE2YHO4cbfk\n h3ZIbBziyX5xDpMR9jZk0ylte0nU6r2aPdzeIHySWmeza8Faekmv9ZfNNFyMkbHdhbaMQoJ0+3F\n BPsgPXbbI3/pPAZPKnUKP8rbXoukZqW5rZNy4eYFdWkTpGbqC3IxaYwlvLkG8rkkpXisNmAZ3or\n /XdHtnLSH4iM4qzfZNmYkXtx0nAUoAwzhJJEC7wwfbqvHDlXCWCKzhhkALE7W3KNvgsuV37NkWR\n Ty0x8s3uHZKLf3dzSk4bRS7GuSGy2gHhewRkG3fyVCG6GII6yqbWHWyHVngEcq7wY5vL3NN18eU\n Y5ozW1CVQoWBlumMvEICQZ2SWuiY0HZ70quPp3pEVYQho3B1Byi6vkEyXl4jgNhQOCJFe45BrgU\n Sn1y7rYC+rLhWWdR6zjDUNpJ168iCwN6JeGqvTn7nFaWQzWIw==","X-Received":"by 2002:a05:620a:280c:b0:8cf:d62a:c81d with SMTP id\n af79cd13be357-8fa88942bb7mr267249185a.29.1777530901456;\n Wed, 29 Apr 2026 23:35:01 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Wei Gao ","Date":"Thu, 30 Apr 2026 06:35:00 +0000","Message-ID":"<20260430063500.4035-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430034724.1628-1-wegao@suse.com>","References":"<20260430034724.1628-1-wegao@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM,SPF_HELO_NONE,\n SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] shmctl03: Fix 32-bit compat mode failure by adjusting\n comparisons for compat mode truncation","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]