[{"id":3684286,"web_url":"http://patchwork.ozlabs.org/comment/3684286/","msgid":"<177749881568.809163.3651828558097466353.b4-review@b4>","list_archive_url":null,"date":"2026-04-29T21:40:15","subject":"Re: [PATCH 1/9] qom: add trace events for object/property\n lifecycle","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"On Wed, 29 Apr 2026 22:08:22 +0100, Daniel P. Berrangé wrote:\n> diff --git a/qom/object.c b/qom/object.c\n> index f981e270440..b99da7309db 100644\n> --- a/qom/object.c\n> +++ b/qom/object.c\n> @@ -714,6 +720,7 @@ static Object *object_new_with_type(Type type)\n> object_initialize_with_type(obj, size, type);\n> obj->free = obj_free;\n> \n> + trace_object_new(obj, obj ? obj->class->type->name : \"(null)\");\n\nIt looks like there should be an assert(obj != NULL) after qemu_memalign() instead.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=W2uYxtSI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5W2d2Mjtz1yJr\n\tfor ; Thu, 30 Apr 2026 07:41:11 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wICe3-0007a6-MI; Wed, 29 Apr 2026 17:40:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wICe0-0007Zt-TW\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:40:33 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wICdy-0001bF-5G\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 17:40:32 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-Pm_jtTCDP76SPm-yhUAdew-1; Wed,\n 29 Apr 2026 17:40:27 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B2E6E195608E\n for ; Wed, 29 Apr 2026 21:40:26 +0000 (UTC)","from localhost (unknown [10.44.22.2])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 67CFC1800480; Wed, 29 Apr 2026 21:40:24 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777498828;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=qos86uBtUBviycmBtdvJkWQMQqMeRaX/QKHrhUIoWE4=;\n b=W2uYxtSIb6Mtu3UDr6kc0JnP+MfU86SjKvW1eet8V6FsCgpzO0pr+0HjdplPL22Uw9XNim\n SRTzKIXhNAqDf+UR0L8qi/EDs+vZAl0yRzrcF0upgm4rF0S2+Nq3DCkpeI68uoXwYrNnTk\n i27CjJ/kVGJ5nx+Q/KHAilyosPg0vDE=","X-MC-Unique":"Pm_jtTCDP76SPm-yhUAdew-1","X-Mimecast-MFC-AGG-ID":"Pm_jtTCDP76SPm-yhUAdew_1777498826","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Subject":"Re: [PATCH 1/9] qom: add trace events for object/property\n lifecycle","From":"marcandre.lureau@redhat.com","To":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","Cc":"qemu-devel@nongnu.org, Paolo Bonzini ","In-Reply-To":"<20260429210830.594724-2-berrange@redhat.com>","References":"<20260429210830.594724-1-berrange@redhat.com>\n <20260429210830.594724-2-berrange@redhat.com>","Date":"Thu, 30 Apr 2026 01:40:15 +0400","Message-Id":"<177749881568.809163.3651828558097466353.b4-review@b4>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=590;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=cBADsH6MCZqZ1SxcXD5jjpKnUkAIhdw6Xg2JUYnQiIY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8nrECFq7HQTixjLh/rDiGGPn9DCiHF2U+/+vf\n wBtgWCq1r6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafJ6xAAKCRDa6OEJdZac\n 5Uj/D/9gSxI9+yUe69DIeA0218YPndXROP3XrnALsdoYJTCokBZP/N2W3KsXdB5+TAkSZ5Sok1L\n l/xWSEYf96W90JTujHksJrHbKuhOvcWupUwLnEqz3aRcSzLDPgYouiUpvWuxlk5iu3hQvGecXti\n 6/5af3/lUUS5sJfl80C2uHA2JKgN6Oc6FU2cE8Fw36bcGQpIUd/5CgY6FXVT/0S0p+rPBWbE9N6\n mRWSNxLqHsG55UFKM++25jIyHDAyr0XreroabPr1m4yndiuSs9LF3pEG53f1cuo/11zUNPlmA2Y\n 9Yhw/Owsm9vGskMPAgllLXoehMnthUHeRmuzqDCmyRAoLl/f9z2DPa2X9PIA3xu7JJtt/YB/IzY\n ZLK+6T4Pgfsuv2ulGUA3qb1h1pkniSekzqmgkFrb8mXypEyJt7Hnmm8Gy2dHzyxkEF1P6WKVXD6\n N9SfKZHZjEY6+YfBs10jmPzXcOWa59zf68afvhwfC/6HVbmYLUypshgvngtLGMWL2iiD2QBmQbi\n hE+CfDEYz5nOY6v+h3ygMU82rHU03KF0uNylbn/32BBEVB9arDuo7Y3tDD6Df2NAD7+k/00of7N\n 4nhBKv+VfTkPr7BbIQZ7yz3RWQpCFPHJvTG7JEwkOfSnJZTD81KOoLJ0wLMI0Q1vb8qCzIqfra0\n xD920/931CxyqTg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3684508,"web_url":"http://patchwork.ozlabs.org/comment/3684508/","msgid":"","list_archive_url":null,"date":"2026-04-30T07:56:59","subject":"Re: [PATCH 1/9] qom: add trace events for object/property lifecycle","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Thu, Apr 30, 2026 at 01:40:15AM +0400, marcandre.lureau@redhat.com wrote:\n> On Wed, 29 Apr 2026 22:08:22 +0100, Daniel P. Berrangé wrote:\n> > diff --git a/qom/object.c b/qom/object.c\n> > index f981e270440..b99da7309db 100644\n> > --- a/qom/object.c\n> > +++ b/qom/object.c\n> > @@ -714,6 +720,7 @@ static Object *object_new_with_type(Type type)\n> > object_initialize_with_type(obj, size, type);\n> > obj->free = obj_free;\n> > \n> > + trace_object_new(obj, obj ? obj->class->type->name : \"(null)\");\n> \n> It looks like there should be an assert(obj != NULL) after qemu_memalign() instead.\n\nqemu_memalign aborts on OOM. This \"obj ? .. : ..\" check was a mistake,\ncopy+pasted from the dynamic cast trace events.\n\nWith regards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cgbegOc/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5mjy291Xz1xqf\n\tfor ; Thu, 30 Apr 2026 17:57:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIMH7-0001bj-Sf; Thu, 30 Apr 2026 03:57:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIMGj-0001Xg-V4\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 03:57:12 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIMGi-0000bW-D2\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 03:57:09 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-Uoqh6XwYMLqDFwT4Q7l_xg-1; Thu,\n 30 Apr 2026 03:57:05 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id ABB8218001FB\n for ; Thu, 30 Apr 2026 07:57:04 +0000 (UTC)","from redhat.com (unknown [10.44.48.62])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 2C7B9300019F; Thu, 30 Apr 2026 07:57:02 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777535827;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=SMUHqV3/S1OCEN/Z1Bk3oZqV9TG8An88Wv5LTmQ2pgg=;\n b=cgbegOc/gRkXYvsgw38nmulyJi4SEc6FTU0Wxv1oQK1I0773R7fc5wM0dGhpIzmLNwJvi+\n VMJwMbcnA9QFtC+EelTFQnj2KCYvTXhYdlNx/xww14m3mQ08Lg6Gfb/wiiGymLilpPVrip\n XIaoO4c25vf7E/qacTn+rVrqQFlUMS0=","X-MC-Unique":"Uoqh6XwYMLqDFwT4Q7l_xg-1","X-Mimecast-MFC-AGG-ID":"Uoqh6XwYMLqDFwT4Q7l_xg_1777535824","Date":"Thu, 30 Apr 2026 08:56:59 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"marcandre.lureau@redhat.com","Cc":"qemu-devel@nongnu.org, Paolo Bonzini ","Subject":"Re: [PATCH 1/9] qom: add trace events for object/property lifecycle","Message-ID":"","References":"<20260429210830.594724-1-berrange@redhat.com>\n <20260429210830.594724-2-berrange@redhat.com>\n <177749881568.809163.3651828558097466353.b4-review@b4>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<177749881568.809163.3651828558097466353.b4-review@b4>","User-Agent":"Mutt/2.3.1 (2026-03-20)","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]