[{"id":3684310,"web_url":"http://patchwork.ozlabs.org/comment/3684310/","msgid":"","list_archive_url":null,"date":"2026-04-29T22:49:55","subject":"Re: [PATCH v3 12/26] ui: move FONT_WIDTH/HEIGHT to vgafont.h","submitter":{"id":16148,"url":"http://patchwork.ozlabs.org/api/people/16148/","name":"BALATON Zoltan","email":"balaton@eik.bme.hu"},"content":"On Thu, 30 Apr 2026, Marc-André Lureau wrote:\n> Since those values are related to the VGA font, it make sense to move\n> them here.\n>\n> Reviewed-by: Daniel P. Berrangé \n> Reviewed-by: Philippe Mathieu-Daudé \n> Signed-off-by: Marc-André Lureau \n> ---\n> ui/console-vc.c | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/ui/console-vc.c b/ui/console-vc.c\n> index b9da9ddf30d..457d071c774 100644\n> --- a/ui/console-vc.c\n> +++ b/ui/console-vc.c\n> @@ -13,6 +13,7 @@\n> #include \"ui/console.h\"\n> #include \"ui/vgafont.h\"\n> #include \"ui/cp437.h\"\n> +#include \"ui/vgafont.h\"\n>\n> #include \"pixman.h\"\n> #include \"trace.h\"\n\nPatch does not seem to contain what the commit message says. Maybe a \nrebase error?\n\nRegards,\nBALATON Zoltan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5XZZ2Kg2z1yHZ\n\tfor ; Thu, 30 Apr 2026 08:50:28 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDjJ-0005ZD-4o; Wed, 29 Apr 2026 18:50:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDjG-0005Z5-Rp\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:50:02 -0400","from zero.eik.bme.hu ([152.66.115.2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDjF-00053q-7W\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 18:50:02 -0400","from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id 4AD93596964;\n Thu, 30 Apr 2026 00:49:57 +0200 (CEST)","from zero.eik.bme.hu ([127.0.0.1])\n by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP\n id n6cH1Aeujrvh; Thu, 30 Apr 2026 00:49:55 +0200 (CEST)","by zero.eik.bme.hu (Postfix, from userid 432)\n id 442F4596963; Thu, 30 Apr 2026 00:49:55 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n by zero.eik.bme.hu (Postfix) with ESMTP id 429B7596962;\n Thu, 30 Apr 2026 00:49:55 +0200 (CEST)"],"X-Virus-Scanned":"amavis at eik.bme.hu","Date":"Thu, 30 Apr 2026 00:49:55 +0200 (CEST)","From":"BALATON Zoltan ","To":"=?iso-8859-15?q?Marc-Andr=E9_Lureau?= ","cc":"qemu-devel@nongnu.org,\n =?iso-8859-15?q?Daniel_P=2E_Berrang=E9?= ,\n\t=?iso-8859-15?q?Philippe_Mathieu-Daud=E9?= ","Subject":"Re: [PATCH v3 12/26] ui: move FONT_WIDTH/HEIGHT to vgafont.h","In-Reply-To":"<20260430-qemu-vnc-v3-12-be96757428d0@redhat.com>","Message-ID":"","References":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>\n <20260430-qemu-vnc-v3-12-be96757428d0@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed;\n BOUNDARY=\"3866299591-891041428-1777502974=:45390\"","Content-ID":"<5b2731d2-e604-6fa6-2463-d50e7c8de3e5@eik.bme.hu>","Received-SPF":"pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu;\n helo=zero.eik.bme.hu","X-Spam_score_int":"-18","X-Spam_score":"-1.9","X-Spam_bar":"-","X-Spam_report":"(-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3684519,"web_url":"http://patchwork.ozlabs.org/comment/3684519/","msgid":"","list_archive_url":null,"date":"2026-04-30T08:06:23","subject":"Re: [PATCH v3 12/26] ui: move FONT_WIDTH/HEIGHT to vgafont.h","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"Hi\n\nOn Thu, Apr 30, 2026 at 2:50 AM BALATON Zoltan wrote:\n>\n> On Thu, 30 Apr 2026, Marc-André Lureau wrote:\n> > Since those values are related to the VGA font, it make sense to move\n> > them here.\n> >\n> > Reviewed-by: Daniel P. Berrangé \n> > Reviewed-by: Philippe Mathieu-Daudé \n> > Signed-off-by: Marc-André Lureau \n> > ---\n> > ui/console-vc.c | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/ui/console-vc.c b/ui/console-vc.c\n> > index b9da9ddf30d..457d071c774 100644\n> > --- a/ui/console-vc.c\n> > +++ b/ui/console-vc.c\n> > @@ -13,6 +13,7 @@\n> > #include \"ui/console.h\"\n> > #include \"ui/vgafont.h\"\n> > #include \"ui/cp437.h\"\n> > +#include \"ui/vgafont.h\"\n> >\n> > #include \"pixman.h\"\n> > #include \"trace.h\"\n>\n> Patch does not seem to contain what the commit message says. Maybe a\n> rebase error?\n\nIndeed, this patch is already applied. Thanks for the catch.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=AvXdKRij;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=hMs7XXb/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5mx62zWlz1yGq\n\tfor ; Thu, 30 Apr 2026 18:07:22 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIMQG-0003nO-MW; Thu, 30 Apr 2026 04:07:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIMQ0-0003mo-4H\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 04:06:50 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIMPy-00032e-PO\n for qemu-devel@nongnu.org; Thu, 30 Apr 2026 04:06:43 -0400","from mail-pj1-f72.google.com (mail-pj1-f72.google.com\n [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-246-3Ql5KDZROEqE8Tzs5iCZoA-1; Thu, 30 Apr 2026 04:06:40 -0400","by mail-pj1-f72.google.com with SMTP id\n 98e67ed59e1d1-35641c14663so773169a91.2\n for ; Thu, 30 Apr 2026 01:06:40 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777536401;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=snZVnQoDZaVtQ1ET7rt6b7cDSDqe56B5uwNcf/nqDLM=;\n b=AvXdKRijlEgjWiOiCqKLYW6ONJW3QziSzYr733e+2OaHtkKSBpG1SLne9hAh8Hed+KbyyA\n URJzyFk9xXweOTNzhstcSgOeXNoBB+erW8+evLAZWxhTX7EK8bGFxtK/wR1LER1b6o1Gq9\n IBO6cEpwAOQnWYZ4S+1SYqP08+K/+rI=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777536399; x=1778141199; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=snZVnQoDZaVtQ1ET7rt6b7cDSDqe56B5uwNcf/nqDLM=;\n b=hMs7XXb/lNWyB51hVKFCTfn43WOFCFapovaCHfVRly/sR6yNAF/XEUXXjX65TEWfn8\n 10CjHm0GB0+wLR8JdZrnSucyGqdHfv8/WrazQU0R50DcTTm8acKNDA3RltdBnxcN57Cc\n YOHSyDhbDiM1rpXk5d+zU5T2Sv1uC38q+rF9W+2ol3E7sxp1k2f9kUV0v0U2QnDWECmX\n dxzSpW/Qekom6Lwa81sKbHpZsmkKVzg0iCedVOoou0CbTjGTMH8ITAZMWiuk24C8uUP1\n AejTVIiKkVR9y13qkb4uacHTfqdQU8fv55hd/WIZiG2LithgoXF3jLcjcfr7rT/rp1DL\n mkhg=="],"X-MC-Unique":"3Ql5KDZROEqE8Tzs5iCZoA-1","X-Mimecast-MFC-AGG-ID":"3Ql5KDZROEqE8Tzs5iCZoA_1777536399","ARC-Seal":"i=1; a=rsa-sha256; t=1777536399; cv=none;\n d=google.com; s=arc-20240605;\n b=Kjq1mGFH8kpJ+aEUZI8qU29TtUbrPEM8ppTCRP7ovA7GRDoFoHojCTpN88T8wj/r9k\n FJ3hmjYK6Rsx3dsG1axBZtEEfyqGNDRoep99Z5MwaMJlGk0BIPNBMqFjKAj940S2JYaW\n dQjd6u/rOFqG8vkd3NqdW1Ek5QjPODCbkldRQuoCM74Rli4aYiVlfp959rFMAIAmByN3\n ccn53Wa558qRnXVPumgBZc/YTAyOzeUA16E1bfvmt7WRoi3THO5W00fvEWrvHaL7EGdL\n Bmztg4WzOcrjO2SVnYkfYd1s18+AukJGMz04Xp78q7svfV5p6P4MeVkFfzC7OK5RcRae\n DH/w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=snZVnQoDZaVtQ1ET7rt6b7cDSDqe56B5uwNcf/nqDLM=;\n fh=l8EYjGkga9Y1bnur8fRa+nADtAuK2B2YM1OMwSOmkhk=;\n b=aniUyVcIW/xh/oAgtcURnk7UMbffds81/icLZYK9nHdGLSEQoK7YJtlsCWPDxG98gg\n P3QFo5hsElGa4oWxNKyO4EVlejOoiXrb+q2ifRDUoRveIwVk95yR+GeWm7iqF4pDvifI\n mel2hDEbdZK3B1oqMUWzcNPE23wlzsDCa7+VJQ1v8rT9qnKDEo5C8TxQI3vInkwwaNaB\n 2qoSj8P8s+s1Brm2rGjsxZMn+62j3Re0v+OCVG2NtyVVMUkXm4dXX4tRb0nuSRi8uVos\n RLbBg+cKQl9gv0p6IQ0UNN6Ejrmx6n8iDFU4Vyfwjltk/W+d02czBtZiug9IT5ANFgj6\n 6I5g==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777536399; x=1778141199;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=snZVnQoDZaVtQ1ET7rt6b7cDSDqe56B5uwNcf/nqDLM=;\n b=BwIeiJvm3ZrAgpZaORQS3y3oV4BsyBytACrGzFHqDvLLC6pPrW+Eho61AOqz22cqqQ\n dd0sJN8Rx/Yg25ZmYL6y4OoYGaS6eCTUmmmJr6Y7PMwqwnnZUgDyCUFMD/hKRFOI6voE\n pgXnzi/uawC5Vuii2fYivYh/kmi4wapDurFng/qFsRL9yVDrJLzAMbbd3BB0ueJs1Cns\n 6Vh3izuKU7myZ4vY7V/ekawkWM2fH+xIFGLuSez0FiBtzlc1ikURs5l3KkRAWdtWvAav\n 8uDw7zPn6c4/Mm+Q+xKvZWqNqcdMMCT+h3GZL7OX/Gjkh4bO9ofMcYuytwkvB0cvtq02\n hurA==","X-Gm-Message-State":"AOJu0YzNESY3WY8NLXXgwNN6AbRiM2LIFnlGf+xCxDGWVKtVXLIf1IxA\n /rupgmUPKpQf83At0xALYsL6f9Fs29AMW9IYXwutnpUZyfOa/PBpzBrx5be6qc1lVzHoBJWGJqX\n RoWjaiOBDk4Zfm+MPJmoNfL47emMY543rqPsgdR8Ebbq4B7WQbKZHhm3V8A0+OZy9f06R5r3wSq\n iL6JkCMwT8wNUnYenkzAkgMlGPWVD1dPoPzgKsBIawYA==","X-Gm-Gg":"AeBDievEJ/rcR1AGIdn/pEWlYW8mM5qZQWsS6skQxtNjMqxvEqQQudYUNLdg0BQDfO8\n 00h2QlvOruCRKyvltf4qblb4hZKn7+5untS7EGuC0OVCnn1PcVopBIyVYSeCIZBj5UsR08NeF1Y\n aB8gaLQRLaBs7HJY9e+7D/O5I+rAXveN5bExlncnWxibRRnd+fkosIlqXOAmubIwr8TPWFy2ire\n I8jwwN6BnAEmZ0zPPnO0/1fm8r7HK1vs3JGMN3JLZMDU/Y84kZPbFXFGfBJsakbHRsFaRSfO+bH\n n4YKMn01aiN0Z8dEkXZcUNOUF9MNehT5y94=","X-Received":["by 2002:a05:6a21:3086:b0:398:8d38:c60c with SMTP id\n adf61e73a8af0-3a3cf7f1e01mr2139367637.55.1777536398985;\n Thu, 30 Apr 2026 01:06:38 -0700 (PDT)","by 2002:a05:6a21:3086:b0:398:8d38:c60c with SMTP id\n adf61e73a8af0-3a3cf7f1e01mr2139177637.55.1777536395831; Thu, 30 Apr 2026\n 01:06:35 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260430-qemu-vnc-v3-0-be96757428d0@redhat.com>\n <20260430-qemu-vnc-v3-12-be96757428d0@redhat.com>\n ","In-Reply-To":"","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 30 Apr 2026 12:06:23 +0400","X-Gm-Features":"AVHnY4JHwvZJrFzfBH9EKBnm03Ho_JS0D-5jFlH_-DNwqcxF9lYE0EZwzKOpdc4","Message-ID":"\n ","Subject":"Re: [PATCH v3 12/26] ui: move FONT_WIDTH/HEIGHT to vgafont.h","To":"BALATON Zoltan ","Cc":"qemu-devel@nongnu.org,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=mlureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]