[{"id":3684533,"web_url":"http://patchwork.ozlabs.org/comment/3684533/","msgid":"","list_archive_url":null,"date":"2026-04-30T08:36:11","subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] libie: log more info when\n virtchnl fails","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Aleksandr Loktionov","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan On Behalf\n> Of Li Li via Intel-wired-lan\n> Sent: Wednesday, April 29, 2026 10:41 PM\n> To: Nguyen, Anthony L ; Kitszel,\n> Przemyslaw ; David S. Miller\n> ; Jakub Kicinski ; Eric Dumazet\n> ; intel-wired-lan@lists.osuosl.org\n> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David\n> Decotigny ; Singhai, Anjali\n> ; Samudrala, Sridhar\n> ; Brian Vazquez ; Li\n> Li ; Tantilov, Emil S \n> Subject: [Intel-wired-lan] [PATCH iwl-next v3] libie: log more info\n> when virtchnl fails\n> \n> Virtchnl failures can be hard to debug without logs. Logging the\n> details of virtchnl transactions can be useful for debugging virtchnl-\n> related issues.\n> \n> Tested: Built & booted on a test machine and synthetically produced a\n> virtual failure to produce the following log:\n> \n> idpf 0000:01:00.0: Non-zero virtchnl ret val (msg op: 1, ret val: 6,\n> data_len: 8); xn id: 0, cookie: 0\n> idpf 0000:01:00.0: Transaction failed (op 1, xn state:\n> 3, id: 0, cookie: 0, size: 8)\n> \n> Signed-off-by: Li Li \n> ---\n> v3:\n> - Use dev_err_ratelimited in both logs.\n> - Move log placement to after virtchnl field validation.\n> - Remove redundant op/cookie fields since they were validated.\n> v2:\n> - Use dev_warn_ratelimited instead of dev_notice_ratelimited based on\n> reviewer feedback.\n> \n> drivers/net/ethernet/intel/libie/controlq.c | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> \n> diff --git a/drivers/net/ethernet/intel/libie/controlq.c\n> b/drivers/net/ethernet/intel/libie/controlq.c\n> index ebc05355e39d..ceca8a076d79 100644\n> --- a/drivers/net/ethernet/intel/libie/controlq.c\n> +++ b/drivers/net/ethernet/intel/libie/controlq.c\n> @@ -766,6 +766,14 @@ libie_ctlq_xn_process_recv(struct\n> libie_ctlq_xn_recv_params *params,\n> \t msg_cookie != xn->cookie)\n> \t\treturn false;\n> \n> +\tif (ctlq_msg->chnl_retval) {\n> +\t\tdev_err_ratelimited(\n> +\t\t\tparams->ctlq->dev,\n> +\t\t\t\"Non-zero virtchnl ret val (msg op: %u, ret val:\n> %u, data_len: %u); xn id: %u, cookie: %u\\n\",\n> +\t\t\tctlq_msg->chnl_opcode, ctlq_msg->chnl_retval,\n> +\t\t\tctlq_msg->data_len, xn->index, xn->cookie);\n'virtchnl ret val' 'ret val:' looks like a duplication in dmesg.\n\n\n> +\t}\n> +\n> \tspin_lock(&xn->xn_lock);\n> \tif (xn->state != LIBIE_CTLQ_XN_ASYNC &&\n> \t xn->state != LIBIE_CTLQ_XN_WAITING) { @@ -1011,6 +1019,11\n> @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params)\n> \t\tparams->recv_mem = xn->recv_mem;\n> \t\tbreak;\n> \tdefault:\n> +\t\tdev_err_ratelimited(\n> +\t\t\tparams->ctlq->dev,\n> +\t\t\t\"Transaction failed (op %u, xn state: %d, id: %u,\n> cookie: %u, size: %zu)\\n\",\n> +\t\t\tparams->chnl_opcode, xn->state, xn->index, xn-\n> >cookie,\n> +\t\t\txn->recv_mem.iov_len);\nProbably %u fits better for enums than %d, what do you think?\n\n> \t\tret = -EBADMSG;\n> \t\tbreak;\n> \t}\n> --\n> 2.54.0.545.g6539524ca2-goog","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=LHY+KQ9g;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5nZg5Sknz1yGq\n\tfor ; Thu, 30 Apr 2026 18:36:27 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 2594D61BCF;\n\tThu, 30 Apr 2026 08:36:26 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id o4gNxyRsk49c; Thu, 30 Apr 2026 08:36:24 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 13E4461B70;\n\tThu, 30 Apr 2026 08:36:24 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 0BAE918F\n for ; Thu, 30 Apr 2026 08:36:23 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id F12CF84522\n for ; Thu, 30 Apr 2026 08:36:22 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id CeHlAieRc3Od for ;\n Thu, 30 Apr 2026 08:36:22 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.14])\n by smtp1.osuosl.org (Postfix) with ESMTPS id E296884596\n for ; Thu, 30 Apr 2026 08:36:21 +0000 (UTC)","from orviesa002.jf.intel.com ([10.64.159.142])\n by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2026 01:36:15 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2026 01:36:16 -0700","from ORSMSX901.amr.corp.intel.com (10.22.229.23) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 30 Apr 2026 01:36:14 -0700","from ORSEDG901.ED.cps.intel.com (10.7.248.11) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Thu, 30 Apr 2026 01:36:14 -0700","from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.29) by\n edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 30 Apr 2026 01:36:14 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by CH3PR11MB8138.namprd11.prod.outlook.com (2603:10b6:610:158::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.20; Thu, 30 Apr\n 2026 08:36:12 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9870.020; Thu, 30 Apr 2026\n 08:36:11 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 13E4461B70","OpenDKIM Filter v2.11.0 smtp1.osuosl.org E296884596"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777538184;\n\tbh=5oiOLxNRgOTIGgoyvkcEMZYbiI+2Y1hdivQepJsFLgw=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=LHY+KQ9gIZNIWokIAyALK9IXXPVjCujR3xncSyAicNxKgBs73HKXTQflXCNtw9ezl\n\t eFm3s5hzPenxcWU5eY7mQd0SrSHGAzp66yDGaEz8Jb387PKD0xM8TpiCiYprCHTjsT\n\t cZDC4d7B4i0y2taDu5Is93vYiawZIBffWQnv9xTUlbJCMjC0ZBAliatgLC2OuBWQO7\n\t Rddoa+jHUe9OtimCf0ptHxGVVPlf/WzbPyoD9KXjPTaqHa31AzQmDLdWjhWcjIfX7c\n\t CgIOAzgjMj0wQkmRIsXGh+mj7x59EeajmXwXD0cAZ05dk1IBcKCB+dPwh8u7SZmDQl\n\t mxfsYdYPuJr/Q==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.14;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org E296884596","X-CSE-ConnectionGUID":["Ia93uMaTSyifX7sYwxO+sA==","adhQR9hdQ+WfE7JOQPaxaA=="],"X-CSE-MsgGUID":["wl9TQ1CURxKZbc4GAA6pxg==","leDhEbsUSc21VbrAvv6ytQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11771\"; a=\"82346162\"","E=Sophos;i=\"6.23,207,1770624000\"; d=\"scan'208\";a=\"82346162\"","E=Sophos;i=\"6.23,207,1770624000\"; d=\"scan'208\";a=\"264892989\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=obLHvZZmJRpqPpesUTBqx9yFP78oM7DPdITUIvO4jHgjxIHRyodC1rlSxYPUZdgiP0KTM4KmK5hWkuIwVY2De0Z7L0aFCIe1sbkhPeJtzQn25VJTtt0NSC+rFnQfnEnC9sGEWtfyyWAFkgTxx2m4HfyUWNMTFxqPG41laLgUKGGleIm/r40PgxZ9K/Cvq/x4+fpLbazp6Id20TEW8NE4hRS22u7QDQY2dO9sUA9EUwqvtnoXZb1+f2ARFg9RwJ3xao53vt33dWdzLLr6OOOPFMR94vfhlupZM3LaGW1rtx1ld0GGRCkenIWHYHzXI3vD47Y4ZOrkylG6qKni9YMYIw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=5oiOLxNRgOTIGgoyvkcEMZYbiI+2Y1hdivQepJsFLgw=;\n b=cuckwqTMmIvsUiagNadawyCYDLcuRiiJp3U2CD865EZ+EPH/N3s1Ys8P6HocimR56MikwwkUIMNBi1oNgG65Md4SzPW7ydmxFhBUInwVaIKcw9mWR7guT5sHlBkCMAN7ksx6xbD/IFoPNzovmcOdeIQkZs6cPAqPbBaCWrHNqAjtiWO/qoQSj5H3DdsIZGxDW1mu4KixqB+cXv7lA/aYjUYC09dfiUAY5JyMW86KtxkF6PWAAZHDDB9fIS5pLRgt+IIbOGQXIDsEKSZ7DbCtzUAt6Ui5+TC48+hQssLDqd2WxcYxrgphKVsJcOPFZ3Qpi1PjkyumsJBJW9pezfq7Rw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"Li Li , \"Nguyen, Anthony L\"\n , \"Kitszel, Przemyslaw\"\n , \"David S. Miller\" ,\n Jakub Kicinski , Eric Dumazet ,\n \"intel-wired-lan@lists.osuosl.org\" ","CC":"\"netdev@vger.kernel.org\" ,\n \"linux-kernel@vger.kernel.org\" , \"David\n Decotigny\" , \"Singhai, Anjali\" ,\n \"Samudrala, Sridhar\" , Brian Vazquez\n , \"Tantilov, Emil S\" ","Thread-Topic":"[Intel-wired-lan] [PATCH iwl-next v3] libie: log more info when\n virtchnl fails","Thread-Index":"AQHc2BihK+GMa1EmWEWdLE9SK1g4BLX3PkxQ","Date":"Thu, 30 Apr 2026 08:36:11 +0000","Message-ID":"\n ","References":"<20260429204128.2865817-1-boolli@google.com>","In-Reply-To":"<20260429204128.2865817-1-boolli@google.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|CH3PR11MB8138:EE_","x-ms-office365-filtering-correlation-id":"900cd9cb-a7d5-4460-4a36-08dea69388c4","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|38070700021|56012099003|22082099003|18002099003;","x-microsoft-antispam-message-info":"\n W/5oN0ps3O53Gp9vm3cEOY1jl4tOQjWtBJ3Lnv/Z4uD4tRD63UB0VIN4SDK0V/Fk090uFr36mVTS1cFOWGOFWC72gNfqUqKC/UWCHcQr1vwIzXGmxmriZ+cKh3dbqg89DPqcuXNrkdkG6AxumwFGC254fryi0KJyE3LDFveC/T6avB7v8OSgdF+Y3qiWgT6i52FLFdpB3Th42Cw42Nw0brEj0WE2Im/dVbYunWWCcNhCy4mM5q5u7UKxzc3UAAHZKHfeX1cyB3dgKXpUOJ2rJHzi/Qxr5l0GHAyzzueE6sbcifg7Qb1+RTKLD5n22d9thimXSSgG87OKz8SWbvG71+nuYVSJ1QyG161P1bPR8a0GcxE4GH5bS6kvJwrDP6Y9oJPyIOB3q56/Tp3ZyKGboD0VGihmmkOnLN0Wc5C7JfJgBOMhMEQDtOor8kn2eojLeFFB7I7mRZr1NtjXJdo61hVV68qUcJlzAqK+BU7hO3ePWJblerSDFhiYBNEUq0nhki13vv3gdhPjaJOQwJLOisC2gEJxvinx6SdGn8WidCZEtYbSiPWoANbQtFORFfX2gLmysrgUmDGfJ/0uQ9TdAbPeSA0vV/kWA7aax6G3BV1f2yUkkxeUL7Pb+ZUoqGmzp2nAWaOrHfOuu3KhvFK9Autt35AbOG0S3TuZdy4v9sH8WHE//kNvT+maUB58huaUeeD31+xlZqyBwY/jCE/2dl9I0cQUsLydSbbfzzSsDhYB/f8vB4H8SuMfkHRFaUIlmkeoseQ2JsFQZJjnIOGNXbLNtAFBpFj5PnMb1q/9NPc=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(56012099003)(22082099003)(18002099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?OSke4x1PeRcorpaZR0HNXqsnEp3z?=\n\t=?utf-8?q?wC/yj7cfr9DZzKJxyJ82YHfl3to/SPMjJdO4Ty0wipDqN3IqZbY8pYlEeJYTjYyO9?=\n\t=?utf-8?q?SOoKf18/lpn1Qg8qYsQAb1MI1rARNagEFPy8kXVH6FrSRaM2nPgVhXb6OlojMdjsH?=\n\t=?utf-8?q?u5119kVMYFNNMVtlFUQCVw8H0WVYe490L8Kp3rHGZLiFQiv/fxzBHn+PuqE3cY7bT?=\n\t=?utf-8?q?iiFAT6GkoXi9KAdS50f+wxpdhO4xUR6ZvSyVKtRQvMtfx/i1vkjfgSIq0NxRfxUNI?=\n\t=?utf-8?q?gpw1S9c7UV5ttUHyl9PAX5Hd3LmGIaJZdr7V8yeD9S1zCTJb8OzqNxDITlxKRk9XY?=\n\t=?utf-8?q?1qn/5Czgq4+0SnstvRdrgprVxShFVG5pH62x3254z/72cju93LAmWpXHHjGqDcEnK?=\n\t=?utf-8?q?zrXaoHG3B3nKraOGjTCcn5OUT+zcrPzsx6MvtriQyEuElwVrF7jDulhHrfaGI+NUr?=\n\t=?utf-8?q?RL8K5UeMkSlR4mgo7cgWzDVlOjfgNQ0vxcPUqGmNCzyrLy59JA/W1rWreWEr3stlV?=\n\t=?utf-8?q?XQHbIhqhOoWCmRnA8RFerHKYQk5RXqQmO9bxOz++VKQrcu2r3IDLgHsNSXPc5xYa0?=\n\t=?utf-8?q?AJcQp3qfQfwgDJ9oqBJyvkbb/gR3W8+Q3zxHLZfgK/ilA9EwNKS992IuCdJoBQYUz?=\n\t=?utf-8?q?QlCIYxmHw/i6JjAqLg2DX5EMxvUsJ9iQSzS0g3s1WW0oK73dd4oL30XXKnkmNS0Rx?=\n\t=?utf-8?q?1PjRlSueOPbF7IWZNr+ctY0dyMmlm+aihrW60wJ88hFJYbeVg+Tmu6nF2654pPMga?=\n\t=?utf-8?q?RN5fJ4AToED+TVoswCG997cNreRVxP+GAnRtLYPDteQ4lb8QfqlfvSWA+uvNQoEJl?=\n\t=?utf-8?q?2TqV9V48iUpiLqz7RqoAe8d6yN0O460n5tio7Oj6xCk5nLrPisgStiS5PQV9XjE9x?=\n\t=?utf-8?q?h9D5JJivV66CUqdN5QxKr8SVqnjW4eX8DPuhxbRYPgisGMnCUWUIldWgrWrTjUC/c?=\n\t=?utf-8?q?KbLNFbvNIEOnqOar15e+h3o7rRDEJw0B74YW0b2Udplx2x4CYLvgGxYMo3DZicjaT?=\n\t=?utf-8?q?z6LurFta4643yUHmSGNQrhovqvaJcrKJeuRTkvZRFHooeTqHCPp6R6+ewYCdZgF8n?=\n\t=?utf-8?q?qPxn/YQmkRrRgJiXDsJx30VPqpfDTzgDRFjJbm7eFNXsRcR/hjbJBeir0TSBgqn5C?=\n\t=?utf-8?q?bWA2n5LscHse83TZrZ2WDref8D6iUVp8uv1H9CpUx8w8wk21cp+25bs/UpobHYW27?=\n\t=?utf-8?q?gVGBR7YPiIv8/mJurq1xMRETDbb+LDpy6jHoaI/OT0oDOC3fdNn26z6kRhLZw4wlb?=\n\t=?utf-8?q?sEJbAcC6iDzX4KcKvmYyOZtYxmepHTCY87GvZjdfcSX7Q3nc9VAJF6oiFFf0RR7gt?=\n\t=?utf-8?q?AolKWa9ziTGgS5L8hl3pbvzwMWsbpW66qfIx7LqGJpdLljp/imayFgzhzQ8auzlkP?=\n\t=?utf-8?q?TJL6L/gEoGei7LAXNjHMBQbcvl69Ew8StycSZNL/sEXZCxiOytaiqRMoNrpcchsE5?=\n\t=?utf-8?q?O/kFlLkVnn3L5/42GQqujzNvrl/Kmf094YqRcv3f8zpLjmRUUx7yS/0p1yrToK4RO?=\n\t=?utf-8?q?nPsjTcEI73q/M2c1bPVLC3+dmpP0t00vj8hqR+raKTkWY22UAChQelY3hYK0iBBJh?=\n\t=?utf-8?q?14p4+JU6ntA8Ko2qo0kaj68U1RuNCb92BOSYiEa8jrEhO8bNSN3nLjrVp7FjGfR7d?=\n\t=?utf-8?q?RZng1/l7JvK7pDidpWw0d+q+D0He9fByaePTXkJfTxTjem3UKZoRE=3D?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n czhamNz4s7u3CaglW0KBV4buMI1nRlwoK6hFpgwO2oJjeFvxvNhcbEnWAGn1enbCk+NXskIGfxuPNc/SF0CR7if8Xto+1/xZG48Ibq4KO3bBAg0NlaoqaZkp6nKmXpnZaHDyOCdnLGldKz3mSPb6Gt9m8FvJ1uZ+X1KcxUQku8bNzav6K/yo8KPkObCrGfxqLHr4tcyg2m85X+xaWACObqvep+M0Z559nKbajFSPeAXBxZHEKZTzbj66ubiBar2JuZsvhK+EWRObOsB6NbO+OOAg6Q1P9OPJ0RgpyaRXDqUHWRdWPaUdN51JzCOGfiZqu4TxARIqkI7A8dYylLA/KA==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 900cd9cb-a7d5-4460-4a36-08dea69388c4","X-MS-Exchange-CrossTenant-originalarrivaltime":"30 Apr 2026 08:36:11.8021 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n rfaPlF4LmFm6KAVFOW10KJMY5iYBeS2SonflCywfj7J6J6G55Ycp8yF8PFp4i23AzaGq3ofcwSgBllnpUJbG2hmFPl4GplNPbBPYgKMs1sk=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH3PR11MB8138","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777538182; x=1809074182;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=5oiOLxNRgOTIGgoyvkcEMZYbiI+2Y1hdivQepJsFLgw=;\n b=YnEtBmhP1/vB5jGpUAham5u20YhZB7TPRtUcPHhhPrtBy9A1kaybP5Ru\n YIv9C7mJsIgNyQ0IlpwoQKjhtaJvtslJVqSHaZMU3hRtxI1C03Own0Gq3\n BD/M9XiMyzHlsgeEzWDYBQ9Y3rgueyqGysfEfgouwtJadYnkPXbnWPD3g\n BP2cDwZNM+J3EqfkTEoXNT0rNaB0d3SOaaUDyytDsgV6kkNIob0x+32AZ\n dgTCc+4OVI5cjBjHhRynDZleNBqVuHu8azigVgUBl8V8QQIOeMP4vkEV/\n C2nPH6VQqK/JJWgDCD7GdWXQLm/qQDZYCSAiC73v8JwPDtd46FEAQ2LUn\n A==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=YnEtBmhP","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] libie: log more info when\n virtchnl fails","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3684998,"web_url":"http://patchwork.ozlabs.org/comment/3684998/","msgid":"","list_archive_url":null,"date":"2026-05-01T01:14:18","subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] libie: log more info when\n virtchnl fails","submitter":{"id":92373,"url":"http://patchwork.ozlabs.org/api/people/92373/","name":"Li Li","email":"boolli@google.com"},"content":"On Thu, Apr 30, 2026 at 1:36 AM Loktionov, Aleksandr\n wrote:\n>\n>\n>\n> > -----Original Message-----\n> > From: Intel-wired-lan On Behalf\n> > Of Li Li via Intel-wired-lan\n> > Sent: Wednesday, April 29, 2026 10:41 PM\n> > To: Nguyen, Anthony L ; Kitszel,\n> > Przemyslaw ; David S. Miller\n> > ; Jakub Kicinski ; Eric Dumazet\n> > ; intel-wired-lan@lists.osuosl.org\n> > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David\n> > Decotigny ; Singhai, Anjali\n> > ; Samudrala, Sridhar\n> > ; Brian Vazquez ; Li\n> > Li ; Tantilov, Emil S \n> > Subject: [Intel-wired-lan] [PATCH iwl-next v3] libie: log more info\n> > when virtchnl fails\n> >\n> > Virtchnl failures can be hard to debug without logs. Logging the\n> > details of virtchnl transactions can be useful for debugging virtchnl-\n> > related issues.\n> >\n> > Tested: Built & booted on a test machine and synthetically produced a\n> > virtual failure to produce the following log:\n> >\n> > idpf 0000:01:00.0: Non-zero virtchnl ret val (msg op: 1, ret val: 6,\n> > data_len: 8); xn id: 0, cookie: 0\n> > idpf 0000:01:00.0: Transaction failed (op 1, xn state:\n> > 3, id: 0, cookie: 0, size: 8)\n> >\n> > Signed-off-by: Li Li \n> > ---\n> > v3:\n> > - Use dev_err_ratelimited in both logs.\n> > - Move log placement to after virtchnl field validation.\n> > - Remove redundant op/cookie fields since they were validated.\n> > v2:\n> > - Use dev_warn_ratelimited instead of dev_notice_ratelimited based on\n> > reviewer feedback.\n> >\n> > drivers/net/ethernet/intel/libie/controlq.c | 13 +++++++++++++\n> > 1 file changed, 13 insertions(+)\n> >\n> > diff --git a/drivers/net/ethernet/intel/libie/controlq.c\n> > b/drivers/net/ethernet/intel/libie/controlq.c\n> > index ebc05355e39d..ceca8a076d79 100644\n> > --- a/drivers/net/ethernet/intel/libie/controlq.c\n> > +++ b/drivers/net/ethernet/intel/libie/controlq.c\n> > @@ -766,6 +766,14 @@ libie_ctlq_xn_process_recv(struct\n> > libie_ctlq_xn_recv_params *params,\n> > msg_cookie != xn->cookie)\n> > return false;\n> >\n> > + if (ctlq_msg->chnl_retval) {\n> > + dev_err_ratelimited(\n> > + params->ctlq->dev,\n> > + \"Non-zero virtchnl ret val (msg op: %u, ret val:\n> > %u, data_len: %u); xn id: %u, cookie: %u\\n\",\n> > + ctlq_msg->chnl_opcode, ctlq_msg->chnl_retval,\n> > + ctlq_msg->data_len, xn->index, xn->cookie);\n> 'virtchnl ret val' 'ret val:' looks like a duplication in dmesg.\n\nLet me send out v4 to simplify it.\n\n>\n>\n> > + }\n> > +\n> > spin_lock(&xn->xn_lock);\n> > if (xn->state != LIBIE_CTLQ_XN_ASYNC &&\n> > xn->state != LIBIE_CTLQ_XN_WAITING) { @@ -1011,6 +1019,11\n> > @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params)\n> > params->recv_mem = xn->recv_mem;\n> > break;\n> > default:\n> > + dev_err_ratelimited(\n> > + params->ctlq->dev,\n> > + \"Transaction failed (op %u, xn state: %d, id: %u,\n> > cookie: %u, size: %zu)\\n\",\n> > + params->chnl_opcode, xn->state, xn->index, xn-\n> > >cookie,\n> > + xn->recv_mem.iov_len);\n> Probably %u fits better for enums than %d, what do you think?\n\nSure, let me use %u in v4.\n\n>\n> > ret = -EBADMSG;\n> > break;\n> > }\n> > --\n> > 2.54.0.545.g6539524ca2-goog\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=WYkkYSNI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6CkW16bbz1y1d\n\tfor ; Fri, 01 May 2026 11:14:42 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 7392D422F7;\n\tFri, 1 May 2026 01:14:39 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 7zmnKL5s2qTj; Fri, 1 May 2026 01:14:38 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id A1F42422F2;\n\tFri, 1 May 2026 01:14:38 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 11940204\n for ; Fri, 1 May 2026 01:14:37 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id E70B861672\n for ; Fri, 1 May 2026 01:14:36 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 8j-c9Iftk7Wd for ;\n Fri, 1 May 2026 01:14:36 +0000 (UTC)","from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com\n [IPv6:2a00:1450:4864:20::22f])\n by smtp3.osuosl.org (Postfix) with ESMTPS id E80DC6F67C\n for ; Fri, 1 May 2026 01:14:35 +0000 (UTC)","by mail-lj1-x22f.google.com with SMTP id\n 38308e7fff4ca-38e7d983f79so15506861fa.0\n for ; Thu, 30 Apr 2026 18:14:35 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org A1F42422F2","OpenDKIM Filter v2.11.0 smtp3.osuosl.org E80DC6F67C"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777598078;\n\tbh=nSQkpXPvbzNQeoub82VoqlOWrgCeyn6/Q35lCNTDSoo=;\n\th=References:In-Reply-To:Date:To:Cc:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From:Reply-To:From;\n\tb=WYkkYSNIGb93m6SA5hpQffwug/Xp5ZL7XUybNgbbELjvZ/s7hZ5r1vnIpDvuml2dD\n\t wRggiHUqnwVU+WMOKv29vOTtFw1EFUjmuA3uzWSu+AI3FYyA2mBFOSoEF9PXqTDm8/\n\t W9keXkBHLPVHMuz33jDuqTVDupCYyc588C1pWdIKQaWVwgC/JzIqSpXs95GHtiDVZC\n\t cjTeP33A/WInkZ6xZoxGukwy6n8oReZw4YwGxMJV57Pa7c7eEwuyz8mjW/ctiLyEsG\n\t 0ZplyK+koaXelVd8QnCjJJ6YUbMDNDCR5GoaC/vy7K4DZgXOazV7iu11AvJLHrcpX/\n\t UEXincjvcaeDQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::22f; helo=mail-lj1-x22f.google.com;\n envelope-from=boolli@google.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org E80DC6F67C","ARC-Seal":"i=1; a=rsa-sha256; t=1777598073; cv=none;\n d=google.com; s=arc-20240605;\n b=i8H8DN/2KkaWgmg4WmOIf+PmoN1vztec6UIBZTR36dWtZtKSqs+wByrJgEZmExGOby\n tnsREvYZtIVeMOY0Xs39gIkgYaRya/l/Bx8tcxbdMnkTiItDyZfn9Ao/eq996JmCDRyZ\n 4ylEsQuzLtIgj9Puuh94PY+fRgd7jpG0X+RmUVeHxBQrAeG+LDoGWVWI3Xiwyk+NUOxs\n 8pswv3gNfesN6d+oIrnW41ZBXIW0E12prbiFMsZnEy20FY0aIaSAwzap0/uw505vDphs\n 4aXVLSYXIB4VP4TeFrpEW1O5LIiWTdi+xdk7ZZyVHeg+igbffCujBa8ybKt/ZwFcs3XG\n 6AhQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=nSQkpXPvbzNQeoub82VoqlOWrgCeyn6/Q35lCNTDSoo=;\n fh=6rlFSyVhnoNFedSHnGyRHbKH2kBZyhOB+tI+XJd1i1k=;\n b=GSDUc9FBwmEJD5292QyiC4zM6P6ejKaEmrD390lBihVwcu6VdE08f/AfFkv1Ig1ezn\n 8q8sWectCawiDXBtygWDDue/10+xbS9llJo8fcosU9PJUxnUVZ6xwf/i+BSIhySmG7zU\n QneWuY2QH94EE21Sy6v4S+HPA+Hzq+8QOB+qV9mC0lBPWY3dS0HdJA8xz2hmiCZhugez\n bvinsJ7FD3KK5BWEf6d/Qyp5/erIoojLT3uEJfe0HB1XMSAZX8t/11U61XLpJ4juvo51\n wcdO7UV90tL7JiA3e/dY8l4DC0rROlHWEPy38tp5xnCKEhCbLvt3YXcIAaG6EftypU7I\n R/Nw==; darn=lists.osuosl.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777598073; x=1778202873;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=nSQkpXPvbzNQeoub82VoqlOWrgCeyn6/Q35lCNTDSoo=;\n b=iwCxSm0us+urWVPydPps/LJzmNvbhRdDEZQjOEKzkTLBei9bplG1KWQGnATFfO34Fe\n AXM/7wXuACvUv6bqrq4qz79esWSDwZlQstFElJVH1uCyQZiAeU6GrQQGWueHEsTxSS1P\n lD0hz3ZLU+4Z1StNVVzYW0EbvgXRsaDYdk6aZLjEen6YQ02FM7sNad2t1ezDH5m2BR1a\n sa4F8FB/KyFb509lz93ik2TeaF7Ed87UKO6KjJo3zu5SbKUG1fvhSzZGR90NYW1hD5rc\n P7dZ/8F9Wawv5Th7EEJ9otfv3IcmJTU+vF5muzMqoEPkjQTXEq8EYmhe+tmNjwntNv+B\n f1Qw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ89H716RrLK71TcOn6W/9qpnoCTdq0XUMCgj9k9LX3BRoHlotCPe5aRh9SFGRQe6uBySM4r2aBZlq3r0tvORZc=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YyEalmS78mai9McqY3iaIGQM1FOxawdbZ/9YzL+aeLoRerT2FI7\n 7vrf+PxOwpy0n/u1I8NPAW+gE5clrN2i7uQ6wDUQPFEpqn+X+aagC7W9zi0hoddUsQvNF82tVxB\n mupVDkDUxVYKtwCDLf9mxWyCbKMipl8AbOTVbPsLv","X-Gm-Gg":"AeBDieuhmxLbF1Lat9BvYc5AC4u36uiIfsyrCtOwYFJiXJ8IHFCeCZi5iqxz2Tc+70y\n XYo4pZiuVam2hFKS86GriQaUewK0grJYJ2fZOgdS2y8ZWwzTVr2XGFDWVHJdcDNzY7vS1MBxyYv\n 090EA2i9h99OezPxdY3SA1LRzVtoDQxnS+FRiwzJnR6cQ5cOPIujIxkeHhdeEzI4m8SBraxC/6Z\n fpTO0qinZCHjqqevmdAie+xzYiZrRSeiWGiPaU8SSafK6WKbz11g9jAOHddZiNWX96FRAdy8aZK\n k/8AOQthuhfxhalU63iYh8wE+tobkdpb9zEWgEEmNTEBZS60Kbm8VChxzGc=","X-Received":"by 2002:a05:651c:502:b0:38a:902:dcd with SMTP id\n 38308e7fff4ca-3934e204d45mr18166231fa.20.1777598072804; Thu, 30 Apr 2026\n 18:14:32 -0700 (PDT)","MIME-Version":"1.0","References":"<20260429204128.2865817-1-boolli@google.com>\n ","In-Reply-To":"\n ","Date":"Thu, 30 Apr 2026 18:14:18 -0700","X-Gm-Features":"AVHnY4J_plv41lTEdTL-vvxKy5_2KloHTpmwjewmh1NkxAdrXpoon5Ni15mn_Pw","Message-ID":"\n ","To":"\"Loktionov, Aleksandr\" ","Cc":"\"Nguyen, Anthony L\" ,\n \"Kitszel, Przemyslaw\" ,\n \"David S. Miller\" ,\n Jakub Kicinski , Eric Dumazet ,\n \"intel-wired-lan@lists.osuosl.org\" ,\n \"netdev@vger.kernel.org\" ,\n \"linux-kernel@vger.kernel.org\" ,\n David Decotigny ,\n \"Singhai, Anjali\" ,\n \"Samudrala, Sridhar\" ,\n Brian Vazquez ,\n \"Tantilov, Emil S\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1777598073; x=1778202873; darn=lists.osuosl.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nSQkpXPvbzNQeoub82VoqlOWrgCeyn6/Q35lCNTDSoo=;\n b=FZDI90TSE3rE5UMsw0BDkX0A8sInJfPf9LaJSdp4Te582+a9jf1u+mvUoco+iIaPqj\n F+2ziBlV4HZvF81bJ922qKYj6tuEEtHtc74qCGCVNrf72DDAsZ6XCWOtIpCfBfn9Zg8l\n Q7FApoSRY0r2ORn4+mNTetD0XGfN6SD9XxAh1Un3yXi7pYyE22is+aKFk6zmImRqffPE\n ER84ipK+CfZqpyf6GBE+oa9tGBvN2tpWVCQE6jbh6xDyX2IU8VeeMDy+MNMmfXCaChBA\n ksxpv7hydgIbuO4jIeqVjXanRTaQ/Tee+Zxqpx4EFRElfeWIjSOkjFwag4G41/Dmm6SX\n qZYA==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=google.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=google.com header.i=@google.com\n header.a=rsa-sha256 header.s=20251104 header.b=FZDI90TS"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next v3] libie: log more info when\n virtchnl fails","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Li Li via Intel-wired-lan ","Reply-To":"Li Li ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]