[{"id":3684130,"web_url":"http://patchwork.ozlabs.org/comment/3684130/","msgid":"<20260429152005.3985-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-29T15:20:05","subject":"Re: [LTP] aio_cancel: Fix incorrect strerror() usage","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Martin,\n\n--- [PATCH 2/2] ---\n\nOn Wed, 29 Apr 2026 16:53:12 +0200, Martin Doucha wrote:\n> aio_cancel_6-1: Rewrite test\n>\n> The test schedules multiple async writes into a file and then hopes that\n> at least one will block long enough that aio_cancel() will cancel it.\n> [...]\n> This fixes a race condition where aio_cancel() could be called after the\n> target write has already finished. [...]\n>\n> Signed-off-by: Martin Doucha \n\nThe commit body says this fixes a race condition, so a Fixes: tag is\nrequired. Patch 1/2 in this same series correctly uses Fixes: tags for\nanalogous rewrite-as-bugfix commits to 5-1.c and 7-1.c. Please add a\nFixes: referencing the commit that introduced the original 6-1.c.\n\nPre-existing issues noticed in the surrounding code (not introduced\nby this patch):\n\n- aio_cancel/5-1.c — Uses nanosleep() in a spin-wait loop for\n synchronization.\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://patchwork.ozlabs.org/project/ltp/list/?series=502088\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mxE92Vlf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Lb24QDZz1xqf\n\tfor ; Thu, 30 Apr 2026 01:20:14 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 9C7823E49C8\n\tfor ; Wed, 29 Apr 2026 17:20:12 +0200 (CEST)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 1AB473C66CA\n for ; Wed, 29 Apr 2026 17:20:09 +0200 (CEST)","from mail-ua1-x942.google.com (mail-ua1-x942.google.com\n [IPv6:2607:f8b0:4864:20::942])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 3BFC41A00933\n for ; Wed, 29 Apr 2026 17:20:08 +0200 (CEST)","by mail-ua1-x942.google.com with SMTP id\n a1e0cc1a2514c-94ac8cbf3feso7820507241.0\n for ; Wed, 29 Apr 2026 08:20:08 -0700 (PDT)","from\n runnervmeorf1.h3kajnb5sjwe3pjjo5i2acy55g.cx.internal.cloudapp.net\n ([135.119.238.193]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b3ef71b89fsm21162796d6.21.2026.04.29.08.20.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 08:20:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777476006; x=1778080806; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZbBEEWtPLAojeh6ugLQSr+C+lNBdryV21kEmWZa5bB4=;\n b=mxE92Vlfr++moMweiDtMHrrkKia2nVtC0riupt6ajqESV2A+cvd0KoAoZQ8z38NzQQ\n XxKz4aknFw8PMaKFElpR+wLAdSSgwgs6as9SPJRVZsJE5Oi3XakDjsZsrem+Dfra4eUD\n pBdWKP5VhxX7pwDwScdQxmn64kqmpf7WZtM+1qBEmLYgNOwgcKZIOTr8FNvdhbbYgi92\n ZY4ERBxBaAJO3m+08Jzw1qYA/fnWBuZMQ28ZKvAZNpTjADgeXTHJOA2vAOCWpo0gQ2rp\n MV+i3Lfeh5MJmjNSxQttcKHqFcVelSUe3joaqxAovLWy3hgsUiGQ1Pl9BG9DD2VKCfeo\n oKkA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777476006; x=1778080806;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ZbBEEWtPLAojeh6ugLQSr+C+lNBdryV21kEmWZa5bB4=;\n b=YiZG4rsKy+Xcdn3gPLH/W/M9xIWIsLQFPGiwxm9/L0mLia9Wvh+HzdpR+yOM+hbx/J\n Sq48vqvCiFdFdBHnNvIwjrxCCUvhmiB+MZJiTWSx8kLZwtDzVmo3K9PKVdV0EtNX5nT5\n ptxF/2qTiQf7+wGnjFhsBJZ0hlx9NNHaVHAfD94ETPj5/dNr4hKpl0sOB/CZ/pzX/iOU\n 6WeOMyW2YILLudEnfBmLRmzA1RqBW+LLWL+2hKeWtBvi82jnMIlVRSu5nxg8DXnwT8Mt\n Nx8UnRNaPN1nhDIgd8DSmpQEv2r9fUiVgPfpJmr1yL/MWgHw3gWj57ypo3yulUOvQf/c\n Mu2w==","X-Gm-Message-State":"AOJu0YwAmgdmx+vLdTj8bRHaB7uD7QtiUuoH4s41oohnIWPfDmA1Um1C\n uHIrYBu4ppVv0GT533yY0jS+nIGYprroR5y1qes6sEAtSO0XopB55yiS","X-Gm-Gg":"AeBDieu/ugV9xRv47USvbh29ZejZlhd49Me/HErTbfeMfsTVQEld4LvwzSaok44q+38\n pf56ES8yTRBqBOUvTNY0pRi8t0MgyHsMOfWBUNMLs2UGFtDZwpd/cHihCSkV65ckNWdciftna24\n ivO70VvR8DoMTm3a9DQ/BCiQid4sNEJ8PEsEz34+CJVWtIADcUDnQ9PUD1X06Dh3S0FVriF/Bzy\n LpYJjvkBdphQo3w0eimd4mSLo3PqpTH9yWld6FROhlr5P14YaiudLbhJ27/O3ELuS/hYg8kFE+V\n 2Sod5RZzPFl16On/SMTJVAU0Sy+Q3dnBkprZ3GiE22eEUE6wtcBq8NRsH2MlWgkauY1nZdeSLW4\n SU1lB4r54rO+DadFBFP8/mxBtkL6xtsFDrnCnQVwPQW5kClRrZllS7n5+Nihy3qFqOBNZk1CcDV\n RaNA2WbfqS6FMwW5latzNfxnLsEcM/8dL8XBQqmhisdzwSqIrw4Ly+Snpp1B32wREgFMjsMgtol\n kC/N1BV/KWCQ1sIe7U5QlxQkQEXOjBz27z7IBF4EBHNgusJSE8G","X-Received":"by 2002:a05:6102:6b01:b0:605:6089:674a with SMTP id\n ada2fe7eead31-629272e90b8mr2781194137.23.1777476006475;\n Wed, 29 Apr 2026 08:20:06 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Martin Doucha ","Date":"Wed, 29 Apr 2026 15:20:05 +0000","Message-ID":"<20260429152005.3985-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260429145314.79256-1-mdoucha@suse.cz>","References":"<20260429145314.79256-1-mdoucha@suse.cz>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] aio_cancel: Fix incorrect strerror() usage","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]