[{"id":3684324,"web_url":"http://patchwork.ozlabs.org/comment/3684324/","msgid":"<523cc81f-afc9-4790-b984-576f38adcc8b@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-29T23:00:46","subject":"Re: [PATCH v2 11/17] bsd-user: Add bsd-ioctl.c infrastructure and\n termios conversion","submitter":{"id":93152,"url":"http://patchwork.ozlabs.org/api/people/93152/","name":"Pierrick Bouvier","email":"pierrick.bouvier@oss.qualcomm.com"},"content":"On 4/29/2026 7:45 AM, Warner Losh wrote:\n> Add initial bsd-ioctl.c file with termios conversion functions,\n> structure type definitions, and ioctl table infrastructure.\n> Includes target_to_host_termios and host_to_target_termios for\n> terminal I/O control conversion, along with the ioctl dispatch\n> table framework.\n> \n> Style complains about STRUCT and STRUCT_SPECIAL defines:\n> ● checkpatch.pl: 197: ERROR: Macros with complex values should be enclosed in parenthesis\n> ● checkpatch.pl: 198: ERROR: Macros with complex values should be enclosed in parenthesis\n> but that's fine. We are doing weird things with macros, and it's fine.\n> We can't put parens or do while (0) around these since they are table\n> building macros for files that are included multiple times.\n> \n> Signed-off-by: Stacey D. Son \n> Signed-off-by: Warner Losh \n> Signed-off-by: Sean Bruno \n> Signed-off-by: Kyle Evans \n> ---\n> bsd-user/bsd-ioctl.c | 221 +++++++++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 221 insertions(+)\n> \n\nReviewed-by: Pierrick Bouvier ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=EMzjHUOE;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=P0cdI4GS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Xpp6JdMz1yGq\n\tfor ; Thu, 30 Apr 2026 09:01:06 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDtn-0002l7-Uz; Wed, 29 Apr 2026 19:00:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDtm-0002kt-0E\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 19:00:54 -0400","from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDtj-0008F2-Mj\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 19:00:53 -0400","from pps.filterd (m0279872.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63TKbjqH3203450\n for ; Wed, 29 Apr 2026 23:00:50 GMT","from mail-dy1-f200.google.com (mail-dy1-f200.google.com\n [74.125.82.200])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ducj83spr-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Wed, 29 Apr 2026 23:00:50 +0000 (GMT)","by mail-dy1-f200.google.com with SMTP id\n 5a478bee46e88-2bda35eab74so348159eec.0\n for ; Wed, 29 Apr 2026 16:00:50 -0700 (PDT)","from [192.168.1.170] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ed1c07058esm5638484eec.15.2026.04.29.16.00.47\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 29 Apr 2026 16:00:47 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n YGwBi+sYquQJR7uDVeJDs7hOT3XWkBEq7bPIAxFvUVs=; b=EMzjHUOEGV4RWdR2\n WRvXCEm3IjpPCqcfxRExPH0UJE9tealh9RVO3sd6IrF4xpLJkbAorFk4A1Fv5/FF\n CDFfbvazeXB2zDItwBr8U5/jQxpvCeP9lzMdOHgIMd3/Yj24uDb4fh8356S1xXlH\n XeKeGpYWiVrAfjeHSbkGyB5IH6+lceMvkM6oOgkIIR0z5ofBtoXFvfHz45bQdbJF\n kmqA6o8ZJp5Fj3y3JvSbTHzGuP4+FpErU5WCmwQ9RFYA8VCkfXS9PdRQmL+7YciH\n jdykS6uIE+zp8w4TXJ3519GJTwtUFP94kIFcRTP4mVMkvMeItW5euPp0RRYHrHJN\n XRDaWQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1777503649; x=1778108449; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=YGwBi+sYquQJR7uDVeJDs7hOT3XWkBEq7bPIAxFvUVs=;\n b=P0cdI4GS4MaDsTTAYqGBpGYL54k9gEIX8sHVb5lILTmV1kZd/Lg+tCrZtKVAJUheCx\n DzLN829UxsoqExNMJEV+AR24OZLFM19CdkLrpbri8/a35fK5vC419lva2v7hcZCNg3xj\n vYlGu16bO42xwZ5jb2sTYq0/fk73eSjT9oCuBJRvNi8o+qChwfU/1AUHjT9wZs2XqUVO\n tjc9baxvNUTue/z8TvgkCO+p2HHjJ6+Ra37ImktxZegEX5QGzQV5J2XqMytK1xj07aKi\n udniGaQLFlBwX3TF2xHPZvxQRnditPerluSaPYlnX956DzdKOD2fkYtnyLwPYgJcSdoe\n eBRA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777503649; x=1778108449;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=YGwBi+sYquQJR7uDVeJDs7hOT3XWkBEq7bPIAxFvUVs=;\n b=U71ek6bxMLqNZo640mBMTKQ6FHoU9Pk/IJgQyY9ERp5rLnlePA5vJ1Loe5sDxTYahV\n wM1yprXapBat4a1ZQYMHELWbuYz5uvnhuyq+Kw3uu/Vu7GE257f+plEMTtCCx0eGvmSF\n /jl0eGy/HSyJIpMP0+IXWHafXQMMXuwpemhH5J/0EYBWwf8BnDpPl4j/fHj4qKZrMrOO\n ib1oHRonKkiPCvb6tDRo8oTHI3ATJsq2yK4+K4tscX6VMA+qQrlx1BXqV7m36jfYrsVQ\n UF+RKjodoe4htf2pGie8sQrcbErq8ss1BWZRkQ5iewKXezpk9Gn/G9t9+6gSxedjpUS7\n sikA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/1PYd9cMuGyBNWEXRdXYc4KELgsNXbsux/TMp6SCya8D+buwIrnfFj6ZInBG815tfYKLt4hjIKCgNw@nongnu.org","X-Gm-Message-State":"AOJu0YyVL79+vKBYPKf2iwN4pphhewgl9YAXZAwnDEyKxhLr8saEMGU0\n fBmqq9wFY1P4VwA6dDjb4jJ2JfZAIDtftItkXyUGVOGN3/vRFlgbIR7C2U04itrAAg/2X1sHPfD\n GUlBSfMNdwvDCPsrjUS5p1XKxP5Ao0cvBQgHmCtcZbUdfo3FN/nwDUXPqlQ==","X-Gm-Gg":"AeBDieurmywcthLDUzxaXKcNO6aOxBxOLMCmftklOUq1FlMLYs3soCUBhWLMuCwlDqj\n JLBmsDjleFDAoWeAWjCkJ+LIXK8Dwv/d06yGmYy4f4jDToxgLCf9mAruBvx03xndwJk9sgamU77\n pa1PN6ySUwFWOEbt8GjgiCYJ5AHoxXrSTDlBo9y157MHhJQA1uePRVmDIHyzVj9CMGgNtlpDiIO\n Yfe+X14TmzWHM4vZ1FzL3BbhilRJLONwNO2lOfEbMWUrSShm1mrPjxMUyOuFEoFa7A29fRfUEL6\n 56E+14DpdhKJT/wv9sAv30x24uyQD8P0uso7U38xPqUVojbAgN3qpRNZgBN0Svi9qUbR/e+vSHu\n XaUoHnos3LA0TfdPXgAGq3oOz5Eg9lG9RiukkUJi4tlaHlGRGkJuC3fZhWnJnNZzh0j9uabd8pu\n Lj/aaw8cHuUF1WayTPlTWmFuUL","X-Received":["by 2002:a05:7300:3248:b0:2a4:701a:b9ba with SMTP id\n 5a478bee46e88-2ed4edd506fmr30328eec.14.1777503649264;\n Wed, 29 Apr 2026 16:00:49 -0700 (PDT)","by 2002:a05:7300:3248:b0:2a4:701a:b9ba with SMTP id\n 5a478bee46e88-2ed4edd506fmr30308eec.14.1777503648588;\n Wed, 29 Apr 2026 16:00:48 -0700 (PDT)"],"Message-ID":"<523cc81f-afc9-4790-b984-576f38adcc8b@oss.qualcomm.com>","Date":"Wed, 29 Apr 2026 16:00:46 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 11/17] bsd-user: Add bsd-ioctl.c infrastructure and\n termios conversion","To":"Warner Losh , qemu-devel@nongnu.org","Cc":"Kyle Evans ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n \"Stacey D. Son\" , Sean Bruno ","References":"<20260429-ioctl-v2-0-288639bc2427@bsdimp.com>\n <20260429-ioctl-v2-11-288639bc2427@bsdimp.com>","From":"Pierrick Bouvier ","Content-Language":"en-US","In-Reply-To":"<20260429-ioctl-v2-11-288639bc2427@bsdimp.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"iH-3HzAMakdxVrQLrx3P7WhETlWT5xA9","X-Authority-Analysis":"v=2.4 cv=RI6D2Yi+ c=1 sm=1 tr=0 ts=69f28da2 cx=c_pps\n a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=iLqgmErQAxjCjdq5jj1Aqg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22\n a=6I5d2MoRAAAA:8 a=7Qk2ozbKAAAA:8 a=EUspDBNiAAAA:8 a=OG5E2G-EYVFjY02b_6IA:9\n a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22\n a=1lyxoWkJIXJV6VJUPhuM:22","X-Proofpoint-GUID":"iH-3HzAMakdxVrQLrx3P7WhETlWT5xA9","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI5MDIzMSBTYWx0ZWRfX3hzcvvb0EMpG\n CiY1Z+80JsY+QuW7RSnSCK1EhR7oLHaa8ObcuYCQYlKAhsSTsgn7T8NssLQ+gip975ZD/kP9wlS\n vVvXPVbZQpRi12Yx2ojKzqKxLL5QY33CHsUPs+Oi+sosSS5So7+2KXtBdQQEfCTJNYSYQbR0zbD\n msVy7ycWCwrVt4HHxlXqLvwJGYqxYHH5yGT6WKKKDeRglXqZeM4Ct1ijs2ljjVb1+MaJfKuaR+c\n FjRooZ5jFzZyHXxxLkkT0D9XZvSUdkYO2n/k/zR2TT82S1fXNruK/rhMkh5LlhFDlCv+8P1CKs5\n fLkUXL27uYCocpdCDzfSa2A0kO9+uRkQycw+Rsv+yJ7VjjPBJHY/EIBfdXERlGfaSzjsdAlQqSQ\n nnfiCTcQDeVKE6aQVEWjXSCcG1GHd41ONl8CNtw+yxo5jcCOvV5EmMJu2EQNLZu57/f0p6r4Zi1\n Uwcvhbm6NU/P3DIl98w==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-29_02,2026-04-28_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n phishscore=0 priorityscore=1501 malwarescore=0 suspectscore=0\n lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604290231","Received-SPF":"pass client-ip=205.220.180.131;\n envelope-from=pierrick.bouvier@oss.qualcomm.com;\n helo=mx0b-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]