[{"id":3684328,"web_url":"http://patchwork.ozlabs.org/comment/3684328/","msgid":"","list_archive_url":null,"date":"2026-04-29T23:03:59","subject":"Re: [PATCH v2 15/17] bsd-user: Add do_ioctl_in6_ifreq_sockaddr_int\n function","submitter":{"id":93152,"url":"http://patchwork.ozlabs.org/api/people/93152/","name":"Pierrick Bouvier","email":"pierrick.bouvier@oss.qualcomm.com"},"content":"On 4/29/2026 7:45 AM, Warner Losh wrote:\n> Add special handler for IPv6 interface request ioctls that take\n> a sockaddr_in6 structure as input and return an integer flag value,\n> such as SIOCGIFAFLAG_IN6 and SIOCGIFALIFETIME_IN6.\n> \n> Signed-off-by: Stacey D. Son \n> Signed-off-by: Warner Losh \n> ---\n> bsd-user/bsd-ioctl.c | 32 ++++++++++++++++++++++++++++++++\n> 1 file changed, 32 insertions(+)\n> \n> diff --git a/bsd-user/bsd-ioctl.c b/bsd-user/bsd-ioctl.c\n> index 2ff37a0817..aa0153bbaa 100644\n> --- a/bsd-user/bsd-ioctl.c\n> +++ b/bsd-user/bsd-ioctl.c\n> @@ -262,3 +262,35 @@ static void target_to_host_sockaddr_in6(struct sockaddr_in6 *hsa_in6,\n> memcpy(&hsa_in6->sin6_addr, &tsa_in6->sin6_addr, 16);\n> __get_user(hsa_in6->sin6_scope_id, &tsa_in6->sin6_scope_id);\n> }\n> +\n> +/*\n> + * For ioctl()'s such as SIOCGIFAFLAG_IN6 and SIOCGIFALIFETIME_IN6 that\n> + * passes a struct sockaddr_in6 in and gets an int out using\n> + * struct in6_ifreq.\n> + */\n> +static abi_long do_ioctl_in6_ifreq_sockaddr_int(const IOCTLEntry *ie,\n> + uint8_t *buf_temp, int fd, abi_long cmd, abi_long arg)\n> +{\n> + abi_long ret;\n> + struct target_in6_ifreq *tin6ifreq;\n> + struct target_sockaddr_in6 *tsa_in6;\n> + struct in6_ifreq hin6ifreq;\n> + struct sockaddr_in6 *hsa_in6 = &hin6ifreq.ifr_ifru.ifru_addr;\n> +\n> + tin6ifreq = lock_user(VERIFY_WRITE, arg, sizeof(*tin6ifreq), 0);\n> + if (tin6ifreq == NULL) {\n> + return -TARGET_EFAULT;\n> + }\n> + memcpy(hin6ifreq.ifr_name, tin6ifreq->ifr_name, IFNAMSIZ);\n> + tsa_in6 = &tin6ifreq->ifr_ifru.ifru_addr;\n> + target_to_host_sockaddr_in6(hsa_in6, tsa_in6);\n> +\n> + ret = get_errno(safe_ioctl(fd, ie->host_cmd, &hin6ifreq));\n> + if (!is_error(ret)) {\n> + put_user_s32(hin6ifreq.ifr_ifru.ifru_flags6,\n> + arg + offsetof(struct target_in6_ifreq, ifr_ifru.ifru_flags6));\n> + }\n> + unlock_user(tin6ifreq, arg, 1);\n> +\n> + return ret;\n> +}\n> \n\nReviewed-by: Pierrick Bouvier ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=Cc/dm9NR;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=E5n10V9R;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5XtX6lwMz1yGq\n\tfor ; Thu, 30 Apr 2026 09:04:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wIDwt-0004cH-44; Wed, 29 Apr 2026 19:04:07 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDws-0004c4-6T\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 19:04:06 -0400","from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wIDwq-0000TW-JZ\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 19:04:05 -0400","from pps.filterd (m0279872.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63TKbk4r3203482\n for ; Wed, 29 Apr 2026 23:04:03 GMT","from mail-dy1-f199.google.com (mail-dy1-f199.google.com\n [74.125.82.199])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ducj83sxr-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Wed, 29 Apr 2026 23:04:03 +0000 (GMT)","by mail-dy1-f199.google.com with SMTP id\n 5a478bee46e88-2eaf70f3b5fso434488eec.0\n for ; Wed, 29 Apr 2026 16:04:02 -0700 (PDT)","from [192.168.1.170] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ed1bfa6766sm4200860eec.13.2026.04.29.16.04.00\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 29 Apr 2026 16:04:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n YiPw9t06smp/3niIbpzodDGXxTn8teJ1hDjW5pUWHco=; b=Cc/dm9NRHNk3s/kf\n EZVMfDcDWpwLyRmXhkNjSEDboyyZvVfp/A7IHsvbfHqFLRBIu5BzUHZm/YJE5lpf\n uHYb/wWA3iZXI6Yf6pI40fPBCCo+W2FPjBhIBqRYQTwt1mlLSCwJe/kTjWI3nIuT\n zvD/GS8mHUsMk63M3qOfL9NTuQepnfRQhD1YzPoWLadlXo/L4sDRlP1iPSXikXdu\n H+BsKxIlpZjTyyK+FkyRS5g1foJxmpMuOg6LFqPpFC/oqZjlebFZCDwAP/c5BlO9\n 2bSnV/APiIVFjw8WdPbqbZwSLNAOpEtJnDqX5R8ZDt6Y4ddGXhOf+ikVmmso5TsN\n 1PDnJQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1777503842; x=1778108642; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=YiPw9t06smp/3niIbpzodDGXxTn8teJ1hDjW5pUWHco=;\n b=E5n10V9Rc5rbuG/FqkhQ9kOPq4cgAfnz5Zd4kaHVgTc3TcPA25wzCWsmVLugdmwZRz\n N59YTZ5+mE+4J7zHSL1J6Uugf7YrMpIrHZVfKObql2xjliVnnL76Cq+COxU9EBkuJ7hE\n j8JaJsAfy8VNaPC9d3RAOt9EW9lU1Vl/bK7y26d692AvZiemKPjofxZaKBd11k+dngLT\n 2pjITM1spg6u6iXy0g4XOH2SPpWTabApzyHyhtMB5XqHMtA4rgYmOhP5AOYB15niX+cc\n lqUg1j+t4AsN4QvEXDKpf+g4p60n3kLfI/ANxLrt0Wc1Z7d1uWEj7grqrB07JnJFewIC\n yzUA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777503842; x=1778108642;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=YiPw9t06smp/3niIbpzodDGXxTn8teJ1hDjW5pUWHco=;\n b=O60nwtfoN710gQvBWiXMl1ry5BEihEablSAyNVnbANi48SuoAOG1y5ndP0K+g4O79u\n 55/cpzrurFuTUjAZDBClUXReQUrBUoJw72y9p4BjnZSOGDASlkewtO8gVaBcuf2asNg5\n SdohTg8is+WU/q4aKkrsBzomPOg25XgZxcHohBWma2Ip8fbygEiNUE/yXjsd021F998F\n 3VStd3/HOKEKzfPUqYD2DYcu19NIW4zASVBsjXNtfFc28KYOsO+xyrE6+GtNRvzu6T/f\n u1bxuO10+rxhxgPaXMzlL8aLCJT2t4mCBeuJopXrXIzSRrAprxjwYgP2Wb268EyU7s5b\n EeVA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+CzUqBMK03JZm7ZfgVZjHY6h7qBhU02XRrQPBPIgs8cAdwXKN5R//3JsWy4W9E+DykdoLF3soNGP7A@nongnu.org","X-Gm-Message-State":"AOJu0YwG681nLGlScQnw78I24wHu+l07F7UR22SnLBxu/QtPgBaqHp9c\n HeKvQsQweVkSHWMT6BaNPYFg620j69VMKpN5suLvH4lSGsp4FjgiHzbPr+nqK14yEuICChoFsUi\n We5GPdhnFBu8nMGJwV2yRSvlZeJ+k9VuAjQlGHZqfcEG82XgUqoyp00sL2Q==","X-Gm-Gg":"AeBDieuBQfB9PO4lbxewZWp80v/uWOs4iWjzmSeyRkIW0ppvR8n7iAh2/gIa0GYsDPB\n /zJwBarPyiTutTCJZMlxlNt5YZH2fI9T7HauInrUVRyEfZUTO9eRP3c6L0anGx4G/J0vpdYoDwT\n VdedKHTksO9IxE8QiwYSdcdCGlJCJtHIBniT1nl922NGQ/C5xqeUUgvW/9qatBpjh8mbSSvQOWk\n cyzxayvF5Ac0JwkS1frVqzZzjO0jOBit+0ZJGlHlK9K1wAFyH4AQj38BSOG8wL/oOe252LhoMg0\n 4qwJAD/RjQDTTuMWOGKvo4nwENoSP0d3rj2AAwCHp9MQL9TCgLG4WvuYxN/lRp/0xmkZjLJLSvY\n VSIfCDgm3/XgwDBiXpeyDua4VeKssfClG/WTYhki0nJHgqtp9Z03fM+xT50j722TLegiyCM6n/0\n 3vnCKWhJrW27G0+dbtlAfagsLx","X-Received":["by 2002:a05:7301:e0b:b0:2c5:50fe:c78f with SMTP id\n 5a478bee46e88-2ed3c7c823amr133132eec.12.1777503841816;\n Wed, 29 Apr 2026 16:04:01 -0700 (PDT)","by 2002:a05:7301:e0b:b0:2c5:50fe:c78f with SMTP id\n 5a478bee46e88-2ed3c7c823amr133101eec.12.1777503841150;\n Wed, 29 Apr 2026 16:04:01 -0700 (PDT)"],"Message-ID":"","Date":"Wed, 29 Apr 2026 16:03:59 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 15/17] bsd-user: Add do_ioctl_in6_ifreq_sockaddr_int\n function","To":"Warner Losh , qemu-devel@nongnu.org","Cc":"Kyle Evans ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n \"Stacey D. Son\" ","References":"<20260429-ioctl-v2-0-288639bc2427@bsdimp.com>\n <20260429-ioctl-v2-15-288639bc2427@bsdimp.com>","From":"Pierrick Bouvier ","Content-Language":"en-US","In-Reply-To":"<20260429-ioctl-v2-15-288639bc2427@bsdimp.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-ORIG-GUID":"QTwxjDWovn0_-SVnosH7jW0IAHB9kqQd","X-Authority-Analysis":"v=2.4 cv=RI6D2Yi+ c=1 sm=1 tr=0 ts=69f28e63 cx=c_pps\n a=cFYjgdjTJScbgFmBucgdfQ==:117 a=iLqgmErQAxjCjdq5jj1Aqg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22\n a=6I5d2MoRAAAA:8 a=7Qk2ozbKAAAA:8 a=EUspDBNiAAAA:8 a=kpqsSCUBY61UU6rk4iUA:9\n a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 a=1lyxoWkJIXJV6VJUPhuM:22","X-Proofpoint-GUID":"QTwxjDWovn0_-SVnosH7jW0IAHB9kqQd","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI5MDIzMSBTYWx0ZWRfX2IQEcul+vtKa\n bpg3DKRTJiyFgRwKavee4LjpDvbcu4o0iupAsO+vfm42GU6G0JzlORMb78ZDiW1/CVzXlcSXbL1\n uakKr0uUEZ48XLO8hlbiv+zAEMXBBRi51GCy6hWZUxiV2BQMNFVzfogK6AIBxzBZFzStLbve7Xo\n b4ezgYOhtGiTgR1hyo+oIP1fdo5YdceV8Uosb+MJK5u2fxrqxRMvgtE6BqDwiHu9yl9jxsYupV9\n 3qRkjdkkDBCejZRJ46oJilHyspcEg8mZ1ylbyGAxfAY7six6vNgeFLEpZEHpnj/4LOqDwPYPJMq\n +F1jGGZD5H512TKqDLfT/fNELk5LqcBQvYwFHElpvzYwdXokZpzxXP+1qqSv+6wmH9hhoO9lO23\n jBAxZK6Nm+/CanHqUxjO/bJQ8EAxQCfAY4KGTPkWd28+w4/mAq+vOhn/OFDfBi+vpxvlc51kYyK\n aXCRHLHt7EZmPRBysfA==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-29_02,2026-04-28_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n phishscore=0 priorityscore=1501 malwarescore=0 suspectscore=0\n lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604290231","Received-SPF":"pass client-ip=205.220.180.131;\n envelope-from=pierrick.bouvier@oss.qualcomm.com;\n helo=mx0b-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]