[{"id":3684050,"web_url":"http://patchwork.ozlabs.org/comment/3684050/","msgid":"","list_archive_url":null,"date":"2026-04-29T13:13:34","subject":"Re: [PATCH v2 5/6] tests: Check whether the I2C master flag is set","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/people/91136/","name":"Arun Menon","email":"armenon@redhat.com"},"content":"Hi,\n\nOn Wed, Apr 29, 2026 at 12:17:42PM +0000, Stefan Berger wrote:\n> Replace the 'once' variable with a check for whether the master flag is\n> set so that the flag can be set when needed.\n> \n> Signed-off-by: Stefan Berger \n> ---\n> tests/qtest/qtest_aspeed.c | 9 ++++++---\n> 1 file changed, 6 insertions(+), 3 deletions(-)\n> \n> diff --git a/tests/qtest/qtest_aspeed.c b/tests/qtest/qtest_aspeed.c\n> index f6da9adea9..7bf5abb9be 100644\n> --- a/tests/qtest/qtest_aspeed.c\n> +++ b/tests/qtest/qtest_aspeed.c\n> @@ -15,18 +15,21 @@\n> #include \"qtest_aspeed.h\"\n> #include \"hw/i2c/aspeed_i2c.h\"\n> \n> +static bool aspeed_i2c_is_master_enabled(QTestState *s, uint32_t baseaddr)\n> +{\n> + return qtest_readl(s, baseaddr + A_I2CC_FUN_CTRL) & A_I2CD_MASTER_EN;\n> +}\n> +\n> static void aspeed_i2c_startup(QTestState *s, uint32_t baseaddr,\n> uint8_t slave_addr, uint8_t reg)\n> {\n> uint32_t v;\n> - static int once;\n> \n> - if (!once) {\n> + if (!aspeed_i2c_is_master_enabled(s, baseaddr)) {\n> /* one time: enable master */\n> qtest_writel(s, baseaddr + A_I2CC_FUN_CTRL, 0);\n> v = qtest_readl(s, baseaddr + A_I2CC_FUN_CTRL) | A_I2CD_MASTER_EN;\n> qtest_writel(s, baseaddr + A_I2CC_FUN_CTRL, v);\n> - once = 1;\n> }\n> \n> /* select device */\n> -- \n> 2.43.0\n> \n\nReviewed-by: Arun Menon \n\nRegards,\nArun Menon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LfraV+ay;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=eEWdCCRw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5J1725xrz1xqf\n\tfor ; Wed, 29 Apr 2026 23:24:09 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wI4se-0001ZM-34; Wed, 29 Apr 2026 09:23:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI4sc-0001Z8-Q0\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 09:23:06 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI4s9-0003gB-DB\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 09:23:06 -0400","from mail-pj1-f71.google.com (mail-pj1-f71.google.com\n [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-335-p5Ow9IlOOmSsOmLYjudzbA-1; Wed, 29 Apr 2026 09:13:43 -0400","by mail-pj1-f71.google.com with SMTP id\n 98e67ed59e1d1-35d99c2908cso12142334a91.0\n for ; Wed, 29 Apr 2026 06:13:42 -0700 (PDT)","from fedora ([49.36.110.142]) by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-364a4152038sm3253907a91.2.2026.04.29.06.13.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 06:13:40 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777468741;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=R80XNyhECYyHOqYawSkigCKtybqAUxewXFMHZeRfyKM=;\n b=LfraV+ay4g5+nvJFNYRlbFqQapgrzjpZjvVk1UHX2grc9MR+OkN4rlVo9X3tbssqw5s/Bc\n /jA/sC9HcX56zlPzTQpXXQNz6mN64wboYA1NI2wcSIUlqs3Ujlg1yiMDEKCiDuTk4lZSJx\n v7r3pwRbps03et9XryHYvjI14VvrxhQ=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777468422; x=1778073222; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=R80XNyhECYyHOqYawSkigCKtybqAUxewXFMHZeRfyKM=;\n b=eEWdCCRwm8Prc/umdboz1oGRx5DUlrJVmmb1ErR2LTEXMU04Llx1+AnGqIK4jPj/19\n g+mqZ2LSYN3xvImhKzIzzrv7Xh3fyLdKqNx3GHeZHm4DNXSqxHNKfNq8lSXGpNUzmXML\n BO9th/fHiWyargWIxN7o4zMGMX/D5CVh4vy89aL5JcQL+0cJJcLy50dYsUUQXMNkSamj\n il2hrufrCEVwaPbvgd67SiPfS8St1BWKPYD/Dut22E/6Vbp1U+YrVYQZ7Mp8R+LU7qtL\n ssDY3b9K95TWIQzIXFu4woGuKhXgfoGeze5sF9wpWpm+3FzPw8bwKu5zaqXs0KkluSUr\n wloA=="],"X-MC-Unique":"p5Ow9IlOOmSsOmLYjudzbA-1","X-Mimecast-MFC-AGG-ID":"p5Ow9IlOOmSsOmLYjudzbA_1777468422","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777468422; x=1778073222;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=R80XNyhECYyHOqYawSkigCKtybqAUxewXFMHZeRfyKM=;\n b=ay74QwFOQp7bh6ZFTMR4L5djCDQ5O68B8UyuyyeLSy0w2KvawjSAEx1jqU9rV01XlK\n +4DYlwY1j+Gjo6KzA3xWtEZuxxoMx3EIlklWiQCWV4/xinEUtTVZ5uTaRjssfTNZoCn5\n jExvQQapcszAbZYRxFtisZ++EH+J85UIz1PBmLj7pP8DIFXpdSqWStobxG6qsrgoDXsD\n HzinUqAhGhwo6UzqRA5Pxbos/w/bPhUgiS5GY+DfeCq0Mq6CFxc2PFMLliZIsWS2p4Gw\n ++ctXYjaV6m77wrrtYzUTHKZG883YgCTb9/Q4l9+rx4BWeOdsQaFOASVkFWNH0T9qzNG\n S7tQ==","X-Gm-Message-State":"AOJu0YwGvikRBMPfzAJQ0Tn9UUkpdhiKoP/Qs3BMj4UdAgVO5CkhILzE\n ni/y1B/LldCeI+WxzFYYMx6ankYejpWjgBmiFRX5Gg3xIfaYkNosd3YUHlzroNMB+1DKLkt5OiG\n Sn3+QB0MP4ToYFwdYJS/sjCZat8XrObfo890blEz7X0N99gR6qEa01GH1","X-Gm-Gg":"AeBDies0+KN3uWP8EFg1rw+JZIlomyQR5rGCQ4Ak0Qe+sb/QaAFK2NVpw3Za3BHLrL5\n nQjFwtoB5ZHkX4KTz3S8cqvBsGpHHBP6Yt5qiAPDXsC4ttX5rNpEAQ5FvsVASQqp6NgnIhnscIO\n g9zvVdBGk1thjbY1I/7zOoNbGtuMT6V8zGWm0VcFiWB+jnmzCc9f4W/dpxHVoZI4jpCSLQ5H3dC\n M+oC99vQZtS12erHhh+xzOTkdAAA/Dd+STzZe8YMCoB4W/J4s152GmuDIaOx6n6ML2FpdRTwin6\n n95nerEbGVuBz8KijKlwW31SeGvJI5A5YdF2f+KT79lTJdKwRCLC/2wgOJcDnlgGaO05KVmCBYR\n udCpObtJcvkEGwuQfyn5FVPc=","X-Received":["by 2002:a17:90b:1d51:b0:359:8e5e:43de with SMTP id\n 98e67ed59e1d1-3649203b479mr7587215a91.22.1777468421648;\n Wed, 29 Apr 2026 06:13:41 -0700 (PDT)","by 2002:a17:90b:1d51:b0:359:8e5e:43de with SMTP id\n 98e67ed59e1d1-3649203b479mr7587189a91.22.1777468421227;\n Wed, 29 Apr 2026 06:13:41 -0700 (PDT)"],"Date":"Wed, 29 Apr 2026 18:43:34 +0530","From":"Arun Menon ","To":"Stefan Berger ","Cc":"qemu-devel@nongnu.org, marcandre.lureau@redhat.com","Subject":"Re: [PATCH v2 5/6] tests: Check whether the I2C master flag is set","Message-ID":"","References":"<20260429121743.1346635-1-stefanb@linux.ibm.com>\n <20260429121743.1346635-6-stefanb@linux.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260429121743.1346635-6-stefanb@linux.ibm.com>","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]