[{"id":3684022,"web_url":"http://patchwork.ozlabs.org/comment/3684022/","msgid":"<20260429122610.4065-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-29T12:26:10","subject":"Re: [LTP] icmp_rate_limit01: Fix rate limit change on older kernels","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Martin,\n\nOn Wed, 29 Apr 2026 14:11:27 +0200, Martin Doucha wrote:\n> icmp_rate_limit01: Fix rate limit change on older kernels\n\n> +\tif (!access(\"/proc/sys/net/ipv4/icmp_msgs_burst\", F_OK))\n> +\t\tSAFE_FILE_PRINTF(\"/proc/sys/net/ipv4/icmp_msgs_burst\", \"50\");\n\nSAFE_ACCESS() exists in tst_safe_macros.h, but since it calls tst_brk()\non failure it cannot be used here — file absence is the expected case on\npre-v6.12 kernels and handling it gracefully is the whole point. Is raw\naccess() acceptable for this feature-probe pattern, or should a different\nidiom be used?\n\nPre-existing issues noticed in the surrounding code (not introduced\nby this patch):\n\n- testcases/cve/icmp_rate_limit01.c:203 — sleep(2) in packet_batch()\n used to wait for ICMP responses; consider a poll-based approach.\n\n---\nNote:\n\nOur agent completed the review of the patch.\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=MP9sa/vh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5GkP00R0z1yHX\n\tfor ; Wed, 29 Apr 2026 22:26:20 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 5D2453E210E\n\tfor ; Wed, 29 Apr 2026 14:26:18 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 41AE43CB251\n for ; Wed, 29 Apr 2026 14:26:14 +0200 (CEST)","from mail-dy1-x1342.google.com (mail-dy1-x1342.google.com\n [IPv6:2607:f8b0:4864:20::1342])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id B5B981400C6B\n for ; Wed, 29 Apr 2026 14:26:13 +0200 (CEST)","by mail-dy1-x1342.google.com with SMTP id\n 5a478bee46e88-2d96243c91fso20481984eec.1\n for ; Wed, 29 Apr 2026 05:26:13 -0700 (PDT)","from\n runnervmeorf1.aemngpi4zd0ubehhx3cejhsp4e.dx.internal.cloudapp.net\n ([52.190.141.35]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ed1c0e9a89sm2568560eec.31.2026.04.29.05.26.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 05:26:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777465572; x=1778070372; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TN4/5+Yg45F/V2QpwFVkPUcsG788Do51T9tx25Pyefs=;\n b=MP9sa/vhLFkl8H5RcCohJH9GlixKuJX6WArPgJN7cytcjD4HcCtsyYxcY/HNSXQSJV\n 0AQI9M2UAGPb3JrJ19y5Xv0d5nsiTJGJpVVhA9ynuo3Ilf65NFhdKYNo3N4MMwf84q1c\n Hf9hIcsuOVLomNMYsH3b3RgGBJbbUIoJUdBBWpn0z8YLlboKJUfuoc/VOerNd3vTTuvq\n BK65y91VnVGRCkf+AslxdjVrKf+IyZ53oYAN45/KORBPr2kpC7tHPXf7o8P7YYRqPrb/\n MVV8dl3iO0hYYvXxIQaIkgDWf+WtipC6FxTBpuTjai1KbsHETaioDs3pEaV0GGKjtwnd\n Z92A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777465572; x=1778070372;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=TN4/5+Yg45F/V2QpwFVkPUcsG788Do51T9tx25Pyefs=;\n b=U5E2a7R0BesjsuQBLkSJYxjpaD6CfCV0tHMZLaI8wVyp5/+vdhlSW4vmOoK4Ld/CIW\n Y5xOobscOxL+eDK5OZu+aFX4prCTfNTBizHViOtJk33zMAJekcbbhX4Kv/N+6I7eoGCv\n bVBOtDApEbkBqfZ/yDXziNctNavDIyEV9lO64bbOO4SG6zR2hwOYow9Y9kazgSgyUUFo\n WXYc8XO6K71oW1AXSsrdbur8qrkhwMFCm2UWSNg+8uk2GAAPj2qyICALDfFCLiTKv6ut\n QsEnGxuEg/W+OetM+KBy+k+0kX142v1sYiYXWFpBPCOpORPUYVsvhsLQNYS3uKw6ViPO\n 1U0Q==","X-Gm-Message-State":"AOJu0Yy4Hud68rud9exHIjVEoTjs6o3Uul8echxkhxzRcQeIOcSfKTk6\n M9kBfyoZR9qx7ly57imaXMcfS03cTXW8sPv8hAywkzNiTtmfxwxg/hiL","X-Gm-Gg":"AeBDietT9BsC35P7kxLxXqjUubQMmZxynQ6wcsi1c12dfHl8Zwr0wPd/X+r8WQEqZ/U\n s8WuO0gA74KgUZ6WmA+LEVDU7aCNNLo6h5VBrd0/K31aELAamhA0x+HD0x4g7xjiCiFw9lHz6MJ\n C/czBOoq0M+uujOsZhJAZuyLZ2l5nh+wTXNPCkpmI10Xw7IKjHzhckn+ZtT54QOatSTKgLXYB4I\n JjvqC86FCih4X1F0ueQpaC3MrbuXEwqUruD8K1rLFPRmq9FFHHegAhexrgfzinrcwmL3Ofgg84p\n lD7xnbjUo0HXfz4QoxUuUfCGRgRBk1gRipZ5kRyOq9Kk4ZK0AybFdiR3Qi+M8w1L+tLjI4t3ZSv\n GSSE5n7TanZ/LbOA0B07sfvNLEdBsvXAOkVJcIopqtKIAWHB9IAEqE3wUFFb85MTR6nXwSJcRAc\n wd49HoHN0XkhmNEiL/aJQjdWId+uPDUFg5KB+NSQ178iVp9KGrw0eMSu8Ruk2cd2zh/o08Ph3o5\n q96FY3/84uvA4OZ3a9XCDehZa8Bwh7kUXy8dISRCPiZZ/j4Yg==","X-Received":"by 2002:a05:7300:2141:b0:2d1:299f:521a with SMTP id\n 5a478bee46e88-2ed0a1871a7mr3327881eec.26.1777465571913;\n Wed, 29 Apr 2026 05:26:11 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Martin Doucha ","Date":"Wed, 29 Apr 2026 12:26:10 +0000","Message-ID":"<20260429122610.4065-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260429121129.21911-1-mdoucha@suse.cz>","References":"<20260429121129.21911-1-mdoucha@suse.cz>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] icmp_rate_limit01: Fix rate limit change on older kernels","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]