[{"id":3684253,"web_url":"http://patchwork.ozlabs.org/comment/3684253/","msgid":"","list_archive_url":null,"date":"2026-04-29T20:45:59","subject":"Re: [PATCH v4] smb: client: fix state-consistency bugs in\n smb3_reconfigure() multichannel path","submitter":{"id":89563,"url":"http://patchwork.ozlabs.org/api/people/89563/","name":"Henrique Carvalho","email":"henrique.carvalho@suse.com"},"content":"Hi DaeMyung,\n\nThank you for the update.\n\nThis version is better than the previous one, but I think it still needs\nsome work.\n\nFirst, `mchan_rc` appears to be vestigial in its current form, so I do\nnot think it should stay.\n\nSecond, I think remount/reconfigure should be all-or-nothing. If any\npart of the reconfigure attempt fails, we should not commit the rest of\nthe changes, otherwise userspace gets an error without a clear view of\nwhat actually took effect. As written, I do not understand why\n`scale_busy` is handled specially while other failure paths are not.\n\nLastly, please shorten the commit message. It would be better to follow\nthe style of nearby CIFS commit logs.\n\nThanks,\n\nHenrique","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=VLSmlpvv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11297-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com\n header.b=\"VLSmlpvv\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.49","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=suse.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5TqH2mRqz1yHX\n\tfor ; Thu, 30 Apr 2026 06:46:19 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 46FD430071F8\n\tfor ; Wed, 29 Apr 2026 20:46:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7B6813A3801;\n\tWed, 29 Apr 2026 20:46:13 +0000 (UTC)","from mail-wm1-f49.google.com (mail-wm1-f49.google.com\n [209.85.128.49])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0261A3009C7\n\tfor ; Wed, 29 Apr 2026 20:46:11 +0000 (UTC)","by mail-wm1-f49.google.com with SMTP id\n 5b1f17b1804b1-488b8bc6bc9so1113315e9.3\n for ;\n Wed, 29 Apr 2026 13:46:11 -0700 (PDT)","from precision ([2a01:4b00:c007:bb00:be9d:a3c4:18b1:4a25])\n by smtp.gmail.com with ESMTPSA id\n 71dfb90a1353d-573b6b7d4eesm1871652e0c.2.2026.04.29.13.46.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 13:46:09 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777495573; cv=none;\n b=Rs/0MJdakxysOuGN1unLRzQrewfUcTKiIaJ64xC7v9IQQCDngVnh/7tg+Y80CUaufb3Ln7hvLXQKdRrbCQuOfElklAKd8lmsq+j3u3NkIbK7unkqMjvaQY4PHvTfUW+6IfSsFzM0Utc5852D5xzd2kEFMK3KOOm0zC3aiNdscSY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777495573; c=relaxed/simple;\n\tbh=zl1e9ZzqOUMtp/cDxIw1N0nsCcf87S2hObyRsrFDNj4=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=MZcTW5B7sFmMC7ZuKCpR4t7udgoPnZBTEwmZz/0Nq80b7V4DS9zLg/5KjL8Q3fRmfXPvJhrPoqVXQ4r/ElvccSU8BiAy0NupDdDXx0Phqg6+k9ye2lw+cs1ybx4bTMJwY8ml/4SlaKDLBX4Th0DUTYhH8XBwZjF4HrXMzWDauUY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=suse.com;\n spf=pass smtp.mailfrom=suse.com;\n dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com\n header.b=VLSmlpvv; arc=none smtp.client-ip=209.85.128.49","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1777495570; x=1778100370;\n darn=vger.kernel.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=zl1e9ZzqOUMtp/cDxIw1N0nsCcf87S2hObyRsrFDNj4=;\n b=VLSmlpvvS0A6Bx4DeqiGmyHdg7hhUg5o4kg3xBtKJSHfezNcJGLK6Wq0QTHBElQsYR\n 16hQfNwxvfEPDGzMgDV5fSolNlGXtyxx0N2JezmwSLWaJ2fVgH/ojy1oEsZUgl+xsmtV\n 7/6gtq5+wFoiMQAMiCwHkuczboldi6YC9QbhKaAWxOe2CERD7yZ4x5uqoCYJVXOo3B5o\n H8HfakrYZRR8KLRBz6Az57T+rM9oXuTybuxzhcfKb1jUWGx4MOB5edeiJcZ9Okb6DNtw\n +2NamIW1TmWzL15ylnokOvEWZDXKx6VUGac3CajDtodt/ZT8PQHfpMIDfcpEfFD0rQXh\n QVVA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777495570; x=1778100370;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zl1e9ZzqOUMtp/cDxIw1N0nsCcf87S2hObyRsrFDNj4=;\n b=fdzF8mARoKrITpRPMuFmjyFWSYl/rBaWIJGemJJQxV8doi/WkL93eFxQ5CdPDpNvO5\n lE1jGw9jRwJepck4XKgNMWyN2qqSxeJX7tP0/WZNaXq120TvMuSN/C7pV6PBws5MU4oU\n kB2ZT/Djnp6trAiDkkceEAPMhIltqXZ5sJ89zLqbB0aYO+9nvD278QdFaFeZTChYnAT4\n W7X+T95NRHHcrqo6rqpUo/boUWKHJdd4n0DkPnJJ3WjS8TjVqgDJisiO6+V6+ZsBDf6P\n w+gqS61Px0VowToj2PITQC4bWPg5QGWYtjfxiVGS8qvcs5dcDTAZfxMyXtUKRC0VjgGK\n HrUw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+QS5IyLIIENQX/okyIhVfcd7z6npDhCFdbtwBerBfEpca8Ao+MWCBoONgoOTAxARs4PanbkfPjtyb6@vger.kernel.org","X-Gm-Message-State":"AOJu0YwiV2rq0bOmQF/oNQkccWHZpqKu50Jfiayj/L9rYhmB52umf7Y5\n\txTdFZ2Jamki+aqHmQknFVZirkVMdQc7lu0eg0jbYNm0khSpe6z8ozlVSrzXXc9Y8IBs=","X-Gm-Gg":"AeBDiesAzz+3vB3/xIB6p6QVVedjFY7WxDbCuGB22sqkJAVbnNZquK38oyKYeSHRwUa\n\tQnfo9/yJ6YKzgg2nljJUDYwXIC7soa+4hEr8JqtKUnK7lqaXnDUqvwNP/G9oEOQYCtCK+gv/zkh\n\tNWvM/q9JzxFUT7FPX6ZpmSEKowKRwotuJoZqBy92uyCvN94WhegsV/JdnNwecTfzboxbvhZ0wVF\n\teP+k/C4G+jFdy0JM0av2ClDJTyA8PJvq20tOSaeqapjt5lHB7p70eCy1X7iLGDce0Sysy2KIZxm\n\t5e/OrOUiYxXj5MHr2n8hk5qXI9RPfuDe0mDPbK6LeoveOcQMyfDvdUgw+Z56MMbEtqIH17Ygf0k\n\taiZIwCxNB35mAL6h48WDwddI2A6/srx1F225BTXCe8NVeEcQQ3nFxqtGsl9/i3TL2S/Pu6qXpSW\n\tL8Fh1Gmwn1LaqTC7IK6pi9kBYkr7qLut+KSuex3jMn01wq","X-Received":"by 2002:a05:600c:1f8e:b0:488:a824:fe04 with SMTP id\n 5b1f17b1804b1-48a8447f466mr1852815e9.26.1777495570184;\n Wed, 29 Apr 2026 13:46:10 -0700 (PDT)","Date":"Wed, 29 Apr 2026 17:45:59 -0300","From":"Henrique Carvalho ","To":"DaeMyung Kang ","Cc":"Steve French , Paulo Alcantara ,\n\tRonnie Sahlberg ,\n Shyam Prasad N ,\n\tTom Talpey , Bharath SM ,\n\tRajasi Mandal ,\n Rajasi Mandal ,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v4] smb: client: fix state-consistency bugs in\n smb3_reconfigure() multichannel path","Message-ID":"","References":"<20260416151839.3315696-1-charsyam@gmail.com>\n <20260429121013.1696901-1-charsyam@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260429121013.1696901-1-charsyam@gmail.com>"}}]