[{"id":3685111,"web_url":"http://patchwork.ozlabs.org/comment/3685111/","msgid":"<20260501122756.GB15617@horms.kernel.org>","date":"2026-05-01T12:27:56","subject":"Re: [PATCH 1/2] net: wan: fsl_ucc_hdlc: fix uhdlc_memclean","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Wed, Apr 29, 2026 at 01:42:07PM +0200, Holger Brunck wrote:\n> Unmapping of uf_regs is done from ucc_fast_free and doesn't need to be\n> done explicitly. If already unmapped ucc_fast_free will crash.\n> \n> Signed-off-by: Holger Brunck \n\nAs a fix for code present in net, this warrants a fixes tag\nthat cites the commit that introduced this bug.\nPerhaps this one is appropriate.\n\nFixes: ca20e191eed0 (\"net: wan: fsl_ucc_hdlc: fix ucc_hdlc_remove\")\n\nAlso, as a fix for net it would be best to explicitly target that branch,\nlike this:\n\nSubject: [PATCH net 1/2] ...\n\nI don't think it's necessary to repost to just to address either of the\nabove. But for reference more information on the Netdev development\nprocess can be found here:\n\nhttps://docs.kernel.org/process/maintainer-netdev.html\n\nThe above not withstanding, this looks good to me.\n\nReviewed-by: Simon Horman \n\nFTR, an AI generated review of this patch is available on sashiko.dev.\nAll the issues flagged there seem to be pre-existing and I do not\nbelieve they should block progress of this patch. But you may want to\nlook into then in the context of follow-up.\n\n...","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=S3ywNExU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20362-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=S3ywNExU;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=horms@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6VgZ6FJrz1xqf\n\tfor ; Fri, 01 May 2026 22:28:10 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g6VgS1xpHz30Bd;\n\tFri, 01 May 2026 22:28:04 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g6VgQ3y2Zz2xWY\n\tfor ; Fri, 01 May 2026 22:28:02 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 1523A60126;\n\tFri, 1 May 2026 12:28:00 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7C625C2BCB4;\n\tFri, 1 May 2026 12:27:58 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777638484;\n\tcv=none;\n b=g1xUCbVHnBmfF3W1kM91IbRC7+dyGf9Y8npRRGneYxPGaOY604UZdRxD/nYJsMPoLrw/vj7vTL0rlnGr5a/vuSGL0vGyVD8PXchNugnjNGSDZgVuL4t3Tx7Edtn3O47csgcjUvz1u+kl5kXvC8TUM7gmhKlYoSAyY5+dnEVZbsYYLgO0pwH+F6zZl23rZrXC14SnQNLqoNMLSKqYIHQGDoQ6icZp/JuOcqOPFm4LdLhYSdN/NgFTcrkK5aeziXP2WxtITdOwNZju09sW6dzDAsTesvxuw8NypCfQQcPR+vrvXGW4LqPYjiEGhp/DRX7cfhOn0++s2D7gos4o7tl4QA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777638484; c=relaxed/relaxed;\n\tbh=AbSReR+I1Yt1K1hRuf274vwb+5+jTP41Ywe9J+9tWBQ=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=HUPS+rlFci5jTLKm+4r7OwSrYR0treiXt5Jhk6LysaCLZBI5KMdZt5ETeekUae/D3tj5sfd6J/JtYn82aTZXGVk1KmSe+7aTa7e3HGKbSL08h9ss6VIoATbyhYjD5S5LURxgnoRmurP8DXfVhXj6ZDImrLcqU9S3EwUW7A6LQTijFWhZYCXj9KqcoFeHJNxKtAAnXW3n+CA/yI1ra73LeJdVlV6vVF7TbF79APkvy+6VplEpLqKZt93t6ApBbZwB/8z7yGEyNYbufYiN3NuBHVDkkQFHJe+rgs79tWsjuOA3047J7rWo2Uhbs761fOfFzX1Bib/aNFyOj1VwGtYccg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=S3ywNExU; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=horms@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777638479;\n\tbh=5lT6TRvgI8koPXV5OrJFxLzqZFSDbD429ThALkAUV5E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=S3ywNExUj2rzEoONYig+O5R/gH4E4ylYWyD1Q4XffE93Bn70bImrpG29F2WbHGP9g\n\t k1Q0utKUddFKMo71CQGsHyV5fJqSIJvfer2braPRwRiMO96oeVgFcVfnQ/3KiLUDrd\n\t toWkkruv1TnGP2NHecRVAl66yd9/VlybHG7lr/gVFaF3dLOFcbonIAGN4YPAiniOVA\n\t B+9nw1HdiDlheCg4wCTyv+nl/F2I5DuTOngZNz/EMlqo2ki8W8E76s3io2tZl/zcFM\n\t 20rW5X56AY+LnJBVf3OGL4DyA3Plz5bQvbWjpfpzMXUwD21+3afkWDef/DEU5rOZNr\n\t DuZLj/wvEx9+g==","Date":"Fri, 1 May 2026 13:27:56 +0100","From":"Simon Horman ","To":"Holger Brunck ","Cc":"netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tandrew+netdev@lunn.ch, chleroy@kernel.org, qiang.zhao@nxp.com","Subject":"Re: [PATCH 1/2] net: wan: fsl_ucc_hdlc: fix uhdlc_memclean","Message-ID":"<20260501122756.GB15617@horms.kernel.org>","References":"<20260429114208.941011-1-holger.brunck@hitachienergy.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260429114208.941011-1-holger.brunck@hitachienergy.com>","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]