[{"id":3685112,"web_url":"http://patchwork.ozlabs.org/comment/3685112/","msgid":"<20260501123555.GC15617@horms.kernel.org>","date":"2026-05-01T12:35:55","subject":"Re: [PATCH 2/2] net: wan: fsl_ucc_hdlc: fix ucc_hdlc_remove","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Wed, Apr 29, 2026 at 01:42:08PM +0200, Holger Brunck wrote:\n> If the driver is used in a non tdm mode priv->utdm is a NULL pointer.\n> Therefore we need to check this pointer first before checking si_regs.\n> \n> Signed-off-by: Holger Brunck \n\nHi Holger,\n\nI have the same feedback as for patch 1/2:\n\nAs a fix for code present in net, this warrants a fixes tag\nthat cites the commit that introduced this bug.\nPerhaps this one is appropriate.\n\nFixes: ca20e191eed0 (\"net: wan: fsl_ucc_hdlc: fix ucc_hdlc_remove\")\n\nAlso, as a fix for net it would be best to explicitly target that branch,\nlike this:\n\nSubject: [PATCH net 2/2] ...\n\nI don't think it's necessary to repost to just to address either of the\nabove. But for reference more information on the Netdev development\nprocess can be found here:\n\nhttps://docs.kernel.org/process/maintainer-netdev.html\n\nThe above not withstanding, this looks good to me.\n\nReviewed-by: Simon Horman \n\nFTR, an AI generated review of this patch is available on sashiko.dev.\nAll the issues flagged there seem to be pre-existing and I do not\nbelieve they should block progress of this patch. But you may want to\nlook into then in the context of follow-up.\n\n...","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=P24Mo1II;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20363-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=P24Mo1II;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=horms@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g6Vrf4Hgsz1y04\n\tfor ; Fri, 01 May 2026 22:36:02 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g6Vrf2y9Jz309S;\n\tFri, 01 May 2026 22:36:02 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g6Vrd54wWz2xWY\n\tfor ; Fri, 01 May 2026 22:36:01 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id B002160126;\n\tFri, 1 May 2026 12:35:59 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 24CD0C2BCB4;\n\tFri, 1 May 2026 12:35:57 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777638962;\n\tcv=none;\n b=otPTm4H28l38edC2ZIerhW9stT2CxdxXSkWB4P8OfivOlxgjm8ax+ld7T0U82swaD8vktyXWiIo0sYUvA4NB1VQ3WY27Os+SsrndKZv+Q0upz24f6PR5xMXkZCirnF8w/VSufI6CB4MitG3c01vfIt7RFux6/rqGN1rakw2X3ClXUPz0K7pI4WR6KgwS3nn2LZGtgzuvxH8zcCrlEM7Ac/5r+Liv1DuV3MBDny0n68i2ov/nK5yqSbq0IuUqdhwTzhV/a7QJPrfIhQs6DpvDxid+KjgOdSPPXrJz/rsOGt0A8SBxIJKolkbQTK1VG6TFu3SuP/tc5EDgBbq1+6nf4Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777638962; c=relaxed/relaxed;\n\tbh=+K2jQAl8Hv/LPmM5NOSPiAMmtoZuqIiApcMhc4jYUBw=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=iZ7q4kRISEW44LgTSNmIat19QzqoEUcMNf7H86mrlBZ4nCRMDLvRWO8DkZOUQNbJlf537sS3H8hqlbdC8mSnBTHAr6K3rs6dkRn0lVn7ZrvIHmd44bLw5kccKMUdtBCm4ajw9m/lXvmkrEcWL1HQb2TeFasE3EnhjwheT0l+spmUjW5se32DSgR9fWG6JAGp4DIdsaXUK4Szh+EsyfHdQE5HbD2p+8vz9BbWeA/IWq79km4/B5IYv31YAOM10ZAPk1a1DnIp2d6xkAtmbNas64FfFdjHx1zdV15JTpGH915WeYNrNCBqxt8YiNaqHmvL0hgmoOFRl9C+y9NFNH8MLw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=P24Mo1II; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777638959;\n\tbh=zs6x/LEwnR68uhk/ijWwQApW1jJL4t87b71Ve+6e4Zc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=P24Mo1IIqSwDbUdn19Cf3/oy2Ut72ojBWwp/ETMZXT91XiN4IRr1onQu6mCobGA0K\n\t BszQ1jEhWnGELgzCquvA+Iqg42LzKc4+zgSMY8dzFSPQ8OF7Uh+Q2iNVVQjSzZq4id\n\t dwvxelJYGFxlbPce3b3+628jh6eAetX0gOva1fitNc2iuFGmBO0/EGRFEEfGoNrVQr\n\t nSvF/rv/vfCH8mrM7wG4PcV76z8HeTkEuwv4U0gRkC6u3YnD2mCPxPO3hOvuOb82h8\n\t AbTAoSMOyKEkgvHq1UhelRZmWeosM1EjYDxyAzWGSXN72XJa2uV3O1AS2KxFvVS9rw\n\t bRAuL2nDh5jIQ==","Date":"Fri, 1 May 2026 13:35:55 +0100","From":"Simon Horman ","To":"Holger Brunck ","Cc":"netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tandrew+netdev@lunn.ch, chleroy@kernel.org, qiang.zhao@nxp.com","Subject":"Re: [PATCH 2/2] net: wan: fsl_ucc_hdlc: fix ucc_hdlc_remove","Message-ID":"<20260501123555.GC15617@horms.kernel.org>","References":"<20260429114208.941011-1-holger.brunck@hitachienergy.com>\n <20260429114208.941011-2-holger.brunck@hitachienergy.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260429114208.941011-2-holger.brunck@hitachienergy.com>","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]