[{"id":3684024,"web_url":"http://patchwork.ozlabs.org/comment/3684024/","msgid":"<20260429123355.4104-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-29T12:33:55","subject":"Re: [LTP] shmctl03: Fix 32-bit compat mode failure by adjusting\n comparisons for compat mode truncation","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Wei,\n\nOn Wed, 29 Apr 2026, Wei Gao wrote:\n> shmctl03: Fix 32-bit compat mode failure by adjusting comparisons for compat mode truncation\n\n> Link: https://lore.kernel.org/ltp/aJm5SBOaRoe1e0PB@yuki.lan/\n> Signed-off-by: Wei Gao \n\nThis is a bugfix; please add a Fixes: tag pointing to the commit that\nintroduced the regression.\n\n[...]\n\n> +#define TST_ASSERT_SATURATED_INT 0x01\n> +#define TST_ASSERT_BITWISE 0x04\n\n0x02 is unused without explanation. Either renumber TST_ASSERT_BITWISE\nto 0x02 or add a comment marking the gap as reserved.\n\n[...]\n\n> +\tif (flags & TST_ASSERT_SATURATED_INT) {\n> +\t\texpected_val = (sys_val_64 > (unsigned long long)INT_MAX) ? (unsigned long)INT_MAX : (unsigned long)sys_val_64;\n\nLine exceeds 80 columns. Split into an if/else block:\n\n\tif (sys_val_64 > (unsigned long long)INT_MAX)\n\t\texpected_val = (unsigned long)INT_MAX;\n\telse\n\t\texpected_val = (unsigned long)sys_val_64;\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://patchwork.ozlabs.org/project/ltp/list/?series=502039\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=pBx5kqCE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5GvJ0ZTMz1yHZ\n\tfor ; Wed, 29 Apr 2026 22:34:04 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 8F4E13E210E\n\tfor ; Wed, 29 Apr 2026 14:34:01 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 924CB3C1AAA\n for ; Wed, 29 Apr 2026 14:33:58 +0200 (CEST)","from mail-qk1-x743.google.com (mail-qk1-x743.google.com\n [IPv6:2607:f8b0:4864:20::743])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 896DF1400C54\n for ; Wed, 29 Apr 2026 14:33:57 +0200 (CEST)","by mail-qk1-x743.google.com with SMTP id\n af79cd13be357-8eae9229110so118565385a.1\n for ; Wed, 29 Apr 2026 05:33:57 -0700 (PDT)","from\n runnervmeorf1.zrqr2oex231ezjigm0txkepa0a.cx.internal.cloudapp.net\n ([20.161.28.100]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-5101ae3cf8fsm16112781cf.17.2026.04.29.05.33.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 05:33:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777466036; x=1778070836; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=y6TUCEl8O9VjO+BN1cb4mF+Aa24Yt539nqdsYDMTIQE=;\n b=pBx5kqCEo11aybYHUaxndxbD64xCgq2am09UdZquU0gOmTymPyNzmUdHW/9jXnXfjY\n 0EUO6ExHt58qfsRBtmJ43BJbvmgBlY2EyPYe+ic+BpiD0mmSDAdL5AcHLxImWGvBBB2J\n h2APJbtB7RrEh0mDPoUAXg/IcsPaEP8z6L9Jl0e6+u5Nv/eyx3MDPlB0xvUrGVU61Och\n Jeqw/ss2iVlP5gJenrXdTt/c2n1Y5Y/CljmpUK8I6eB7w76yIBOZY04ze5fKyPDJ/4sq\n v1aZfZKbHrAPNe4XZw9UDhCeJ8lU+1QqySB6AzaadfhOyfdzKJSoP13YK6G3vbxJ64HH\n UaNw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777466036; x=1778070836;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=y6TUCEl8O9VjO+BN1cb4mF+Aa24Yt539nqdsYDMTIQE=;\n b=Na9geGOl90bSGgShB5i1wl55hfR6vlp7QJYRNgsZA94GeZxTKH1pPoS/jVcWLQWvaF\n mS2MP/XUnqBqHJovGIgyJoHBYK0jqb5TobqO8CZIJX9zI+bauIs6Q+j6fOXMY5soy4I+\n wqxfT8oiz2ngnTwxLngdPYeSInO5mTV8kU+nLK/NCpzZxZNfE/HIcVnrrRPsnlqsa6wt\n 2oQ/AQ8Dvtj1Z0e8h/btjF0lw8IL558aDoZpXshiTkQ6Mvp4PZr4j/d/GDndd0F+cbA4\n q6nm5J9+wExhWfVqVbLS73/T0NCgRbUrJp2reTQT8RGpNPHl7HwTmDBEmKeB9IYBb3+w\n Trcg==","X-Gm-Message-State":"AOJu0Yzzi2wH+2nJluxIa1GU7MvUGk97KH6aWfPkpwYDL3i+UxqHOChV\n Gh+OTHn1+SAw+ftUSeoE5HVW5ty4c6RtpKF8oCxz0NffmA81Mg5XnerH","X-Gm-Gg":"AeBDieuyK5EkZ8ptMNI79UTEzlDcQlV3C7sb9ABcmilpoXF2HhBxeDF8waePVx7FvJV\n WIQbAIo1pIyX4dW/zBvrfOF4JYGEdDp07rBOtZNDa5E2oITo9+9HNFZmaDa9leaAKkARs8a0F7G\n EaH/GatydheZ9LGE8NZ1fMmYfyl1Ytlshga3HSx3y1DjI8fVluEvwVnQQetOmQ2fRiPHQhEsKf/\n 6hgsrRdJsT8rdZ7yV4ZWN/VZ3lRd1EuyuaoarCwwi7Ddmzd2OFWl/h8d4SalP+JinJwNZoowMEa\n Dl5b2k2xQA7v/TE147yGX/7wXq4xMWZz19FnLiZXtOWGAC021lwbxws4rxkINnIjGqcYsIAJN0H\n EzZmaKX3qL0+0NRxAOGjm6HZSmLgFgZhA3NPujYOc1oB/4y9OWqZg48zlyNymRQkB6fh6javEjH\n MqHU7hSU7mrQbXkiYlOhqYL7foA+7XlItnEfAq2UaZcjRYQiCOcktwGVa6dyXZHDBm+vyNv1BxT\n DemDoGjPNSAVpO8cI9V/27WGA7RfrEL/0D8iEm4D87jpg1fgg==","X-Received":"by 2002:ac8:5a03:0:b0:50e:5f71:62c3 with SMTP id\n d75a77b69052e-5100e1daae7mr99593611cf.42.1777466036259;\n Wed, 29 Apr 2026 05:33:56 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Wei Gao ","Date":"Wed, 29 Apr 2026 12:33:55 +0000","Message-ID":"<20260429123355.4104-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260429111823.1046-1-wegao@suse.com>","References":"<20260429111823.1046-1-wegao@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=1.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Level":"*","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] shmctl03: Fix 32-bit compat mode failure by adjusting\n comparisons for compat mode truncation","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]