[{"id":3684178,"web_url":"http://patchwork.ozlabs.org/comment/3684178/","msgid":"","list_archive_url":null,"date":"2026-04-29T17:16:32","subject":"Re: [PATCH RFC next 5/5] net: SYS_RX_ETH_BUFFER defaults to 8 when\n CONFIG_FSL_ENETC=y","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Quentin,\n\nOn 2026-04-29T10:35:00, Quentin Schulz wrote:\n> net: SYS_RX_ETH_BUFFER defaults to 8 when CONFIG_FSL_ENETC=y\n>\n> drivers/net/fsl_enetc.h specifies ENETC_BD_CNT \"buffer descriptors count\n> must be a multiple of 8\". This constant is set to\n> CONFIG_SYS_RX_ETH_BUFFER which defaults to 4.\n>\n> All defconfigs enabling CONFIG_FSL_ENETC fortunately have it set to 8,\n> according to\n> ./tools/qconfig.py -l -f CONFIG_FSL_ENETC '~CONFIG_SYS_RX_ETH_BUFFER=8'.\n>\n> Let's make sure the default is sane by having it set to 8 when this\n> driver is enabled. Note that originally[1] it was said EEPRO100 and 405\n> EMAC should be 8 or higher. 405 (PPC405?) support seems to have been\n> dropped in commit b5e7c84f72ee (\"ppc4xx: remove ASH405 board\"), 11 years\n> ago. Maybe there's something we can do for EEPRO100 though?\n>\n> [1] commit 53cf9435ccf9 (\"- CFG_RX_ETH_BUFFER added.\")\n> Signed-off-by: Quentin Schulz \n>\n> net/Kconfig | 1 +\n> 1 file changed, 1 insertion(+)\n\n> diff --git a/net/Kconfig b/net/Kconfig\n> @@ -250,6 +250,7 @@ if NET\n>\n> config SYS_RX_ETH_BUFFER\n> int \"Number of receive packet buffers\"\n> + default 8 if FSL_ENETC\n> default 4\n\nMaybe convert the spaces here to tab?\n\nAlso suggest a note in the help text mentioning that FSL_ENETC needs\nENETC_BD_CNT to be a multiple of 8.\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=XRra5dXs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"XRra5dXs\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5P9Y08fGz1xqf\n\tfor ; Thu, 30 Apr 2026 03:16:49 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E7381848D1;\n\tWed, 29 Apr 2026 19:16:46 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 081E0848D4; Wed, 29 Apr 2026 19:16:46 +0200 (CEST)","from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n [IPv6:2a00:1450:4864:20::62e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0A1E2848CE\n for ; Wed, 29 Apr 2026 19:16:44 +0200 (CEST)","by mail-ej1-x62e.google.com with SMTP id\n a640c23a62f3a-ba3115fe0d5so213059566b.1\n for ; Wed, 29 Apr 2026 10:16:44 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777483003; cv=none;\n d=google.com; s=arc-20240605;\n b=jUpQUryvTzDBxwr2kNv08LScZxGJ4Hum6mmJb/TyEZ5XMEnZJ5n8zL4tJtSpPZ57/s\n 9x6f5fDUsiavV6OgQp/GX8HxsBtxNsGWzHLBDeT+g76Kjo23PteV4osuk9SFH6KIlOww\n jBbWB7Oaw9UpAdEwL5ECs6vt1BR51NYDAeHJAmbPMnUqKeNmE51DYVM364TslLf3DjUh\n tYaX2MKn2+cIRJq7zE+pvWXqTsSRX9h0VEnFDPGWAgYC+rQpLxtt3diVDdfXg1zAfUf1\n QSVDz1ErFhpw0e95j+pEutxvsVUo9dmfVQ97BaE+9AFQk5KxrzA035YQE7WPtsOscPWa\n AO+A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=frbBwfaCJ+D9pSOsJ8IGHPA8MHOp6ENYp/STkSqhdYU=;\n fh=+/pNFDyGYsDJMoXpsFeigOK5l3QyGzKdfAevrQne9bY=;\n b=I0+D7eincEeHhs/TuoghtBwUpMPEGfYUqJRhgCJ6CCX8VHyoBh6c9BMt5yfe/LHNWK\n LHTQiXc9a58F/ORigKl74C51tH62BJI709Udb/lMHHy/3o+5VT2+xUy29Cfhzgj43J+c\n /YsxifsFfvvdpS/3/1++d4dK7nK//h9P/Xe8TMiBCpnMEaVxGgSuhOHtdXf7ngMgru4r\n N+4rqcUjGzbE/aqaWQnt/Sksf8k8Lwywn2DnK/be7iFESCyMndcnVOJtVvU3cwbABOaO\n v1a32NeelcTz9PcctCEVDorNalHBawx4PSc64oCRejSeJILB5maqq34Xv2769Uftcs3I\n 6qKA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777483003; x=1778087803; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=frbBwfaCJ+D9pSOsJ8IGHPA8MHOp6ENYp/STkSqhdYU=;\n b=XRra5dXs5cfOxoDrAxYqSV0K1K74ZI7xJkUGY8aQrgAOMgkXFWioKiXy2A8qe/baw2\n /+yYohx0HuQVwgTLpsEU2qOP6CUlE5FKxJuh2jbNbZRLw62DagS/gD2G0OnCF7Ssx+Lz\n 0JWR7o0TmToXJt2kzOuPfdNvcRsZPp/+FP7f4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777483003; x=1778087803;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=frbBwfaCJ+D9pSOsJ8IGHPA8MHOp6ENYp/STkSqhdYU=;\n b=e+/ALjZ+orEIZzGvJPYgdec/8j3iEHKGz04bNgSr8/xy5i3BbYzDz+lTP+OaDBMWVI\n mUH2qq15MvPp916bklRQbXI17FtP9Arwjo5IQKdshQyC9f34jGyKQvm2vyivjyJw4HWJ\n HF7u5gRjA5z5xQuob8KZ0d7SkrFWheyLxRs7+Nhkg9j2I6TjYugcLiANK3J4axUKDq+o\n Gdjjb1CwgHLBSCvK2UjCCxb4VPMWDbBgMqwsI7IjCZfeEUO41WzVcCRa/k7mXhVN8hIV\n wvMsA28hl5abl6vSBS5tjfZNr2HZGBheviRpcDH6M1YoNw2d96wBCvOFROEWGjk7C1m0\n u6cQ==","X-Gm-Message-State":"AOJu0YwycHglC61Grnme1aINU+XJPlsfXCnpmnIDCEx15dJ271lLS/xN\n mRARpbspNRJ9smHxKeRXig9VIW66LV4K5G9x7vBkxkWtq7SnKwbT1qZtuW25Q/pCwZIrRHT7LNm\n Ri+W/KduEjf3A5nmqIuRJk7JwlJHe9hNbtFBGvlR2","X-Gm-Gg":"AeBDieuoapc7G7jp2S942MpQgKU5+PQNowL9sQb0j9+c1mlWNGldeVIZ8hKHxrn+1F4\n SbnNDlQBwS8anuzRIJY/xx1rNotgmCSCF1/bQPaBWTszMCAIFyDMB4e2hz9BycAH7H4I/qsyZoo\n REBIVPtEvvsUvy7nQApgz4NxnRhFQKas+1UFaafgPVell3Q7llSYSGTEUxCyKKvibmriisDMf2w\n NU1aZ4i1Zc7Kk3w8PMoXEzSZCnbu+fa2rzhsUhyUJW2e/h3TclvftSfaK6RLclsvNiDaIlftRpl\n NeV62/7xc2k7DFk/kZQwTRHj0i0QhWASSJDHa1YFm5U3xsRBAICz","X-Received":"by 2002:a17:907:7f8e:b0:b9c:48d9:9025 with SMTP id\n a640c23a62f3a-bb96ab9e65emr218378066b.13.1777483003459; Wed, 29 Apr 2026\n 10:16:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20260429-sys_rx_eth_buffer-no-net-v1-0-396ef37ae93c@cherry.de>\n <20260429-sys_rx_eth_buffer-no-net-v1-5-396ef37ae93c@cherry.de>","In-Reply-To":"<20260429-sys_rx_eth_buffer-no-net-v1-5-396ef37ae93c@cherry.de>","From":"Simon Glass ","Date":"Thu, 30 Apr 2026 05:16:32 +1200","X-Gm-Features":"AVHnY4IaYGV4GY9N2Dx77eJaqYIntnnjM_ZJM8Nxo_QUwMtZY5Hh-0sNKtHS6RA","Message-ID":"\n ","Subject":"Re: [PATCH RFC next 5/5] net: SYS_RX_ETH_BUFFER defaults to 8 when\n CONFIG_FSL_ENETC=y","To":"foss+uboot@0leil.net","Cc":"u-boot@lists.denx.de, Tang Yuantian ,\n Tom Rini , Fabio Estevam ,\n Alice Guo , Jerome Forissier ,\n Peter Robinson , Simon Glass ,\n Andrew Goodbody ,\n Benjamin Hahn ,\n Ilias Apalodimas , =?utf-8?q?Alvin_=C5=A0iprag?=\n\t=?utf-8?q?a?= , Quentin Schulz ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]