[{"id":3684174,"web_url":"http://patchwork.ozlabs.org/comment/3684174/","msgid":"","list_archive_url":null,"date":"2026-04-29T17:14:56","subject":"Re: [PATCH RFC next 1/5] ls1028a: only include\n drivers/net/fsl_enetc.h\n when driver is compiled","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-29T10:35:00, Quentin Schulz wrote:\n> ls1028a: only include drivers/net/fsl_enetc.h when driver is compiled\n>\n> As hinted by its path, it's not really meant to be included outside of\n> the driver itself. This header uses CONFIG_SYS_RX_ETH_BUFFER which we\n> are trying to move under CONFIG_NET dependency. This file here can be\n> compiled without network support so make sure this only gets included\n> when needed.\n>\n> The function from that header (fdt_fixup_enetc_mac) is already guarded\n> by CONFIG_FSL_ENETC so simply guard the inclusion of the header the same\n> way.\n>\n> This was tested by building ls1028aqds_tfa_defconfig with\n> CONFIG_MSCC_FELIX_SWITCH and CONFIG_FSL_ENETC disabled.\n>\n> Signed-off-by: Quentin Schulz \n>\n> board/nxp/ls1028a/ls1028a.c | 2 ++\n> 1 file changed, 2 insertions(+)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=c2YEmasA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"c2YEmasA\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5P7p1r1Mz1xqf\n\tfor ; Thu, 30 Apr 2026 03:15:18 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8168D848C3;\n\tWed, 29 Apr 2026 19:15:15 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id F301E848C5; Wed, 29 Apr 2026 19:15:13 +0200 (CEST)","from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n [IPv6:2a00:1450:4864:20::62f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 18FF9848B6\n for ; Wed, 29 Apr 2026 19:15:12 +0200 (CEST)","by mail-ej1-x62f.google.com with SMTP id\n a640c23a62f3a-bb962ce4dcfso173219266b.1\n for ; Wed, 29 Apr 2026 10:15:12 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777482911; cv=none;\n d=google.com; s=arc-20240605;\n b=N1Y/JRzEcW/jrb4wrUEvMcSGPJIvlY5P+ZpJJrHweqqWKAqKyjivjYap1487j9TISn\n xZjYQa/Ag7ci5rMoZFpDhYwoLfzC8rQ0brmEBq0hRyIGMPwRQKU5ZS8VF7GP6pirEPnk\n 6EwQvlSintLUHdaRnQm89iJjtxh+r9ftH5tG87QhP1vmf0a1fTQ9qm4OtbRbuduTcMRE\n ofiTWkvZjVCLLiNPb6uewbs5NsBadVaw/aGDLckUZqqvoLv2MZnTRRQYo52lQIBNkKy5\n /cPiEftnP7fkh8qm8eEvEJsk3Iy28XQEZhXOZgamwBveXBnbZ3BeeHcAnHmpZFSz+yBS\n wjPw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=stIoPaBQ2ySWsfc+zh8kFUZrrJKDrRsXOfTYMlUjWZQ=;\n fh=+/pNFDyGYsDJMoXpsFeigOK5l3QyGzKdfAevrQne9bY=;\n b=lT1pWgMuItbKs8N0IAVPZ17Gc143Dl6VMeaS2YU9jf6pbNz9yW6HnHWPWpb/Fd3eWb\n yZDQhOIHx5KUQ0CmXujaIPkN8V1uBEj2jBcs23TMEjK+FybzcfAilL9sP+8+KalPZPza\n XbxHy1E4dSmXZWjZM127/JFboXwUazLaYs8WYvfLXiyDjr6kvfBaG7+XKqJL8tW6f2vu\n xtNQG/obaG9BpI4+3F+F+szSA5RX+2HSH3OIwMYTURgcr9nT97DG1xRmEazrMxrCRL9W\n OqFMfH4BpRWgwMhbOWDe+DYRvvfu5GdsBz3sdGa8fnZKd8ARnyZdKhfZH004SJvDvk0N\n vpig==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777482911; x=1778087711; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=stIoPaBQ2ySWsfc+zh8kFUZrrJKDrRsXOfTYMlUjWZQ=;\n b=c2YEmasA5L/tgRLEUq1bNSIr/l0Zffni1aUdcfUy/o7LRJljEIRGMzUlVQSMe1+IkK\n vBz+84VFwRTcjmO256gN2Jbiepcs5i+jTt0q3cClfeksBVvv5WRxomZnQRDdYBDcLhX+\n CfAaxIBq+bO1x3WlhE7u3gwI7FroBXSaNr89A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777482911; x=1778087711;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=stIoPaBQ2ySWsfc+zh8kFUZrrJKDrRsXOfTYMlUjWZQ=;\n b=alfvO6BaFnFaVo6gZ4QVPNAi6YBQVaEciziOXdmcBnRdh/wlb7WOpu/shShINe+f5e\n hmdlZv54qcUGK1RSnSlA+QXXSLujuR3CPbltLmX3MW1MENOYjnGsDHfaBO8d2JlZL2DT\n 3h4y7JC1B+XyhFsHdw/cwbCkHl6qQA5hZKrWcg+c0n52zSMJuZoToYLrbacZHkG3XXBm\n dtURKR8ac3MLmJoPxDWVEZwHbjAymvgQnt8Ddrj6b4ktC8TEEELd5JyguTYaeEVm2ylw\n HAkGL1JWb06UokbKVEPSp2dlSIMdOYtBykC4J0co5YTezkJVlNf6j0jZ6aIYyNwCHnLF\n lkyQ==","X-Gm-Message-State":"AOJu0Yy/obCvB2LF1eBlQLqLHymrNQcHQqWdwGyDJtNR2bRPEmhNTmBU\n 3kTFveKF0l86ftNI18V+fb8Q4QJqfqEuYRLGycVQZthzus/zHuDtd3WWYvTF9FdlqpSUVy2/rR6\n UBRpHPbj4s+dO6T8YExtf3wz3bjR3gjaUyIpoc0FG","X-Gm-Gg":"AeBDievjmY1PbnGyUSN22d01MwHFRv1fRMPelsO/tHgYPRHXRiqJ3SOink+yeYOblGk\n 0KmxHi5x96FgPWTQKh3SQ3vcInOJ7233851OALxRQdYC1ePz/ROThCsH7yBCedtU8S9zot2SA7k\n M/8gv78WR1ogR6ulfAq3TALB5NhFrXwbkP+Qcc8ZcAbkpGtaUIA1kFaqjVnNWt6bgia0vG5vpLI\n U/zZb6h1bbugoIzXGQwmhNZcpRQLwdFRXS2HFw63o5YhpTrrDIy+2tC3uTKWuOkwgsnIkBv2v90\n P4bA8g+K0n8NwQbYdBatzo43Tpu5U630zH/ICdugn7egXO+4uiJ+","X-Received":"by 2002:a17:907:960a:b0:ba2:e022:c146 with SMTP id\n a640c23a62f3a-bb804f1a82amr564871366b.43.1777482911446; Wed, 29 Apr 2026\n 10:15:11 -0700 (PDT)","MIME-Version":"1.0","References":"<20260429-sys_rx_eth_buffer-no-net-v1-0-396ef37ae93c@cherry.de>\n <20260429-sys_rx_eth_buffer-no-net-v1-1-396ef37ae93c@cherry.de>","In-Reply-To":"<20260429-sys_rx_eth_buffer-no-net-v1-1-396ef37ae93c@cherry.de>","From":"Simon Glass ","Date":"Thu, 30 Apr 2026 05:14:56 +1200","X-Gm-Features":"AVHnY4KU6dPBGmy2hDB--3kxnGV-qRsnR6t296XxvyhoGFSj2_aGKkAGxymOUyk","Message-ID":"\n ","Subject":"Re: [PATCH RFC next 1/5] ls1028a: only include\n drivers/net/fsl_enetc.h\n when driver is compiled","To":"foss+uboot@0leil.net","Cc":"u-boot@lists.denx.de, Tang Yuantian ,\n Tom Rini , Fabio Estevam ,\n Alice Guo , Jerome Forissier ,\n Peter Robinson , Simon Glass ,\n Andrew Goodbody ,\n Benjamin Hahn ,\n Ilias Apalodimas , =?utf-8?q?Alvin_=C5=A0iprag?=\n\t=?utf-8?q?a?= , Quentin Schulz ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]