[{"id":3684044,"web_url":"http://patchwork.ozlabs.org/comment/3684044/","msgid":"","list_archive_url":null,"date":"2026-04-29T13:08:16","subject":"Re: [PATCH v2 2/3] sunxi: configs: enable power LEDs on 32-bit boards","submitter":{"id":88999,"url":"http://patchwork.ozlabs.org/api/people/88999/","name":"Paul Kocialkowski","email":"paulk@sys-base.io"},"content":"Hi Andre,\n\nOn Wed 29 Apr 26, 11:28, Andre Przywara wrote:\n> We recently gained a simple way to enable a power LED very early in the\n> SPL boot, through simple Kconfig variables.\n> \n> Add those symbols to those boards' defconfigs where the DT indicates a\n> default-on power LED. The number used is * 32 + ,\n> an active low setup means CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH must be\n> undefined. Since its default is \"high\", we can skip the symbol in the\n> defconfig in this case.\n> \n> This will light up the power LED very early in the (SPL) boot phase on\n> those 32-bit boards.\n> \n> Signed-off-by: Andre Przywara \n\nReviewed-by: Paul Kocialkowski \n\nAll the best,\n\nPaul\n\n> ---\n> configs/A13-OLinuXinoM_defconfig | 2 ++\n> configs/Bananapi_M2_Ultra_defconfig | 2 ++\n> configs/Bananapi_m2m_defconfig | 3 +++\n> configs/Mele_A1000G_quad_defconfig | 2 ++\n> configs/Mele_A1000_defconfig | 2 ++\n> configs/Mele_M9_defconfig | 2 ++\n> configs/bananapi_m1_plus_defconfig | 2 ++\n> configs/bananapi_m2_berry_defconfig | 2 ++\n> configs/bananapi_m2_zero_defconfig | 3 +++\n> configs/beelink_x2_defconfig | 2 ++\n> configs/icnova-a20-adb4006_defconfig | 2 ++\n> configs/nanopi_duo2_defconfig | 2 ++\n> configs/nanopi_neo_air_defconfig | 2 ++\n> configs/orangepi_2_defconfig | 2 ++\n> configs/orangepi_lite_defconfig | 2 ++\n> configs/orangepi_one_defconfig | 2 ++\n> configs/orangepi_pc_defconfig | 2 ++\n> configs/orangepi_zero_defconfig | 2 ++\n> configs/orangepi_zero_plus2_h3_defconfig | 2 ++\n> 19 files changed, 40 insertions(+)\n> \n> diff --git a/configs/A13-OLinuXinoM_defconfig b/configs/A13-OLinuXinoM_defconfig\n> index f547635302f..6c5a1b33194 100644\n> --- a/configs/A13-OLinuXinoM_defconfig\n> +++ b/configs/A13-OLinuXinoM_defconfig\n> @@ -10,6 +10,8 @@ CONFIG_VIDEO_VGA_VIA_LCD=y\n> CONFIG_VIDEO_VGA_VIA_LCD_FORCE_SYNC_ACTIVE_HIGH=y\n> CONFIG_VIDEO_LCD_POWER=\"PB10\"\n> CONFIG_VIDEO_LCD_BL_PWM=\"PB2\"\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=201\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_SYS_I2C_MVTWSI=y\n> CONFIG_SYS_I2C_SLAVE=0x7f\n> diff --git a/configs/Bananapi_M2_Ultra_defconfig b/configs/Bananapi_M2_Ultra_defconfig\n> index 375b0063c1a..750868033be 100644\n> --- a/configs/Bananapi_M2_Ultra_defconfig\n> +++ b/configs/Bananapi_M2_Ultra_defconfig\n> @@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=576\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_R40=y\n> CONFIG_MMC_SUNXI_SLOT_EXTRA=2\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=244\n> # CONFIG_HAS_ARMV7_SECURE_BASE is not set\n> CONFIG_AHCI=y\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> diff --git a/configs/Bananapi_m2m_defconfig b/configs/Bananapi_m2m_defconfig\n> index 0c20cce49ea..f75e3e09d03 100644\n> --- a/configs/Bananapi_m2m_defconfig\n> +++ b/configs/Bananapi_m2m_defconfig\n> @@ -7,6 +7,9 @@ CONFIG_MACH_SUN8I_A33=y\n> CONFIG_DRAM_ZQ=15291\n> CONFIG_DRAM_ODT_EN=y\n> CONFIG_MMC_SUNXI_SLOT_EXTRA=2\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=355\n> +# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_FASTBOOT_CMD_OEM_FORMAT=y\n> CONFIG_USB_EHCI_HCD=y\n> diff --git a/configs/Mele_A1000G_quad_defconfig b/configs/Mele_A1000G_quad_defconfig\n> index 1f4739e0005..ee6c902970a 100644\n> --- a/configs/Mele_A1000G_quad_defconfig\n> +++ b/configs/Mele_A1000G_quad_defconfig\n> @@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE=\"sun6i-a31-mele-a1000g-quad\"\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN6I=y\n> CONFIG_DRAM_ZQ=120\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=237\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_PHY_REALTEK=y\n> CONFIG_ETH_DESIGNWARE=y\n> diff --git a/configs/Mele_A1000_defconfig b/configs/Mele_A1000_defconfig\n> index 93e73ebe3f1..48679265650 100644\n> --- a/configs/Mele_A1000_defconfig\n> +++ b/configs/Mele_A1000_defconfig\n> @@ -5,6 +5,8 @@ CONFIG_SPL=y\n> CONFIG_MACH_SUN4I=y\n> CONFIG_VIDEO_VGA=y\n> CONFIG_VIDEO_COMPOSITE=y\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=244\n> CONFIG_AHCI=y\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_SPL_I2C=y\n> diff --git a/configs/Mele_M9_defconfig b/configs/Mele_M9_defconfig\n> index 9b1bb97eedd..293e00db1b0 100644\n> --- a/configs/Mele_M9_defconfig\n> +++ b/configs/Mele_M9_defconfig\n> @@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE=\"sun6i-a31-m9\"\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN6I=y\n> CONFIG_DRAM_ZQ=120\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=237\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_PHY_REALTEK=y\n> CONFIG_ETH_DESIGNWARE=y\n> diff --git a/configs/bananapi_m1_plus_defconfig b/configs/bananapi_m1_plus_defconfig\n> index 22b69aa88cb..14ecaf759b5 100644\n> --- a/configs/bananapi_m1_plus_defconfig\n> +++ b/configs/bananapi_m1_plus_defconfig\n> @@ -6,6 +6,8 @@ CONFIG_SPL=y\n> CONFIG_MACH_SUN7I=y\n> CONFIG_VIDEO_COMPOSITE=y\n> CONFIG_GMAC_TX_DELAY=3\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=249\n> CONFIG_AHCI=y\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_SPL_I2C=y\n> diff --git a/configs/bananapi_m2_berry_defconfig b/configs/bananapi_m2_berry_defconfig\n> index b406d519684..b9975211362 100644\n> --- a/configs/bananapi_m2_berry_defconfig\n> +++ b/configs/bananapi_m2_berry_defconfig\n> @@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE=\"sun8i-v40-bananapi-m2-berry\"\n> CONFIG_DRAM_CLK=576\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_R40=y\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=244\n> # CONFIG_HAS_ARMV7_SECURE_BASE is not set\n> CONFIG_AHCI=y\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> diff --git a/configs/bananapi_m2_zero_defconfig b/configs/bananapi_m2_zero_defconfig\n> index 337bafecd47..5041802ea8c 100644\n> --- a/configs/bananapi_m2_zero_defconfig\n> +++ b/configs/bananapi_m2_zero_defconfig\n> @@ -4,4 +4,7 @@ CONFIG_DEFAULT_DEVICE_TREE=\"sun8i-h2-plus-bananapi-m2-zero\"\n> CONFIG_DRAM_CLK=408\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> +# CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH is not set\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> diff --git a/configs/beelink_x2_defconfig b/configs/beelink_x2_defconfig\n> index 3b0be26f063..16a37da521d 100644\n> --- a/configs/beelink_x2_defconfig\n> +++ b/configs/beelink_x2_defconfig\n> @@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=567\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> CONFIG_MMC_SUNXI_SLOT_EXTRA=2\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_SUN8I_EMAC=y\n> CONFIG_USB_EHCI_HCD=y\n> diff --git a/configs/icnova-a20-adb4006_defconfig b/configs/icnova-a20-adb4006_defconfig\n> index 507e330612e..dcb6457fe71 100644\n> --- a/configs/icnova-a20-adb4006_defconfig\n> +++ b/configs/icnova-a20-adb4006_defconfig\n> @@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE=\"sun7i-a20-icnova-a20-adb4006\"\n> CONFIG_DRAM_CLK=384\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN7I=y\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=245\n> CONFIG_AHCI=y\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_SPL_I2C=y\n> diff --git a/configs/nanopi_duo2_defconfig b/configs/nanopi_duo2_defconfig\n> index 41b5502d24e..9b0fbecff60 100644\n> --- a/configs/nanopi_duo2_defconfig\n> +++ b/configs/nanopi_duo2_defconfig\n> @@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=408\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> # CONFIG_VIDEO_DE2 is not set\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_CONSOLE_MUX=y\n> CONFIG_USB_EHCI_HCD=y\n> diff --git a/configs/nanopi_neo_air_defconfig b/configs/nanopi_neo_air_defconfig\n> index 3b8cbbfcdba..110bb1e864c 100644\n> --- a/configs/nanopi_neo_air_defconfig\n> +++ b/configs/nanopi_neo_air_defconfig\n> @@ -5,6 +5,8 @@ CONFIG_DRAM_CLK=408\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> # CONFIG_VIDEO_DE2 is not set\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_CONSOLE_MUX=y\n> CONFIG_USB_EHCI_HCD=y\n> diff --git a/configs/orangepi_2_defconfig b/configs/orangepi_2_defconfig\n> index 88433808538..43f3ab512f1 100644\n> --- a/configs/orangepi_2_defconfig\n> +++ b/configs/orangepi_2_defconfig\n> @@ -5,6 +5,8 @@ CONFIG_DEFAULT_DEVICE_TREE=\"sun8i-h3-orangepi-2\"\n> CONFIG_DRAM_CLK=672\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_SPL_I2C=y\n> CONFIG_SPL_SYS_I2C_LEGACY=y\n> diff --git a/configs/orangepi_lite_defconfig b/configs/orangepi_lite_defconfig\n> index ea1548f0fcd..499ffd8ace5 100644\n> --- a/configs/orangepi_lite_defconfig\n> +++ b/configs/orangepi_lite_defconfig\n> @@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE=\"sun8i-h3-orangepi-lite\"\n> CONFIG_DRAM_CLK=672\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_USB_EHCI_HCD=y\n> CONFIG_USB_OHCI_HCD=y\n> diff --git a/configs/orangepi_one_defconfig b/configs/orangepi_one_defconfig\n> index e4de13de26b..637eb41207e 100644\n> --- a/configs/orangepi_one_defconfig\n> +++ b/configs/orangepi_one_defconfig\n> @@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE=\"sun8i-h3-orangepi-one\"\n> CONFIG_DRAM_CLK=672\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_SUN8I_EMAC=y\n> CONFIG_USB_EHCI_HCD=y\n> diff --git a/configs/orangepi_pc_defconfig b/configs/orangepi_pc_defconfig\n> index f857d7fa203..01195b68621 100644\n> --- a/configs/orangepi_pc_defconfig\n> +++ b/configs/orangepi_pc_defconfig\n> @@ -4,6 +4,8 @@ CONFIG_DEFAULT_DEVICE_TREE=\"sun8i-h3-orangepi-pc\"\n> CONFIG_DRAM_CLK=624\n> CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_SPL_I2C=y\n> CONFIG_SPL_SYS_I2C_LEGACY=y\n> diff --git a/configs/orangepi_zero_defconfig b/configs/orangepi_zero_defconfig\n> index e128f5fcdb3..49a1f4d03da 100644\n> --- a/configs/orangepi_zero_defconfig\n> +++ b/configs/orangepi_zero_defconfig\n> @@ -6,6 +6,8 @@ CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> # CONFIG_VIDEO_DE2 is not set\n> CONFIG_SPL_SPI_SUNXI=y\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_CONSOLE_MUX=y\n> CONFIG_MTD=y\n> diff --git a/configs/orangepi_zero_plus2_h3_defconfig b/configs/orangepi_zero_plus2_h3_defconfig\n> index caf515c7026..63335b404da 100644\n> --- a/configs/orangepi_zero_plus2_h3_defconfig\n> +++ b/configs/orangepi_zero_plus2_h3_defconfig\n> @@ -6,6 +6,8 @@ CONFIG_SPL=y\n> CONFIG_MACH_SUN8I_H3=y\n> # CONFIG_DRAM_ODT_EN is not set\n> CONFIG_MMC_SUNXI_SLOT_EXTRA=2\n> +CONFIG_SPL_SUNXI_LED_STATUS=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=362\n> # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n> CONFIG_SUN8I_EMAC=y\n> CONFIG_USB_EHCI_HCD=y\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=sys-base.io","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=sys-base.io","phobos.denx.de;\n spf=pass smtp.mailfrom=paulk@sys-base.io"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Hg02nr6z1xqf\n\tfor ; Wed, 29 Apr 2026 23:08:28 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 46D8F84855;\n\tWed, 29 Apr 2026 15:08:26 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 670EE84843; Wed, 29 Apr 2026 15:08:25 +0200 (CEST)","from leonov.paulk.fr (leonov.paulk.fr [185.233.101.22])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E566484857\n for ; Wed, 29 Apr 2026 15:08:22 +0200 (CEST)","from laika.paulk.fr (12.234.24.109.rev.sfr.net [109.24.234.12])\n by leonov.paulk.fr (Postfix) with ESMTPS id 8583F1F8004F\n for ; Wed, 29 Apr 2026 13:08:21 +0000 (UTC)","by laika.paulk.fr (Postfix, from userid 65534)\n id 76DD0B404A2; Wed, 29 Apr 2026 13:08:20 +0000 (UTC)","from shepard (unknown [192.168.1.1])\n by laika.paulk.fr (Postfix) with ESMTPSA id 5AD55B4049D;\n Wed, 29 Apr 2026 13:08:19 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","Date":"Wed, 29 Apr 2026 15:08:16 +0200","From":"Paul Kocialkowski ","To":"Andre Przywara ","Cc":"u-boot@lists.denx.de, Tom Rini ,\n Quentin Schulz ,\n Jernej Skrabec , linux-sunxi@lists.linux.dev","Subject":"Re: [PATCH v2 2/3] sunxi: configs: enable power LEDs on 32-bit boards","Message-ID":"","References":"<20260429092828.3076719-1-andre.przywara@arm.com>\n <20260429092828.3076719-3-andre.przywara@arm.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"pmiThV5x9vjF8zfe\"","Content-Disposition":"inline","In-Reply-To":"<20260429092828.3076719-3-andre.przywara@arm.com>","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]