[{"id":3683963,"web_url":"http://patchwork.ozlabs.org/comment/3683963/","msgid":"<3ace7546-3f98-4a14-9b8e-98be2b9c044a@cherry.de>","list_archive_url":null,"date":"2026-04-29T09:49:12","subject":"Re: [PATCH v2 1/3] sunxi: spl: fix SPL_SUNXI_LED active low\n configuration","submitter":{"id":88462,"url":"http://patchwork.ozlabs.org/api/people/88462/","name":"Quentin Schulz","email":"quentin.schulz@cherry.de"},"content":"Hi Andre,\n\nOn 4/29/26 11:28 AM, Andre Przywara wrote:\n> The newly introduced Allwinner SPL LED \"framework\" defined a\n> SPL_SUNXI_LED_STATUS_STATE Kconfig symbol, that was supposed to denote\n> the active-low vs. active-high polarity of the LED. However this is\n> a bool symbol, so it will simply vanish if not defined, and we cannot use\n> it directly inside a C statement.\n> \n> Filter the symbol through the IS_ENABLED() macro, which will return 0 if\n> the symbol is not defined, which is the intended value here.\n> \n> Since the STATUS_STATE name is a bit confusing, rename it to ACTIVE_HIGH\n> on the way, because that is its real meaning. Also the LED_STATUS_BIT\n> name for the GPIO number is similarly a remnant of the old status LED\n> code, so rename it to LED_STATUS_GPIO as well.\n> \n> This fixes configuring LEDs with active-low polarity.\n> \n\nIndividual patches would have been better.\n\n> Fixes: 256557dd9aae (\"sunxi: remove usage of legacy LED API\")\n\nReported-by: Paul Kocialkowski <paulk@sys-base.io>\nCloses: https://lore.kernel.org/u-boot/adfMQBPdntWy1KIq@shepard/\n\nAcked-by: Quentin Schulz <quentin.schulz@cherry.de>\n\nThanks!\nQuentin","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=cherry.de header.i=@cherry.de header.a=rsa-sha256\n header.s=selector1 header.b=PZlLZZV/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=cherry.de","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=cherry.de header.i=@cherry.de header.b=\"PZlLZZV/\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=cherry.de","phobos.denx.de;\n spf=pass smtp.mailfrom=quentin.schulz@cherry.de","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=cherry.de;"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5CFL3CS5z1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 19:49:26 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1CABD8470B;\n\tWed, 29 Apr 2026 11:49:22 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id CBA1584711; Wed, 29 Apr 2026 11:49:20 +0200 (CEST)","from AM0PR83CU005.outbound.protection.outlook.com\n (mail-westeuropeazlp170100001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c201::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 70DDA84709\n for <u-boot@lists.denx.de>; Wed, 29 Apr 2026 11:49:18 +0200 (CEST)","from DBBPR04MB7737.eurprd04.prod.outlook.com (2603:10a6:10:1e5::22)\n by VI0PR04MB10807.eurprd04.prod.outlook.com (2603:10a6:800:25a::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Wed, 29 Apr\n 2026 09:49:15 +0000","from DBBPR04MB7737.eurprd04.prod.outlook.com\n ([fe80::5960:fb4b:9313:2b00]) by DBBPR04MB7737.eurprd04.prod.outlook.com\n ([fe80::5960:fb4b:9313:2b00%4]) with mapi id 15.20.9846.025; Wed, 29 Apr 2026\n 09:49:14 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=cN+i4kBwhXWOI8f+D36wDdHnx/VKlbJHIpYvAJsgkg9pAfri0dAmaWjG+Yo/JM/XdT5ED4GPa/Q+dydX0ezGYr2V739jviC2aoo6nYELJeUoIC/4q/AwWg9hLUloPuiMX8PdkppOsY6yk81Lk/GO3a18fQDMLBS6d7c84tdiLkt9ofMzcfiuuJV0DUUtCuR6ExuH/LZ8WNxyL1l34htNqp255Kkseh46JQSR3G5QIwfGuNaNQ6mTgCBz7Vi9xVoeOLPXKS3SILwAWwXZvXOAiGDPl1dFtBOmnoKKWeG3pkRQnn3JWyhtuscfzTJD/9DyQpEKxVfv3VOmRqkpg0IB4Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=kHtWRwENf4vn5D6HKX2S/myNngtxJqyeT4H4aNgES9s=;\n b=kUrib5rz0cNQuhl3kAe9d9PBH9Biq+M85RKygB3poKGXamu9Zh5uBe0u0Pl01NZ4IDYA90hbMBAp7SYDY2znD4mPpx9ljKlQBDEMjn3hqJr5XmGWqB/jA8l1Y9La6vofgRvbSKUK7TInGZFjTrWJGNqij0Z4SP4FJFqbPVjNzllg0WgD9udqo9MibqUOlv5QbMWC+LhXaPzYiBkDsEQOCg8upy9oTZ54yoYvlCk5u6dwjzUoEkBIlRf1l7zAZnQFF+/JN+PgSW/yYPXTnuMqn2aQ3vPpF3x4I+0ndME4YKNKEq6Tg+rqzGi7nPlpdaGYCFINsxHAZ1LNDWs5ZNyoMA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=cherry.de; dmarc=pass action=none header.from=cherry.de;\n dkim=pass header.d=cherry.de; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherry.de;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=kHtWRwENf4vn5D6HKX2S/myNngtxJqyeT4H4aNgES9s=;\n b=PZlLZZV/zVdTzz6CHMfUeZeNXX0Ne0v4BBdFITmP6P29FPaj9d8GES8r3PtfKYiaLWo40tR5O+F+Pm7YFCm1++omhjYLRWjBH00wux6uQsF4DyAR5PuF/oD3dCHA2qXZh0u1arc2JK6AZRx9GxgjBoJjrmO5XEyshsiHEUtXkfI=","Message-ID":"<3ace7546-3f98-4a14-9b8e-98be2b9c044a@cherry.de>","Date":"Wed, 29 Apr 2026 11:49:12 +0200","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/3] sunxi: spl: fix SPL_SUNXI_LED active low\n configuration","To":"Andre Przywara <andre.przywara@arm.com>, u-boot@lists.denx.de","Cc":"Tom Rini <trini@konsulko.com>, Jernej Skrabec <jernej.skrabec@gmail.com>,\n Paul Kocialkowski <paulk@sys-base.io>, linux-sunxi@lists.linux.dev","References":"<20260429092828.3076719-1-andre.przywara@arm.com>\n <20260429092828.3076719-2-andre.przywara@arm.com>","Content-Language":"en-US","From":"Quentin Schulz <quentin.schulz@cherry.de>","In-Reply-To":"<20260429092828.3076719-2-andre.przywara@arm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"FR2P281CA0117.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:9d::7) To DBBPR04MB7737.eurprd04.prod.outlook.com\n (2603:10a6:10:1e5::22)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DBBPR04MB7737:EE_|VI0PR04MB10807:EE_","X-MS-Office365-Filtering-Correlation-Id":"c4512160-2dcb-4079-ec20-08dea5d492ae","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|10070799003|376014|22082099003|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n s/Y1YpO8LG+L24JPs+d44ClaWuOuubslfJnfmirNDjrvAqPZ2Rv8SvDwgpGswAsKe+sPSYdOjYJ4dTGa90aZ+6ID5rTBC7smv1BIXg2ZnacV0a6d1l/N3XSlsoB2QE3TK7iCxYHRXo334NlDSVlD/FZ4qNZOoct7R8WpGYoybzw9/cC2BzL8QdDLBNr7YqZVin0Gf4A1IC9vl+1WA9NKXVeCpeLaZN8kw0Q9fA/WlpIQnYiiIjdIT9mxIsHCFMjez4e0xOx3aetOODOsR+i+a/I0qozt97P1REZZ8LtfM2hADxUgMJoFBgUIlFr5fwmGV+yfivDhdLezCcBc3BmInM6xKcPKxmaOtEBLTHFqHdgupgAUWuX3nzeIPAUWZG6Kzgh6NNFi+7ByO+Gl+PWtmcn/ufesaea2sE/TtNzAo0iIO+FKylBod/ErnXmFf0TBRo0Mu0Bpl0ZihcPaAZ/RNRMzw18OY2lp897KztLIf6Nr54smoPBn5kDaf239zaS48ytO5k1ixND0F5gw3uBrPvdXFt7T37icfF174KeL5VRDkQjalpOJvO+rf5oFWp9HeZwRHT3sifAeZtLOje+XhAcFxaRWUBMxg5OzPTRWMS3YbLssY8e4efxfao5G/lHDetwJUFLql6s3gYY60rtV69g2QidWlb1WZmEpkcyXoLZ0j6oX68dgO8+zsRUbF09Bwk6Z1F+OV0M7eSe2B3IF+is7FkwwQxHTPhFuSZUvPjE=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DBBPR04MB7737.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(10070799003)(376014)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?6a0g49+sSm5++HNAqtXOursS1xax?=\n\t=?utf-8?q?A0O9Tyy6dxRdWJkAjaU9bnhJ1/pY9CM2BWYQLE/t/U0fUxQv199hY7URFlHnsmQuV?=\n\t=?utf-8?q?/pLyK0R6maTTbfOO+JJwx6zoeJh2vsk9+Fr1t/mXXX9VUAFRjDelwGT4vxQLPFGRT?=\n\t=?utf-8?q?PIHrTVLS/VzEIQ6w4umUPy40lZt+Gbv6ly6nCdY+7l1TBvAutH7+skpf+JWf9mK9H?=\n\t=?utf-8?q?snqXnLO/knsjAhaM59NQ9JmIR4yK3C6yLR89SaieYWjrm62pKUZQoenOU+z74g+hZ?=\n\t=?utf-8?q?ykmxdNeDP6/jXc+pwyuT7MIjzlFu8yUauDxDf3EjqeoLymv3mfAH6K75W7FjxtVNn?=\n\t=?utf-8?q?t9G5/5xkcp5I+IdaTrlQV1eNSrGuoCtL4AeK7Ct+2ELBwF7ydnBcypHrLQm5CEkYq?=\n\t=?utf-8?q?i2IFL686CukgELoSr7a7gKiyZkVDhcsiL2k0PkqPeVA6lm5tJSqdSR72/RtmPM5Hk?=\n\t=?utf-8?q?xlW6wZhDe0FVBlTHzWthU9fxFk4JHH1haA0MbVEyhWZB4lFxsr+u3TOw6mCwxcX01?=\n\t=?utf-8?q?66w74bu5BA1hfalv+hh/NmbwkYzTPjVICsgpJDIqwOXIoNER2/c+Yo+JkIq/LMZgE?=\n\t=?utf-8?q?jvh5BG/mz/qgA0RHJ2ZPoINjYRxjJXeQg9OVr2ctrAHBymY5QyAUuFOHpikVocnHn?=\n\t=?utf-8?q?cVxZGvTnc+dPbdES12Y2ZTmAvzlvsSgFAr2HwZKzt+Hv7Bx3wxehMYmArJWNBJCOD?=\n\t=?utf-8?q?NK02ezq1Kkz/RZ9YecP19lWsV07Dgek3ehfNhEZK0MSI/8q1evlE0HNQJEcSzGc1F?=\n\t=?utf-8?q?hlILIMJP09H8syLTGDV4I6ecXBvgqL6XMxuqfPeczGixf/jw3AwRXPMTNyKZFtweY?=\n\t=?utf-8?q?VZKg6t2MyAOHtbdsuJL3cAoAnWEaPEUMC7Yu1H52uIeEjF43Cmq2m4hPo2C7gKZLK?=\n\t=?utf-8?q?G/NNhRdnNsDVsFHafx+7MP5ykMlPesu/9Vrz3xYCymFL0Vo1FWRnohkDAeGubGESi?=\n\t=?utf-8?q?pnKw9PlxyfqX0lnj6n2lMlXDDQvT8XkPazqz0gbGJchyq9G1nVcgd2eBC1fyHmmOC?=\n\t=?utf-8?q?vj6vZYAeHfpD7Gl+8H/gA62/Hfo5KIHz6Qqh/0SwIldLUM22DzRCkPhhkbmBfrYPm?=\n\t=?utf-8?q?fxr6AWRNEpl2F7/fFVKgl0XFgJf1vkEyeUXzfgy+NJhfZaU7xnO3xi50ok/Yhanf6?=\n\t=?utf-8?q?4+y4XkfisaaWgE/uPGg1QC9ITGnSFn5eculxvgvfWqav0nJgY4JCTUvP1RHHQW6qC?=\n\t=?utf-8?q?h/fyOUieq7BX/esR5XTlmdN6Z6bcDPNeSUBqoY8Y1DQrBXGMUIMeFvfDmu4sArJ2k?=\n\t=?utf-8?q?Uoa9VX48+5Pgok+5ZaIBxZCBwhChv7F6prEiUY13TqKkb7H23yQ4ZFwYvv8/lThaB?=\n\t=?utf-8?q?A6s2Fuo+S1XaMBDJU6dDgnt+kxxKiv53/5wovaQDw8EQQN/eVbbhLTcprS9F44feT?=\n\t=?utf-8?q?J0wiPQftPjfGsNNhJh343ZoKoUHraFHpdKGlswYM/ziHMeuSFAhd+o3pWrb4upcsL?=\n\t=?utf-8?q?Rn7quyC+2Qte9hLvbl4MeYpPd9oW1aIJmQGNkisPiBs+rb75HrT8Bt++TsFbcxJH8?=\n\t=?utf-8?q?fq2rzAoafyCj94JxM4e2tr0qm0viGAocbUvTiscnKX/cMQ1OGq0ufjMsRhgIqA8/9?=\n\t=?utf-8?q?wSzuw3DbPjHD8Qse44vHu8odr9r7pyIYScARuWOxy0XdyDbEUUXTkzyAcN65o14Nn?=\n\t=?utf-8?q?oym8Vm5tbjvMAZCi2KNeZgq+6hwClkAeYxx/Jc0dqhzlsXBJarh/zKY075zy3NcF4?=\n\t=?utf-8?q?tzl8yCG/l?=","X-OriginatorOrg":"cherry.de","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n c4512160-2dcb-4079-ec20-08dea5d492ae","X-MS-Exchange-CrossTenant-AuthSource":"DBBPR04MB7737.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"29 Apr 2026 09:49:14.8354 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n sv1qaR6BJmrG42Pg96eHad6ZM5Mj4sy1D1ryi3gP7tB2H34ECL91fP/jf+/+rOnSJntW0jL6wqaP6QBztg0XaA/9/wFjTltifyKKXrwwoAA=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI0PR04MB10807","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3684043,"web_url":"http://patchwork.ozlabs.org/comment/3684043/","msgid":"<afICrnsK3Frmp7Hp@shepard>","list_archive_url":null,"date":"2026-04-29T13:07:58","subject":"Re: [PATCH v2 1/3] sunxi: spl: fix SPL_SUNXI_LED active low\n configuration","submitter":{"id":88999,"url":"http://patchwork.ozlabs.org/api/people/88999/","name":"Paul Kocialkowski","email":"paulk@sys-base.io"},"content":"Hi Andre,\n\nOn Wed 29 Apr 26, 11:28, Andre Przywara wrote:\n> The newly introduced Allwinner SPL LED \"framework\" defined a\n> SPL_SUNXI_LED_STATUS_STATE Kconfig symbol, that was supposed to denote\n> the active-low vs. active-high polarity of the LED. However this is\n> a bool symbol, so it will simply vanish if not defined, and we cannot use\n> it directly inside a C statement.\n> \n> Filter the symbol through the IS_ENABLED() macro, which will return 0 if\n> the symbol is not defined, which is the intended value here.\n> \n> Since the STATUS_STATE name is a bit confusing, rename it to ACTIVE_HIGH\n> on the way, because that is its real meaning. Also the LED_STATUS_BIT\n> name for the GPIO number is similarly a remnant of the old status LED\n> code, so rename it to LED_STATUS_GPIO as well.\n> \n> This fixes configuring LEDs with active-low polarity.\n>\n> Fixes: 256557dd9aae (\"sunxi: remove usage of legacy LED API\")\n> Signed-off-by: Andre Przywara <andre.przywara@arm.com>\n\nThanks for your work!\n\nReviewed-by: Paul Kocialkowski <paulk@sys-base.io>\n\nAll the best,\n\nPaul\n\n> ---\n>  arch/arm/mach-sunxi/Kconfig | 10 ++++++----\n>  board/sunxi/board.c         |  4 ++--\n>  configs/pinephone_defconfig |  3 +--\n>  3 files changed, 9 insertions(+), 8 deletions(-)\n> \n> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig\n> index 89f0e77bcdb..07d7ea2b7ad 100644\n> --- a/arch/arm/mach-sunxi/Kconfig\n> +++ b/arch/arm/mach-sunxi/Kconfig\n> @@ -1245,15 +1245,17 @@ config SPL_SUNXI_LED_STATUS\n>  \n>  if SPL_SUNXI_LED_STATUS\n>  \n> -config SPL_SUNXI_LED_STATUS_BIT\n> +config SPL_SUNXI_LED_STATUS_GPIO\n>  \tint \"GPIO number for GPIO status LED\"\n>  \thelp\n>  \t  GPIO number for the GPIO controlling the GPIO status LED in SPL.\n>  \n> -config SPL_SUNXI_LED_STATUS_STATE\n> -\tbool \"GPIO status LED initial state is on\"\n> +config SPL_SUNXI_LED_STATUS_ACTIVE_HIGH\n> +\tbool \"GPIO status LED is active high\"\n> +\tdefault y\n>  \thelp\n> -\t  Whether the initial state of the status LED in SPL must be on or off.\n> +\t  Whether the GPIO of the status LED must be set high or low to turn\n> +\t  the LED on.\n>  \n>  endif # SPL_SUNXI_LED_STATUS\n>  \n> diff --git a/board/sunxi/board.c b/board/sunxi/board.c\n> index d7722d1858a..3d1afec7c66 100644\n> --- a/board/sunxi/board.c\n> +++ b/board/sunxi/board.c\n> @@ -563,8 +563,8 @@ static void sunxi_spl_store_dram_size(phys_addr_t dram_size)\n>  static void status_led_init(void)\n>  {\n>  #if CONFIG_IS_ENABLED(SUNXI_LED_STATUS)\n> -\tunsigned int state = CONFIG_SPL_SUNXI_LED_STATUS_STATE;\n> -\tunsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_BIT;\n> +\tunsigned int state = IS_ENABLED(CONFIG_SPL_SUNXI_LED_STATUS_ACTIVE_HIGH);\n> +\tunsigned int gpio = CONFIG_SPL_SUNXI_LED_STATUS_GPIO;\n>  \n>  \tgpio_request(gpio, \"gpio_led\");\n>  \tgpio_direction_output(gpio, state);\n> diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig\n> index ed7dbc1852b..3a4f4ec51cf 100644\n> --- a/configs/pinephone_defconfig\n> +++ b/configs/pinephone_defconfig\n> @@ -9,8 +9,7 @@ CONFIG_DRAM_ZQ=3881949\n>  CONFIG_MMC_SUNXI_SLOT_EXTRA=2\n>  CONFIG_PINEPHONE_DT_SELECTION=y\n>  CONFIG_SPL_SUNXI_LED_STATUS=y\n> -CONFIG_SPL_SUNXI_LED_STATUS_BIT=114\n> -CONFIG_SPL_SUNXI_LED_STATUS_STATE=y\n> +CONFIG_SPL_SUNXI_LED_STATUS_GPIO=114\n>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set\n>  CONFIG_CMD_PSTORE=y\n>  CONFIG_CMD_PSTORE_MEM_ADDR=0x61000000\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=sys-base.io","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=sys-base.io","phobos.denx.de;\n spf=pass smtp.mailfrom=paulk@sys-base.io"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Hfp0ysTz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 23:08:18 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id F17D3846FD;\n\tWed, 29 Apr 2026 15:08:09 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 3EEFE84707; Wed, 29 Apr 2026 15:08:09 +0200 (CEST)","from leonov.paulk.fr (leonov.paulk.fr [185.233.101.22])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 820CF846FA\n for <u-boot@lists.denx.de>; Wed, 29 Apr 2026 15:08:06 +0200 (CEST)","from laika.paulk.fr (12.234.24.109.rev.sfr.net [109.24.234.12])\n by leonov.paulk.fr (Postfix) with ESMTPS id 626201F8005A\n for <u-boot@lists.denx.de>; Wed, 29 Apr 2026 13:08:04 +0000 (UTC)","by laika.paulk.fr (Postfix, from userid 65534)\n id 95869B404A0; Wed, 29 Apr 2026 13:08:02 +0000 (UTC)","from shepard (unknown [192.168.1.1])\n by laika.paulk.fr (Postfix) with ESMTPSA id BC82BB4049D;\n Wed, 29 Apr 2026 13:08:00 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","Date":"Wed, 29 Apr 2026 15:07:58 +0200","From":"Paul Kocialkowski <paulk@sys-base.io>","To":"Andre Przywara <andre.przywara@arm.com>","Cc":"u-boot@lists.denx.de, Tom Rini <trini@konsulko.com>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Jernej Skrabec <jernej.skrabec@gmail.com>, linux-sunxi@lists.linux.dev","Subject":"Re: [PATCH v2 1/3] sunxi: spl: fix SPL_SUNXI_LED active low\n configuration","Message-ID":"<afICrnsK3Frmp7Hp@shepard>","References":"<20260429092828.3076719-1-andre.przywara@arm.com>\n <20260429092828.3076719-2-andre.przywara@arm.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"l3/hIRm247/+OaIU\"","Content-Disposition":"inline","In-Reply-To":"<20260429092828.3076719-2-andre.przywara@arm.com>","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]