[{"id":3683971,"web_url":"http://patchwork.ozlabs.org/comment/3683971/","msgid":"<20260429101203.4058-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-29T10:12:03","subject":"Re: [LTP] clock_settime: use POSIX runtime detection for\n CLOCK_MONOTONIC","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Andrea,\n\nOn Wed, 29 Apr 2026 10:28:35 +0200, Andrea Cervesato wrote:\n> clock_settime: use POSIX runtime detection for CLOCK_MONOTONIC\n\n> +/*\n> + * Copyright (c) 2026, Linux Test Project\n> + * SPDX-License-Identifier: GPL-2.0-or-later\n> + */\n\nMissing `Created by:` attribution line. Other headers in this directory\n(posixtest.h, mq_send.h) carry it. Add:\n * Created by: Andrea Cervesato \n\n[...]\n\nPre-existing issues noticed in the surrounding code (not introduced\nby this patch):\n\n- clock_settime/4-1.c (and siblings) — uses `test_main` instead of `int main`\n- clock_settime/helpers.h — `getBeforeTime()`/`setBackTime()` call perror()\n without including in the header itself\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/25102778503\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=cb5Ei8Hr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Clf0psMz1yHZ\n\tfor ; Wed, 29 Apr 2026 20:12:14 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id E48203E2537\n\tfor ; Wed, 29 Apr 2026 12:12:11 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 161C33E1A9F\n for ; Wed, 29 Apr 2026 12:12:07 +0200 (CEST)","from mail-dy1-x1341.google.com (mail-dy1-x1341.google.com\n [IPv6:2607:f8b0:4864:20::1341])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id BACF220015B\n for ; Wed, 29 Apr 2026 12:12:06 +0200 (CEST)","by mail-dy1-x1341.google.com with SMTP id\n 5a478bee46e88-2d868d014a5so12222208eec.1\n for ; Wed, 29 Apr 2026 03:12:06 -0700 (PDT)","from\n runnervmeorf1.gqycc2zpl1wenkeeoydy3zbfbh.dx.internal.cloudapp.net\n ([52.159.247.231]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ed1bf6d315sm1639269eec.1.2026.04.29.03.12.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 03:12:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777457525; x=1778062325; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8EzMJs/KfUS/wYg1X35fA9CPv5i85EUrqzlWCcpBu3E=;\n b=cb5Ei8HrR6a6h0wrv5oDXMpO4MLGZpDPyzcx3ElJh31zWpvy952bDPEP/K8PgRT8sa\n 5iBMexrkbl9x0l5IbogLAPyrAqO+Bt1m2ACp25dsjFZgLmvpPBV/HArYBuj9uLjgrSod\n zGSeyj5JYKKK7J7tddK8fEX0TCuXB4C1PSFeiuGIg9qHE/K/Ayxyh8QEhverTxt3Gc9H\n /oBpp1lMPYbwUYYPlK0Bau0qD3iKMjlgo9AltNXCTBH/+UCUvvTcA18VqfV91JPiLcoy\n YeyRrAKQpjgil7sgyoucfc6N/O2vZ7d1wwj+PeAvcS8v6U3bQvIsryC9gejgpM40Lxgv\n TmVg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777457525; x=1778062325;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8EzMJs/KfUS/wYg1X35fA9CPv5i85EUrqzlWCcpBu3E=;\n b=oEX2jvM15J2b0frXcE7vi9NSOjSlVx8ODGWTMNINaggy88SR/LRLulhtuyCkJLJ2c5\n 98xhcc9rBtd22KoSJGfSDTyLRHg96w91wmFDsdQhLFlrk9T6kHjGHv8Tcd/H0q5yZj1j\n rvzWx98NfwbD+avwi1agw7OjGZJtLn6/eVgRUSFUWD3umb7ksrU3v5+c3OZf5ZtOC93X\n lot0rHRzR1d0W8Sq4sXQQ7ZZdJajWf81xgtW/U8frccp12Mfky0R0ycgx23AchXMeE8k\n QW9xLxf7akKoobaZVUB2nf5ycgN26PsvvzxFd51bb0wArhGRBoCRrI3nw0VEY1PpA6z3\n Hm7w==","X-Gm-Message-State":"AOJu0YweQqo9MK/5pWcjA0jMOOEGwA4IoNS5Vxn9OmFloOpsE44/fK1s\n REjdybrdr5YNk2idimx2+C4hTugu6/M9nOtYo+gu1uso9KVd18dXic5B","X-Gm-Gg":"AeBDievMRoFyRSOihYcnRNpQDDMkczis5c0qPQ2TKndFpWzO0CwaH2ankRQ8/HgIt06\n VORQ3jGCQCqIbZ9GhPit2tm9m5lZ8p5mRhkKcJT428D3y2mxMAxfJntt3Ea40Ndn0FBOrrBxlWP\n 1ybYUzskRMMSMFZ81ZP9lvPyay2YJt+ABqeoRBb1EJ5nKKJOxPEF1bUoWB+q+2xWOZvoCONqd77\n ukJNCUMH53ExVHtNBXWi0Cx6swL6aIjLxpJYxH1Yuj6iA12XXkYGA3drd+WJl2eYXzCWldE3pKN\n 2PF2gRS8orcdoGpxHdnFlt9opE2Ao0pYjW4KK69s+43qC6cHpQ3iOi8SJwLzA1+8zELsCGjPiKk\n sxTbhlWem5jFRkQIrLTlmaCix1fwtEf9HsonoP/lmOU9ccfhArpmO8qtci1YyBqSIo5UkmGVWaW\n oYklEPjtgJaKxMrChd5jlCjfuhr0klkl1I53BE+AmO1KqrcIU3791VOCu0TG9b2QirLEBUMBtyp\n r8Zbv4kF6sE8qLlAMGEPhisXon88804SRTVUlyebw9Zs9O0vGc=","X-Received":"by 2002:a05:7301:d8f:b0:2d8:b814:29af with SMTP id\n 5a478bee46e88-2ed19716925mr1418130eec.3.1777457524960;\n Wed, 29 Apr 2026 03:12:04 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Andrea Cervesato ","Date":"Wed, 29 Apr 2026 10:12:03 +0000","Message-ID":"<20260429101203.4058-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260429-fix_clock_settime_helper-v3-1-2608c39d8499@suse.com>","References":"<20260429-fix_clock_settime_helper-v3-1-2608c39d8499@suse.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] clock_settime: use POSIX runtime detection for\n CLOCK_MONOTONIC","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]