[{"id":3684836,"web_url":"http://patchwork.ozlabs.org/comment/3684836/","msgid":"","list_archive_url":null,"date":"2026-04-30T16:38:44","subject":"Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix RSS LUT memcpy size","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/29/2026 12:42 AM, Larysa Zaremba wrote:\n> Based on the following feedback from Sashiko (received for iXD phase 1\n> patchset, but valid for the net tree):\n> \n> \"Is the bounds check xn_params.recv_mem.iov_len < lut_buf_size sufficient?\n> Since lut_buf_size only represents the size of the array elements, should\n> this check instead verify that the payload is at least\n> sizeof(struct virtchnl2_rss_lut) + lut_buf_size?\n> \n> [...]\n> \n> Does memcpy copy the correct amount of data here? rss_lut_size stores the\n> number of 32-bit entries, not the size in bytes. Should it use\n> lut_buf_size or rss_data->rss_lut_size * sizeof(u32) instead?\"\n> \n> After inspecting the code, it was concluded that RSS memcpy size is in fact\n> 4 times smaller than it has to be, since a single array entry in a u32, and\n> rss_data->rss_lut_size is clearly used as an array size. Required Rx buffer\n> size is also too small, but this is a common issue in the idpf code.\n> \n> Use a full buffer size (lut_buf_size) instead of the array length\n> (rss_data->rss_lut_size) when doing memcpy of RSS lookup table.\n> While at it, increase required Rx buffer size to a whole flex-array\n> containing structure instead of just the array.\n> \n> Link: https://sashiko.dev/#/patchset/20260323174052.5355-1-larysa.zaremba%40intel.com?part=8\n> Fixes: 95af467d9a4e (\"idpf: configure resources for RX queues\")\n> Reviewed-by: Aleksandr Loktionov \n> Signed-off-by: Larysa Zaremba \n> ---\n> drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n> index be66f9b2e101..a97d2e9b54d4 100644\n> --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n> +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n> @@ -2916,7 +2916,7 @@ int idpf_send_get_set_rss_lut_msg(struct idpf_adapter *adapter,\n> \t\treturn -EIO;\n> \n> \tlut_buf_size = le16_to_cpu(recv_rl->lut_entries) * sizeof(u32);\n> -\tif (reply_sz < lut_buf_size)\n> +\tif (reply_sz < lut_buf_size + sizeof(struct virtchnl2_rss_lut))\n\nThis feels like it should be using struct_size or flex_array_size...\n\n> \t\treturn -EIO;\n> \n> \t/* size didn't change, we can reuse existing lut buf */\n> @@ -2933,7 +2933,7 @@ int idpf_send_get_set_rss_lut_msg(struct idpf_adapter *adapter,\n> \t}\n> \n> do_memcpy:\n> -\tmemcpy(rss_data->rss_lut, recv_rl->lut, rss_data->rss_lut_size);\n> +\tmemcpy(rss_data->rss_lut, recv_rl->lut, lut_buf_size);\n> \n> \treturn 0;\n> }","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=iVZ2URSS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g60HS2zB4z1xqf\n\tfor ; Fri, 01 May 2026 02:39:00 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id EAC9E42B69;\n\tThu, 30 Apr 2026 16:38:58 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id zEHsxXWuO6GK; Thu, 30 Apr 2026 16:38:56 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D9C4442B68;\n\tThu, 30 Apr 2026 16:38:56 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 08C6218E\n for ; Thu, 30 Apr 2026 16:38:56 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id E2935424FB\n for ; Thu, 30 Apr 2026 16:38:55 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id DLwTmKJuIpD1 for ;\n Thu, 30 Apr 2026 16:38:55 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.20])\n by smtp2.osuosl.org (Postfix) with ESMTPS id A158140089\n for ; Thu, 30 Apr 2026 16:38:54 +0000 (UTC)","from fmviesa010.fm.intel.com ([10.60.135.150])\n by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2026 09:38:54 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Apr 2026 09:38:53 -0700","from ORSMSX901.amr.corp.intel.com (10.22.229.23) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 30 Apr 2026 09:38:52 -0700","from ORSEDG903.ED.cps.intel.com (10.7.248.13) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Thu, 30 Apr 2026 09:38:52 -0700","from BN8PR05CU002.outbound.protection.outlook.com (52.101.57.28) by\n edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 30 Apr 2026 09:38:52 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n CO1PR11MB4929.namprd11.prod.outlook.com (2603:10b6:303:6d::19) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9870.20; Thu, 30 Apr 2026 16:38:47 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9870.016; Thu, 30 Apr 2026\n 16:38:47 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org D9C4442B68","OpenDKIM Filter v2.11.0 smtp2.osuosl.org A158140089"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777567136;\n\tbh=b8GHjb1ptpDV4xgqteHfTSBvpCD3p34ZaVV7CNQTalw=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=iVZ2URSSk3LOylEsv9Pizhvb/F5ua/UXDm/ptu47/3wx5mD7OlzeqCcyDZSChS5Ge\n\t qiQHHxIM+f95CDKiw717oE037Ypa+GdXan2YQQ53gRGfYZQ7eOOc7YtQheW8LUq8sT\n\t zN46XBtbqMXJ3AVKNuRBxYFugGh1BGOa8A9vzN9Gx81HeLAStS3iMOIDL3i3OY5PIT\n\t 7JrMNldh/dFlcwDUQgSzxWmBH1PKqgyLULLRDfouTKpdaW5GkUPp46y6WmThVeJCyF\n\t EPTqGXnlxEflEwKYof3nufIzcTKQk57UOYBoqt8y1AujXDjMoMHOXvXk/lqtB0Duym\n\t qZAi+4z0P/0OA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.20;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org A158140089","X-CSE-ConnectionGUID":["zdrYCaoiQ2qD+NmHug+Xbw==","Nbe8uZjgSiCYQK/RTUnRqQ=="],"X-CSE-MsgGUID":["ROr0lurASguBUX68gxxwhg==","ha1qKy2ZSOC0m291jMesmQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11772\"; a=\"78237266\"","E=Sophos;i=\"6.23,208,1770624000\"; d=\"scan'208\";a=\"78237266\"","E=Sophos;i=\"6.23,208,1770624000\"; d=\"scan'208\";a=\"230279922\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=KHS5nJCNe9ak+uXbZJoRsCc3AXMj6oFkFc7Mnva6k1Z841Ha826j/avtIoz5U3oAmVLVxvs8YztJwDrEURQaLYAfYIbtyI1CgKTLWb3CoDLwmkr15e/vp//jwSHULlZeSF3nq7T0/eCEtfiQy9VxMgmHJbQdQImdkzcrmlYbeONYG78dvkfPpQGaZKAfCzK4kpvl/A+V4p34s7st/kHvQ+xJ6V1ehCk/0qyXw3L/R9J0M1TFYIs8TE1twLedNR1ifv9moEPyYin74pscc2sHl1agl+NV2AoW1r7RmIq2WLdTjWmnFmZYRxtYBR17cFtTm0AUt0IIAWXAfD/M8boMvg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=b8GHjb1ptpDV4xgqteHfTSBvpCD3p34ZaVV7CNQTalw=;\n b=QnILhA1OESwZnjrGU94ScpKlRSprDQiEcJhElvGVtuaxvg56WJ36q4kihttrtKTCU18l4w9OoP7JN7YwZ7dxlLlfk09KtyUD5W2dz9yqTXiJk/hLfzQ5IcN3Rb/M5DVU0P+MXUOX+bsglBRsZaKFDB2fhMu6rCOYmbjdfmjwWlx5If6iEPaxq2eMUyvQG73plZcjHu6xjX+hoTP0aQJQcJ8Vliz141J0PWUzkbfih/p+i5t4bnrQTrzb0QQ6p5TJaVoxXZLM1WVhhBKkErSOboOcjS8z85Melu3WSep1QNNIM+tK/LWPBI/WXSO4HZk9SpxoOKpe36vRQ93gHPiiAw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"","Date":"Thu, 30 Apr 2026 09:38:44 -0700","User-Agent":"Mozilla Thunderbird","To":"Larysa Zaremba ,\n ","CC":"Przemek Kitszel , Andrew Lunn\n , \"David S. Miller\" , \"Eric\n Dumazet\" , Jakub Kicinski , Paolo Abeni\n , Joshua Hay , Willem de Bruijn\n , Alice Michael ,\n , , Aleksandr Loktionov\n , Tony Nguyen ","References":"<20260429074232.180528-1-larysa.zaremba@intel.com>","Content-Language":"en-US","From":"Jacob Keller ","In-Reply-To":"<20260429074232.180528-1-larysa.zaremba@intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR02CA0002.namprd02.prod.outlook.com\n (2603:10b6:303:16d::10) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|CO1PR11MB4929:EE_","X-MS-Office365-Filtering-Correlation-Id":"a37a2f27-aca6-41b6-08de-08dea6d6f39e","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n ew9XUAeLCcGjheRfgSDFbLugEg+VQ5GJJO5CmbKlxwzsh5LtQPQl5BkRV2cRs4mBlqmdQAJUp/YTIFZ2i6HVhFav40lgEzcUGgOBxzdoHndnqYMX71SwksdiV30BG0KpUgONvm92yYxOQ5Uk3/ISnLEuXtQQbJ6ju7RLu/pb3JOXjMdMP9qaDiTh1QfoX7+fcUl4Av/jVbOwOCPWG8muLpEwSvBmIXZUStSJvF2+0LJvolwkiJRKygsCbn8ydrm1eAzI/TE5qOyNBto3v1f9mL+mKhIREM6ieTr/Syd1zYoRkqKGKmbqR+qTpDCOZ5vchvrgNF7/vGCTuYqJSf7eS+swArfcfycsq/7hLRooi8ItsTU7HbLnvzmOE6Fy99VLAEuU5JorHtCLwk0D1/OvsR0BgLTpnnU9SB7/nzoz8NQQqcb1q4YCWg1C7VwuDQDIOq/yBsFQ2TLck8X5R6TN2DrPAC1ia8QpAyw9b3/Mg90BRH0gBIt9ES68YiWqWDH9aSikxu/kNI/pDWemuJ3vgmpJ0dSI4S8XWme1XggUaJLG//3YnH18xLOE9iPGTAruaPF4c81RPCjEEaGYeRcLccNEoQL31maax9LDjWr6NrkzjZ5Dchx6VqPGKgaoB75iOrzPC6rcru09ToI6bCTmoRBSZyL+mXHE6m6B5E9GrSzclH+sIgQEPRtN+EFzXuaE","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?PQ4l+CoA3Iry5VuYOo1U//LIN/3t?=\n\t=?utf-8?q?faGLZTg70dSe9bsFThMmuw4ZxugCYWtPJ1aRvtAzQAIw/wdKTiAoQu7vL8Fg9qS0T?=\n\t=?utf-8?q?nHnUtm8XH1XfdwjQhmFPoEznsTa1o+WRz8bnuzrCIASJIIZ0hXVv6ywvPKxrCGepq?=\n\t=?utf-8?q?zvhHH7d1Ix6YjGdK/T0osDYPmLZ82SpTJCTY4lGMmdz6Hg142U0EzzBAcjWQ1Eknu?=\n\t=?utf-8?q?M/sRUZrZqow1zYHXM/QNvZgXmmc28SfZTfFF1QpuD2PHtSmwdQWPWm3V99a1iLCjC?=\n\t=?utf-8?q?vwJdQ818wZwf8soLU9UYfPe6a6S9y92WXgZm55XJe5VPOEJ97qnvzDBHW71XcytzR?=\n\t=?utf-8?q?gfvhYUVo/1rYGARnKwuh0TJXRLgQ+FZWcPgGiESC/Hu8w61UsUXWDlClS+MQx5v2N?=\n\t=?utf-8?q?i3rY2CPXW491JkKUxOpPvU99c7tTicdo19K/CiFhYeFPo0F4v3+Ke17d9zt4zRDgB?=\n\t=?utf-8?q?P2hFhGjp0q3pmlYnATr9lRt/B1rlY9jgbdjdnp0N0bwqq9lMAt46zIi/mkukgeWz/?=\n\t=?utf-8?q?x08JbSpb8br7gXFm6M5yH68wq5l3mVbCTgWDFUkx5wAm8T1oTByteLOysoG8ixacp?=\n\t=?utf-8?q?UQ4YVPfPc4wEsTsckYGsSO6HbKdXiq8xA/nvLrxkQikt4e86s2CFILH7WkYGmhuUO?=\n\t=?utf-8?q?PM9nsD72q1OzzzwwtCu2Htxn3Mo6QF0ey/hzF+4iJX9Y2kV7u7zN5+JCKJhM7uFzH?=\n\t=?utf-8?q?bcYad+8pR1vlXT7Zyu3a8Y6oNcivNBLMyLkS1W825y2vZNEBhZouczsb+bWM0TOj4?=\n\t=?utf-8?q?zROw0cGV2XmFl54czliL/YC9SswVp70Yt11Ygp3snANFJ8Ei4vxlzMnb3LwajCW0a?=\n\t=?utf-8?q?DgUnZREkfylRU6skwoi4j1jU22M10JMFdP/vVosHyFL8Mo9BMBDxWz4ulUMmWcaqm?=\n\t=?utf-8?q?JoaMviCWZ7vdlvJDxq+zHAq76U4kXYDrLfNcaAPdzKzljkrrZuv1TzuFbAY1/PRiJ?=\n\t=?utf-8?q?F9hwPtI0TitBlBbnKhcclnUatXPVUofBXaL+l3pzhhK/mj4LDuIll9KbIUt/CUIiW?=\n\t=?utf-8?q?1rNDvjGoBDGl/m3lx94gYn7Q7J6pCVAkIBNKkUfhBgIjAHtLDHeZ58EYk2g8QHGLh?=\n\t=?utf-8?q?T/DiWxoiMmcn3zsQcQhm8JulDoxbjXHNNTZ3mQg4a/NNK/NfjC+78NzCAuc0Iwtz1?=\n\t=?utf-8?q?RO7QhL8BgXptAxuSwhay655S3bNwED5jM5YYIJ4cpLbfV3AJKZDFyE/o94qdcsKnB?=\n\t=?utf-8?q?FcogNps+Ryfav3B6eZWP+7duQqrAiJtLWL2JAC4YNiHMxJuqz+9dDy/jKHMx//eYB?=\n\t=?utf-8?q?vzEmfbZ+UrkPBtteYioPW5mRdEzMDRxr2q9haYfBTimXf+dYyjXdrWt555dBKd35j?=\n\t=?utf-8?q?eXLwGNycaj0KwbCjj+RetTsXbC9uYB60Gk4LyA4/FE0KhB+4F7fiOsySXusWYNOKj?=\n\t=?utf-8?q?xyjboPaBsqKXIG7RQ4mux4XbRAz7wvrhM7gc7TLirt7pywShXHySYdc6fu2ph4LhK?=\n\t=?utf-8?q?OfGNjrGiY7pCIb26XXNe5UG0p279DNDmhGwe6NIfB+T5vYG5p+h31GjpOHHTPIUTu?=\n\t=?utf-8?q?AjgZgO4Rio//J52POpXL813JAIZx7ULuamO2IhkvPvrHwa+Y+Y0VNQJbeTEhcV+Hw?=\n\t=?utf-8?q?Zasn0gnWzyDh5g8q0Korvnvqwcy3uWhdbrvwasqP2vHNsRJW5njfsCfVnB8QTfGHa?=\n\t=?utf-8?q?kU49Iq25lJSEAytTvsyfaq2gmkOWXkrdGEh4bsjvESV/KLFZ91AX0=3D?=","X-Exchange-RoutingPolicyChecked":"\n pCnlUE3KKKMn3iBPazcPFy5Xt03OZ9kAuB09I7DzdRyepXul/bIuWvPUygielnJuwzHUUcceBdO//s+IMGyTQQ1sNR7OtKLvXPcP0220JUww890HDknAymBRw8Gx0oraePuLMnrkKeyhFwwUTm/N/Xghzga4khXCx/2kFCRENAX2XD5uxMxcBO78G7oPGarxhQrRC98odK6hpwZqUqon2J7+3JjDSZt7OKvd5vV/6oC6caGF3uTcvr+8JtSz56M/ctk8KurqBjTPH5L866NV2wx5SPiOmwdrQLv1Qm4f7YxMnNI1JmuEnaR1H9FTTQgMK6EpzmU59F8HvdDZOBSCxA==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n a37a2f27-aca6-41b6-08de-08dea6d6f39e","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Apr 2026 16:38:47.5030 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n UK78BW8Kqr/hg4Qzm5AoIl7dNfTLAjX8af2OnEwZxFBEyP82thKzdovY2j5Weyeihps1Encoo3WOv+/XGu6knB1zYH3IhRR6HjGTAf8T9Vs=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CO1PR11MB4929","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777567135; x=1809103135;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=Nty5e9fibnG4aqfDqdzwtDvEVZ44AoXTQJLwJ0Q5oV0=;\n b=Gtmy2uqeZSTpzHdOgP7KJttmZfi1UVLKiIP8BiK4GoJ+hTeJzNIqaQtX\n TGg0qhv18jOsdA6TX9hOQoiTIyjavw01oGWUitedjYHmKaAuEo0vukPdu\n /tE3sMyHKR/Ti6tHqUaGNxhdizMd3zgRlQ6/XXC81wiKD9XLsym+F0qn2\n +4dyMfwOEOHLrUY6cyVK5S9ght6qk90pSDgyN9KRpfXDaWDuxhhJsGZO0\n xHeA11DkDWz3XtrMA3QA5XJGTd9tcp0WXaeTbLMKeMn7d/jzZAheSL7yv\n pjmgkN8Y+tfF8SZcoKQ+iR7mrMwlN4+tnRXzI0WxoY13Pijr+TbdoVtTv\n w==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Gtmy2uqe","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix RSS LUT memcpy size","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3684853,"web_url":"http://patchwork.ozlabs.org/comment/3684853/","msgid":"<20260430165831.GD900403@horms.kernel.org>","list_archive_url":null,"date":"2026-04-30T16:58:31","subject":"Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix RSS LUT memcpy size","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Wed, Apr 29, 2026 at 09:42:30AM +0200, Larysa Zaremba wrote:\n> Based on the following feedback from Sashiko (received for iXD phase 1\n> patchset, but valid for the net tree):\n> \n> \"Is the bounds check xn_params.recv_mem.iov_len < lut_buf_size sufficient?\n> Since lut_buf_size only represents the size of the array elements, should\n> this check instead verify that the payload is at least\n> sizeof(struct virtchnl2_rss_lut) + lut_buf_size?\n> \n> [...]\n> \n> Does memcpy copy the correct amount of data here? rss_lut_size stores the\n> number of 32-bit entries, not the size in bytes. Should it use\n> lut_buf_size or rss_data->rss_lut_size * sizeof(u32) instead?\"\n> \n> After inspecting the code, it was concluded that RSS memcpy size is in fact\n> 4 times smaller than it has to be, since a single array entry in a u32, and\n> rss_data->rss_lut_size is clearly used as an array size. Required Rx buffer\n> size is also too small, but this is a common issue in the idpf code.\n> \n> Use a full buffer size (lut_buf_size) instead of the array length\n> (rss_data->rss_lut_size) when doing memcpy of RSS lookup table.\n> While at it, increase required Rx buffer size to a whole flex-array\n> containing structure instead of just the array.\n> \n> Link: https://sashiko.dev/#/patchset/20260323174052.5355-1-larysa.zaremba%40intel.com?part=8\n> Fixes: 95af467d9a4e (\"idpf: configure resources for RX queues\")\n> Reviewed-by: Aleksandr Loktionov \n> Signed-off-by: Larysa Zaremba \n\nReviewed-by: Simon Horman \n\nThere is an AI generated review of this patch available on sashiko.dev.\nIt seems to me that the issues raised there do warrant further investigation.\nBut that they are pre-existing problems that and don't need to\nblock progress of this patch.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=dee/b1KR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g60kB08Fzz1yHZ\n\tfor ; Fri, 01 May 2026 02:58:42 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 78D3684EC2;\n\tThu, 30 Apr 2026 16:58:40 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qto9XTPoMJwA; Thu, 30 Apr 2026 16:58:39 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id AC2A284EC0;\n\tThu, 30 Apr 2026 16:58:39 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id A446B18F\n for ; Thu, 30 Apr 2026 16:58:38 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 891666E3B4\n for ; Thu, 30 Apr 2026 16:58:38 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xnmP2Dky8RoB for ;\n Thu, 30 Apr 2026 16:58:37 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n by smtp3.osuosl.org (Postfix) with ESMTPS id CFE4C6E2A9\n for ; Thu, 30 Apr 2026 16:58:37 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 6AC9B417B9;\n Thu, 30 Apr 2026 16:58:37 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 54969C2BCB3;\n Thu, 30 Apr 2026 16:58:34 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org AC2A284EC0","OpenDKIM Filter v2.11.0 smtp3.osuosl.org CFE4C6E2A9"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777568319;\n\tbh=vHNk/DO3McKq+d10DsKRU2fzDmeFGYWNzn/M1ngYQ2c=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=dee/b1KRnOSypz06eJJBt8j0atkPYKvco/4ib65Rn17RKojwBc9isj13G//V7TM/W\n\t GPZewWCXsehG2Qh0s8m5QATpCkAszDAJcEGY/ss/996HAHC9po21kI8WMotNW2h4RQ\n\t CD6JdyL7Ce2ygfrB6mLD34jDn6rkVY3I6b9YoimFG7BQ48A/ZA8O1QSwlgeHoo5FCY\n\t cDJp4UQFMfJC/3bzvX+MID1Io7K35IBsVx5+xsCkr7lU2NRgpnDn6EcDvIYwMI2Gy5\n\t yBV+Bcximy02xAY+J8OXARl6Kjj46DxpAc9llwOH4b9U89UBf8JW8JPw2S6rb26sPu\n\t e0+baYLn10qeA==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=horms@kernel.org; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org CFE4C6E2A9","Date":"Thu, 30 Apr 2026 17:58:31 +0100","From":"Simon Horman ","To":"Larysa Zaremba ","Cc":"intel-wired-lan@lists.osuosl.org, Jacob Keller ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n Joshua Hay , Willem de Bruijn ,\n Alice Michael , netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org,\n Aleksandr Loktionov ,\n Tony Nguyen ","Message-ID":"<20260430165831.GD900403@horms.kernel.org>","References":"<20260429074232.180528-1-larysa.zaremba@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260429074232.180528-1-larysa.zaremba@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1777568317;\n bh=oNHjGy1r4xF2BdPh7vABQlnmsczhl5WvYkdeW6mbptU=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=YxbSnqUVc7GhmciR0Mv21C2vykFgEax/IgQBMTl2neLs+v01uqHDCF4Y1xTAV100Z\n d5/LUx6zBcMOc7gPV/3Ykt/7mKV9S9YFf00aMfTyHt0OQy41/7ktk+Fam7xrCoPNun\n /ZtPkc4fCUHrTFoq0tOw9IMO5v/5bSJSuYXk0ZmgkNdbiF+Ax42ektWHkyyi3PnGFD\n ClYjoce+BUtZ6JhDoogz1cCLCiuTyakB2LGhFIaIoTs9lAlP9URI+MRzT5HbPUUY5N\n B96RHeDAFhHyvRizPG9CAFmiUUZGPmmYgsmL4bqdUVZ7+s/EVp2G8jodOxyTc5LZ/C\n mkshd0Pn4rGsQ==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=YxbSnqUV"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix RSS LUT memcpy size","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]