[{"id":3683896,"web_url":"http://patchwork.ozlabs.org/comment/3683896/","msgid":"<3e682dbac6f3ef5f30ed99612ef8c78e256d3e9c.camel@siemens.com>","list_archive_url":null,"date":"2026-04-29T08:26:28","subject":"Re: [PATCH] fdt: check fdt_pack() return value in\n fdtdec_apply_bloblist_dtos()","submitter":{"id":85639,"url":"http://patchwork.ozlabs.org/api/people/85639/","name":"A. Sverdlin","email":"alexander.sverdlin@siemens.com"},"content":"Hi Michal!\n\nOn Wed, 2026-04-29 at 08:22 +0200, Michal Simek wrote:\n> The fdt_pack() function can return an error code, but its return value\n> was not being checked. Add proper error handling to propagate any\n> failure.\n> \n> Also fix typo in comment: \"Shink\" -> \"Shrink\".\n> \n> Addresses-Coverity-ID: CID 645839: Error handling issues (CHECKED_RETURN)\n> Signed-off-by: Michal Simek \n\nReviewed-by: Alexander Sverdlin \n\n> ---\n> \n>  lib/fdtdec.c | 7 +++++--\n>  1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/lib/fdtdec.c b/lib/fdtdec.c\n> index c6e13b6abefd..2d66860f6ed0 100644\n> --- a/lib/fdtdec.c\n> +++ b/lib/fdtdec.c\n> @@ -1781,8 +1781,11 @@ static int fdtdec_apply_bloblist_dtos(void)\n>  \tif (ret)\n>  \t\treturn ret;\n>  \n> -\t/* Shink the blob to the actual FDT size */\n> -\tfdt_pack(live_fdt);\n> +\t/* Shrink the blob to the actual FDT size */\n> +\tret = fdt_pack(live_fdt);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n>  \treturn bloblist_resize(BLOBLISTT_CONTROL_FDT, fdt_totalsize(live_fdt));\n>  }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.a=rsa-sha256\n header.s=selector2 header.b=pzdwJtDQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.b=\"pzdwJtDQ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=alexander.sverdlin@siemens.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=siemens.com;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g59Ps30w4z1yHv\n\tfor ; Wed, 29 Apr 2026 18:26:41 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 71422846F8;\n\tWed, 29 Apr 2026 10:26:33 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 96260846F9; Wed, 29 Apr 2026 10:26:32 +0200 (CEST)","from AS8PR04CU009.outbound.protection.outlook.com\n (mail-westeuropeazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c201::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8A392846F5\n for ; Wed, 29 Apr 2026 10:26:30 +0200 (CEST)","from AS8PR10MB6867.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5b6::22)\n by AS2PR10MB7904.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:648::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.37; Wed, 29 Apr\n 2026 08:26:28 +0000","from AS8PR10MB6867.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::9126:d21d:31c4:1b9f]) by AS8PR10MB6867.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::9126:d21d:31c4:1b9f%6]) with mapi id 15.20.9846.025; Wed, 29 Apr 2026\n 08:26:28 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=ZU8RAkdzvPEeupKaI8DewAtyqJCTbiNsSwmvBmKqcToC4eDhYZi6+CxHWu7WSoFJab1JBuANmHWAFsYGtkcHCFZqLqz42XdKI0md+o8JEDwKfXdwjsqN8a+PwZwiMvudnUYt00TvfcXN1zc2xQVaVou3KXn83CmSC6EzHTmuueLoloJTB+0bxGBXxDhfd7wSmT/yvSwHoMj4jWpR2wINMcId2hWDhhv8bxFKhT++wnlL1/wa7kCYpSmLt0kbFNV9CdYG2dMVPjWy5Z9vsBOQWCkMrBlD8NNfGXmQzdii2xs0JfsIYvNIpzAyQvU4sI60qvQjYp8zq1rSaZ5f4KEe/Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=kLfL5mQZk3iYZt1SkgXu0rx7F/zRNmn5umaYUjsrACE=;\n b=DFulvAPRRCIyklFpEnGzHLJbCGJ2zVf7cFxOTHFFlXhH50RKtBo2soiHSKKQJ4ZXyFxfanoG8T1TA3YHAjKXKL8dj1vUJ0MAgAy1zU6o9Mej7GUK7qNLY3S0bneqnCj/sHvovqlMT9hhE7H3J4fcE/2E5PnJpb6GcoqsMzEBwZ4O9lI7uvNYDP0olQHElhOU+HbjosD7LBIpQOBRYqfmpTCjQSqHDfUcAn9PW/BtPFMPPs93GfCnbyaQ2kIM0V3TjPfbiKwhFHOLAZjtYSUcDBvhJMur3LCRbjZtA7j9sMmfeC6ZMUac+mUrDVEllFkF6ipdLOY3+E816oUuwfy9cg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com;\n dkim=pass header.d=siemens.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=kLfL5mQZk3iYZt1SkgXu0rx7F/zRNmn5umaYUjsrACE=;\n b=pzdwJtDQ4fMcVMlKLYNhMqptMLfVfCEruCWDFsmVgyLSfN6fBAaBRSZ7LEWc2TVNAsRag4vUl9p2pIy9entuJ7ESZRqTIQVKjlkBaa5rUSftWj/tFqlBszfIY8FZ3xnXqwhvgpgG8IC+b1Ucg1WBZk9tYFzJRi8ORfMivhfo8xyrGoIW440nDvMfKwiMV14QnRKLLqr7I/tQhaydA2iDO743yFhGScBxGIzpKBYtTjNCg775ydSvuDO99w+zM0MCtnW3GyX2pfmSXqUdYGQAt871mpbhe8S1YnHroUbBT+O9GaXYVIWArFdnXS3i6tWC07dpwG2eHdAlADIuB3dLJA==","From":"\"Sverdlin, Alexander\" ","To":"\"michal.simek@amd.com\" , \"u-boot@lists.denx.de\"\n , \"git@amd.com\" ","CC":"\"trini@konsulko.com\" , \"pranav.sanwal@amd.com\"\n ","Subject":"Re: [PATCH] fdt: check fdt_pack() return value in\n fdtdec_apply_bloblist_dtos()","Thread-Topic":"[PATCH] fdt: check fdt_pack() return value in\n fdtdec_apply_bloblist_dtos()","Thread-Index":"AQHc16CTUSlpVUN+0EmeHyKaiBpvQLX1tHwA","Date":"Wed, 29 Apr 2026 08:26:28 +0000","Message-ID":"<3e682dbac6f3ef5f30ed99612ef8c78e256d3e9c.camel@siemens.com>","References":"\n <3eeec4427b9ce9bb4abac4e27414ea1cb687e45b.1777443726.git.michal.simek@amd.com>","In-Reply-To":"\n <3eeec4427b9ce9bb4abac4e27414ea1cb687e45b.1777443726.git.michal.simek@amd.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Evolution 3.54.3 (3.54.3-2.fc41) ","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.a=rsa-sha256\n header.s=selector2 header.b=pzdwJtDQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=siemens.com header.i=@siemens.com header.b=\"pzdwJtDQ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=siemens.com","phobos.denx.de;\n spf=pass smtp.mailfrom=alexander.sverdlin@siemens.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=siemens.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"AS8PR10MB6867:EE_|AS2PR10MB7904:EE_","x-ms-office365-filtering-correlation-id":"258eded2-3358-4fe3-2175-08dea5c90295","x-ms-exchange-atpmessageproperties":"SA","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|366016|376014|1800799024|22082099003|18002099003|56012099003|55112099003|38070700021;","x-microsoft-antispam-message-info":"\n meZwh4cHlELD+KecLqdOFm2hAszWOSeW7Q2dMaNQ3baOhF3qqlZZv667sT1+FprZHXtoaBWdNT4TQDSSDb63bFKgTjmximZWH63UpmNcwWWprmjoUYCA5TWQc5mvyfcpAakjfGo8e4z2IC22yihSsnOND4pTWgBax6Luy5Um/x70m+Xt0ZduU3SrwUoqt+G98nkqmwojOsQakKem7cvyQPD5+I/tIgEkRofQ0xtvvjGjZIWUfNcASdgOcplzZoG0HNGSHJdsLWOKQ5LLTdqKp0GYkHPGzOtzUBXvPMcXHjgkeBB6OIxJckNkF3FoqW4BmP97Ws3Ot0hkPySPHJ3AS4IpAOixOyuYJ6NYPFjcvTZSxZ+TbLcSHdWAd58RGZnuMgWLQcys4+bHBPDEv5RhIVDXeS9vT8MHMByvZh0bFyqHZ9d9/Kqh808TDlaESVynfHCZnqxe3Qm4YawcWkrvgC/Ra4ZN88KYL4SVatWeloQBp+z65HHOyZ9MO7c3uMIhV88d8WU4+7Djnz5+Z/ld0hctILmxtKstKECLxwrWDRJWfpcJpUGDdW7r/FIlJ0BNFLQNBeVUgbW5YMFUcX3RZhHXZo2m8kI3YzsjJOsRYbL5bKY4LAInDnP2TeEAF+6WdJmzxayzOCEEk+cZOHvRDYgq33udF7/vkLruE0w3QQiMKlQvFr6K1cWn21cQwihcGcJteyqDprYdmSMzR+Tls8VEITFLvytZAJW7V6tFQyU=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR10MB6867.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(376014)(1800799024)(22082099003)(18002099003)(56012099003)(55112099003)(38070700021);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?7+4RZVxiiZ7EsZ/lt3vM6mX0+7sQ?=\n\t=?utf-8?q?pjz6yCn51kmNSMlrSx54LW+hg7VrpeHL8NjQNhbtrxGMtlg/yaVvI0mAB5GeMVjMi?=\n\t=?utf-8?q?chjnCm3rXRXMzVnCfK2YOIVBg2Fn9z2e8d/W1VBpukPmd2Gy2qxukXFfydD1tcCPt?=\n\t=?utf-8?q?fmGH1iknt6H8l7onGTaZR7EWo8K9+mSC5Ew51wcE/5Z0VxjuD1/Jum3h8U/e0UVfZ?=\n\t=?utf-8?q?w3p/VV/K6n1eHVvRUmjG0dY8xu2QFuHnbV4bOVzpty7yzMzw6fnlIZS0kEF6TO09B?=\n\t=?utf-8?q?jRal9VDsBTrjX85SFKq6xrufiQr4Wuq7/VeDkYypuvhRg/VfRI6ZmqeIlwldO66TK?=\n\t=?utf-8?q?EQI9/C1VOuCO65eA2CTrhPVPAOh33fGk/1Np5YsYkyD6wb38hKKf/JaFbREVwtruq?=\n\t=?utf-8?q?upYbZ57b8gzByzi4qOp1kEBoHZ6cGsBPQW7RbA0NnPt1FF5tVR62YmYxZhSSage4t?=\n\t=?utf-8?q?kMT2EOlq6MYrJO3kbMAUzhLl/uL9KigWTy+nl5xXdfzr33upl3Sb0qsesM/thrk7s?=\n\t=?utf-8?q?Tg89CKdFPmICTq1b46lKTE017u6t2qw1yKMWCAEtIzaBvrLZwnf3lQRWDqTJJ5V8n?=\n\t=?utf-8?q?KaR6GwF7JK+AItrnn1m46DfguZT6vmJedBdK1ADsiiF/KLnVrjlWMYpjuCSOrYa5Z?=\n\t=?utf-8?q?LIG0l7FdtRCkIEvFI6ORc0jhpJy4V/ExVgfhVritQvQYYOU8Gkbgl7aSZWEhsy9Pj?=\n\t=?utf-8?q?n95XtSFXugLpucC+RFRTki+xG0/SoVG+lXQCkAfvDoTGQs25RqhTWpxXYqij1+8yD?=\n\t=?utf-8?q?YpA31CT7pPQ4jyQOsfjgQbOSIPNHzsqN6n0Z0SG+Jiy7LQPB/e4+xYurgglu0tLFx?=\n\t=?utf-8?q?VUteuEJaf7aK2V4lTwIluCla5yQzbG3j6ImeX4O18wa/Bn9u3EICqEakNlObqRHvn?=\n\t=?utf-8?q?Bp2hlhCvGov+B6nM8bFDZfOTOyEoVlv3gEplIiNnZDr9BD/9HfMahGsGynFhjSQJa?=\n\t=?utf-8?q?6k8Zuf3lY7gyAv+0PI38GklEKXMiQaDwdLSzcRrFX0wUu/nK09zdbJIpGbWrY7NSm?=\n\t=?utf-8?q?cGhg1Yi7wi11PZIWQmXWn0rGgfdO5dzz2YLZ+8OaSyYyI8H7ZmXxZXcBOKw8QqNDe?=\n\t=?utf-8?q?DV7hV14TSsgLd7Vhz7EUHzH/GtckCvJlu70M7ZGjiurfri1eJf4cvqHgWhF4aM8U6?=\n\t=?utf-8?q?ZID2t0mrcNCavj5EkT2LFBNVbYdm83GrB3uIJoFoPuDsCwfNJl3IdqoKpPKppR/Yn?=\n\t=?utf-8?q?fxYlM5PTo6kb9NbUnnSP/zD9+La6ErvaK5VA4lBDFerYgsYXi74qsUE6VAKsg/w69?=\n\t=?utf-8?q?O6jYHReBeQURnyn4cQlf3shhb4cAVE0G1lKyNmtHba7irwXwvUCb5GT/jANtEW9eO?=\n\t=?utf-8?q?arThBEL0G6zZqFENH2do2Fhlv+AYizVGUFwSTTEBMA0w1VRMJC+er5IDCDZI7U81c?=\n\t=?utf-8?q?thPzR1YCq+TohxUXNnxlVrjOqx/5KDvO+1nmL2HsCO3Xafj6FO2pGTAZe7raouoII?=\n\t=?utf-8?q?Kp269NlVA8gP4e3Y/KBLWwuK+m5Fzs5JpHlQedE+GCgSMRFa6QeKff1vaQKPzLskD?=\n\t=?utf-8?q?bQkgaQjbATgQJqVayIhli05B7iTftCGYYaP3lnGpG4VGy+G9zlVbqvDJuJxK4aBDm?=\n\t=?utf-8?q?hlTMXCAVtP+1N6+pxryaW+4tvPMkt26pr1BgJ5D36Wz4ttyL57cwc144RfJJQ44hb?=\n\t=?utf-8?q?yafn+6ugdxUs2d74O7vYqWallBxYnHaxpRYlS84iqtesdvciBxNbWXsmmWhsNpnW6?=\n\t=?utf-8?q?mGNNxLt5m?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-ID":"<6FD24A577930A642BC96C46C2241353E@EURPRD10.PROD.OUTLOOK.COM>","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-OriginatorOrg":"siemens.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"AS8PR10MB6867.EURPRD10.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 258eded2-3358-4fe3-2175-08dea5c90295","X-MS-Exchange-CrossTenant-originalarrivaltime":"29 Apr 2026 08:26:28.3299 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"38ae3bcd-9579-4fd4-adda-b42e1495d55a","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n DT2vGQnoe87IAf0AHJYH6vV36VBpErPit0GottmoQ7yeqFji0mUVqnpw4o4rsZT8R7MtbOcDx2Ai0OGXE22kq+wS9eOMxAW/w4EiaCxO7W0=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS2PR10MB7904","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]