[{"id":3683860,"web_url":"http://patchwork.ozlabs.org/comment/3683860/","msgid":"<20260429073327.3985-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-29T07:33:26","subject":"Re: [LTP] testcases/nvme: Add NVMe device discovery and\n identification test","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Priya,\n\nOn 2026-04-30, priyama2 wrote:\n> [PATCH] testcases/nvme: Add NVMe device discovery and identification test\n\nThe subject prefix should match the actual directory path:\ntestcases/kernel/device-drivers/nvme:\n\nThe commit body only describes what the test does (restating the subject).\nPlease add a sentence explaining why the test is needed, e.g. what gap in\nNVMe coverage this fills.\n\n> +/*\n> + * Copyright (c) 2024 IBM Corporation\n\nNew files added in 2026 must use 2026 as the copyright year.\n\n[...]\n\n> +SUBDIRS\t\t:= acpi \\\n> +\t\t ...\n\ntestcases/kernel/device-drivers/Makefile has an explicit SUBDIRS list that\ndoes not include nvme. The directory will not be built. Add nvme to the list.\n\n[...]\n\n> +static int nvme_device_found;\n> +static char nvme_dev_name[256];\n\nThese statics are written in run() case 0 and read in cases 1-3 but are\nnever reset at the top of run(). With -i, stale values from a previous\niteration carry over. Reset them at the start of run().\n\n[...]\n\n> +\t.needs_root = 1,\n\nAll operations here (reading /dev, /sys) are world-readable. Remove\n.needs_root = 1.\n\n[...]\n\n> +\t\tfp = fopen(class_path, \"r\");\n> +\t\tif (!fp)\n> +\t\t\tcontinue;\n> +\t\t...\n> +\t\tfclose(fp);\n\nUse SAFE_FOPEN/SAFE_FCLOSE (include/tst_safe_stdio.h), or document why\nthe raw call with continue-on-failure is intentional.\n\n[...]\n\n> +\tlen = readlink(driver_path, driver_link, sizeof(driver_link) - 1);\n\nUse SAFE_READLINK (include/tst_safe_macros.h).\n\nAlso missing:\n- testcases/kernel/device-drivers/nvme/.gitignore entry for nvme01\n- runtest/ entry for nvme01 (e.g. in runtest/drivers)\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: (not available)\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=dqeEvQY0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g58Dm1kkcz1yHv\n\tfor ; Wed, 29 Apr 2026 17:33:44 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 56F233E28C0\n\tfor ; Wed, 29 Apr 2026 09:33:42 +0200 (CEST)","from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id EA3913E289B\n for ; Wed, 29 Apr 2026 09:33:29 +0200 (CEST)","from mail-qk1-x742.google.com (mail-qk1-x742.google.com\n [IPv6:2607:f8b0:4864:20::742])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 66AE460093D\n for ; Wed, 29 Apr 2026 09:33:29 +0200 (CEST)","by mail-qk1-x742.google.com with SMTP id\n af79cd13be357-8f231f3b130so433253585a.3\n for ; Wed, 29 Apr 2026 00:33:29 -0700 (PDT)","from\n runnervmeorf1.iyldqaevqpzuto5kdmxufowjjb.ex.internal.cloudapp.net\n ([64.236.134.167]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-5101acf99afsm11142421cf.12.2026.04.29.00.33.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 00:33:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777448008; x=1778052808; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UQ1eNeemjpfn/Zby0D+Nw3Lacp5u0rWI6VmH6GrmxCw=;\n b=dqeEvQY0R8dZozOJyB03B6tnlRRzl1NMm3c/yd/kQJ5aOW7enctDo/8LJatGWv58VJ\n cAT6LTfaGDua3OZDq4tZI7LATmgV2rKC8y75e8zibOb7h8QZqE9C/jdXfO9ccMhbU2Hq\n 377u3w5doKWwlcmvjIFimzDu5HPu+ZkY25B2FHHZUhpla11pzbz2Dmd77ZsnptKKwmBu\n O/emWbdjz3I+Y9TuorSDHZyBt5PargIRdKWTKnYdRM872qkBhkaN7vTW3NpJRJNuoXwF\n aUTcD5BqxkpfvvVJgFBbhVauEKkxU2L7y6FBlXAXW8MxykjKisuG1WD9uNIrOdrJKOWn\n lLNA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777448008; x=1778052808;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=UQ1eNeemjpfn/Zby0D+Nw3Lacp5u0rWI6VmH6GrmxCw=;\n b=ksANMSmjhDY00wBMPpTOWd1UJGF0xKHJXc1MVRflqs++i2ml7LkYtQnodkSualJuyg\n BytNQZgCZnNzVxi4rLc1UtE5yF9VLgHj/94zsKvvd8m2tHNmRcm/de4HtVRQ7QgAWUpn\n vOAAPG+rC/OpQKCIIgy7gd+WzBI+Zl5SSCOBQGQk2OTBNO/T3FTxca523ndBcWziIlwv\n /jQDeeHLzsIulJF1p14QQMGgP4+dmHpmOLXrs/d4rLdBDdiC/cEd7EL1sszDUijzO2P/\n o0j90tvoCJpnfsJzPS5KdsF2w7wKgNAdWdstcWu2a6Ge4wpM7PTy9/uc2QG6JLR9zPLJ\n OkCw==","X-Gm-Message-State":"AOJu0YxJmrwa2atYLLaymKppJ6wUtzGiZNdf2akGIMAAIw/mv9Pk1j0x\n GtAWZ/OGgvqFxycpuDjMR5T05EQ68rZlTQhhsrTwI4r3h0WDgg9rY1RrJo40IvqWOGI=","X-Gm-Gg":"AeBDievt8HCBLlxt5fSXxqYdsdKZd1QWH+Cij4vwXir9Vk/7edpq/oVIXkIjqNgM+LX\n 6tjkti9+Y961Q18PIApsFCVJOC8LLUZil9cT4bvz3cBWi7a4DhfVB+A56lpHTgwRyt0PD9mHm3k\n 6hdsNnMo+lG9G2ctanumXdMvVPod+K0lCpvmKdAfwJo119+LkHl4/DndxqdeKZGS+UJM4UJWyGp\n iRtG/o+QVb5s5RDxEUF/U4JXaNyt2E4fSID4SOyhi2rzBIBoVZf+/mNL+D2CSL7yQqkyWfXb/oX\n dcfwesNr2OogySfIeCJ0Ccx/GqOLMfGVW5JLVBgVhY4lB+9F7CVMn8lMkILFrgbjb4Oy7B8Z1fm\n uLc7a7hspfxyssAHu+z1N30EW1rruTvbcT28A+7lx6TreeAeijRdwfBao/jCTeFwc28bCwMK6n2\n y0LK6kRi9TYS8KAuPM4kn8t9/BXnMF2uZKnuyoSkn0M86GkFz73F47gE+a7xeF9rGRoXy5vKtf2\n tQXlWtC/youhwDeULBQ4mPXdtBxH7fZakvtkgRDTD4ggvKcxmE=","X-Received":"by 2002:a05:622a:588f:b0:50f:c2d5:3154 with SMTP id\n d75a77b69052e-51018a7ec1amr38184411cf.42.1777448008108;\n Wed, 29 Apr 2026 00:33:28 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"priyama2 ","Date":"Wed, 29 Apr 2026 07:33:26 +0000","Message-ID":"<20260429073327.3985-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430155241.897024-1-priyama2@linux.ibm.com>","References":"<20260430155241.897024-1-priyama2@linux.ibm.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-5.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-5.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] testcases/nvme: Add NVMe device discovery and\n identification test","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]