[{"id":3683859,"web_url":"http://patchwork.ozlabs.org/comment/3683859/","msgid":"<20260429073313.4011-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-29T07:33:13","subject":"Re: [LTP] testcases/nvme: Add NVMe device discovery and\n identification test","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Priya,\n\nOn Thu, 30 Apr 2026 15:48:52 +0000, priyama2 wrote:\n> testcases/nvme: Add NVMe device discovery and identification test\n>\n> This test verifies NVMe device discovery and identification by:\n> - Detecting NVMe controllers in /dev\n> [...]\n\nThe commit body describes what the test does but not why it is needed —\nwhat coverage gap does this fill? Also, \"Changes in v2:\" belongs in the\ncover letter, not the commit body; strip it before sending.\n\n> +++ b/testcases/kernel/device-drivers/nvme/nvme01\n> new file mode 100755\n> Bin 0 -> 995536 bytes\n\nDo not commit compiled binaries. Remove nvme01 from the patch and add a\n.gitignore in the test directory listing it.\n\n> + * Copyright (c) 2024 IBM Corporation\n\nThis file is new and added in 2026; use the current year.\n\n> +static int nvme_device_found;\n> +static char nvme_dev_name[256];\n\nThese statics are set in case 0 of run() but never cleared. With -i,\nstale state from a prior iteration persists into subsequent ones. Reset\nthem at the top of run().\n\n> +\t.needs_root = 1,\n\nNo operation in this test requires root. All reads from /dev and sysfs\nare accessible to unprivileged users. Drop needs_root.\n\nThe patch is also missing a runtest entry (e.g. in runtest/drivers) and\na .gitignore entry for the nvme01 binary.\n\n---\nNote:\n\nOur agent completed the review of the patch.\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gpejEGaT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g58DQ5Lhxz1yHv\n\tfor ; Wed, 29 Apr 2026 17:33:26 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 8EF0B3E28A0\n\tfor ; Wed, 29 Apr 2026 09:33:24 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id E75333CA6DC\n for ; Wed, 29 Apr 2026 09:33:21 +0200 (CEST)","from mail-qt1-x844.google.com (mail-qt1-x844.google.com\n [IPv6:2607:f8b0:4864:20::844])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id ECD1B601926\n for ; Wed, 29 Apr 2026 09:33:15 +0200 (CEST)","by mail-qt1-x844.google.com with SMTP id\n d75a77b69052e-50e63771d91so110008131cf.0\n for ; Wed, 29 Apr 2026 00:33:15 -0700 (PDT)","from\n runnervmeorf1.ilqebtjoo3redgtn5bhhrwy0we.ex.internal.cloudapp.net\n ([135.232.185.20]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-5101ae3cf8fsm10974561cf.17.2026.04.29.00.33.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 00:33:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777447995; x=1778052795; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=+VlCl07V9/Ht0oJhsLCIjqxiORDxVBiu/UU3zDZHPjk=;\n b=gpejEGaTGghEbMcTfDz5ceBqf3zjxFGsbXpTZneDsi/lGypkSfgiZ9IkXOlR0+rpX/\n QDFUcXieHVs4FaFXKDIj3ChYb2+7DMGWr2pqbzH80QuJqsP07a02Pbr/Cky5GbHpLM7y\n Le3rScEZtDtA2fonizZ9pHxBvO89ndBEFawCJZY+k8vjKy7DYdH87GQc18ZuGIlEEUmb\n N7dUYlwIrXjdPomz+aLbzuF4Sebi2fo82cU9NyyN134x5MeqV492K4L+Okk+pHx26cqi\n p5XTHvRIr77vilxn0KRMZI4ZYoYN5nO+zw0FhCdfJPbsqOsMz+G4odGGsEtCDmbFxOVr\n 6yzA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777447995; x=1778052795;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=+VlCl07V9/Ht0oJhsLCIjqxiORDxVBiu/UU3zDZHPjk=;\n b=A96Vj+JUbvCEfxZPoP5JJ023sRBMVfXrvzPVVpxJFdXMbZt2RSgXyAv5hBVAgyNU61\n HH7noa0fdi9LVtLD0SaSrjDt8blipaTPW2I19OTE0zjcuBd3U41n35qpNcDaEB1taTxy\n gTIgvse1jWEWK++KW2OFJCC6kWktvEKow6sN0oN/5IZaVmeJ7teZevc8KypffZcGmo8D\n liVMkiBdjmytlNMPZ6dPFRmFweExYmwgaHyPLyXJMCuAeCOu1XL6YVEhwcNGH+4QaWkr\n U/DXpYQB/KyV2JaEz6dDx3Z67asfdhX9MvUJNQcp33agr6qE4n7smehP0gE817xDMgWS\n 7xZQ==","X-Gm-Message-State":"AOJu0YyH/0kT/V7cvAWOdE01692VfDDwZFcSMbXIT6eQ34gYG5ciCOOx\n Hs5/9/bmaYWqE7CTLlUroFBvcLpMhxkrjWjRJ3dDBufMqUI73cxIOTNx","X-Gm-Gg":"AeBDievn9wALg1rA8hUXrPQoysWbMlIK6a77YqKqnWB5G8YkIfvAtjWtJK7lic6CNZR\n T237JxuyIqF/Sq3yNCsu2SBH/ZRQclFvxMmJOfOj4jl1bkQ3+KWsqU7hTcoHKy4jDyP/xPaOvVm\n O1sMm+aOPHfx4k/Gh2KKulY8nU3g99Jx2aqzUjHJO1wVgDrPhxaXR/fy3D4c6sJJsEuLEQevBk4\n 2t7Fjjl53zENV9B/kFKXH+/ib5Qeshq6RjL3x6b26fD3h6fBE6Mr+QNGBkgJ8BVX1Tm5/KDYKWf\n 5f76ahb9GAdyaEadrNC5OBQQ0gl6IlqClIie6o3Wad+uc35XYsfWfE9h6SRHAEWrhd0oK37Rklu\n iCsxOurCYMwuhlM6lFyDy3Lkujkhz1X6yE/VoDjo8RfvkHOrrfzQTVw39t5H9YViDbj+Ykpt4nY\n 7p67KXAx6Mng0tCFV+IKo+TaKFgEcEwXShQT2pueITBCyT9D5pqkz6acwazOPXBj5dNtuKwoUj5\n xdnvX+45nFHMumjfUl/PQQ7s+5wzbJr8D/USgPuJFxgAUDB7SM9TyoZpd6zlQ==","X-Received":"by 2002:ac8:5f85:0:b0:50d:a1c4:e154 with SMTP id\n d75a77b69052e-5100e19a1b9mr88528941cf.36.1777447994588;\n Wed, 29 Apr 2026 00:33:14 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"priyama2 ","Date":"Wed, 29 Apr 2026 07:33:13 +0000","Message-ID":"<20260429073313.4011-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260430154852.896072-1-priyama2@linux.ibm.com>","References":"<20260430154852.896072-1-priyama2@linux.ibm.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=1.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Level":"*","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] testcases/nvme: Add NVMe device discovery and\n identification test","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]