[{"id":3683816,"web_url":"http://patchwork.ozlabs.org/comment/3683816/","msgid":"","list_archive_url":null,"date":"2026-04-29T06:10:16","subject":"Re: [PATCH 2/3] i2c: designware_i2c: Remove clk disabled codes","submitter":{"id":91409,"url":"http://patchwork.ozlabs.org/api/people/91409/","name":"Heiko Schocher","email":"hs@nabladev.com"},"content":"Hello Dinesh,\n\nOn 29.04.26 07:11, dinesh.maniyam@altera.com wrote:\n> From: Dinesh Maniyam \n> \n> l4_sp_clk is disabled when i2c device is removed, this would\n> causing unexpected failing behavior for other peripherals which\n> are still running with l4_sp_clk. The patch removes the codes\n> implementation for disabling the lp_spl_clk.\n> \n> Signed-off-by: Tien Fong Chee \n> Signed-off-by: Dinesh Maniyam \n> ---\n> drivers/i2c/designware_i2c.c | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c\n> index 8ad716f410e..40153c72545 100644\n> --- a/drivers/i2c/designware_i2c.c\n> +++ b/drivers/i2c/designware_i2c.c\n> @@ -807,10 +807,6 @@ int designware_i2c_remove(struct udevice *dev)\n> {\n> \tstruct dw_i2c *priv = dev_get_priv(dev);\n> \n> -#if CONFIG_IS_ENABLED(CLK)\n> -\tclk_disable(&priv->clk);\n> -#endif\n\nHmm... clock framework should have a counter how many times clock\nis enabled... with your patch, clock never gets disabled...\n\nbye,\nHeiko\n> -\n> \treturn reset_release_bulk(&priv->resets);\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nabladev.com header.i=@nabladev.com header.a=rsa-sha256\n header.s=dkim header.b=d7leZm3V;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=nabladev.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=nabladev.com header.i=@nabladev.com\n header.b=\"d7leZm3V\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=nabladev.com","phobos.denx.de; spf=pass smtp.mailfrom=hs@nabladev.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g56Ny3xlQz1yHX\n\tfor ; Wed, 29 Apr 2026 16:10:42 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8E6B48482E;\n\tWed, 29 Apr 2026 08:10:39 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 0C40C847B0; Wed, 29 Apr 2026 08:10:38 +0200 (CEST)","from mx.nabladev.com (mx.nabladev.com [178.251.229.89])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id F20A584706\n for ; Wed, 29 Apr 2026 08:10:33 +0200 (CEST)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 8E8B91147AF; Wed, 29 Apr 2026 08:10:31 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com;\n s=dkim; t=1777443033;\n h=from:subject:date:message-id:to:cc:mime-version:content-type:\n content-transfer-encoding:content-language:in-reply-to:references;\n bh=mqWq3SMe8UaX5YCkgA0c1v7n4IYEU1eDL0xHcvIH1+s=;\n b=d7leZm3V+Prn87yPuY0dQRjrEkjR0LDpq7BHRex0P2AFo4Lk/ZANoSvvDMdSLzEddIL588\n ujeOoSTY/Up3w+kSlWIGUKbOEuqEgUE1cdkZ9oX2LhKDvoCN//uBzxDXBBt6ZxzAKEiB53\n DyO6stOPicjbGRTxk/s/qlveHfcddlcrkBxkOjcIDU9A+QspLDxuGqcmpW8VwbmfcnuDNo\n taDA94l4yuSKL6Cc8YM45FIdXd+SacKXiB9CrYBsDCfXs/Omm/9R61R6oyNC5vVTQFUtlM\n lgUjwlY16ASY0KgPyQy4Jn2vZGrsC0yfBXXitXGwNYIY4s9z9a5Fs3dDTieJOw==","Message-ID":"","Date":"Wed, 29 Apr 2026 08:10:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n Thunderbird/91.2.0","Subject":"Re: [PATCH 2/3] i2c: designware_i2c: Remove clk disabled codes","Content-Language":"en-US","To":"dinesh.maniyam@altera.com, u-boot@lists.denx.de","Cc":"Tom Rini , Dinh Nguyen ,\n Alif Zakuan Yuslaimi ,\n Peng Fan , Wojciech Szamocki\n , Maksim Kiselev ,\n Chen Huei Lok ,\n Tien Fong , Kok Kiang ,\n Boon Khai ","References":"\n <2e5bd18743849a8be91ad4690075a545fa56177c.1777439293.git.dinesh.maniyam@altera.com>","From":"Heiko Schocher ","In-Reply-To":"\n <2e5bd18743849a8be91ad4690075a545fa56177c.1777439293.git.dinesh.maniyam@altera.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Last-TLS-Session-Version":"TLSv1.3","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]