[{"id":3683905,"web_url":"http://patchwork.ozlabs.org/comment/3683905/","msgid":"<177745176382.2166241.2505852709346670944.b4-review@b4>","list_archive_url":null,"date":"2026-04-29T08:36:03","subject":"Re: [PATCH 2/6] target-info: introduce TargetInfo in QOM","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"On Tue, 28 Apr 2026 16:45:15 -0700, Pierrick Bouvier wrote:\n> diff --git a/include/qemu/target-info-qom.h b/include/qemu/target-info-qom.h\n> new file mode 100644\n> index 00000000000..db069db718a\n> --- /dev/null\n> +++ b/include/qemu/target-info-qom.h\n> @@ -0,0 +1,23 @@\n> +/*\n> + * QEMU target info QOM types\n> + *\n> + * Copyright (c) Qualcomm\n> + *\n> + * SPDX-License-Identifier: GPL-2.0-or-later\n> + */\n> +\n> +#include \"qemu/target-info-impl.h\"\n> +#include \"qom/object.h\"\n\nMissing include guard. Add:\n\n #ifndef QEMU_TARGET_INFO_QOM_H\n #define QEMU_TARGET_INFO_QOM_H\n\nbefore the includes, and a matching #endif at the end.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Yw0BwOtK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g59dY62c1z1xqf\n\tfor ; Wed, 29 Apr 2026 18:36:49 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wI0PG-0004Oi-Ab; Wed, 29 Apr 2026 04:36:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI0PC-0004OH-8G\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 04:36:26 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI0PA-0007wz-Tq\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 04:36:26 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-VvZceKEWMeSc4Vcn9z1nnA-1; Wed,\n 29 Apr 2026 04:36:20 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8505A1956048; Wed, 29 Apr 2026 08:36:19 +0000 (UTC)","from localhost (unknown [10.44.22.34])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EC2CC19560AB; Wed, 29 Apr 2026 08:36:16 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777451784;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ZaZj8pal5da/zaSmOZv4b0JsFZgLKcdDgZj+F88KO7w=;\n b=Yw0BwOtKi1sVsbwaD2z23nN5/ZaugD/iMjFxhXfwd8Ad8hgHpNgWem6wwSI03nqC037VKY\n /Q3/y0wOsRCYGxDBKfMG57QODsLxoexdETBL1Amdnx66z/9QQ3dPEXRij7RYL4gjnglAdV\n JxF7ySHHTJeRKMsKwBPY3EC82V0ODJY=","X-MC-Unique":"VvZceKEWMeSc4Vcn9z1nnA-1","X-Mimecast-MFC-AGG-ID":"VvZceKEWMeSc4Vcn9z1nnA_1777451779","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Subject":"Re: [PATCH 2/6] target-info: introduce TargetInfo in QOM","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org,\n Pierrick Bouvier ","Cc":"Markus Armbruster , =?utf-8?q?Daniel_P=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Anton Johansson ,\n Richard Henderson ,\n Paolo Bonzini ","In-Reply-To":"<20260428234519.1812371-3-pierrick.bouvier@oss.qualcomm.com>","References":"<20260428234519.1812371-1-pierrick.bouvier@oss.qualcomm.com>\n <20260428234519.1812371-3-pierrick.bouvier@oss.qualcomm.com>","Date":"Wed, 29 Apr 2026 12:36:03 +0400","Message-Id":"<177745176382.2166241.2505852709346670944.b4-review@b4>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=742;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=xp/ueK2QFidmpq3m9A6rwbfNgzIcR540qNMtm7qpkqQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8cL3nVW28ObQHq43vYcdit0B9r5VL6L6lhHJA\n 8xsdvmQxSOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafHC9wAKCRDa6OEJdZac\n 5eZtD/94UqtW6RIT5k0ywTwC8oM/SCnG2y97M1KtGYr25j3cdugBrq7/WkC0r/7pia8rdxnvLQQ\n 5BYXKWin8YUsOVnrSy/XY5pXuhMhwELCYUOF/w6sS4DgPRnR0/jw8rri0YdaBHywX3JnkAW9nq3\n Cq7uAGNnGihtYog6w3xnFwxnFChXlAAD/bStcfZUm+lqF9Zl4WIrOsS0HF9xTCUkv8+9Km2/A1s\n eYIXp351/3qPSjZKMO3XIjHr19O7DTo/HBsvxU6sAaHCDTdrLmdM6VGcmAkLzeFrC96ywUj8cey\n 2Adm2VtPN16v5zrXczldG7zpb2wxJz/GqEsJb38bhP+MpKzMcqlYLmhA0lKKxLMIuEH0WamnUoE\n VP1599aMzqiju408gSI7F5PXHTEPF/PGXMKN1qRTLYVcmxCoXQO9+PUd0YQHvDDRXz0+qfUAnVB\n DJBAK0xG7YgPDsMRlYTClq7RfDGL1G0kSh1uEAnTRRRkk2SbhoFMPpRo566ZcdNHkJimaZTxdZ1\n XGsDyBloNiExPdruts5Sjf8b8Lfe1/nd8QRi7UBjszrb1wOINh80KAkaAPk/MMaDhnxCp72D/Xz\n 5v/x4SSR+fH/xgqUo61KKq7KEU/y2z7qZ5iFao8lpdrTxYgxI5vuwjHwdZhMjbkqEaWxS7eUaCm\n yNbh0edYhuR50cg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"11","X-Spam_score":"1.1","X-Spam_bar":"+","X-Spam_report":"(1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.109,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]