[{"id":3683906,"web_url":"http://patchwork.ozlabs.org/comment/3683906/","msgid":"<177745176384.2166241.6921788598496135839.b4-review@b4>","list_archive_url":null,"date":"2026-04-29T08:36:03","subject":"Re: [PATCH 3/6] system/vl: initialize QOM first","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"content":"On Tue, 28 Apr 2026 16:45:16 -0700, Pierrick Bouvier wrote:\n> diff --git a/system/vl.c b/system/vl.c\n> index 0e1fc217b4f..b4a5ea6f857 100644\n> --- a/system/vl.c\n> +++ b/system/vl.c\n> @@ -2889,6 +2889,9 @@ void qemu_init(int argc, char **argv)\n> os_setup_limits();\n> \n> module_init_info(qemu_modinfo);\n> + /* We need to initialize QOM first to detect target */\n> + module_call_init(MODULE_INIT_QOM);\n> +\n> module_allow_arch(target_name());\n\nThis change is not trivial. By moving the call here, we lose the\ninitializations from qemu_init_subsystems(). Verifying that all\ntype_init() code is safe to run without it is a tedious task. It might\nbe better to introduce a new MODULE_INIT_TARGET_INFO instead","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ddz4LqaK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g59dg6srxz1xqf\n\tfor ; Wed, 29 Apr 2026 18:36:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wI0PQ-0004QE-JN; Wed, 29 Apr 2026 04:36:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI0PI-0004PG-Iy\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 04:36:34 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI0PH-0007yX-9u\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 04:36:32 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-22-1ayG7UkiP8SnxHus4tV1Vw-1; Wed,\n 29 Apr 2026 04:36:27 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D0ADE1956089; Wed, 29 Apr 2026 08:36:25 +0000 (UTC)","from localhost (unknown [10.44.22.34])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 553AB1954199; Wed, 29 Apr 2026 08:36:23 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777451790;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=MFp7jzmv88vJ5NcRT5dloAB9vlIWlJbhgxOJhfQmhUE=;\n b=ddz4LqaKBkytzcT1v4U0vwUYnrwhFkEC1WSu1viNNrZndBSXTLxL97uDa1d7EwqAjnqamF\n cDn4oaTPseL4pfcVMlQmM0Zw/GkI59K+T8jnlM202/wcSIW7HNhe+KCfEnNTO7LUpiuS/u\n 8p4yEBectfRZGdJ0LVzGlkZtOfM5hxY=","X-MC-Unique":"1ayG7UkiP8SnxHus4tV1Vw-1","X-Mimecast-MFC-AGG-ID":"1ayG7UkiP8SnxHus4tV1Vw_1777451786","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Subject":"Re: [PATCH 3/6] system/vl: initialize QOM first","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org,\n Pierrick Bouvier ","Cc":"Markus Armbruster , =?utf-8?q?Daniel_P=2E_Berrang?=\n\t=?utf-8?q?=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Anton Johansson ,\n Richard Henderson ,\n Paolo Bonzini ","In-Reply-To":"<20260428234519.1812371-4-pierrick.bouvier@oss.qualcomm.com>","References":"<20260428234519.1812371-1-pierrick.bouvier@oss.qualcomm.com>\n <20260428234519.1812371-4-pierrick.bouvier@oss.qualcomm.com>","Date":"Wed, 29 Apr 2026 12:36:03 +0400","Message-Id":"<177745176384.2166241.6921788598496135839.b4-review@b4>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=834;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=cPi2jWRM79AR65Rt+J7IdH1m64+OE2pG43tGRo7VKVU=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp8cL3Bgubct81/V0ln1Zr/K5DTvYJHk+vp8ueP\n uurEYcHN0OJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCafHC9wAKCRDa6OEJdZac\n 5Z0wD/47jLVwhRInDRxNvfTFkzek4y+/WfMwxL6Qh8PP1rqq6y8uaom87pZ7Kq7osOy5HxI9oWj\n sBmvC4+7Uai/X9Id3Y9xFPApmq0tP43oSq4lfksFORpaCeLAXv3FD5R+DU4xtlXZfXeaWWnxuCT\n TLNr1B5YCOhElltX5bQd/yINSDG7XrYBDclrqZz/JBkF2IMJZCJ0UIn6KHypGiFlNYBs1HPDq2g\n o40hEAB9BM+wGRkdJajRRd0Xt9ihnPJ4l1Citpcz6rs3vpFzytn9J7e+0zF/nk8sSpRiIrtPtdZ\n BozlQ3SrnGQAkz/7Prfk4P6/s/FuVpvEBvzbj2zZcFfZSiA1TdzUo3w5Fc8w5Q0dtn+OFHDry5J\n H3jmdQLLIvuaaK8J0x1W7ekcSEeJgE7/1vb7Su1t+LkJkOsKSKKLVjzRc1Cx4hlZiipbkcl2gri\n pvYG+h40N1GOUnxnF4dysmnA8bygG+d+l71DIB5xwXbKpMEpgILrVgqe+dT2arVuAqTQq6J1iwr\n SjsU07s+hHSvACWk7vRtTkoJ+OK8N+fi7TAPkx50PnmI9beBfu66Kb++n6jX7HRl3tbpqSSbHJQ\n NFZxpys7ZhAViTnRwnGSldFP5oRCYCgwuZJp+uP1s6D7/8aBAt9JLY+absUemNbPN9CD/0N/TIt\n M7CMkcSUWRtnGcw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"11","X-Spam_score":"1.1","X-Spam_bar":"+","X-Spam_report":"(1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.109,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3683914,"web_url":"http://patchwork.ozlabs.org/comment/3683914/","msgid":"","list_archive_url":null,"date":"2026-04-29T08:46:34","subject":"Re: [PATCH 3/6] system/vl: initialize QOM first","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Wed, Apr 29, 2026 at 12:36:03PM +0400, marcandre.lureau@redhat.com wrote:\n> On Tue, 28 Apr 2026 16:45:16 -0700, Pierrick Bouvier wrote:\n> > diff --git a/system/vl.c b/system/vl.c\n> > index 0e1fc217b4f..b4a5ea6f857 100644\n> > --- a/system/vl.c\n> > +++ b/system/vl.c\n> > @@ -2889,6 +2889,9 @@ void qemu_init(int argc, char **argv)\n> > os_setup_limits();\n> > \n> > module_init_info(qemu_modinfo);\n> > + /* We need to initialize QOM first to detect target */\n> > + module_call_init(MODULE_INIT_QOM);\n> > +\n> > module_allow_arch(target_name());\n> \n> This change is not trivial. By moving the call here, we lose the\n> initializations from qemu_init_subsystems(). Verifying that all\n> type_init() code is safe to run without it is a tedious task. It might\n> be better to introduce a new MODULE_INIT_TARGET_INFO instead\n\nI'd be inclined to have a MODULE_INIT_QOM_EARLY, along with a\ntype_init_early(), so we're not presuming target info is the only\nuse case for earlier init.\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=dZHAv2sl;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Qg0R+7wz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g59t24N2rz1yHX\n\tfor ; Wed, 29 Apr 2026 18:47:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wI0ZC-0008IR-7R; Wed, 29 Apr 2026 04:46:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI0ZA-0008I2-85\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 04:46:44 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI0Z8-0002af-IA\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 04:46:43 -0400","from mail-qv1-f71.google.com (mail-qv1-f71.google.com\n [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-41-tfwZBUyNNACortIcCI4yfg-1; Wed, 29 Apr 2026 04:46:39 -0400","by mail-qv1-f71.google.com with SMTP id\n 6a1803df08f44-8b1f39c5827so159322906d6.1\n for ; Wed, 29 Apr 2026 01:46:39 -0700 (PDT)","from redhat.com ([2a02:8012:f011:0:f1ce:ac56:d2cd:7c2e])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b3ef7ea763sm12925056d6.24.2026.04.29.01.46.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 01:46:37 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777452401;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:in-reply-to:in-reply-to: references:references;\n bh=kz1uzSATI+wQiospVHcrJHYUfESAxUB8gFZrtyhc0ZY=;\n b=dZHAv2sloeIb/apm2jFSY+kLqG0lZ2IV6Z11FsTCf/efzAe9KkvIWgRC0SUK0fKMceZVR5\n 0WAqq51EhIsmFTuAdAj4sdfEocky39fz+0BHY7gbS4oHX9o6O3A6zXjk1IN0BoYSN37rzY\n J7fhhzvKQmnih58RHX4QRiD8G1hfAdQ=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777452399; x=1778057199; darn=nongnu.org;\n h=user-agent:in-reply-to:content-disposition:mime-version:references\n :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date\n :message-id:reply-to;\n bh=kz1uzSATI+wQiospVHcrJHYUfESAxUB8gFZrtyhc0ZY=;\n b=Qg0R+7wzT4iOtvAgg5VMqKiU+RoO6J+uPeTmS+pxNsxBr1CmG7AoBvWyvZgRXnSt8+\n P8IVs7W3SodELW9luqh0ub9a0MbVSYg29Wqxgm2yysY3yxdf657jHk6T7tf/h5pC6kzg\n BpM5RDnz5vSu2YsjCpoux3C/THh7v9c2qM6MaUnHYtMVET7Zf1BPynMCKvhz6LSk2SW0\n 3z5W8jWEY30x1ULY4tUaQqku8wRsqJd7su0CK+k0AotS9ByUEgpDFuDpWpEzr0ZpjaBZ\n 3JnkDl+oUm6FYtRUeiaj1vsoMtUV1sxROAiopxDCc/Lrgqw/lBX0b7UwSnvwt/fFbxzM\n Magw=="],"X-MC-Unique":"tfwZBUyNNACortIcCI4yfg-1","X-Mimecast-MFC-AGG-ID":"tfwZBUyNNACortIcCI4yfg_1777452399","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777452399; x=1778057199;\n h=user-agent:in-reply-to:content-disposition:mime-version:references\n :reply-to:message-id:subject:cc:to:from:date:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=kz1uzSATI+wQiospVHcrJHYUfESAxUB8gFZrtyhc0ZY=;\n b=W1CWi6gSVXBEk+XoqVZohcRZMD4UytPux1ZcxzviL5NqFezuA91fQIfWAa/zAfeF6G\n jGKEgerfB7DeXRsOTNMzwU4uA5AUwvrej76fn+Olk1fhm58D/yUMXnmmnAP9nbmRIL/m\n bTM+YaTC2rMFuEXutU1wWbQaH4IRL7KYPh066vfPqP9a5VdhnFL8uDTYeFd7Ct6mZyxW\n OewSwFIkhym4bRQ+HwKqZ+lQ9oL9e76NVtkn1McHB9EKlOTWxQROh9ChlkK9n1/wGRhN\n jYUgz9PDEDAN21dXWZTH0vb0nabYoPmh4MUE9tYt3BIBAa3OmMYWHdYcGy83QmlxZMbj\n bzQg==","X-Gm-Message-State":"AOJu0YxZNIK9BWj3QM7eB1diwwM40P2+Hm2YC+prW2m9SKX/80VENoB7\n 0Usxb2twXaw2MptAVKjHXlZRE12VpI4WtgSU7RURIkd0Tuw5pLcbtvbWxGfai9+S/pyrLG9L+t7\n L+QfJZ3Twyz4vfG9hN2uhawioNCGEa4oI4tMwByfs4Am6CC261mNDA24T","X-Gm-Gg":"AeBDietS5p96xLiLyiQb3aibf5HUlPminh2MNkaQrFjpUjOYKlGJR0M2cC1ri9mwG1g\n EADWQ00e85kmTVjaX5T6dIFPp8/OXvFMAN6dso3OvgzslnB/tZFYnJcnKUQZsogF9N/ytlyLq9V\n hgA6/bpEaXpV1ha7qzJBq+ftKh21NK1ehPnJPQ/MDSW33f7wtu+0KWbtTaXipZu5XBHTqpE0tSh\n RH3V7zjdtHdZm6YORlHaHzDbIZ9MeMR+H0evxPrvBV6csXDQHvvDkkzdau+LQnTxvEpDmR0HfAW\n fwk5QlbxLa3CeAy3glmoZyOFSFrs50tgjizJ8KIfxMToC8lckXJQUgfzUdXihpO2rtn03GBo2fT\n m2Csakt3v8G+RvCHq3WdC1yoEOLYD2e8=","X-Received":["by 2002:a05:6214:260f:b0:89c:a2b2:8d3a with SMTP id\n 6a1803df08f44-8b3e304e936mr102468006d6.4.1777452398942;\n Wed, 29 Apr 2026 01:46:38 -0700 (PDT)","by 2002:a05:6214:260f:b0:89c:a2b2:8d3a with SMTP id\n 6a1803df08f44-8b3e304e936mr102467786d6.4.1777452398411;\n Wed, 29 Apr 2026 01:46:38 -0700 (PDT)"],"Date":"Wed, 29 Apr 2026 09:46:34 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"marcandre.lureau@redhat.com","Cc":"qemu-devel@nongnu.org,\n Pierrick Bouvier ,\n Markus Armbruster , Philippe =?utf-8?q?Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Anton Johansson ,\n Richard Henderson ,\n Paolo Bonzini ","Subject":"Re: [PATCH 3/6] system/vl: initialize QOM first","Message-ID":"","References":"<20260428234519.1812371-1-pierrick.bouvier@oss.qualcomm.com>\n <20260428234519.1812371-4-pierrick.bouvier@oss.qualcomm.com>\n <177745176384.2166241.6921788598496135839.b4-review@b4>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<177745176384.2166241.6921788598496135839.b4-review@b4>","User-Agent":"Mutt/2.3.1 (2026-03-20)","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-21","X-Spam_score":"-2.2","X-Spam_bar":"--","X-Spam_report":"(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.109,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]