[{"id":3683731,"web_url":"http://patchwork.ozlabs.org/comment/3683731/","msgid":"<a42deb45-79c5-4eae-8b9a-6837766a5bce@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-28T22:05:16","subject":"Re: [PATCH] linux-user: Allow getsockopt() with NULL optval address","submitter":{"id":93152,"url":"http://patchwork.ozlabs.org/api/people/93152/","name":"Pierrick Bouvier","email":"pierrick.bouvier@oss.qualcomm.com"},"content":"On 4/28/2026 2:46 PM, Helge Deller wrote:\n> From: Helge Deller <deller@gmx.de>\n> \n> Some programs test availability of socket options by asking for the\n> value with an NULL optval address, which currenrly always trigger an\n> EFAULT in qemu.  Fix it by allowing a NULL address, in the same manner\n> as the Linux kernel on physical machines.\n> \n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/2390\n> Signed-off-by: Helge Deller <deller@gmx.de>\n> ---\n>  linux-user/syscall.c | 50 +++++++++++++++++++++++++-------------------\n>  1 file changed, 28 insertions(+), 22 deletions(-)\n> \n\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=KE+KUnFI;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=bcnuPm+Q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4vf765Jmz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 08:06:22 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHqYc-0003uJ-GZ; Tue, 28 Apr 2026 18:05:30 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@oss.qualcomm.com>)\n id 1wHqYY-0003u1-N4\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 18:05:26 -0400","from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@oss.qualcomm.com>)\n id 1wHqYV-0006tN-F4\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 18:05:25 -0400","from pps.filterd (m0279868.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63SFsbhS4070822\n for <qemu-devel@nongnu.org>; Tue, 28 Apr 2026 22:05:20 GMT","from mail-dy1-f197.google.com (mail-dy1-f197.google.com\n [74.125.82.197])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dtttjjn18-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Tue, 28 Apr 2026 22:05:20 +0000 (GMT)","by mail-dy1-f197.google.com with SMTP id\n 5a478bee46e88-2e60238adb1so30805095eec.0\n for <qemu-devel@nongnu.org>; Tue, 28 Apr 2026 15:05:20 -0700 (PDT)","from [192.168.1.170] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2ed1c06ebcdsm136748eec.16.2026.04.28.15.05.17\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 28 Apr 2026 15:05:17 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n DKo9VE+oEK1I9Kb9Ry80y+JO+cqNRZQ4L8YhGB7HyWc=; b=KE+KUnFI1qZgxqyq\n WMqzW9hjOIgMnBn8dzBbSGKsOPWxWktWufVJDpR6NAg0n0cxnmFYneVn5viHIxvY\n BM2jPyxMleBdcl2lJ8sYP0pmLVSy3PEGoKF1To99b/X46Gywj8sfvakvol7omgcU\n IhXODE5IcZ4ftSpHEWO1HXKeBl47cghs5mP7JehD+51cJocX6Y8/F8e4xT1yvsGZ\n 6tXxhWQowzMXSLfSluynVnUpZdSyV8D6fhYYBnJ6x5bbiq6z/2bEvSXoXWAuZFU1\n hWNZ7A2t3inqwWmsqcpd0D2/OjnEVaWDOEGSmdZmPO8KzCexSWbGMeqQ6i277Prx\n WqnA8w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1777413919; x=1778018719; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=DKo9VE+oEK1I9Kb9Ry80y+JO+cqNRZQ4L8YhGB7HyWc=;\n b=bcnuPm+QxzUZe1edTAhmb6T6gZu5JC6Vg0bQ59gnbrsepftk1kV8euqUzp5PpXBoZW\n 7gOgGG6deQOcktCXyBOMbw7gCh8ud6Oom3rs4LX2pKyb4shj51Ifn9RCOJJ54wQLzks9\n KiejpsHZH5vFRQTjsinQD0efmm87ik6Ghu3toQdaWIXPtfKz7QoOW39vtYjRKCZNY3FG\n h6ewOG1Sfr96pESc/ex2HAcDQZ+dZ/2iHUyzViE/0ttOfvqnTe3GEEB9Iu0gkuXG7N2A\n iAdT3aMppdFeGpVI7RK77IOvW28ImU62pzIRgEFThwIXOprCfDHgI4M9wt/biPAOqM85\n ybHg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777413919; x=1778018719;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=DKo9VE+oEK1I9Kb9Ry80y+JO+cqNRZQ4L8YhGB7HyWc=;\n b=sbkRpQRbTQSe+iyKXg7qzkzf8OPZJUKpQoUkKgJZh5vrVBZx27ZjTB+n1OMFrz5NVV\n lsOZ7SgA7BHxYGYc0kK6wtmJcQEe0mIsIFCK5/uvH+W9Gi2gchtHXdvFPr0l150IEdtQ\n c7VNO54BJwbrMRf5bUaV6lPewKGAyT8n42xbLya+k/r0vHyo2c/6wCRiVb2SbgrXjZd3\n uErcei9zeyIBQDFCfsoAV0mT1f9mLLWUis0c7HuOZqHNHVEbiTM8ygNwvEfP+YFsYGVZ\n sVzNmYZXK9ABYwBKK2BNTziXxpaorKI2KTZ1ElpbYa3V2fSP3pShDXWwdzp2hJxe9Vrc\n FOKA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/0TXSQZrcyruyfDXI2LhdglQ6kPKuAwF1EBLEiwGg3hk+DzU5NkU64RtuAHbBBugTfMQcmCDl/5p0J@nongnu.org","X-Gm-Message-State":"AOJu0YwHRBMGHJGZqpVGdW0EvtjJvf6srMCF+Rwg/5VyCnHW/SCSAgIS\n 8hITkxckjiv0G2/wTBXxpx/+46kQRx5iaq2Cl7lP7c/AUNA1zuvyk4Hs1GGn+oyXa1O2sVVOV2P\n 6u5vH9PR1tFJGOP0T7kAnFUAIv37025bG1jNIqIChwUIKi30NcHqYToTDJQ==","X-Gm-Gg":"AeBDievxysCyXcMiFrSFuXoSvY93erVZuP7W7QYUltCO7liAMBaUWlOvc1GIbsQooCc\n 21lQgDz6BnFxosqbt6hSHwJxjUnDkGSLvCLzPkk2afs5WXWiNJav6qeLsDbnFfvWaMWn+T+zv/l\n M2zSKg6a3ng7N5p9GNHhSOz6z59f+Aqwao1/5PvMFu4m48WgHPqavE5eGEoUNLnVqJI2Bv1/Bk9\n rDmXN7/7vjI2c78JewWmv/+IRaKuSU+MzSgL4RpGR3A0TeBxZQT+1AR9aIuGNUWcGZVVwOw9oI1\n v8jrN4ohKlikZ/Y7u+1axsZZSN/LNgUqrWklKSXkWR4Ch4JLh9l++x1ndHy4saE9AngTeXiHCHY\n 6Xj39bsKYlOisIQZYifjuiO4aZ2AY7Ydc+yAF9IT2bLvQXH/ybXL1sE5Z18TGepGlP78ETynPdy\n 6fShPJKY4/sJ4SZNpXVa+yAoBZ","X-Received":["by 2002:a05:7300:d513:b0:2df:5715:82ca with SMTP id\n 5a478bee46e88-2ed09fcfde5mr2359409eec.11.1777413919489;\n Tue, 28 Apr 2026 15:05:19 -0700 (PDT)","by 2002:a05:7300:d513:b0:2df:5715:82ca with SMTP id\n 5a478bee46e88-2ed09fcfde5mr2359389eec.11.1777413918904;\n Tue, 28 Apr 2026 15:05:18 -0700 (PDT)"],"Message-ID":"<a42deb45-79c5-4eae-8b9a-6837766a5bce@oss.qualcomm.com>","Date":"Tue, 28 Apr 2026 15:05:16 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] linux-user: Allow getsockopt() with NULL optval address","To":"Helge Deller <deller@kernel.org>, qemu-devel@nongnu.org","Cc":"deller@gmx.de","References":"<20260428214626.13329-1-deller@kernel.org>","From":"Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>","Content-Language":"en-US","In-Reply-To":"<20260428214626.13329-1-deller@kernel.org>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI4MDIxNiBTYWx0ZWRfX7CXcl368zD0V\n bCcF1nZEtYGLYykrDT0j3DH1Mqj2xUimjcJ5/HyzlWschlP8Hym8uDSTZfuxiaVDJaPhINTK3yd\n CY3r0DqsjeZKtaHoRV545uN/CaAX5Yaj/dv+WV0X9uRr2YWbDAnA8Eysphtk6pE/mz2qCNpGVoN\n pYyFYAgGMZPB3L93i/4BcvWpqA9Gm1SqmSdCXQHCWIZ6QKsZcE+S7vYPtnqstmuzRMVdxT2IYbe\n Zk6ifxjRfWL0NM4n7JWU6O/8nkztlV4S4LOneGgGtk26gKPIxPuipJXNu3XX31b26WlD+3CIkNH\n vJbl1JZaYGwIyYWBFmyqaucH6O/RkEGlFoJX6ryscKouMq+8svmPhl/dshdR6AAFuun6Kwj1LKB\n 16p0S0rbLjuzDv1IEiaIcuXR5b3KCQ/Zqm0B1hm9sIv9CqNJ2tklM4TOeoNtREqjJrjvtDZeb2Y\n 0x6cbr8N0KDr/vr5chA==","X-Authority-Analysis":"v=2.4 cv=TZKmcxQh c=1 sm=1 tr=0 ts=69f12f20 cx=c_pps\n a=Uww141gWH0fZj/3QKPojxA==:117 a=iLqgmErQAxjCjdq5jj1Aqg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22\n a=p0WdMEafAAAA:8 a=EUspDBNiAAAA:8 a=tnm1e80skVYX9a8ToU4A:9 a=QEXdDO2ut3YA:10\n a=PxkB5W3o20Ba91AHUih5:22","X-Proofpoint-GUID":"3Q_pPBzbbRF-sX7XIcQXBf0wjO2Tcilf","X-Proofpoint-ORIG-GUID":"3Q_pPBzbbRF-sX7XIcQXBf0wjO2Tcilf","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-28_05,2026-04-28_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 spamscore=0 adultscore=0 phishscore=0 clxscore=1015\n suspectscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280216","Received-SPF":"pass client-ip=205.220.180.131;\n envelope-from=pierrick.bouvier@oss.qualcomm.com;\n helo=mx0b-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]