[{"id":3683890,"web_url":"http://patchwork.ozlabs.org/comment/3683890/","msgid":"","list_archive_url":null,"date":"2026-04-29T08:17:39","subject":"Re: [PUSHED] phiprop: Fix typo [PR125067]","submitter":{"id":1765,"url":"http://patchwork.ozlabs.org/api/people/1765/","name":"Richard Biener","email":"richard.guenther@gmail.com"},"content":"On Tue, Apr 28, 2026 at 11:28 PM Andrew Pinski\n wrote:\n>\n> When I factored out the code in can_handle_load, I had a small typo\n> which seemed to work for most cases but I had noticed later on was\n> broken. Basically the bb where the vop definition has to be dominated\n> by the current bb (and can't be the current bb).\n>\n> Pushed as obvious afte a quick bootstrapped.\n\nI'm curious whether LLM patch review would have catched this?\n\n> PR tree-optimization/125067\n>\n> gcc/ChangeLog:\n>\n> * tree-ssa-phiprop.cc (can_handle_load): Fix copy and pasto\n> on dominated_by_p.\n>\n> Signed-off-by: Andrew Pinski \n> ---\n> gcc/tree-ssa-phiprop.cc | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/gcc/tree-ssa-phiprop.cc b/gcc/tree-ssa-phiprop.cc\n> index 07c81fdce28..b7ce7b4a184 100644\n> --- a/gcc/tree-ssa-phiprop.cc\n> +++ b/gcc/tree-ssa-phiprop.cc\n> @@ -259,8 +259,8 @@ can_handle_load (gimple *load_stmt, basic_block bb,\n> if (SSA_NAME_IS_DEFAULT_DEF (vuse))\n> return true;\n> if (gimple_bb (def_stmt) != bb\n> - && !dominated_by_p (CDI_DOMINATORS,\n> - bb, gimple_bb (def_stmt)))\n> + && dominated_by_p (CDI_DOMINATORS,\n> + bb, gimple_bb (def_stmt)))\n> return true;\n> return false;\n> }\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=f2L8/IuO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=f2L8/IuO","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=209.85.218.46"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g59DH46BQz1yHX\n\tfor ; Wed, 29 Apr 2026 18:18:23 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 76D394BB24D5\n\tfor ; Wed, 29 Apr 2026 08:18:21 +0000 (GMT)","from mail-ej1-f46.google.com (mail-ej1-f46.google.com\n [209.85.218.46])\n by sourceware.org (Postfix) with ESMTPS id ACFB54B99F5E\n for ; Wed, 29 Apr 2026 08:17:53 +0000 (GMT)","by mail-ej1-f46.google.com with SMTP id\n a640c23a62f3a-ba8472c1613so1790307866b.0\n for ; Wed, 29 Apr 2026 01:17:53 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 76D394BB24D5","OpenDKIM Filter v2.11.0 sourceware.org ACFB54B99F5E"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org ACFB54B99F5E","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org ACFB54B99F5E","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777450673; cv=pass;\n b=Ugsc2cdSn7Z7gYFcIHOTiHfnWMe/AG3mh90QBdDmKUeYKqNiRNdX18bHrcAXCqrSiz9mBvUarVeNpbSpwhUl9g94yo9s8RYCaJTXzxsbdtJMyzPJTmUBT2ChmkYVG+C/Up6hsw1s8LJ6hJ1+0BnvN5+TOazgerB/TFp3UvjalNs=","i=1; a=rsa-sha256; t=1777450672; cv=none;\n d=google.com; s=arc-20240605;\n b=My/7/JGwynvHglpJl8YeP20YNHFrLfBHuFhCm3Tt2O0QrRunwSfR5OKHVw9s94/nHs\n s9LGxLLyYC3LL8j0yJmAaQaKW/sZ6RZDE/2uENeZRcZfTxrdpEc2wuUFuG2eiWieQi6x\n Z7PbILyZAENeIhMndMspLq8HDuHQ2BqSuJGl1KPqE5bxYuEGJYV6t8fOiii+lVRnPJOG\n lRJuT48VeD+NS4b6MeUNetFQK4DbE5U9zink98X5vnvDaqHq+7sr/LiteA6TqR3kTCO/\n NDhDRX8Cdu17aPyqc4u0t76y/tJ9Cr33ZaEpbTrsTOqPU1XwUOw0SZ+HYTuFwSUuZQ81\n OXkQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777450673; c=relaxed/simple;\n bh=QDX/iwVBks1p/VV4M4siirujcDIs8FvB0XUP7SFwat4=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=sX0Z39stVmW5ipI+y/5i61PQ0Rb9RvO0fFG5XrOJOfBcP7iJsDCICVgjxVLeEH7NrFZRWVqVfYq4b2BYeG8a1Mr8DJq0B3wwYDLT6uZmCmuO7byu95iqG2nZatovuGNB8813QbGmpNyvW6ti3eCqBk4tfVAi1k/7qE5njGN9C3E=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=LeuOAJywN+47/gmtxUgFswfURtTYiXKa8S/mU3FLij8=;\n fh=+uEDwx55CzEWtNA/tzpV1shOHaMh+Xh7AN17D33930Y=;\n b=OfScmKzhJdGoEc7wBomnIosiWJwc/zHpaqvm3c1mbtFV+paHnPRcQRFkeyS99d3Lxo\n 5OOwF2eGfBzfkcu5oAR7A2hf10niUK1LwPAg30wTCJLO/82WuD/bGiOg73oCaHgSaut1\n fooyY9dvlW8oXaJdcVOMMy+ZYCCY1XuUZKw+9yTewvghwRwnCZ9ZhkzMtOfUrZZyZ52m\n rDc4Rgcvpn3TYUad2aJ2vvWOSpTGqnJDWKLCcIutqF+25lWtVADK2AdrPDzwxOALECmQ\n kRXMAhPqwi0c+ADPAuhy5Slvqj/h7QfNnUQud1rmMqx87753bO7HqWeDTFQlhzmEQvoj\n 3DsA==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777450672; x=1778055472; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LeuOAJywN+47/gmtxUgFswfURtTYiXKa8S/mU3FLij8=;\n b=f2L8/IuOe/LiUexeFAkelh6FS8cd4E8eGPE3DAo3cStcpHY/LwymiESPIfs5kuUyFp\n 3JZ7FXu4cSgLqwFEJ2QsoiJa9G4u1WuNw8YksB7HozgJbIJYwyActG/RkK0u7/weCZoU\n GeMMhgDu+nYIVitTxu/BOo8axNEoB7c+SAy2P5cfpT+6d+VzrKJg7CfFWU9zTXWHvuKh\n a82vCrH9j5w/GnILWXvRbGFcof48q7kZxf/+HJB0n/7XKZbaAeWhv32BM5kzz/EKBhOW\n Cp6I96D+kJHL3gqe2FG78GC29yORtuBTWnsmd2WfoLKP78ogkfYoT89yu/iT4/BKr7Dx\n XxUw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777450672; x=1778055472;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LeuOAJywN+47/gmtxUgFswfURtTYiXKa8S/mU3FLij8=;\n b=TlGYRgVZSoR6UvYrfDHqsZOa6gPmRO+gk4jhvDZnca9gNlrxqMa9Y3oKayHq9TXaKx\n 0Js0XJPfeHp4QPL65KuGwyytjo+KXf4DTzlCO6FXj59GXobzs/cAgAPUPi9kErDWGk5H\n rx2jSKCl0+pOEQnVqgqDrFTnHeRbaBaUe5+Vw+82tXNvAfKXJ1a9Yjb1eTDh2Jbj9nPO\n zGDoiHmgwLQommsgvBSa8kHl35Ja8o9pOQph++Rp+gKJyB8PRgW5DRzN4nYJ1jKzKbPG\n gKTmdOs4b2Qc2cMgEynp+VsuAmnTJP9cm/+aAhYnuPz06hkGgtQSmMkbBKGRPEZutKHN\n fBzA==","X-Gm-Message-State":"AOJu0YxCAI9CTAGpJ/TmHaWqG1ro14rAhPCBszV6a98mbsi9TTgUldhW\n 7CwsNs4/FdA9mJlRpNgAyZND6nlj4G9aDdHAuUyWRL/KP4CiNvlwaEWPRJfi+9FuCJaf0misjwY\n 7pzvH9D8cLKda/pCLSGNCUJGVFPK3iTY=","X-Gm-Gg":"AeBDiesNSsjmrS8XqSuC7N8ZHDUHKgdCP0l9jpan+re2mmP2Y0ZE82ioOKgGQ/AhZHK\n +vF6+/6pgbfa5tiK502M5iX0BU1DGCIhg36vjES0metIcrQLlUZsLqfwg8PofdP46Q1BZCCpnS/\n PwE0l2gwGRhHObhwmpdtc2iCuhDpUlBryhlhbpFXQt59UnV+jm5HtvRYBFtfHaiKm7Jkza4C7TV\n f5G9HAKENPrgYlaxUim6RCWPOvPbPCYnbXpeLuK8pu9VPdvdER1xIGwpuwTseI6fHr56VTneU7J\n gbVxkfotpPjwLYlm","X-Received":"by 2002:a17:907:1804:b0:ba9:3162:182 with SMTP id\n a640c23a62f3a-bb801ed5633mr395474766b.19.1777450672244; Wed, 29 Apr 2026\n 01:17:52 -0700 (PDT)","MIME-Version":"1.0","References":"<20260428212712.1460554-1-andrew.pinski@oss.qualcomm.com>","In-Reply-To":"<20260428212712.1460554-1-andrew.pinski@oss.qualcomm.com>","From":"Richard Biener ","Date":"Wed, 29 Apr 2026 10:17:39 +0200","X-Gm-Features":"AVHnY4JBikaHAdUXaYJ3sbGB-cfUdZ9G_RaUY2KrmM3NCPd6knOPMv35JN17Z68","Message-ID":"\n ","Subject":"Re: [PUSHED] phiprop: Fix typo [PR125067]","To":"Andrew Pinski ","Cc":"gcc-patches@gcc.gnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3684166,"web_url":"http://patchwork.ozlabs.org/comment/3684166/","msgid":"<498A7A44-4E6C-498C-B697-D5B8B1E9E9DF@comcast.net>","list_archive_url":null,"date":"2026-04-29T16:50:58","subject":"Re: [PUSHED] phiprop: Fix typo [PR125067]","submitter":{"id":4385,"url":"http://patchwork.ozlabs.org/api/people/4385/","name":"Mike Stump","email":"mikestump@comcast.net"},"content":"> On Apr 29, 2026, at 1:17 AM, Richard Biener wrote:\n> \n> On Tue, Apr 28, 2026 at 11:28 PM Andrew Pinski\n> wrote:\n>> \n>> When I factored out the code in can_handle_load, I had a small typo\n>> which seemed to work for most cases but I had noticed later on was\n>> broken. Basically the bb where the vop definition has to be dominated\n>> by the current bb (and can't be the current bb).\n>> \n>> Pushed as obvious afte a quick bootstrapped.\n> \n> I'm curious whether LLM patch review would have catched this?\n\nMy best guess, take it for what it is worth.\n\nAn LLM patch review could definitely catch this, but it highlights a specific strength and a specific weakness of LLMs when it comes to code analysis.\nHere is how an LLM would likely \"think\" about this patch:\n1. The \"Pattern Matching\" Catch (The Strength)\nLLMs are excellent at identifying logical inversions in standard patterns.\n\t• The Pattern: In compiler theory (and GCC specifically), dominance checks are almost always used to ensure a definition is available for a use. The pattern if (dominated_by_p(...)) is extremely common.\n\t• The Red Flag: Seeing !dominated_by_p followed by return true triggers a \"heuristic\" alarm. Most LLMs would flag this as suspicious because it essentially says, \"This is safe to use only if the definition doesn't reach here,\" which is the opposite of how SSA form works.\n2. The Contextual Catch (The Weakness)\nWhere an LLM might struggle is knowing exactly what can_handle_load is supposed to do without the surrounding code.\n\t• If you just showed the !dominated version, an LLM might assume there is a very specific, niche reason to exclude dominated blocks (e.g., preventing a specific optimization loop).\n\t• However, the moment you provide the ChangeLog mentioning a \"copy and pasto,\" the LLM's \"intent-alignment\" kicks in. It will compare the old code to the new code and immediately recognize that the new version fits the \"SSA dominance requirement\" template.\n3. Would it have caught it before the fix?\nIf you had submitted the original, broken code to an LLM for review (before Andrew fixed it), the results would be hit-or-miss depending on the prompt:\n\t• General Review: It might miss it, assuming the developer knew what they were doing with the inversion.\n\t• Safety/Correctness Review: A prompt like \"Check this for SSA dominance violations\" would catch it 100% of the time.\nWhy Andrew's fix is \"Obvious\" to an LLM:\nThe fix moves the code from Impossible Logic (using a value where its definition doesn't reach) to Standard Logic (ensuring the definition reaches). Because LLMs are trained on millions of lines of correct GCC/LLVM code, they are biased toward the \"Standard Logic\" and will flag the \"Impossible Logic\" as an error.\nVerdict: Yes, a modern LLM (like GPT-4 or Claude 3.5) would likely flag this as a \"potential logical inversion\" or \"incorrect dominance check,\" especially if asked to verify the SSA integrity of the function.\nDo you think the \"obvious\" nature of this fix is why it was pushed without a PR-specific test case initially?","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=comcast.net header.i=@comcast.net header.a=rsa-sha256\n header.s=20190202a header.b=t5rp+cB4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=comcast.net header.i=@comcast.net header.a=rsa-sha256\n header.s=20190202a header.b=t5rp+cB4","sourceware.org;\n dmarc=pass (p=reject dis=none) header.from=comcast.net","sourceware.org; spf=pass smtp.mailfrom=comcast.net","server2.sourceware.org;\n arc=none smtp.remote-ip=96.102.19.41"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5NcN6BGVz1xqf\n\tfor ; Thu, 30 Apr 2026 02:51:31 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 7EA414BB58CE\n\tfor ; Wed, 29 Apr 2026 16:51:29 +0000 (GMT)","from resqmta-c2p-570641.sys.comcast.net\n (resqmta-c2p-570641.sys.comcast.net [96.102.19.41])\n by sourceware.org (Postfix) with ESMTPS id 4BED34BB5891\n for ; Wed, 29 Apr 2026 16:51:02 +0000 (GMT)","from resomta-c2p-555442.sys.comcast.net ([96.102.18.241])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 256/256 bits)\n (Client did not present a certificate)\n by resqmta-c2p-570641.sys.comcast.net with ESMTPS\n id I4Uiww8XAwSGdI87pwSXyg; Wed, 29 Apr 2026 16:51:01 +0000","from smtpclient.apple ([76.133.244.13])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits)\n (Client did not present a certificate)\n by resomta-c2p-555442.sys.comcast.net with ESMTPSA\n id I87nwDL79O17mI87owYLzA; Wed, 29 Apr 2026 16:51:01 +0000"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 7EA414BB58CE","OpenDKIM Filter v2.11.0 sourceware.org 4BED34BB5891"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 4BED34BB5891","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 4BED34BB5891","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777481462; cv=none;\n b=mDT9SIMuNa8piPAwj8jYcf46UYXCYxvdYhhqFzxCDKUHI08efSHjMpiuLiyjH6lknHdfD1y8mKBFFtlPfFNFlgfI7a0LH3Zm3CRjUaiJCdyDP4dy1RqyeorO6NTd7h24YmL0E1Ni09ABRAysbwXOiC3SmVyaGq/hBPn8ZjmGM+o=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777481462; c=relaxed/simple;\n bh=X8A95shU7N6zC1CaEmvAmzMhqA66Jo2zK5e5pRfl/30=;\n h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To;\n b=Sl+SUJktoHPqWCWRGIWMrH9xAKE99crrQHNsUeqVDUjgB6MLQITyiP8rgpA6nH7nT+CQR178hDMNgzYThPk4FNb8sqHS7IbG4CC9f09BEc/LSxBcgijrCPYGQO7AE2eNtjBPKAcunh2q/JuTFfAzPpI+AgDe5mol0wpGl9TtCuI=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\n s=20190202a; t=1777481461;\n bh=209lqMEbtwf+017seZw4KHx9tVJm5CMT/+PBIT+lB7E=;\n h=Received:Received:Content-Type:Mime-Version:Subject:From:Date:\n Message-Id:To:Xfinity-Spam-Result;\n b=t5rp+cB4ctxcXRHO2yAinHQ9P1siBeQNo2eUMCtRvSHcf1cuBh5PqdMr8OjPEEXjr\n iSswi+/jWixAlkdWryqK2uosO0WL8np06uaopz6MFWjOPP6yTWV3I765FEfYGyvEmQ\n q8gFiWTsZuytG1A0zd9bV5KgFOo8Ae6OiwN16pqJmIF1GIZKJ9Ryiof8S6HlTOWC3D\n S4umiwWsJ6loOyIyBtcJZhZQCHFA2X5XR6RsDUooWL0KuXO2Q/YI9q+a4qp+bwCrsP\n a4aazzdYo66TkA/0/F+234qwy1Vza+POEpyYQBGr9kdFohNrd80hLtK6JkjAMqrhBQ\n 7JJv5c7qwMdAg==","Xfinity-QID":"I87nwDL79O17mI87owYLzA","Content-Type":"text/plain;\n\tcharset=utf-8","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3696.120.41.1.10\\))","Subject":"Re: [PUSHED] phiprop: Fix typo [PR125067]","From":"Mike Stump ","In-Reply-To":"\n ","Date":"Wed, 29 Apr 2026 09:50:58 -0700","Cc":"Andrew Pinski ,\n gcc-patches@gcc.gnu.org","Content-Transfer-Encoding":"quoted-printable","Message-Id":"<498A7A44-4E6C-498C-B697-D5B8B1E9E9DF@comcast.net>","References":"<20260428212712.1460554-1-andrew.pinski@oss.qualcomm.com>\n ","To":"Richard Biener ","X-Mailer":"Apple Mail (2.3696.120.41.1.10)","X-CMAE-Envelope":"\n MS4xfN8gBZodIP8Wr8tlCQ9sYoOxxG/9iUbFdz2m34D3XPZIsGVe6G6FpJX/7CDG9r+SzrWiw0sIRRP2WcfTeftv1cipNU3vqL6K2TBe9kL6CH48HMv1tRpB\n Y1mrNPpxx7sFkvuDGXfSkwJqEqhjIIC1a5fWO5sKJ6ssDKqL48bQFDRog4bfYcnxQBUOjwN+q/GJ5Z2TAnktB6aIo4N7fTrG94pLgsNUF45Ppg2eYRum8/sf\n tQ3rYYTP4JVKO5nyRptS59aJcdfalhTCSNYFpQsHgBxeqmuaQtQMp4dwWO9fLfUY","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3684189,"web_url":"http://patchwork.ozlabs.org/comment/3684189/","msgid":"","list_archive_url":null,"date":"2026-04-29T17:49:46","subject":"Re: [PUSHED] phiprop: Fix typo [PR125067]","submitter":{"id":1765,"url":"http://patchwork.ozlabs.org/api/people/1765/","name":"Richard Biener","email":"richard.guenther@gmail.com"},"content":"On Wed, Apr 29, 2026 at 6:51 PM Mike Stump wrote:\n>\n>\n>\n> > On Apr 29, 2026, at 1:17 AM, Richard Biener wrote:\n> >\n> > On Tue, Apr 28, 2026 at 11:28 PM Andrew Pinski\n> > wrote:\n> >>\n> >> When I factored out the code in can_handle_load, I had a small typo\n> >> which seemed to work for most cases but I had noticed later on was\n> >> broken. Basically the bb where the vop definition has to be dominated\n> >> by the current bb (and can't be the current bb).\n> >>\n> >> Pushed as obvious afte a quick bootstrapped.\n> >\n> > I'm curious whether LLM patch review would have catched this?\n>\n> My best guess, take it for what it is worth.\n>\n> An LLM patch review could definitely catch this, but it highlights a specific strength and a specific weakness of LLMs when it comes to code analysis.\n> Here is how an LLM would likely \"think\" about this patch:\n> 1. The \"Pattern Matching\" Catch (The Strength)\n> LLMs are excellent at identifying logical inversions in standard patterns.\n> • The Pattern: In compiler theory (and GCC specifically), dominance checks are almost always used to ensure a definition is available for a use. The pattern if (dominated_by_p(...)) is extremely common.\n> • The Red Flag: Seeing !dominated_by_p followed by return true triggers a \"heuristic\" alarm. Most LLMs would flag this as suspicious because it essentially says, \"This is safe to use only if the definition doesn't reach here,\" which is the opposite of how SSA form works.\n> 2. The Contextual Catch (The Weakness)\n> Where an LLM might struggle is knowing exactly what can_handle_load is supposed to do without the surrounding code.\n> • If you just showed the !dominated version, an LLM might assume there is a very specific, niche reason to exclude dominated blocks (e.g., preventing a specific optimization loop).\n> • However, the moment you provide the ChangeLog mentioning a \"copy and pasto,\" the LLM's \"intent-alignment\" kicks in. It will compare the old code to the new code and immediately recognize that the new version fits the \"SSA dominance requirement\" template.\n> 3. Would it have caught it before the fix?\n> If you had submitted the original, broken code to an LLM for review (before Andrew fixed it), the results would be hit-or-miss depending on the prompt:\n> • General Review: It might miss it, assuming the developer knew what they were doing with the inversion.\n> • Safety/Correctness Review: A prompt like \"Check this for SSA dominance violations\" would catch it 100% of the time.\n> Why Andrew's fix is \"Obvious\" to an LLM:\n> The fix moves the code from Impossible Logic (using a value where its definition doesn't reach) to Standard Logic (ensuring the definition reaches). Because LLMs are trained on millions of lines of correct GCC/LLVM code, they are biased toward the \"Standard Logic\" and will flag the \"Impossible Logic\" as an error.\n> Verdict: Yes, a modern LLM (like GPT-4 or Claude 3.5) would likely flag this as a \"potential logical inversion\" or \"incorrect dominance check,\" especially if asked to verify the SSA integrity of the function.\n> Do you think the \"obvious\" nature of this fix is why it was pushed without a PR-specific test case initially?\n\nSo I threw Andrews patch at Gemini 3.1 Pro Preview and Gemini 3.1\nFlash Preview and both correctly identified the negated\ndominance check error (together with a lot of not so useful work they\nstart to do with my eventually not ideal prompting...)\n\nThat said, I wondered whether trying to build a bot that reads\ngcc-patches, does reviews and sends those for\npre-screening to humans who can forward or throw them away would be\nsth useful. I'm at least considering to\nthrow my own patches at such a thing, if only to fine-tune prompting\n... (and catch such errors)\n\nRichard.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=r0/9eZgO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=r0/9eZgO","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","sourceware.org; spf=pass smtp.mailfrom=gmail.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=209.85.218.47"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5PwT0kTlz1xqf\n\tfor ; Thu, 30 Apr 2026 03:50:31 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id B8D0E4BB589A\n\tfor ; Wed, 29 Apr 2026 17:50:29 +0000 (GMT)","from mail-ej1-f47.google.com (mail-ej1-f47.google.com\n [209.85.218.47])\n by sourceware.org (Postfix) with ESMTPS id D63E24B99F4C\n for ; Wed, 29 Apr 2026 17:50:00 +0000 (GMT)","by mail-ej1-f47.google.com with SMTP id\n a640c23a62f3a-ba7fd666666so1251065566b.3\n for ; Wed, 29 Apr 2026 10:50:00 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org B8D0E4BB589A","OpenDKIM Filter v2.11.0 sourceware.org D63E24B99F4C"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org D63E24B99F4C","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org D63E24B99F4C","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777485001; cv=pass;\n b=IoDazLaGuHhiT9hbvwWsQb3zqszydMTghCmBR1kUoOvVmbYHrIZwXn0ekNs8Ous6cNmcOshH7/34/+xgHpSBUn8QL/kkzUTWKYBpFqxOKUPbijcmbT+Fz+6b1V5XJ/wn2XbNejGCLAN58+MHzv8MqsI5RyBM7Rm5wGJoESARx8g=","i=1; a=rsa-sha256; t=1777485000; cv=none;\n d=google.com; s=arc-20240605;\n b=GMF6UkedniVbGrSgpV1ljMQ77HExyEG2i0hcougAqT4mfDFvB4hKcz8MGzP79RCEG6\n C8v5sMvJI3nOVBzSKPpsOdC1tj9tCqkhmfitOhl/yGJjwM4bveV0KFIjJwyYCi26YR7W\n a2gd3E/7sVMhqiaiYnZovvQ1uUHx958GHNWOXD6WxEnlk/RDqaW03o1P4crqvK+JHfzU\n a0HDDIqmnTA7ynmQIGfprnF/hW211VBMW27NPgTZtiL+BwyY/vzDj8O44WvekwpsGiBM\n 0ClW0VdiAwcdbb7WPDu/eLB28t6VKADHvlk7wZLywH+kbnficANJZ9loKDaHB9xVoA/g\n M7Rw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777485001; c=relaxed/simple;\n bh=B4YwKbsZF8PnFDMC7c2BeRBSFEIJzQyiGzmwCJG2GiU=;\n h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;\n b=ggFx29qu4E16oYCvj0vnCMuZl8+EWPvwjOgR67hgQJkCpHT59H85hsr4iczTgqlmM4c7YZhOpLbSJlXowthdWXlyhxhRLzkmgL2DWAU9zd9m/ksTBTbFRKFr3xX2UJAa1EM1jCVhoVVBwT+NnuXtBtDdcpYv28ky27bDpA1Fp5g=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=yEsiJR8WroR7vy/UfDv6ia5GQbshh9frsFAFeG6Yw8I=;\n fh=1N10RpXbZM6BM4qSfxLYVcPqf+izKOk//GRauRB7Ycs=;\n b=fdO66o9leUdaWC/70xembn9acsKfUbhkXox+f4OvgliT+USIvLK9TUnz/F7Yn+9h0L\n GDtnF5rV3iBQRBVULff3u1uh/DOEY1CiM/knaoTugzmZ5q0X5343jJ3ThVRH6eTQHyM9\n E9B9Z9KFuPu1qz16ao9rbL3cN5Zj2XfDWuSH01t3baYex3WdATRg/3EvsiB/k1TBdRDO\n VZWXxptPpWq34VoP61DPLDD0JlK8otV7LQ5cFHUHosWoiyhUZuSubqMGX31xiiCfEK4z\n V5ZObXz8DpCptvwle4b+IYam6+fipHejUZJj8T1Bh6woy87d7juvyecyZOLrOm3BmjH/\n 1EfA==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777485000; x=1778089800; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yEsiJR8WroR7vy/UfDv6ia5GQbshh9frsFAFeG6Yw8I=;\n b=r0/9eZgOrg+zZwxHEuqOqUaLCPyg88zBFalqpqz31SFM7ByMYznT8+OUIPC1C/cNsP\n S/S+76O9hijX3s9PFsb7mcwirIWtqxeG6BmIpE+E4yzROWILUch6NifBvhArwUFl8Jop\n ss7LBQlkNir+hG0gOJ1iFpiavCYF6ubUZZ9AvM/x1gDh/D46jk0DCAnqeFNLbA4m7F2/\n 2t+ZivhrUZTGtzdrC6oeka2bUQyYGO6QDuwJkLWmrMV93oeN426wlPoGgfbE0tIO/6Ht\n woeqeH/pk12ZNu9fGLBn5ds0GFRPFVbc0cDRKi0HIt6nFsDE19eK6++5nrkvZj6LYrhn\n rrXQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777485000; x=1778089800;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yEsiJR8WroR7vy/UfDv6ia5GQbshh9frsFAFeG6Yw8I=;\n b=D9NaJEmHxYnND5mMI4IUZ4SC795OZGY6otiyxohqBK2MgDbGIDE0FNYpAv/DyZkVUG\n T3BfdBp3YSnOoyWZewv3+g8KfB/RBxxb9HSysCbRyr24fWdrHK2VZoQGMs5weKpvCOCM\n beUGiykbL4uE8tkmZo3t2El2EjWDr+BOBjVt6OIwtZfR0UsvZoaDvJ0w/h0UcnBx2eR8\n B9kEiwrjpV8c5CtVa9Ahl2LTzfnjH9x4GQdIp1E5goO4MMxScIC2sZwZssaux1Fy4rfG\n LuxzCGEjPXV0jxYXCDs8W0tEuYzxCXVSFBZWHz3ahn0euuIM4Sb60337m+6284qO7feg\n YR9A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/bknCemzXQwDO15PIY79f78IheaGVK4QjOBMdEFFkKtsIEwDc2GKL3l8JgBreqv6Y8LVAhI8ouqf9GJA==@gcc.gnu.org","X-Gm-Message-State":"AOJu0YzaSDIZhKd8kOa/TY1x+x4dhz1vjDzMQoWqHoH24+It83a3kmcL\n JWie15MnZuU+P9KoST2ICKG38F5vKaLUOGVb/yXLU1kjB9JeNIKy0vdBj7FJmBYCCDP3ZywJ4z1\n XUOD4P1ab1echWSVRgvh72b5XI3M4OHuABA==","X-Gm-Gg":"AeBDievR9HByDrMtE8Mcf5bu7LcC29iA3b6t1+BWh9NDOKLLX2XauRhVMe02uOrr0ub\n Emfk5xoOuD98sjEpsZtBN4VsTmEom+XXWaIOOwVIjmokBw2ohS3qKBB+gdqgJBc0c5hv7Z0u1k2\n Pl0QmEREFHj0EWpCJZTqdBVICMG15KxwXDPRPJ3Dfr9DQ8I75p8WsMFP4fzfQ66U7qUVXJVfs3W\n kTILLV2zMmOZYCkGF8lhBtZh962OlJsPIKPnxbiHf2iXx7jG3SMBMZXQ3GjfJqfDMoZ8qi+6G0j\n jng0Eljp4evozuM=","X-Received":"by 2002:a17:907:d109:b0:ba5:3e3a:81ee with SMTP id\n a640c23a62f3a-bb804a2b561mr607771466b.39.1777484999532; Wed, 29 Apr 2026\n 10:49:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20260428212712.1460554-1-andrew.pinski@oss.qualcomm.com>\n \n <498A7A44-4E6C-498C-B697-D5B8B1E9E9DF@comcast.net>","In-Reply-To":"<498A7A44-4E6C-498C-B697-D5B8B1E9E9DF@comcast.net>","From":"Richard Biener ","Date":"Wed, 29 Apr 2026 19:49:46 +0200","X-Gm-Features":"AVHnY4LvKvguSYAfVMFm7UmrbaS5R54BzAiIMzNbm4ksMIIqXDeuOuWxYm2OSKI","Message-ID":"\n ","Subject":"Re: [PUSHED] phiprop: Fix typo [PR125067]","To":"Mike Stump ","Cc":"Andrew Pinski , gcc-patches@gcc.gnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3684259,"web_url":"http://patchwork.ozlabs.org/comment/3684259/","msgid":"","list_archive_url":null,"date":"2026-04-29T20:53:02","subject":"Re: [PUSHED] phiprop: Fix typo [PR125067]","submitter":{"id":92310,"url":"http://patchwork.ozlabs.org/api/people/92310/","name":"Jeffrey Law","email":"jeffrey.law@oss.qualcomm.com"},"content":"On 4/29/2026 11:49 AM, Richard Biener wrote:\n> So I threw Andrews patch at Gemini 3.1 Pro Preview and Gemini 3.1\n> Flash Preview and both correctly identified the negated\n> dominance check error (together with a lot of not so useful work they\n> start to do with my eventually not ideal prompting...)\nYea.  I've done a bit of that as well.  There was an AArch64 patch that \nwas known to have 2 bugs and per a request I threw it into a couple \nmodels.  Each model caught one bug, but not both.  I'm seeing reasonable \nsuccess with things like RTL target patterns and match.pd patterns.\n\n>\n> That said, I wondered whether trying to build a bot that reads\n> gcc-patches, does reviews and sends those for\n> pre-screening to humans who can forward or throw them away would be\n> sth useful. I'm at least considering to\n> throw my own patches at such a thing, if only to fine-tune prompting\n> ... (and catch such errors)\nSure.  Though I'm seeing enough useless stuff that there mass LLM \n\"review\" is going to generate a lot of useless crud.  As much as I've \ntried to do prompt engineering (in another context), I've found it's \nbeen very hit or miss in terms of improving quality of results in \ngeneral.  So while I'm finding LLMs useful for patch review and some \ncode analysis, they haven't hit the level of quality that I'd like to see.\n\njeff","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=gMpEROAu;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=U5LomRsF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=gMpEROAu;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=U5LomRsF","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=205.220.168.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Tzj01tvz1yHv\n\tfor ; Thu, 30 Apr 2026 06:53:35 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 9CC8E4BBC0C1\n\tfor ; Wed, 29 Apr 2026 20:53:33 +0000 (GMT)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n by sourceware.org (Postfix) with ESMTPS id 7DDFE4BB5891\n for ; Wed, 29 Apr 2026 20:53:06 +0000 (GMT)","from pps.filterd (m0279863.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63TKcAWm2873768\n for ; Wed, 29 Apr 2026 20:53:05 GMT","from mail-dl1-f70.google.com (mail-dl1-f70.google.com\n [74.125.82.70])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dubq9kkj2-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Wed, 29 Apr 2026 20:53:05 +0000 (GMT)","by mail-dl1-f70.google.com with SMTP id\n a92af1059eb24-12c726f4019so248796c88.1\n for ; Wed, 29 Apr 2026 13:53:05 -0700 (PDT)","from [172.31.0.17] ([136.38.201.137])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12de321f1cesm5558788c88.8.2026.04.29.13.53.03\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 29 Apr 2026 13:53:04 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 9CC8E4BBC0C1","OpenDKIM Filter v2.11.0 sourceware.org 7DDFE4BB5891"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 7DDFE4BB5891","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 7DDFE4BB5891","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777495986; cv=none;\n b=kVsynqOPNUqO/NqTzxKK5kDSvS2UmVf/9/vEAWof2k+oJdwfKVCK6SHJ3yPsI1VupK+EqAlCoa2Z13TvGqZSWkyeuwQp+TW4d7VRc5Tbya0BxtZx8XMy/tAOevI1atabMimgbK9FkYNTwoDnflIz8LUXe4CRlBhBqYnSzyKsIjc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777495986; c=relaxed/simple;\n bh=ybf7tDXM/rLAN05rC+pP3Pbb7BO8n1TDbGrTBHy6CiQ=;\n h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version:\n Subject:To:From;\n b=KZJFgh+udUnLthpjngiuTcYlluR703jah+yk0wCQh7WfoXajVtEr+pCUCruVj+/WDr6JICdoKXhCazhf9yOngqjOBTmxvqssWJFJP6UX/pbR3VTpm3K0/M+vZDUuPFCu+8JW9IO9AuEHvcwQ7HSoqVQXqJXjTj3C3/h80MJDhLg=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n eZnoKGyiznagzca2H5CTQyuytcRo6oMWjiMXqokUTt0=; b=gMpEROAu1UCDQCyH\n bZ8eQwv/C45XNW6daYRFqLAKonGQ9ZgKfbimaCqoIeDsDa4GOEqf1bY5a4ODLXkw\n LooI4K1g+5u4dDDbNeawALoBCExZI8cH7JuD9D8/L5s8aRZ0IDEwwsO2t7PA2RM7\n Ou5eEH38ACTEYTHMj3WFyVtpuhZN30J1QjDrveG6IAv1LFuVGyraPI2e4G9v1WFz\n MSv/NUtSg6TYqh1g3c17FQVYkhlp9Cc3YGRQGYFAYYAEEEszHasbsTIWSe/AWnYt\n pTkcSiIveib4T7CE0mnlQp/k9RklVqsN5ASMep2utpaMUdFMTXWFIqrsW10jiIpx\n Ht2jCw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1777495985; x=1778100785; darn=gcc.gnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=eZnoKGyiznagzca2H5CTQyuytcRo6oMWjiMXqokUTt0=;\n b=U5LomRsFMQTpnv2PFJmhM3uszj8gjMUL6ycfdLNLddCrAWROyjcjjddJsp3ld5KSwI\n hWEwOVwCdoUWC1e5V6kbVUjV+46C4YVsG5SeZxzO6eEDPUjmsGTS5osffyF8Bu7lqAC3\n n/q1t1e3j3WoVcc8tM0U9kIiO8+4d/LGMyJigKhAxKgX2PvmeJa0wM4ou7ttrbbqrxbC\n OED5rF2GEtQJbXf7vepZawaSW76h0O4m2WkUxZQ4Eh9Rb1v/R2NJsM7ZZZfYHMjuwznb\n +alaFrckCBqL9NGGVhTCi9iJuYkAxecZTBDK3XmgSH/u/zN5NMBjkWJp6/DtIRx8zxil\n CIRQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777495985; x=1778100785;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=eZnoKGyiznagzca2H5CTQyuytcRo6oMWjiMXqokUTt0=;\n b=AWI+pcUvsYD9oUTUfqYkTfI8o2+Gy9Eqg4KjHfhta+67alykpjFdaEF+hBAkUPvQYe\n d07OitzeK/l2wVf3XHkJbApFvkfFyJ5unkjTtwkDyJCfQQmpTpGs7VMPIMrOKrX10QKN\n VXZ/QIuYq2i155/MQWmZAZbMCYR0kIxkbxlGjrQRJxfEJpvyQtm2AHuEKSnXuIFuftAY\n RJs3vKioaxs5yO2v/pfcAPVOStz8B3YH+6CvaabIqgU7iWhOgKNN3m/3bTyv8D7RSJtw\n 9FjVpBTnp/eGxTJfPIqY29jG+Bb6+1Xc2mFXYXnSJ3vzpO7lo2fsAbvGJwIqpHu3joNa\n XZ5w==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/f+/tF0Z25x3NMO5NyWVrWb1Sq0qWvBn9RUpf27L9yiu7H8OT8TkB8ZdngeBUVhSHkHeQKYLzqCCsgTg==@gcc.gnu.org","X-Gm-Message-State":"AOJu0YzPiJ00n48ZKe2UzWI2PXg7Josdoi3xn+CkC2SC6gFG+jIVP3LH\n 7nA7sHFZrfKH6aMY1ZWPmDHCOU+Xb0FCrpNrBRlRz3mQqJ2jMWMm0xDm4cdGzKpFfQmF5OPnl0W\n lKY4FFQhuHTR4lDNGjyEQHjHYa89DfxqQ3pNZI5mn7+cbIHhKuswg7MBk7mBY","X-Gm-Gg":"AeBDiesQ3IQW55Rd/6fGuttJx6KpTlfmb/T7zPPMoaOalXtFFS26iDmKIrtZhTV5cq7\n iluHDKYZ2DO6h3rKbmIvJsWrc59yp9xtVjJa4N4OraQqS9ZtGtnG6dpUkXFNLjPL88FQUGRFE5M\n xrReTOggCXOdb2NXd+igoSU2vMU+tIqCHY0ZhfEfgi+cqpZMsdQUem6ol4PDzbmwKvdBGxySLwq\n cEqJPJMed9SbR/Y8N2vqTTcCS8GE2LCOYSA4VAxQKQng/RagdVxO2/FOVXiF6H1S2Tkr9DNrBT3\n AHXECfWlrGrHlRy8DHjJ9CpvhGFQRlO90dZYN4wc5v0oc4GZYAVtY4d/l+Uo4i9fcUXM5ZKepg7\n 0LyNLIltTgLiPTQWTnWVjMJNKLB/Po4Mz1s8zyICjCRhZhrHTqffAQ36I5MR3","X-Received":["by 2002:a05:7022:1281:b0:12d:b175:2573 with SMTP id\n a92af1059eb24-12deac4f473mr107203c88.7.1777495984822;\n Wed, 29 Apr 2026 13:53:04 -0700 (PDT)","by 2002:a05:7022:1281:b0:12d:b175:2573 with SMTP id\n a92af1059eb24-12deac4f473mr107185c88.7.1777495984296;\n Wed, 29 Apr 2026 13:53:04 -0700 (PDT)"],"Message-ID":"","Date":"Wed, 29 Apr 2026 14:53:02 -0600","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PUSHED] phiprop: Fix typo [PR125067]","To":"Richard Biener ,\n Mike Stump ","Cc":"Andrew Pinski , gcc-patches@gcc.gnu.org","References":"<20260428212712.1460554-1-andrew.pinski@oss.qualcomm.com>\n \n <498A7A44-4E6C-498C-B697-D5B8B1E9E9DF@comcast.net>\n ","Content-Language":"en-US","From":"Jeffrey Law ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Proofpoint-GUID":"4T3V7JCTgucJVCzoCxVRF0QOg5-9Puvo","X-Proofpoint-ORIG-GUID":"4T3V7JCTgucJVCzoCxVRF0QOg5-9Puvo","X-Authority-Analysis":"v=2.4 cv=Wak8rUhX c=1 sm=1 tr=0 ts=69f26fb1 cx=c_pps\n a=SvEPeNj+VMjHSW//kvnxuw==:117 a=asGLMfRmzhnGNxaIYohjRg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22\n a=_Szo24brEAjMPE7sic8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=Kq8ClHjjuc5pcCNDwlU0:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI5MDIwOSBTYWx0ZWRfX+9mFnmCVjSAF\n fpGtLuxF51KT8hSQf0mMFmBX/270IzHCRicxxp2H2kfIXNWTuBaEqtj/M0ddApQMNP6IdK6ntpP\n x3ezYOQMe9o+uWbVf8t6uzFNksnbtxGHoLjFEVvqHVMsH1rHUW8tVP57jQgkLohq/ePARYNchWz\n SyG3NVtvgmR1kgdXYE2o0F0CsW8YN/sQj/mC16PFhh3GsOwtsDNtMIqPKYj4+c2J18NO5bxXMG4\n a8aFWj+//96iBapCOselZ2BBofh3difkaQB3k9BGJaXY1GkAXexc81xVomBsLgiMNU6mkIIDkC6\n Cb4qjqN+CeSpwX9IZIjcPI8/nW/ko19wzUkyhQIb0d8+oZJlPE+I6iIFOPOW53OjvkOT14IzEVC\n mQRSHr7BvenmPpQ8R4doBAuh+4VXqlVllt5OSj9MvxgjXzBj2uassO5VIfpP2b7+STDjOC1k0dR\n jj3pGwWMu99N/QtVl6g==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-29_02,2026-04-28_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 clxscore=1015\n bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290209","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]