[{"id":3683803,"web_url":"http://patchwork.ozlabs.org/comment/3683803/","msgid":"","list_archive_url":null,"date":"2026-04-29T04:17:42","subject":"Re: [PATCH 1/7] arm64: dts: rockchip: Add #{address,size}-cells to\n Chromium-based /firmware","submitter":{"id":81844,"url":"http://patchwork.ozlabs.org/api/people/81844/","name":"Chen-Yu Tsai","email":"wenst@chromium.org"},"content":"On Wed, Apr 29, 2026 at 1:12 PM Brian Norris wrote:\n>\n> Chromium/Depthcharge bootloaders may dynamically add a few device nodes\n> to a system's DTB under a /firmware node. A typical DT looks something\n> like the following:\n>\n> ## From a RK3399 Gru/Kevin Chromebook:\n> # find /sys/firmware/devicetree/base/firmware\n> /sys/firmware/devicetree/base/firmware\n> /sys/firmware/devicetree/base/firmware/coreboot\n> /sys/firmware/devicetree/base/firmware/coreboot/ram-code\n> /sys/firmware/devicetree/base/firmware/coreboot/compatible\n> /sys/firmware/devicetree/base/firmware/coreboot/board-id\n> /sys/firmware/devicetree/base/firmware/coreboot/reg\n> /sys/firmware/devicetree/base/firmware/coreboot/name\n> /sys/firmware/devicetree/base/firmware/chromeos\n> /sys/firmware/devicetree/base/firmware/chromeos/readonly-firmware-version\n> /sys/firmware/devicetree/base/firmware/chromeos/active-ec-firmware\n> /sys/firmware/devicetree/base/firmware/chromeos/firmware-version\n> /sys/firmware/devicetree/base/firmware/chromeos/nonvolatile-context-storage\n> /sys/firmware/devicetree/base/firmware/chromeos/vboot-shared-data\n> /sys/firmware/devicetree/base/firmware/chromeos/nonvolatile-context-size\n> /sys/firmware/devicetree/base/firmware/chromeos/nonvolatile-context-offset\n> /sys/firmware/devicetree/base/firmware/chromeos/hardware-id\n> /sys/firmware/devicetree/base/firmware/chromeos/compatible\n> /sys/firmware/devicetree/base/firmware/chromeos/firmware-type\n> /sys/firmware/devicetree/base/firmware/chromeos/fmap-offset\n> /sys/firmware/devicetree/base/firmware/chromeos/name\n> /sys/firmware/devicetree/base/firmware/ranges\n> /sys/firmware/devicetree/base/firmware/name\n>\n> The /firmware node has an empty 'ranges', but does not have\n> address/size-cells.\n>\n> Commit 6e5773d52f4a (\"of/address: Fix WARN when attempting translating\n> non-translatable addresses\") started requiring #address-cells for a\n> device's parent if we want to use the reg resource in a device node.\n> This leads to errors like the following:\n>\n> [ 7.763870] coreboot_table firmware:coreboot: probe with driver coreboot_table failed with error -22\n>\n> Add appropriate #{address,size}-cells to work around the problem.\n>\n> Note that Google has also patched the Depthcharge bootloader source to\n> add {address,size}-cells [1], but bootloader updates are typically\n> delivered only via Google OS updates. Not all users install Google\n> software updates, and even if they do, Google may not produce updated\n> binaries for all/older devices.\n>\n> [1] https://lore.kernel.org/all/20241209092809.GA3246424@google.com/\n> https://crrev.com/c/6051580 (\"coreboot: Insert #address-cells and\n> #size-cells for firmware node\")\n>\n> Closes: https://lore.kernel.org/all/aeKlYzTiL0OB1y3g@google.com/\n> Fixes: 6e5773d52f4a (\"of/address: Fix WARN when attempting translating non-translatable addresses\")\n> Signed-off-by: Brian Norris \n\nReviewed-by: Chen-Yu Tsai ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=FOYbthWP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14045-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=\"FOYbthWP\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.208.179","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=chromium.org"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g53v146Qxz1yHX\n\tfor ; Wed, 29 Apr 2026 14:18:05 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 1F7CB3008D50\n\tfor ; Wed, 29 Apr 2026 04:18:01 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D8CC6389104;\n\tWed, 29 Apr 2026 04:17:59 +0000 (UTC)","from mail-lj1-f179.google.com (mail-lj1-f179.google.com\n [209.85.208.179])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9CF37B00A\n\tfor ; Wed, 29 Apr 2026 04:17:55 +0000 (UTC)","by mail-lj1-f179.google.com with SMTP id\n 38308e7fff4ca-38ce0ab821cso103705601fa.0\n for ;\n Tue, 28 Apr 2026 21:17:55 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777436278; cv=pass;\n b=deAHF6yANl/dBisfKJiFnQw1NKt6P99etdmmf5Itnt0yz+ekNE9KTQm5T+WDtynu4/DW6BoKv+JPsIc69UtOZu2GxMDUpRN1XYw/BhfS86xQNPLkiRqGstZxwn1EG88s4mLFaM2VK5HVRLVbuMcMti4WoMGsQx/QY0jINHXvDkI=","i=1; a=rsa-sha256; t=1777436274; cv=none;\n d=google.com; s=arc-20240605;\n b=Uf83pZpWyPk74Yt1kj4na3sA2PZozuW9UDyrjBjZpO4d5GSNJX3LP5WLyIz/Ty8wBb\n MchsZ3qReWfS2tGwOoSTFZutRjkfuZCOSxir6UGAKh/csrYZaVK4atJY472lm8143btb\n ptyITzlM5jIlbvaB8EP/oDbAlSgI0q3BstRhAG3n8ujDlpD1+c8bpTjXrgxPoo0t304A\n DApTSsqcZO7Gb6MbwjqIuQZtez/gSacVVug72rwrjtjuKpBos/2elDp0IdI1uhp4rDVh\n iQOSQSK8UWu8s/Ue8QZp3oCT3Oy6Heb1U8VR7uNqmRd5iE7aKXhFK7QSY4mpOQMmRg4W\n FjdQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777436278; c=relaxed/simple;\n\tbh=AzwVlyIqYxfmPExGHlhzDdBcn2kCaAcRsyV/IiibDeo=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=ULHF5qka6fYSSgSfabzlDUf3zyzKoqDKQ0gKROkwD0meM0kbn0IFM9VyPLegCWo4M7aw7ny129GxhtfuaGxSZMTmzdFkTNBXH2cMrrK46gpKmgNHCXWshjwq7wJ24rWRbiNPXjdB9R0kVUHhIHB4ElGEIx/4ltc2AwRn6901n8A=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=OGT5/UW9QnYnxFplrWMvYfyGjM/y+JrwSoKrwJn5UdU=;\n fh=jvjFQv+hNKpkXC3KwZvzqH8IiF4uYu/bda7++Bmxd7c=;\n b=B+qHwmuy3UHYn3KTfB+KSxgX2locDH4Y+isDGNSYHyMXZReUmIaFt08DD03/PkvRRL\n OSKO8GrvO9Mn+oqn7zr823j2r8ZWiV+GxRvuRz030mKxwuw+3j0AGniF7aFbAZgpAos7\n eWLzbHdZB1zX6D1S7quzoJ+ReGf8iMKTBFpwSdUFKNbCPHqql5EGR0Slf8lNuCLPUvjW\n 4Aax5N/wP9L1XAbelnKW2E8TbTLIwpYjXv0iqC8j/yoDa0k34BwK/+VtBJqG/cVOh/xq\n f1IK8cRONiHV2zTxb9cTr0w5AFCv01qy0156j6/RMD10nD2WFOH5/5JupxpsSEqeuiWJ\n X4dQ==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org;\n spf=pass smtp.mailfrom=chromium.org;\n dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=FOYbthWP; arc=pass smtp.client-ip=209.85.208.179","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777436274; x=1778041074;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=OGT5/UW9QnYnxFplrWMvYfyGjM/y+JrwSoKrwJn5UdU=;\n b=FOYbthWPP8lZx5mA4McOSfJeVR0BRGPHdmtlgr+cFqDyaIit578GgtZp31cw0VznxH\n wKUndv8E0Ym7rLT/XDgblyvzj9usFKBf1rj3kFh+mLXvelnaKsP7iTgtAULRzrmny72b\n FRk3AuvUtX08mGI610FMukA4zPRDmNgO5zMjk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777436274; x=1778041074;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=OGT5/UW9QnYnxFplrWMvYfyGjM/y+JrwSoKrwJn5UdU=;\n b=W2z16GXHpmNb+NZHZmvIQ0o2ADFyPixRXZ7zrfzohOspEO8pt5DcpOa5l0rWciP6rv\n uSJn+owkixMRvO9UI0OEpZTOf7juGWjhuD6h40wvDqkUSSAtb+fuSVzUZ5SJfAr5Hyxj\n /4AE5uUtQXbkdmyziqdGBlQ1dFKTq0FOkQrPQX5tjL8S21oCC7sz91kMQL8GqahoEb1C\n 1EOJwb8p1/HLnA3XrYe0BVjAGVJK7T6Z6L02rKeVvgXfxD8YAUVPdY/fuuLmBZ9smwXk\n /hCmNv7x9x3nLqxzrNkAb9I4fhSreyw+L9yq4aIpIM9ua8L7otVe/ROQxW9HriJr202e\n dlrA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9D5lIoAWUjink3NxmtcZKsA5vQHDzUrVM217OmJ9bQ862d4N3LvbSmWaCjt6YA9UrNaACGWPHotIGkeA==@vger.kernel.org","X-Gm-Message-State":"AOJu0Yxzjhe9bL/1KNq9vnqV6PlnjYfdym8ij3Huw2uXZBR23WCGEita\n\tjQNyELPH3B/5kC3vVU3iUeliNWGXG7JMAchON5FThm5ekuUIUXNzPX6gHtSHtdGwhk2lWbYTBzY\n\tbSPKrYXzWfb59vPLvpyNMk9GcUAoMkaFci8Cw2Llu","X-Gm-Gg":"AeBDietHIFRzWlYMeGZD4wuzK8vtP+HksCkWJM0Td5DXAXiTc1lhgAVVw3nvKq0dFAf\n\ttDGkYEdM0DPlL8mZN19Orf1FOCm2kwuxYTfBwLegq61gtIAf5XKOCqP6L3lg92EmhTk6O7jqo2h\n\tfZruByZPS+NtVkTTbZbQF6gLSGK/KQpjm2Hn1qrO3Q3FxgOHTFGyCDOnaQudI3yJpd61kDfO2uh\n\th4QuQkxPaaq2hHDhjYm5B9GmsUmhWJyb5OwRifjM0T+eHwkTOSsQlaPzzv7bOgGOtw+NzTDp+Oa\n\tFdtS09H9y3bxNb62Cw==","X-Received":"by 2002:a05:6512:3b21:b0:5a7:46f1:d96a with SMTP id\n 2adb3069b0e04-5a749cf6fd8mr890120e87.13.1777436274082; Tue, 28 Apr 2026\n 21:17:54 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260428200712.2660635-1-briannorris@chromium.org>\n <20260428200712.2660635-2-briannorris@chromium.org>","In-Reply-To":"<20260428200712.2660635-2-briannorris@chromium.org>","From":"Chen-Yu Tsai ","Date":"Wed, 29 Apr 2026 13:17:42 +0900","X-Gm-Features":"AVHnY4JKvPmufJ1LEj4mzB6PnqIoSu-1P7-pbmF9YGak1q31h2Rrygv9WVJBRdY","Message-ID":"\n ","Subject":"Re: [PATCH 1/7] arm64: dts: rockchip: Add #{address,size}-cells to\n Chromium-based /firmware","To":"Brian Norris ","Cc":"Rob Herring , Krzysztof Kozlowski ,\n\tConor Dooley ,\n Thierry Reding ,\n\tJonathan Hunter , Heiko Stuebner ,\n\tMatthias Brugger ,\n\tAngeloGioacchino Del Regno ,\n\tBjorn Andersson ,\n Konrad Dybcio ,\n\tdevicetree@vger.kernel.org, Doug Anderson ,\n\tlinux-arm-kernel@lists.infradead.org, Tzung-Bi Shih ,\n\tchrome-platform@lists.linux.dev, linux-rockchip@lists.infradead.org,\n\tJulius Werner , Alim Akhtar ,\n\tcros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org, linux-samsung-soc@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]