[{"id":3683802,"web_url":"http://patchwork.ozlabs.org/comment/3683802/","msgid":"","list_archive_url":null,"date":"2026-04-29T04:17:09","subject":"Re: [PATCH 5/7] arm64: dts: mediatek: Add #{address,size}-cells to\n Chromium-based /firmware","submitter":{"id":81844,"url":"http://patchwork.ozlabs.org/api/people/81844/","name":"Chen-Yu Tsai","email":"wenst@chromium.org"},"content":"On Wed, Apr 29, 2026 at 1:12 PM Brian Norris wrote:\n>\n> Chromium/Depthcharge bootloaders may dynamically add a few device nodes\n> to a system's DTB under a /firmware node. A typical DT looks something\n> like the following:\n>\n> / {\n> firmware {\n> ranges;\n>\n> coreboot {\n> compatible = \"coreboot\";\n> reg = <...>;\n> ...;\n> };\n> };\n> };\n>\n> Notably, the /firmware node has an empty 'ranges', but does not have\n> address/size-cells.\n>\n> Commit 6e5773d52f4a (\"of/address: Fix WARN when attempting translating\n> non-translatable addresses\") started requiring #address-cells for a\n> device's parent if we want to use the reg resource in a device node.\n> This leads to errors like the following:\n>\n> [ 7.763870] coreboot_table firmware:coreboot: probe with driver coreboot_table failed with error -22\n>\n> Add appropriate #{address,size}-cells to work around the problem.\n>\n> Note that Google has also patched the Depthcharge bootloader source to\n> add {address,size}-cells [1], but bootloader updates are typically\n> delivered only via Google OS updates. Not all users install Google\n> software updates, and even if they do, Google may not produce updated\n> binaries for all/older devices.\n>\n> [1] https://lore.kernel.org/all/20241209092809.GA3246424@google.com/\n> https://crrev.com/c/6051580 (\"coreboot: Insert #address-cells and\n> #size-cells for firmware node\")\n>\n> Closes: https://lore.kernel.org/all/aeKlYzTiL0OB1y3g@google.com/\n> Fixes: 6e5773d52f4a (\"of/address: Fix WARN when attempting translating non-translatable addresses\")\n> Signed-off-by: Brian Norris \n\nReviewed-by: Chen-Yu Tsai ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=dvDACpim;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14044-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=\"dvDACpim\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.167.47","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=chromium.org"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g53tH42NMz1yHX\n\tfor ; Wed, 29 Apr 2026 14:17:27 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9F46A3019526\n\tfor ; Wed, 29 Apr 2026 04:17:24 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6D6DC388E6F;\n\tWed, 29 Apr 2026 04:17:24 +0000 (UTC)","from mail-lf1-f47.google.com (mail-lf1-f47.google.com\n [209.85.167.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5950613C918\n\tfor ; Wed, 29 Apr 2026 04:17:22 +0000 (UTC)","by mail-lf1-f47.google.com with SMTP id\n 2adb3069b0e04-5a2c7427ad9so11859953e87.1\n for ;\n Tue, 28 Apr 2026 21:17:22 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777436244; cv=pass;\n b=otlNlhcs3P+lDEbFfVJD2YS3rYGBSGaenhFSiQZNJ3zo3Mo50JQxd20pz1L5N625NI5UPpJOI3BwVX1LtOZerMftsGg71I4ZppopzlgEwugbtFes10OV52GBWhq43kqDSC1sJbbXoViZlrlg8+YCssjJaAcE1dLb9vD1UU1IfyM=","i=1; a=rsa-sha256; t=1777436241; cv=none;\n d=google.com; s=arc-20240605;\n b=dpoLTF0SgI7ZMYnZ5n3RV7Mv9MdxpDtB3ins8y7sF5840B1VP2j2J3ziBIcD5bIbOM\n X0U2UjpNoEblo61aC6lVElSJ70i9One9westpxFrDI/4Dl9vziemJz54RqJws1KF9d5v\n 5+XmiZM9TeecbrQZZ5UmY/XEAe3L4shcWzR87b6KhzAP14FGWrSDofLsqn/0DlOtjV5p\n uR5fqjWMjk5BpOYVp6CMGrxbDjaiJT6e/17eYIlHj2S52FCQuFrS1Wqdg4XcOzYA9q8d\n U8LBR3/50hwxnjlhfNY5kxOszoClJpxy7ey4wmLeCsQTzRjAJd30K6mF86NFl0CoTS53\n 9ImQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777436244; c=relaxed/simple;\n\tbh=ucY3TNrWMvRb0oHVhltYdiDBL03lh8F0+Cv3NgZ1q9E=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=EId41DTECxVnjng3AqYPdMYsa00dd3phJL/SxnMpZ7q2LRQQSoEoveaFk5NxPBmV+HsV1z6Vtaz9nmCFtX1o5xPKot6C2+lGvYmbX4GOLZXIuWpN0OolN1G/0GoFmFMvouB7rTm2/NHzYMVd5Md99jPnrqyPtauzvHSmxn8F6DE=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=S+wgx278PuWohl1935Byl8WX7gkc8WHJmkUS4pGdFI4=;\n fh=su/PcUdZkJ5qmkQyoJscOeKsEq8kvCtYWdr4QlQDy0c=;\n b=Ersw0twd0CkmIOq6xAnu9Q1EhOgAen+brEEMrEWhSYMgUBlwreQzXSWl+VN9uMkWNz\n 4Ej9bjMpWP4p40jE9eM83mmpjmwEEVRw0e8XLWAF0zJbMUr6Qo+2kXPaoJF3NzWcpOjn\n DA3yM6Z41OOkzLyC/JMD7WLrEHdD9h/wE8qza5yTyaZfb0YCUg4nAgzM84DSx95JdxHL\n Q86JJLdQvkvF77RoizpHT3/h9+LmldDxC9Dqva390thX4a610hV6UBtpEOwwykpKoA+r\n YyBeY3XSe8E94kpf/NnOYNaDk3Cf6GVrrJRGG/qA1uglOQr+LraG3B9JPOFHTO4cGNMm\n 3G7g==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=chromium.org;\n spf=pass smtp.mailfrom=chromium.org;\n dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org\n header.b=dvDACpim; arc=pass smtp.client-ip=209.85.167.47","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777436241; x=1778041041;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=S+wgx278PuWohl1935Byl8WX7gkc8WHJmkUS4pGdFI4=;\n b=dvDACpimEfz+lkjDu+p4DjT+fvQBqaJ38nt13vAj6O5Zjc3j5SRV7RVEUyAsHY5zDy\n k7SDY3R2RpdAJvuxg2G9SneYMEVqCzmGkqLfRFIYzTR0vB68T5h0PdGzttJYBLPSjwwp\n zysiSnFZUrxLZPQ4xUk/g5MimDPy32mTPkyA0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777436241; x=1778041041;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=S+wgx278PuWohl1935Byl8WX7gkc8WHJmkUS4pGdFI4=;\n b=mfyq/oiYEViJkdHfrcY3BcE6PqaqnBAxRyesjqLRFx+CnXEEXpbOncvk2C55JbG3Hh\n +yFmGHRe83slP9k1nq1U+cUf5GDR3AiA1jzU/dPbOdzQ1lHCntx+jJwN7WyQkjaGor43\n J8gkrKanJ4NaUliZm4H5j/pG5KD49s7K0SZ+x+duUcziRA7KvJlTSQcJfkB+8mSE/rrv\n jj+L+HdUi4+WPr9p5/h7ddaqyWrusfuQ8kahJB1OWOi7odXa0mYZ70iM/Lz0kxP5N/3M\n NpsoLT8GnKVP6nFsFQ/blZILZ6V3BUjf3PKVHFw58+a+oCyYGHFke/4YDfIBzoyOSAQQ\n GNyQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+Y39HE6phSXyG6jLk9Gut27T+Kv/0uidwJHDBDobQHcsuZrWYyNejgObUXTYau6nLCmcpA/JGS1sTvrw==@vger.kernel.org","X-Gm-Message-State":"AOJu0Yyb23KHmkxvvEoaO7StPjUKwk60EHV6j5w2ZoiSygplTX5XXVVV\n\tPGb+1qfRW7z8nDD4AMtKtLwAHxuWZRVvKuW5ami8hvY34inqfsIUrfW7mJ0fx2gkf7XAzb9Df3K\n\tbLj4MNk/ClBBl3j3now2/KNwaIyqbfhm4f0bbjFyVHUz0rTEIfTeVsw==","X-Gm-Gg":"AeBDiesR3hDkWIxgusicV47rsP0ptqYqSISX56dww8wjiOBX+YGY2UVRk00TBRwk3UX\n\tfyQ9YtpsopQ9jG56N+TLORaPStGSHCa2s6EtOdosIgzrIeTCwI5EIVO/EwYOpJFe1Y1myeRZI+N\n\tSREYG+ml+UB2cUD4GF2E8FE/fokHhIhv9BOA56QQPflNgutdMfpjjU6pC5Cayb0X0qrQufblLwI\n\tMThmyD6uHum0QpsWpTJ1pLQYkhLJHWoagDgJxvxa6rtfXKrwwxWtHUGjSEeuhYho51XAQxOVNZt\n\tfYrgvyCAYvhkFAYAng==","X-Received":"by 2002:a05:6512:3983:b0:5a2:836a:ca47 with SMTP id\n 2adb3069b0e04-5a746623733mr2096698e87.20.1777436240634; Tue, 28 Apr 2026\n 21:17:20 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260428200712.2660635-1-briannorris@chromium.org>\n <20260428200712.2660635-6-briannorris@chromium.org>","In-Reply-To":"<20260428200712.2660635-6-briannorris@chromium.org>","From":"Chen-Yu Tsai ","Date":"Wed, 29 Apr 2026 13:17:09 +0900","X-Gm-Features":"AVHnY4JUF2jGqzImUjvVT0R20VSVC4ANB99NMBVznnvWckelDQ9DcqAgZCUM5q8","Message-ID":"\n ","Subject":"Re: [PATCH 5/7] arm64: dts: mediatek: Add #{address,size}-cells to\n Chromium-based /firmware","To":"Brian Norris ","Cc":"Rob Herring , Krzysztof Kozlowski ,\n\tConor Dooley ,\n Thierry Reding ,\n\tJonathan Hunter , Heiko Stuebner ,\n\tMatthias Brugger ,\n\tAngeloGioacchino Del Regno ,\n\tBjorn Andersson ,\n Konrad Dybcio ,\n\tdevicetree@vger.kernel.org, Doug Anderson ,\n\tlinux-arm-kernel@lists.infradead.org, Tzung-Bi Shih ,\n\tchrome-platform@lists.linux.dev, linux-rockchip@lists.infradead.org,\n\tJulius Werner , Alim Akhtar ,\n\tcros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org, linux-samsung-soc@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]