[{"id":3683583,"web_url":"http://patchwork.ozlabs.org/comment/3683583/","msgid":"<20260428165951.3950-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-28T16:59:51","subject":"Re: [LTP] ima_violations.sh: Wait for ima_mmap to exit","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Petr,\n\nOn Tue, Apr 28, 2026 at 18:10:33 +0200, Petr Vorel wrote:\n> ima_violations.sh: Wait for ima_mmap to exit\n> ima_violations.sh: ima_mmap.c: Replace sleep with checkpoints\n\nBoth patches look good.\n\nReviewed-by: LTP AI Reviewer \n\nPre-existing issues noticed in the surrounding code (not introduced\nby this patch):\n\n- ima_mmap.c:2-8 — no doc comment describing the test; only a copyright block present\n- ima_violations.sh — missing # --- doc and # --- env blocks\n- ima_mmap.c:18-25 — cleanup() does not set file = NULL after SAFE_MUNMAP\n\n---\nNote:\n\nOur agent completed the review of the patch. The full review can be\nfound at: https://github.com/linux-test-project/ltp-agent/actions/runs/25066130804\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=GwknENEF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4mrf1FMWz1yHv\n\tfor ; Wed, 29 Apr 2026 03:00:02 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 206763E5349\n\tfor ; Tue, 28 Apr 2026 19:00:00 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 9B60F3E2D7C\n for ; Tue, 28 Apr 2026 18:59:55 +0200 (CEST)","from mail-qk1-x741.google.com (mail-qk1-x741.google.com\n [IPv6:2607:f8b0:4864:20::741])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 60C0B1400B96\n for ; Tue, 28 Apr 2026 18:59:54 +0200 (CEST)","by mail-qk1-x741.google.com with SMTP id\n af79cd13be357-8ef45a6d9dfso843029285a.0\n for ; Tue, 28 Apr 2026 09:59:54 -0700 (PDT)","from\n runnervmhkfpo.pkiwiyq2oyfulktwfhbrosnyua.bx.internal.cloudapp.net\n ([172.214.44.5]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8f7c53a556esm236789985a.21.2026.04.28.09.59.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 09:59:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777395593; x=1778000393; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tQleimgUpS8ICOkm5f9N+2w7SwgsrrETX6bacE4cDHI=;\n b=GwknENEFfXIdtgyKPGjFAPiWYLa5x4yDOvFjhqNFsgdorCwUwdGzXAvZtwugA22nV1\n xl54sewe7k/NeKg9Eqa78eZzeq/2dVrGN57q5SXD5qJ9RdukIIPcQtFUfXKtIsZK3y03\n doR6XIY1tjCuSW7VvruDKWcOIw4dYAaRwL6CJEq8oZp4NDIsrHxdvo827OuDJxYJ8sIK\n Na1ydtye1fWgcSsoUXSSzWWFAzBj6GwrYIt3yTh2PM1YPDmRZs5H6F75jY3STFR/uw04\n sQrr5BX4eiySKi00eemzTtooPuvoP6HK/MQA7VFsLySyUgeZBaaW39G/p9g9kMqzWN5g\n A4bA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777395593; x=1778000393;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=tQleimgUpS8ICOkm5f9N+2w7SwgsrrETX6bacE4cDHI=;\n b=fRrQmACBiGOcddCWmhEa3mfQN63x/ZQz7qabq1IcVjSY0nuVCo+fflI97Ft8mIBHm2\n 2aUhZ5J1o44Yg+v3RqZ628GkvbhEufaWbGMshyprjrKXRLphyHm0C4uXthVAt5F5ZcMD\n QWYyBAc8fOPdo5SkmE8I/TxceN/veal63wGfjoyXQOPacqH34OqXmue4ltPT23GqGNTJ\n VTutpvnThYfdE/tFA5S5YevRT2DB4uRrJDw091Qiydh06N6tnkmxpZxCpG2yGEJncv8K\n 7Es+bGuByYIbPKOGPkVXyFFHC8jqUWk5hP8gTOw3HdI3UX1+2j3rhpJ5R/LoBSCxs7oB\n UGLw==","X-Gm-Message-State":"AOJu0YzobLxB9sEUL2EWLxaZFT7YFCwjf3oecpZzAJuC96THzCf6+eWG\n kKtg5XMrLMUXPMh5HLDveZH1IMc+fCeVRbxn1ny/EFMd2Cp0JucKY+Yc","X-Gm-Gg":"AeBDievLKzjrun+Li4+YChON6TliTsBFGGlurSbpTiAv/n3EYsgXRpiCZyBX/vmv833\n jGwvSSvr3dU2rDXnDh8S4ijR2Z6+mss/OdsfISOl1arneq+zm9/xVYe1YK9hEX9rBDF8mE5dSEA\n 0cLCI90h+ukg3qdVDMDsj7oswH4gyUYtoGjHwJ841UzgD4vUGpt7La0ZOnG0BGvQMGvJkcs2B/g\n 1FT5eFiSiuWZqM0AtBXWE3ThMd1fmKgsa49miE+/SSxxAnkCcQ7e03qAVr12Gw7kJGdB1SgCwLX\n l0uno0SbmoErSZq7gUbkfOj/W9rTfVebQMXlfS9aSjsw3e94wSD4bug7xaGoUPcIgU7D9ieitnN\n RbpDtJVhIFueWtOI5YDiuNmNwnBIud++sbn4cWSGWEnkgagJ1h6hgjQS24k6D1tglcaEf37RJ9d\n H2smzitO2dcRLV06h1c/nMKR2Of74DkBsNAAQNBnEgP93Ch2TS5lSnEuiXDwnxmN4M4utz/ciOs\n ORpjpvJFeij0PegufDwTJo+o1cvzD8xOh+knQ6aEIKatNPN","X-Received":"by 2002:a05:620a:2850:b0:8f8:5905:8291 with SMTP id\n af79cd13be357-8f8590588cfmr311762385a.47.1777395592874;\n Tue, 28 Apr 2026 09:59:52 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Petr Vorel ","Date":"Tue, 28 Apr 2026 16:59:51 +0000","Message-ID":"<20260428165951.3950-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260428161034.947614-1-pvorel@suse.cz>","References":"<20260428161034.947614-1-pvorel@suse.cz>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] ima_violations.sh: Wait for ima_mmap to exit","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it, LTP AI Reviewer ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3684546,"web_url":"http://patchwork.ozlabs.org/comment/3684546/","msgid":"","list_archive_url":null,"date":"2026-04-30T09:03:15","subject":"Re: [LTP] [PATCH 1/2] ima_violations.sh: Wait for ima_mmap to exit","submitter":{"id":8530,"url":"http://patchwork.ozlabs.org/api/people/8530/","name":"Cyril Hrubis","email":"chrubis@suse.cz"},"content":"Hi!\n> test3()\n> {\n> +\tlocal pid\n> +\n> \ttst_res TINFO \"verify open_writers using mmapped files\"\n> \n> \tlocal search=\"open_writers\"\n> @@ -168,6 +170,7 @@ test3()\n> \techo 'testing testing' > $FILE\n> \n> \tima_mmap -f $FILE &\n> +\tpid=$!\n> \t# wait for violations appear in logs\n> \ttst_sleep 1s\n> \n> @@ -177,7 +180,10 @@ test3()\n> \tvalidate $num_violations $count $search\n> \n> \t# wait for ima_mmap to exit, so we can umount\n> -\ttst_sleep 2s\n> +\twait $pid\n\nYou can simplify this just by doing 'wait' that will wait for all\nbackground jobs (we have only one here).\n\nEither way:\n\nReviewed-by: Cyril Hrubis \n\n> +\tif [ $? -ne 0 ]; then\n> +\t\ttst_brk TBROK \"failed to execute ima_mmap\"\n> +\tfi\n> }\n> \n> test4()\n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=yVwMzFIh;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=O3/C3SEe;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=g7XGpBs7;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=RP8m4pIj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=g7XGpBs7;\n dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=RP8m4pIj"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5p9s4jJfz1yHZ\n\tfor ; Thu, 30 Apr 2026 19:03:29 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id D162C3E659D\n\tfor ; Thu, 30 Apr 2026 11:03:26 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 932683E2628\n for ; Thu, 30 Apr 2026 11:03:23 +0200 (CEST)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id D399A200B62\n for ; Thu, 30 Apr 2026 11:03:22 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id BC9616A7CD;\n Thu, 30 Apr 2026 09:03:18 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AB02C593B0;\n Thu, 30 Apr 2026 09:03:18 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id 4tD5J9Ya82lmKQAAD6G6ig\n (envelope-from ); Thu, 30 Apr 2026 09:03:18 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777539802;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=wuWeK+49G8+gltjgEPrQvgzUIRCbjLPmBVFt1uvHX0U=;\n b=yVwMzFIhX0Ow1kF6JjM60N1k5m2YM670YIKKyIcZxCTPVOaZ8CObLYr/KQ/0QJBntF1yV5\n uXaE2VHzdLHnAAUMwfbd9kFw4v2aA09XKFhzdJEyCEOF/YNfyYvzjum16hkuVjdv/jWlRG\n 42+2QxL0g94kZ7AicepDS8vlZ+gGnIw=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777539802;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=wuWeK+49G8+gltjgEPrQvgzUIRCbjLPmBVFt1uvHX0U=;\n b=O3/C3SEeLJgaGO5xh12XADFX1ijvd9C9J82gw28bNPrRKTXqzHAiLfDLwuOB4+2ycJ97wS\n j8Ua1wYuG6tiXLBA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1777539798;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=wuWeK+49G8+gltjgEPrQvgzUIRCbjLPmBVFt1uvHX0U=;\n b=g7XGpBs7JMOvXquiahV237RjXaZqDaPKS+dbINuH10LQ1RcN884g6b7QVIxeABoZ51+Xil\n XH0qZMzzgsD+iFlwQS3rwlXHbaFwgT2XUkFtwuaTbvlSonncIiOn2ETnZpCxkQeOWzh8Sh\n ekI1xWD79mAi8G0Z04lMGWHLpIPzAK4=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1777539798;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=wuWeK+49G8+gltjgEPrQvgzUIRCbjLPmBVFt1uvHX0U=;\n b=RP8m4pIjkUcWQHOYC+6dbUgXlo3IcP30HBwPf3+NkFUvI6DDxXidQ7ee2/FXSqmMvQlg8x\n 1lV4O+Syu9Yb2WDA=="],"Date":"Thu, 30 Apr 2026 11:03:15 +0200","From":"Cyril Hrubis ","To":"Petr Vorel ","Message-ID":"","References":"<20260428161034.947614-1-pvorel@suse.cz>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260428161034.947614-1-pvorel@suse.cz>","X-Spamd-Result":"default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[];\n MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[];\n TO_DN_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7];\n RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n DKIM_TRACE(0.00)[suse.cz:+]","X-Rspamd-Action":"no action","X-Spam-Score":"-4.51","X-Spam-Level":"","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"BC9616A7CD","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 1/2] ima_violations.sh: Wait for ima_mmap to exit","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"linux-integrity@vger.kernel.org, ltp@lists.linux.it","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]