[{"id":3683912,"web_url":"http://patchwork.ozlabs.org/comment/3683912/","msgid":"","list_archive_url":null,"date":"2026-04-29T08:45:03","subject":"Re: [PATCH] mips: select legacy gpiolib interfaces where used","submitter":{"id":92191,"url":"http://patchwork.ozlabs.org/api/people/92191/","name":"Bartosz Golaszewski","email":"brgl@kernel.org"},"content":"On Tue, 28 Apr 2026 17:56:19 +0200, Arnd Bergmann said:\n> From: Arnd Bergmann \n>\n> A few old machines have not been converted away from the old-style\n> gpiolib interfaces. Make these select the new CONFIG_GPIOLIB_LEGACY\n> symbol so the code still works where it is needed but can be left\n> out otherwise.\n>\n> This is the list of all gpio_request() calls in mips:\n>\n> arch/mips/alchemy/devboards/db1000.c: gpio_request(19, \"sd0_cd\");\n> arch/mips/alchemy/devboards/db1000.c: gpio_request(20, \"sd1_cd\");\n> arch/mips/alchemy/devboards/db1200.c: gpio_request(215, \"otg-vbus\");\n> arch/mips/bcm47xx/workarounds.c: err = gpio_request_one(usb_power, GPIOF_OUT_INIT_HIGH, \"usb_power\");\n> arch/mips/bcm63xx/boards/board_bcm963xx.c: gpio_request_one(board.ephy_reset_gpio,\n> arch/mips/txx9/rbtx4927/setup.c: gpio_request(15, \"sio-dtr\");\n>\n> Most of these should be easy enough to change to modern gpio descriptors\n> or remove if they are no longer in use.\n>\n> Signed-off-by: Arnd Bergmann \n> ---\n\nReviewed-by: Bartosz Golaszewski ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=UboxyE7O;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35781-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"UboxyE7O\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g59qW50PCz1yHX\n\tfor ; Wed, 29 Apr 2026 18:45:27 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C79ED303C003\n\tfor ; Wed, 29 Apr 2026 08:45:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4208E3B0ADD;\n\tWed, 29 Apr 2026 08:45:07 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 01DB63B9601\n\tfor ; Wed, 29 Apr 2026 08:45:06 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id AC192C2BCF4\n\tfor ; Wed, 29 Apr 2026 08:45:06 +0000 (UTC)","by mail-lf1-f42.google.com with SMTP id\n 2adb3069b0e04-5a337552604so11489226e87.2\n for ;\n Wed, 29 Apr 2026 01:45:06 -0700 (PDT)","from 969154062570 named unknown by gmailapi.google.com with\n HTTPREST; Wed, 29 Apr 2026 08:45:03 +0000","from 969154062570 named unknown by gmailapi.google.com with\n HTTPREST; Wed, 29 Apr 2026 08:45:03 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777452307; cv=none;\n b=NnGbjIrEGQF+GrBsiCBYhu88QVVFOHfX1r2Ww3nD9Dtah621eUEfH/dfPyq5ixEkcqbJGezNh06g2mIVNlAfKp4S+9ElfEW+uVCFvjZZs5aUt35huBVmr9TmjUcrgeqcmisEK1y9YIEEJDUm3owCIowrCIUIdJrLv/MkmSx4Caw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777452307; c=relaxed/simple;\n\tbh=AG2CfndSRmEyHhUxf+LTkGJV4s0YhLuGqKWpvvo80NI=;\n\th=From:In-Reply-To:MIME-Version:References:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=P7e8bD1btuSUrdzNNZJ7zRUfKM8RL20TPOxCepNKT1nN0bJRgbi1Vca9zCjJOVRuRiCuPkXl/DD2nxoBUSU3LPD4+OoEyaB0Xl6j1492oq4CdwHKAzrsybqznO4MX0WZ03zkVWp/112RAoh7eOqXHX6u5a5oDvRfD+JSgJCh4Xs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=UboxyE7O; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777452306;\n\tbh=AG2CfndSRmEyHhUxf+LTkGJV4s0YhLuGqKWpvvo80NI=;\n\th=From:In-Reply-To:References:Date:Subject:To:Cc:From;\n\tb=UboxyE7OzK4NW20A3R7NaOTWhFB537xNRC0P6AVcCYUBgiJtZ7FMZ7AgsGS8fkvOr\n\t kIytbjOBk2m3SZTnuhK1eUanr7JjvyPjX64fRmZFXDqks7XEplXjNcPrYwhagiF7dm\n\t 3ScrYeGIbaG9UGDrFGI0wF4jP3ZS/Gt2/kt8ld8Hknfg6J+btT5zYd0X+btu4ZHq6M\n\t pdftzFNBX+uErIIpytzTUkXD6OxW34evqkoQIr77lO2qHa92NQ7Kgaztve7LTuEI+C\n\t 95qr0ciRB2Mqvyx9DW+uAHeaeje5l4IvjJLKAhtRWFmIOwzArTpp1QtL1sVtjjSWvd\n\t Ofgaj6NBr37cg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ95/YZ+cps3YL5RTmvvFpy0Z2219C/zuAKKYNv0UzAm61gBnaP3r3vxQQ7JWcqHDyFgN0H7+Q7ld3nG@vger.kernel.org","X-Gm-Message-State":"AOJu0YzovYKnFlldqNQBMdxkrwXHGaBYEvh/cmLBpHU8KbP8Pb/SWE3C\n\tXA0vnqbXGQNgIYOz/oitGaXBZHbecq8t3Nz8ISjtdF6Og+uO9dNrQjE39DsvwPCb4Xpl1tfDQWu\n\twhmbDo+6M1vC6ymbV+TC+Zj9xBOR8gAYZBgM/jRZ3Og==","X-Received":"by 2002:a05:6512:6d6:b0:5a2:afbe:4aaf with SMTP id\n 2adb3069b0e04-5a749d16a22mr1008681e87.21.1777452305304; Wed, 29 Apr 2026\n 01:45:05 -0700 (PDT)","From":"Bartosz Golaszewski ","In-Reply-To":"<20260428155651.3252500-1-arnd@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260428155651.3252500-1-arnd@kernel.org>","Date":"Wed, 29 Apr 2026 08:45:03 +0000","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AVHnY4K1cbFZX_UqU9MbAACS7R1pQ0IJ0CRy7--CuSoLDUfZDeX5U1g4d3_vtCg","Message-ID":"\n ","Subject":"Re: [PATCH] mips: select legacy gpiolib interfaces where used","To":"Arnd Bergmann ","Cc":"Arnd Bergmann , Thomas Gleixner ,\n linux-mips@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,\n\tThomas Bogendoerfer ,\n Linus Walleij ,\n\tBartosz Golaszewski ","Content-Type":"text/plain; charset=\"UTF-8\""}}]