[{"id":3683553,"web_url":"http://patchwork.ozlabs.org/comment/3683553/","msgid":"<afDX7WabVPVce4kc@ashevche-desk.local>","list_archive_url":null,"date":"2026-04-28T15:53:17","subject":"Re: [PATCH] gpiolib: move legacy interface into linux/gpio/legacy.h","submitter":{"id":8583,"url":"http://patchwork.ozlabs.org/api/people/8583/","name":"Andy Shevchenko","email":"andriy.shevchenko@linux.intel.com"},"content":"On Tue, Apr 28, 2026 at 05:45:07PM +0200, Arnd Bergmann wrote:\n\n> Split the old contents from gpio.h for clarity. Ideally any driver\n> that still includes linux/gpio.h can now be ported over to use\n> either linux/gpio/legacy.h or linux/gpio/consumer.h, with the\n> original file getting removed once that is complete.\n> \n> No functional changes intended for now.\n\nBut I'm not sure why. The idea to kill gpio.h completely, no need to keep it\nlonger than legacy stuff exists. I don't take 'clarity' as a good justification\nhere, since the old header are still there (however just a shallow wrapper).","headers":{"Return-Path":"\n <linux-gpio+bounces-35714-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Hi9K4462;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35714-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"Hi9K4462\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.175.65.18","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4lPR0M3Bz1xrS\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 01:54:50 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 0C24830BA926\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 15:53:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BA4F73C3C03;\n\tTue, 28 Apr 2026 15:53:24 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.18])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 40A7B125AA;\n\tTue, 28 Apr 2026 15:53:22 +0000 (UTC)","from fmviesa002.fm.intel.com ([10.60.135.142])\n  by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 08:53:22 -0700","from kniemiec-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.244.213])\n  by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 08:53:19 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777391604; cv=none;\n b=MnzKFj2js0J/IqJmJQpV6yg0ZdTwtdSl2OuyXCekrYwhK/9J17iU8tYwt2g7xgnyBG2iyJL1j4UcLpZszQ6XnLQP9/up1vdoex0YCtgCPtSVwzDzCG+cAzaKuD1ZNz5SbQ3NfXi3corAPLpkG7Arl/kcxRYdcDXDiQbWNv352Dw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777391604; c=relaxed/simple;\n\tbh=JMt8H9iAMk6x8ihJgGd8qy1rGIfkjZMj9pTiUslgLfk=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=WaeNI9wz+31rzMb6B++tnzEURa7juWxyZwqc66LhexpxFeZ5lRQtNBOw4x2FYdYYCfawddUQsOv5nNNeXTJ8cMaJQtYVqBfIlyY+IMjPw8ernEe4jziM7JJimt/WDhmwDz5oRLCOxNgQ+YJgue0ORWp1MJUZ5Y5YL4e3eZD5+kI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=Hi9K4462; arc=none smtp.client-ip=198.175.65.18","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n  t=1777391603; x=1808927603;\n  h=date:from:to:cc:subject:message-id:references:\n   mime-version:in-reply-to;\n  bh=JMt8H9iAMk6x8ihJgGd8qy1rGIfkjZMj9pTiUslgLfk=;\n  b=Hi9K4462NVgg9lmwSu5qKlBe7CrzbmDEvu0ICtTfHSDkAvu2vHhQlGoB\n   uchyuKujG5ZCoT3PCcEKUOm+UmFXez2hnuWFVhnu18JMVTmYVvaJ2DAeT\n   VN921lXGMb8IFo49HkrgRIW0ZuvcZLZ/ZnPKd0ZbF618oU9PROipJnWqC\n   QPxgqOvv4qnK++NFm9YllrXOyasuijljCV9bk9jaRgmLRKlczAIJPaFiO\n   Ctuyn7Yj+CtkS16VbwShKq4PG/SyBgoL7Q1HT0/e/5fGkXU8OJ96bLar9\n   7wgIqGen5KtY1l5OMn1Rj7wWHb2UF+GQifqAVFm2MtXISu8M2w4mqxNG7\n   g==;","X-CSE-ConnectionGUID":["RlIHUVHjTfOmuFrE2lto2Q==","bblyab2ZRMSKiRwhs3bZkA=="],"X-CSE-MsgGUID":["kjDuego6R4CSYEqJJX0IDg==","kg7dTy14Q0iA8y8QJSZlNw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11770\"; a=\"78323095\"","E=Sophos;i=\"6.23,204,1770624000\";\n   d=\"scan'208\";a=\"78323095\"","E=Sophos;i=\"6.23,204,1770624000\";\n   d=\"scan'208\";a=\"257309931\""],"X-ExtLoop1":"1","Date":"Tue, 28 Apr 2026 18:53:17 +0300","From":"Andy Shevchenko <andriy.shevchenko@linux.intel.com>","To":"Arnd Bergmann <arnd@kernel.org>","Cc":"Linus Walleij <linusw@kernel.org>,\n\tBartosz Golaszewski <brgl@kernel.org>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tAlexander Sverdlin <alexander.sverdlin@gmail.com>,\n\tlinux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org","Subject":"Re: [PATCH] gpiolib: move legacy interface into linux/gpio/legacy.h","Message-ID":"<afDX7WabVPVce4kc@ashevche-desk.local>","References":"<20260428154522.2861492-1-arnd@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260428154522.2861492-1-arnd@kernel.org>","Organization":"Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6\n krs, Bertel Jungin Aukio 5, 02600 Espoo"}},{"id":3683568,"web_url":"http://patchwork.ozlabs.org/comment/3683568/","msgid":"<16e058af-dfa9-43b1-be6e-47150d6c7cb0@app.fastmail.com>","list_archive_url":null,"date":"2026-04-28T16:17:32","subject":"Re: [PATCH] gpiolib: move legacy interface into linux/gpio/legacy.h","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/","name":"Arnd Bergmann","email":"arnd@arndb.de"},"content":"On Tue, Apr 28, 2026, at 17:53, Andy Shevchenko wrote:\n> On Tue, Apr 28, 2026 at 05:45:07PM +0200, Arnd Bergmann wrote:\n>\n>> Split the old contents from gpio.h for clarity. Ideally any driver\n>> that still includes linux/gpio.h can now be ported over to use\n>> either linux/gpio/legacy.h or linux/gpio/consumer.h, with the\n>> original file getting removed once that is complete.\n>> \n>> No functional changes intended for now.\n>\n> But I'm not sure why. The idea to kill gpio.h completely, no need to keep it\n> longer than legacy stuff exists. I don't take 'clarity' as a good justification\n> here, since the old header are still there (however just a shallow wrapper).\n\nI currently count 59 files that use the legacy header,\nand I have a patch to change those over to include it\ndirectly. I could post it now, but the exact list seems to\nbe changing by the day at the moment. It may be better\nto split it up by subsystem once the first patch is merged,\nor it could go through the gpio tree.\n\nThere are another 94 uses of linux/gpio.h that should\nbe linux/gpio/consumer.h instead. That patch is of course\ntrivial as well, but I have not prepared it yet.\n\nI don't think the legacy stuff is going away any time soon,\nso removing it from linux/gpio.h with the follow-up patch\nshould help avoid new instances getting merged unnoticed.\n\n    Arnd","headers":{"Return-Path":"\n <linux-gpio+bounces-35721-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256\n header.s=fm2 header.b=jAXDlAmA;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=messagingengine.com header.i=@messagingengine.com\n header.a=rsa-sha256 header.s=fm2 header.b=b3PlFL7W;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35721-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de\n header.b=\"jAXDlAmA\";\n\tdkim=pass (2048-bit key) header.d=messagingengine.com\n header.i=@messagingengine.com header.b=\"b3PlFL7W\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=103.168.172.145","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=arndb.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=arndb.de"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4mHT1ZdZz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 02:34:45 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id E814830DBDD3\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 16:22:21 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2053932D0D8;\n\tTue, 28 Apr 2026 16:17:56 +0000 (UTC)","from fout-a2-smtp.messagingengine.com\n (fout-a2-smtp.messagingengine.com [103.168.172.145])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DABC32936C;\n\tTue, 28 Apr 2026 16:17:53 +0000 (UTC)","from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44])\n\tby mailfout.phl.internal (Postfix) with ESMTP id 3A946EC00C8;\n\tTue, 28 Apr 2026 12:17:53 -0400 (EDT)","from phl-imap-02 ([10.202.2.81])\n  by phl-compute-04.internal (MEProxy); Tue, 28 Apr 2026 12:17:53 -0400","by mailuser.phl.internal (Postfix, from userid 501)\n\tid F08AE70006A; Tue, 28 Apr 2026 12:17:52 -0400 (EDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777393075; cv=none;\n b=fiEMrcJgjtIQyZWsbbHEOPYPoXuXMRdMiF887zvp7mirOB1RTrHJJ2seJCQQ+LSkL34bxHpRtZmpcNSsuNDrG/bB4lSLLd1MN5Rj+p3Lw7HOuUjL9nM7zxnB4WXnDoDDlMXnebVrj+b6Cd1TjPEaRq56EaVUavb+l8+Wpppo+ZU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777393075; c=relaxed/simple;\n\tbh=ilZ3ic4NHx2Z51nghgD7/27zpBjZpxCwNAbERIJ9038=;\n\th=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References:\n\t Subject:Content-Type;\n b=ZCrqsqoFHs8W9niplsGe5BKJ47qyzanCJg2ENA2aJ00eDkg1bkM/KzpOZth7ax0Sf2GxCpKBtt9IHPWbZLafph4dC/j/Ym0CZ+cvbK7YboM/CqGp8XSSOHem7/D9j27N4wc+aYv275S8gItkdS2n21qEomRTyB36ivhFL2ZuqJY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=arndb.de;\n spf=pass smtp.mailfrom=arndb.de;\n dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de\n header.b=jAXDlAmA;\n dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com\n header.b=b3PlFL7W; arc=none smtp.client-ip=103.168.172.145","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc\n\t:cc:content-transfer-encoding:content-type:content-type:date\n\t:date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm2; t=1777393073;\n\t x=1777479473; bh=NOtq5+rfTdtcUV80Tb+r5KplcBOzRSAAUcR5coq1YGo=; b=\n\tjAXDlAmARmS4ZiywfRUCVIoUU59sm8EKh/PsH1DWXThE+Ix9YYPBhz1YQebw9h5n\n\t+0qfhzbU8GbcZaJIZWxcBoR42osdClRLFH6bjd3Q602DUDdM3g3DNqaMdchaO/F5\n\t1B/LqTs4uz+7y/antJKGPxfHFspH1L01Yb5GK+Zdn/h75TWoYqLfEv6dNXvS88Wi\n\tCmoHanlGvWt/OyZxX1e8mar6CihCUdpTUciKDXM2LWqYhU54hPQ+q/ntObLrfqpO\n\tU3saJSKdZSOenA2jods3nIH7HVLUMHuxd2RT0g0xiCKa8Q0yKRY82If/2E7wKV9G\n\tmkYB5sWtbyxezi9S7CiJVw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1777393073; x=\n\t1777479473; bh=NOtq5+rfTdtcUV80Tb+r5KplcBOzRSAAUcR5coq1YGo=; b=b\n\t3PlFL7W3uwkCp2pMbXtmFgsSdV0RAsBm+kZjWmxHfBWCXdoxq4UWBn9SEB2VFXsV\n\tnUc4/enZV0MGoH+GHmcgEdQQcabQgJl7oQaQ6AFzcHqXO2gg3hT/ApTaX273Ysnl\n\tng2SIDmYWLGCzb/R3xWk66j/+XJXDckohHkMkGExDwpoh7IpRTmi7n1ySQjjrx7p\n\tUFrTkH8MbKZ/7vEHpm9HBjiR6wtSPo1Deb+k6PpEiN9KEWKP2tLHNiqFSFtLBHpe\n\tk59T81d3pva4Q+NNxmVwWvh14aJP9kqBxNfpdyljhu/0o7DNZuDHGF6Of0tsPEwb\n\tQpi11IK3fIr22j5FlywVA=="],"X-ME-Sender":"<xms:sd3waaBsNC7_sIahudsWB-QA_st5tCYQnUWvWTPQ-RQYDNWADUMgsQ>\n    <xme:sd3wafXT-ITxQpPbEIB0zHwAM_tQiFMlhR3_DPiUxatEIIqFCz9FDBm8oI__gzMfC\n    a8Y9viwc79ifaka2jnqS5YK-SbaFBFcPCjyVdmHVTKim7rJqhfQRhoi>","X-ME-Proxy-Cause":"\n gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdekvddtvdcutefuodetggdotefrod\n    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr\n    ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug\n    hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhhnugcu\n    uegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtthgvrh\n    hnpefhtdfhvddtfeehudekteeggffghfejgeegteefgffgvedugeduveelvdekhfdvieen\n    ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnug\n    esrghrnhgusgdruggvpdhnsggprhgtphhtthhopeejpdhmohguvgepshhmthhpohhuthdp\n    rhgtphhtthhopegrlhgvgigrnhguvghrrdhsvhgvrhgulhhinhesghhmrghilhdrtghomh\n    dprhgtphhtthhopegrrhhnugeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepsghrghhl\n    sehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhhsfieskhgvrhhnvghlrdhorh\n    hgpdhrtghpthhtoheprghnughrihihrdhshhgvvhgthhgvnhhkoheslhhinhhugidrihhn\n    thgvlhdrtghomhdprhgtphhtthhopehlihhnuhigqdhgphhiohesvhhgvghrrdhkvghrnh\n    gvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghr\n    nhgvlhdrohhrgh","X-ME-Proxy":"<xmx:sd3wacG6IeebUcBwuJ_yJH7qlqW8s0AtJKWIiAsBcCgyveJuKbh6GQ>\n    <xmx:sd3waUbles3mGsmKXk-WOujVQqdKIYTxypjv1m7nos2GfBHRgJgpTA>\n    <xmx:sd3wacVAZYuUafN4ys1KAuGEHU-oRq0d69ainiaLrpB61uJ_heSq8A>\n    <xmx:sd3waamv0lJgFy-S0SNTwvGstrLUmF51dFYN5l8fEMmqphCdKf391w>\n    <xmx:sd3waW1Yzsz3beVHm0vLs6oi6Rg1sVtG6zJ8hjxIpLrW-qxt8g1tKOMM>","Feedback-ID":"i56a14606:Fastmail","X-Mailer":"MessagingEngine.com Webmail Interface","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","X-ThreadId":"AWBZ1R5XxVsg","Date":"Tue, 28 Apr 2026 18:17:32 +0200","From":"\"Arnd Bergmann\" <arnd@arndb.de>","To":"\"Andy Shevchenko\" <andriy.shevchenko@linux.intel.com>,\n \"Arnd Bergmann\" <arnd@kernel.org>","Cc":"\"Linus Walleij\" <linusw@kernel.org>,\n \"Bartosz Golaszewski\" <brgl@kernel.org>,\n \"Alexander Sverdlin\" <alexander.sverdlin@gmail.com>,\n linux-kernel@vger.kernel.org,\n \"open list:GPIO SUBSYSTEM\" <linux-gpio@vger.kernel.org>","Message-Id":"<16e058af-dfa9-43b1-be6e-47150d6c7cb0@app.fastmail.com>","In-Reply-To":"<afDX7WabVPVce4kc@ashevche-desk.local>","References":"<20260428154522.2861492-1-arnd@kernel.org>\n <afDX7WabVPVce4kc@ashevche-desk.local>","Subject":"Re: [PATCH] gpiolib: move legacy interface into linux/gpio/legacy.h","Content-Type":"text/plain","Content-Transfer-Encoding":"7bit"}},{"id":3683919,"web_url":"http://patchwork.ozlabs.org/comment/3683919/","msgid":"<CAMRc=Md6koMNyW6hqRZmNshwx8nqz1M+W8vHPC9evMzkCMdReg@mail.gmail.com>","list_archive_url":null,"date":"2026-04-29T08:48:52","subject":"Re: [PATCH] gpiolib: move legacy interface into linux/gpio/legacy.h","submitter":{"id":92191,"url":"http://patchwork.ozlabs.org/api/people/92191/","name":"Bartosz Golaszewski","email":"brgl@kernel.org"},"content":"On Tue, Apr 28, 2026 at 6:17 PM Arnd Bergmann <arnd@arndb.de> wrote:\n>\n> On Tue, Apr 28, 2026, at 17:53, Andy Shevchenko wrote:\n> > On Tue, Apr 28, 2026 at 05:45:07PM +0200, Arnd Bergmann wrote:\n> >\n> >> Split the old contents from gpio.h for clarity. Ideally any driver\n> >> that still includes linux/gpio.h can now be ported over to use\n> >> either linux/gpio/legacy.h or linux/gpio/consumer.h, with the\n> >> original file getting removed once that is complete.\n> >>\n> >> No functional changes intended for now.\n> >\n> > But I'm not sure why. The idea to kill gpio.h completely, no need to keep it\n> > longer than legacy stuff exists. I don't take 'clarity' as a good justification\n> > here, since the old header are still there (however just a shallow wrapper).\n>\n> I currently count 59 files that use the legacy header,\n> and I have a patch to change those over to include it\n> directly. I could post it now, but the exact list seems to\n> be changing by the day at the moment. It may be better\n> to split it up by subsystem once the first patch is merged,\n> or it could go through the gpio tree.\n>\n> There are another 94 uses of linux/gpio.h that should\n> be linux/gpio/consumer.h instead. That patch is of course\n> trivial as well, but I have not prepared it yet.\n>\n> I don't think the legacy stuff is going away any time soon,\n> so removing it from linux/gpio.h with the follow-up patch\n> should help avoid new instances getting merged unnoticed.\n>\n\nTrue and if anything - it at least spells out loud that this is a\n\"legacy\" header, which gpio.h does not.\n\nBart","headers":{"Return-Path":"\n <linux-gpio+bounces-35782-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Kaj/8o+2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35782-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Kaj/8o+2\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g59vs0PSmz1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 18:49:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 0909D300C3BD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 08:49:11 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 56441194AE6;\n\tWed, 29 Apr 2026 08:49:09 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CFA5D3B47CD\n\tfor <linux-gpio@vger.kernel.org>; Wed, 29 Apr 2026 08:49:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 48ED0C2BCB3\n\tfor <linux-gpio@vger.kernel.org>; Wed, 29 Apr 2026 08:49:08 +0000 (UTC)","by mail-lf1-f45.google.com with SMTP id\n 2adb3069b0e04-5a10d130b37so665640e87.0\n        for <linux-gpio@vger.kernel.org>;\n Wed, 29 Apr 2026 01:49:08 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777452548; cv=none;\n b=qZwE7OTzqK7uplo1ge7f83f0Tt/derN/+hBlRrUSjCaC78RwHTqm0W+nmkR3dS4c4bqP30Lu4glj10+xD1Z3YArjMg1HFqFUoVSoc2PV1YGb+TrRbyqhilysfK5vca5pxuqCOjE5M6JaXfxNTI5mlB1wbYUco2izgU3eziJciIM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777452548; c=relaxed/simple;\n\tbh=jvcSwXq2vhwFctE+5eqsyXmsdw/EOJobTuUWj7ocm1w=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=c1X7AwptbQZ0Qbz2JtjMadwHmkky/tv87Rioq6TY+McqSlE6q78mXib5goOq6wPLQaMy8L1XHqOrz+oqoKcpmhhvsEQCFKSPINMPDIR41sk0SD496vRBMuxS9XjV2NdVwY2KqAqYIbcSJZWr4uiJDs/mPY+sIzhB8eP1duIPai4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Kaj/8o+2; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777452548;\n\tbh=jvcSwXq2vhwFctE+5eqsyXmsdw/EOJobTuUWj7ocm1w=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=Kaj/8o+277I9YGZDii1WQVv9X2dOLGKWK1T5LeJOQRPbeYnwj23U3gCLRy3cWnXnA\n\t m9UQ4x2vWZQExRyFjiws/VGu1J7Q1snEMSNtdXg2TU7D3O5CBbbinHnVJw4F0sw5Oj\n\t yRfF86IE4JVBO/nvhWsRRUJreNtq0whl7HMoWfb2Jl0YdQury8g3ozcWn4zkkOs6w+\n\t gFw46A3ctcCuIrrAMWuLgRlqRBbQq7d8U2EjKCA3RUTAqkqMOwx70dqLOR+kVQoXYG\n\t 1GqlXAGASG5Ez7/70g4jJtPCXQWEBVHUpwNfjXMLJsNEYwY+q5C7x5MfLylVDzjW6u\n\t q5NJcC0MD4X5A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9y4u4qV0TBum3AT/LLTrHiKKQoanIWuZZS8PHlDTE1+aptDjjYmio8gpDnBdPfIw+M0r14IEaBSXdo@vger.kernel.org","X-Gm-Message-State":"AOJu0YzcTwnl2THeQSymojGiAjcDOzul+MjStmf9wUaFdOaAi8u01dTQ\n\tJJymsAI/qVkGJXXyn8+Kr5ptq362YFT3yGvgkf+j/mxnXAAHugQOba/Uyw2bF+rMyRSy5q/FVrZ\n\tSxQtc01gwekpKLjCqJwbGyR4i/VjdSGbE8f+JEcjLBw==","X-Received":"by 2002:a05:6512:2385:b0:5a2:b259:5569 with SMTP id\n 2adb3069b0e04-5a74a352322mr725809e87.15.1777452544811; Wed, 29 Apr 2026\n 01:49:04 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","References":"<20260428154522.2861492-1-arnd@kernel.org>\n <afDX7WabVPVce4kc@ashevche-desk.local>\n <16e058af-dfa9-43b1-be6e-47150d6c7cb0@app.fastmail.com>","In-Reply-To":"<16e058af-dfa9-43b1-be6e-47150d6c7cb0@app.fastmail.com>","From":"Bartosz Golaszewski <brgl@kernel.org>","Date":"Wed, 29 Apr 2026 10:48:52 +0200","X-Gmail-Original-Message-ID":"\n <CAMRc=Md6koMNyW6hqRZmNshwx8nqz1M+W8vHPC9evMzkCMdReg@mail.gmail.com>","X-Gm-Features":"AVHnY4KTzMwsOKfDbL28IoJzkYMkw57uohqFCHTnjbnU47St7nLbwJf2a0MH-XM","Message-ID":"\n <CAMRc=Md6koMNyW6hqRZmNshwx8nqz1M+W8vHPC9evMzkCMdReg@mail.gmail.com>","Subject":"Re: [PATCH] gpiolib: move legacy interface into linux/gpio/legacy.h","To":"Arnd Bergmann <arnd@arndb.de>","Cc":"Andy Shevchenko <andriy.shevchenko@linux.intel.com>,\n Arnd Bergmann <arnd@kernel.org>,\n\tLinus Walleij <linusw@kernel.org>,\n Alexander Sverdlin <alexander.sverdlin@gmail.com>,\n\tlinux-kernel@vger.kernel.org,\n\t\"open list:GPIO SUBSYSTEM\" <linux-gpio@vger.kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]