[{"id":3683709,"web_url":"http://patchwork.ozlabs.org/comment/3683709/","msgid":"<3a684241-f922-44f7-a9f7-445ed8790078@baylibre.com>","list_archive_url":null,"date":"2026-04-28T20:47:34","subject":"Re: [PATCH v2 4/6] pinctrl: airoha: add pin controller and gpio\n driver for EN7523 SoC","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/people/87228/","name":"David Lechner","email":"dlechner@baylibre.com"},"content":"The subject is a bit long on this and other similar commits.\n\nSuggest:\n\n\tpinctrl: airoha: add driver for EN7523 SoC\n\nor\n\n\tpinctrl: airoha: add pin/gpio driver for EN7523 SoC\n\n\nOn 4/28/26 10:34 AM, Mikhail Kshevetskiy wrote:\n> The driver based on official linux airoha pinctrl and gpio driver with\n> Matheus Sampaio Queiroga changes.\n> The changes:\n> * Separate code for each SoC and keep some of the functions in\n> common between them,\n> * Add pinctrl driver for EN7523 SoC.\n> \n> The original Matheus Sampaio Queiroga driver can be taken from the repo:\n> https://sirherobrine23.com.br/airoha_an7523/kernel/commits/branch/airoha_an7523_pinctrl\n> \n> This patch adds U-Boot pin controller and gpio driver for Airoha EN7523 SoC.\n> \n> Signed-off-by: Mikhail Kshevetskiy \n> ---\n\nSame comments about commit message and general style from core patch apply\nhere as well.\n\n> +static const struct airoha_pinctrl_func_group en7523_phy3_led1_func_group[] = {\n> +\tAIROHA_PINCTRL_PHY_LED1(EN7523, \"gpio7\", GPIO_LAN0_LED1_MODE_MASK,\n> +\t\t\t\tLAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(2)),\n> +\tAIROHA_PINCTRL_PHY_LED1(EN7523, \"gpio6\", GPIO_LAN1_LED1_MODE_MASK,\n> +\t\t\t\tLAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(2)),\n> +\tAIROHA_PINCTRL_PHY_LED1(EN7523, \"gpio5\", GPIO_LAN2_LED1_MODE_MASK,\n> +\t\t\t\tLAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(2)),\n> +\tAIROHA_PINCTRL_PHY_LED1(EN7523, \"gpio4\", GPIO_LAN3_LED1_MODE_MASK,\n> +\t\t\t\tLAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(2)),\n> +};\n> +\n> +static const struct airoha_pinctrl_func_group en7523_phy4_led1_func_group[] = {\n> +\tAIROHA_PINCTRL_PHY_LED1(EN7523, \"gpio7\", GPIO_LAN0_LED1_MODE_MASK,\n> +\t\t\t\tLAN0_LED_MAPPING_MASK, LAN0_PHY_LED_MAP(2)),\n> +\tAIROHA_PINCTRL_PHY_LED1(EN7523, \"gpio6\", GPIO_LAN1_LED1_MODE_MASK,\n> +\t\t\t\tLAN1_LED_MAPPING_MASK, LAN1_PHY_LED_MAP(2)),\n> +\tAIROHA_PINCTRL_PHY_LED1(EN7523, \"gpio5\", GPIO_LAN2_LED1_MODE_MASK,\n> +\t\t\t\tLAN2_LED_MAPPING_MASK, LAN2_PHY_LED_MAP(2)),\n> +\tAIROHA_PINCTRL_PHY_LED1(EN7523, \"gpio4\", GPIO_LAN3_LED1_MODE_MASK,\n> +\t\t\t\tLAN3_LED_MAPPING_MASK, LAN3_PHY_LED_MAP(2)),\n> +};\n\nAre these suppose to be LANX_PHY_LED_MAP(3) instead of 2?\n\n\n> +U_BOOT_DRIVER(airoha_pinctrl) = {\n\nairoha_en7523_pinctrl\n\n> +\t.name = \"airoha-en7523-pinctrl\",\n> +\t.id = UCLASS_PINCTRL,\n> +\t.of_match = of_match_ptr(airoha_pinctrl_of_match),\n> +\t.probe = airoha_pinctrl_probe,\n> +\t.bind = airoha_pinctrl_bind,\n> +\t.priv_auto = sizeof(struct airoha_pinctrl),\n> +\t.ops = &airoha_pinctrl_ops,\n> +};","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=hQinN6mC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"hQinN6mC\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4svL6BWKz1yHv\n\tfor ; Wed, 29 Apr 2026 06:47:42 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D6D9C846A0;\n\tTue, 28 Apr 2026 22:47:39 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 6B4DE846A2; Tue, 28 Apr 2026 22:47:39 +0200 (CEST)","from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com\n [IPv6:2607:f8b0:4864:20::c35])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E760A84688\n for ; Tue, 28 Apr 2026 22:47:36 +0200 (CEST)","by mail-oo1-xc35.google.com with SMTP id\n 006d021491bc7-66f747175d8so6018904eaf.0\n for ; Tue, 28 Apr 2026 13:47:36 -0700 (PDT)","from ?IPV6:2600:8803:e7e4:500:1770:76c1:cfc7:3a0c?\n ([2600:8803:e7e4:500:1770:76c1:cfc7:3a0c])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-4340e915fdcsm212592fac.12.2026.04.28.13.47.34\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 28 Apr 2026 13:47:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777409256;\n x=1778014056;\n darn=lists.denx.de;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=YicmoZgKdPPAuWi6qWP57xWkEjP2sZatEECTFzsJpPE=;\n b=hQinN6mCF06tbTDEg6+37rRJ2+f/L/Sski0gYDJT6iDVQRpNS1AqhcpfI8OtUdRgu5\n In+fvd/honjAFe8iBL6fSy1EkdcaYBErwAAk12OLnuuDbB4NvkebZ/pRvzJFn666Pbzp\n x9ieE1SCXYkN95y3TtIcleyEusPY4VlMngjCzehZai/tkHs6MMhdh56JUL9iXuuIi6Po\n 7S9ZUBDEYV3OMKqaQZliEbdD9+MEfleym5Sln/pxfmU6OBHAlYe/JjqMHoKXPDK2Z+4d\n /toJ6FgHISaJd3VlBr4FI8tROqfSbIbTeEc+81XewsiUZkmdjCBoCdx2tmttFCeOnaGv\n mrGg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777409256; x=1778014056;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=YicmoZgKdPPAuWi6qWP57xWkEjP2sZatEECTFzsJpPE=;\n b=MJhBKms54gt8BTduzdcM0swWPO1uQNTlNqHEQvn4wDthjwZWVizdxJA/uxrQ4/PUSo\n DOMVUq+VfoCbkQ8OGhjw626vSSKJNrVTlKskhVKJ4jP08TPw6PC/u5ibnM5dk8w1LL0L\n jvcdkLUFyZ8/bVOS9aSQBBkyBqMTndNJ9YUaXCrxpGzAEDsTf8FTTWkhuNujUMF6qPqH\n ADOWqCsUlOnZc7A0AZIMVyuZXFHcNymEIvH5gnRmj2Y1yICdJs4b9aBnZGtqyke9sJT2\n IRj9+9uo6cxkTgpNp0Al3SrazcHozPSqCs73JVpHLIAdIs+A21hJeyjB/PjRYJuiDSdI\n JG1Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/UOe8xpc2mT+619I3d8Y4Y/i+qTYazSPr8J7X5vyAB9ariuRXOpnSqYY4MwmckZupV8J3xWF0=@lists.denx.de","X-Gm-Message-State":"AOJu0Yy4wcI2ON6UNMXfuwCNLbX6giuqzXw/X1ZKxZp9NfR4vj4XB/4l\n Dh5iBILAM4p3+Kb02b4xY+QsPaBcb1kLhr/VET3Xv1jwoy+15rYyJ0ZICfqAMjbtOGU=","X-Gm-Gg":"AeBDies3BjOuZwABm3zn8hkxDDNAkGalCN8UieTexZw9yicR3ZIYKTieG06gBXsjK9V\n i9i1fh9D3YxGDNiOcWPfosRN2u6k6jS4HjIw0GY9V2fn9dvdkiUdQYez/92d+e/Otn9yS7sLrlB\n W87BSaSCyiMSyFLkfcu8Sc5bvNxkd4fMQqlL32owDrFKtp8Ki6YXnSsGsCtppxNM8V4eWg3QYAm\n CYFjw4TJm/SPabIpl+5zsYK1MbA5+Tm6MHWz0FRjdnzdn2KCaZCCg5agdHUHEsicAMLIzS+Fvzb\n xyDmzp5pMGJduGlsjJSGLSGsqcczY51+fB0H5SOTLq95smcjkOa86BVYgbta8e31lhjb454/vHZ\n yVFCvl3N6rjmF3CdU5vKLXGpm9uDhtGceg3xqqVir+XrQuty892M1SLmNji35p+BkiONxF9Mikv\n GbHS5BO8Vosa/Jjyt35Bz8Yd36NnCTlUojI880x4I2ud0TLHN9vjlkRDa2d2xr/Ys78/hQ7Qoi0\n P8wAz+BeM5c","X-Received":"by 2002:a05:6820:16a3:b0:67e:2fcc:fa99 with SMTP id\n 006d021491bc7-6966851bb92mr655600eaf.55.1777409255625;\n Tue, 28 Apr 2026 13:47:35 -0700 (PDT)","Message-ID":"<3a684241-f922-44f7-a9f7-445ed8790078@baylibre.com>","Date":"Tue, 28 Apr 2026 15:47:34 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 4/6] pinctrl: airoha: add pin controller and gpio\n driver for EN7523 SoC","To":"Mikhail Kshevetskiy ,\n Tom Rini , Christian Marangi ,\n Simon Glass , Marek Vasut\n , Peng Fan ,\n Sean Anderson , Yao Zi ,\n Michal Simek , Anis Chali ,\n u-boot@lists.denx.de, Lorenzo Bianconi ,\n Markus Gothe ,\n Matheus Sampaio Queiroga ,\n Benjamin Larsson ","References":"<20260428153448.980150-1-mikhail.kshevetskiy@iopsys.eu>\n <20260428153448.980150-5-mikhail.kshevetskiy@iopsys.eu>","Content-Language":"en-US","From":"David Lechner ","In-Reply-To":"<20260428153448.980150-5-mikhail.kshevetskiy@iopsys.eu>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]