[{"id":3683699,"web_url":"http://patchwork.ozlabs.org/comment/3683699/","msgid":"<8c84d587-beaf-42c5-b08f-fcc6ad9dd09c@baylibre.com>","list_archive_url":null,"date":"2026-04-28T19:52:58","subject":"Re: [PATCH v2 1/6] pinctrl: add missed pinconf/pinctrl definitions","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/people/87228/","name":"David Lechner","email":"dlechner@baylibre.com"},"content":"In the subject, I would say \"more\" instead of \"missed\".\n\n\nOn 4/28/26 10:34 AM, Mikhail Kshevetskiy wrote:\n> The code was taken from linux-7.0\n\nThe commit message should also explain why we need these changes\nin U-Boot.\n\nAnd in this case an explanation of why you chose the locations\nfor the code would be helpful.\n\nSince the code is taken from Linux, it is odd that some goes in\na U-Boot dm/ header while the other goes in a linux/ header.\n\nThe patch itself seems OK to me, but I wouldn't mind hearing from\nsomeone who has been working on U-Boot more than me to say what best\npractices are on copying code from Linux.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=Uyis97+x;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"Uyis97+x\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4rhN1DbWz1yHv\n\tfor ; Wed, 29 Apr 2026 05:53:08 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 67EBA84682;\n\tTue, 28 Apr 2026 21:53:03 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BDA7F84687; Tue, 28 Apr 2026 21:53:02 +0200 (CEST)","from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com\n [IPv6:2001:4860:4864:20::2a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 935BC8466B\n for ; Tue, 28 Apr 2026 21:53:00 +0200 (CEST)","by mail-oa1-x2a.google.com with SMTP id\n 586e51a60fabf-415e568a7ecso4549337fac.0\n for ; Tue, 28 Apr 2026 12:53:00 -0700 (PDT)","from ?IPV6:2600:8803:e7e4:500:1770:76c1:cfc7:3a0c?\n ([2600:8803:e7e4:500:1770:76c1:cfc7:3a0c])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-4340e98d29asm84611fac.15.2026.04.28.12.52.58\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 28 Apr 2026 12:52:58 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777405979;\n x=1778010779;\n darn=lists.denx.de;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=AN5+Nc4ZOUaBcZA6boVYUMV4wmUM6XPWFOwD6rZ2y0M=;\n b=Uyis97+xV5zoJI6PzMeaHanq/6zQgJEdxdvWUf3gGQZHW2dRbpK051zZpEORNyxNBM\n ShNqUI4MNy4Q/bco2eAzquTcji7Qt8ZrIHepKqitlm0L2+phg+SAAYkKw7U1/92xv/EI\n Q4pj6lHSnd2JIniKCQTMabr2StLpAV14hmLSD5YUy+kNOFkXuBWmylEdqLSZQxQ0UTHd\n IDgwpvIMGU4ReaIW9ZnllMa/4EL4V87wojvoa05EtVN5Ry//1amWAYm5TqXMZKyeTFuD\n VtQevWdl8yPIUCnR9Jr1J6moorptJiyRcjTs837jDRTqo2Gpv7PjO4wtyskDaF4POaG5\n nQ/A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777405979; x=1778010779;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=AN5+Nc4ZOUaBcZA6boVYUMV4wmUM6XPWFOwD6rZ2y0M=;\n b=fufyodHn17f7qlCS8MVor94uuTE519MX48O4EJZscztgeKz5wHAfLZCVzQYx+i+nP0\n i/Q3sOsFreCvxRhwkgoUT+Oabq6NtcId9mnjRvjBHttoMii0hKbfRpa1GqqSIi2OidPk\n 4qa0EIkVAUexf0Ps3oiZhjFnMZUTgLnmmM9lZ4C8uDMtAVps6fdjphbYr88GrwTzb6sK\n nZZ4LqeelPfQKs25MqrslumXbt99b2pFu3hemvwztXOSKKRk2VfnNtxFotyfXQoax/G5\n BC7pL5EUvculw+5OkSqyrF95CGf4i5tmuo7GebiTGa8cvScIo9xCSjugva8MSmzLm/v+\n zvJw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8JJ/nWFGq8007nqOgLeJmjWCune013QRv4QpYB0r8IHFQGGBAMhI00SbWlO8CJwPljGZ21a/4=@lists.denx.de","X-Gm-Message-State":"AOJu0YxB/6nqF0g297UxNuUqAROE1YLtkGUf6SOJ+fSk/w4oBniQaqfu\n 0Cd6Jaz2UKLBL5xCQTG5N53FQ1s0yeKe9AKvQtG/3Ukq+wHOnxEkvypn28tM2mUimFU=","X-Gm-Gg":"AeBDiety/NLpGCwed/VE2yeHkiSJJUcKobG+nmmOt4D3EzfXLvKlCBQkkqwCjpu6JUj\n RFe2cbGzfCTlid5R7hQDz30s2eF+1R7Fc8NBDCfBHlzqySTOoSNk7tiereTqxaHrroYQhD0pE/u\n v/mjQezg0ZrFQZaqnzgLDZbI52s0pDLaBDBEVdhLxoLPD4Nu/M+qqPVkuTcNjfrFQBDsAm0jstx\n uGeqMpY8DSqIDI2O6vag7/ktYjDIgpp03OhqrsBwjgv0VeQH7sVvdV0900LNF2x8uMBtcEuqvpt\n tZXkiOJsu9xZtC5ii/Q1pb60OE8/4CarmbwUPxWp1OmDAwA7zhKtHLAIf/HBYBXHpoIkjXpqHGr\n MWGYM01CQXO3ujrjqE3z7XHbpWfUpOBqkiOIGtynfAif2VhVMVH23ArYWDc/0Kgs7v7iq0SCAZA\n gthkFOK6Dh/WcQ3Vvj36OyJ3AQoAtE3sQkVoU2OL7mtUFIrXsxm8/M/4lnFXfHztfL7jQZCM4yN\n eWEzgip48g1","X-Received":"by 2002:a05:6870:a101:b0:434:98c:d935 with SMTP id\n 586e51a60fabf-434098d5682mr806739fac.2.1777405979289;\n Tue, 28 Apr 2026 12:52:59 -0700 (PDT)","Message-ID":"<8c84d587-beaf-42c5-b08f-fcc6ad9dd09c@baylibre.com>","Date":"Tue, 28 Apr 2026 14:52:58 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/6] pinctrl: add missed pinconf/pinctrl definitions","To":"Mikhail Kshevetskiy ,\n Tom Rini , Christian Marangi ,\n Simon Glass , Marek Vasut\n , Peng Fan ,\n Sean Anderson , Yao Zi ,\n Michal Simek , Anis Chali ,\n u-boot@lists.denx.de, Lorenzo Bianconi ,\n Markus Gothe ,\n Matheus Sampaio Queiroga ,\n Benjamin Larsson ","References":"<20260428153448.980150-1-mikhail.kshevetskiy@iopsys.eu>\n <20260428153448.980150-2-mikhail.kshevetskiy@iopsys.eu>","Content-Language":"en-US","From":"David Lechner ","In-Reply-To":"<20260428153448.980150-2-mikhail.kshevetskiy@iopsys.eu>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]